201444 2019-09-03 20:22:13 -0700 [macOS] Unable to open local file from favorites bar 2019-09-03 21:12:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1567620 0 pvollan 2019-09-03 20:22:13 -0700 The sandbox extension handle should be created providing the pid of the receiving process. 1567621 1 377951 pvollan 2019-09-03 20:24:48 -0700 Created attachment 377951 Patch 1567622 2 377951 bfulgham 2019-09-03 20:26:40 -0700 Comment on attachment 377951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377951&action=review r=me > Source/WebKit/UIProcess/WebPageProxy.cpp:1068 > + if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) { Yikes! How did we miss this path? 1567625 3 pvollan 2019-09-03 20:30:53 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 377951 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377951&action=review > > r=me > > > Source/WebKit/UIProcess/WebPageProxy.cpp:1068 > > + if (SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath(), process.processIdentifier(), sandboxExtensionHandle)) { > > Yikes! How did we miss this path? I originally thought only the explicit references to "/" needed replacement, but also this one needs replacement. It actually resolves to "/" as well. Thanks for reviewing! 1567632 4 377951 commit-queue 2019-09-03 21:11:14 -0700 Comment on attachment 377951 Patch Clearing flags on attachment: 377951 Committed r249454: <https://trac.webkit.org/changeset/249454> 1567633 5 commit-queue 2019-09-03 21:11:15 -0700 All reviewed patches have been landed. Closing bug. 1567634 6 webkit-bug-importer 2019-09-03 21:12:17 -0700 <rdar://problem/55005268> 377951 2019-09-03 20:24:48 -0700 2019-09-03 21:11:14 -0700 Patch bug-201444-20190903202447.patch text/plain 1735 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDk0NTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA5LTAzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFVuYWJsZSB0byBv cGVuIGxvY2FsIGZpbGUgZnJvbSBmYXZvcml0ZXMgYmFyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDE0NDQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2FuZGJveCBleHRlbnNpb24gaGFuZGxlIHNo b3VsZCBiZSBjcmVhdGVkIHByb3ZpZGluZyB0aGUgcGlkIG9mIHRoZSByZWNlaXZpbmcgcHJvY2Vz cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6Om1heWJlSW5pdGlhbGl6ZVNhbmRib3hFeHRlbnNpb25IYW5kbGUp OgorCiAyMDE5LTA5LTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgRnJhbWVMb2FkZXI6OkZyYW1lUHJvZ3Jlc3NUcmFja2VyOjpwcm9ncmVzc0NvbXBsZXRlZCgp IGRvZXMgbm90IG5lZWQgYSBwYWdlSUQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAkocmV2aXNpb24gMjQ5MDUyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA2NCw2ICsxMDY0LDEyIEBA IHZvaWQgV2ViUGFnZVByb3h5OjptYXliZUluaXRpYWxpemVTYW5kYm8KICAgICAgICAgaWYgKHBy b2Nlc3MuaGFzQXNzdW1lZFJlYWRBY2Nlc3NUb1VSTChyZXNvdXJjZURpcmVjdG9yeVVSTCkpCiAg ICAgICAgICAgICByZXR1cm47CiAKKyNpZiBIQVZFKFNBTkRCT1hfSVNTVUVfUkVBRF9FWFRFTlNJ T05fVE9fUFJPQ0VTU19CWV9QSUQpCisgICAgICAgIGlmIChTYW5kYm94RXh0ZW5zaW9uOjpjcmVh dGVIYW5kbGVGb3JSZWFkQnlQaWQocmVzb3VyY2VEaXJlY3RvcnlVUkwuZmlsZVN5c3RlbVBhdGgo KSwgcHJvY2Vzcy5wcm9jZXNzSWRlbnRpZmllcigpLCBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlKSkg eworICAgICAgICAgICAgbV9wcm9jZXNzLT5hc3N1bWVSZWFkQWNjZXNzVG9CYXNlVVJMKCp0aGlz LCByZXNvdXJjZURpcmVjdG9yeVVSTCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0K KyNlbmRpZgogICAgICAgICBpZiAoU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKHJlc291 cmNlRGlyZWN0b3J5VVJMLmZpbGVTeXN0ZW1QYXRoKCksIFNhbmRib3hFeHRlbnNpb246OlR5cGU6 OlJlYWRPbmx5LCBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlKSkgewogICAgICAgICAgICAgbV9wcm9j ZXNzLT5hc3N1bWVSZWFkQWNjZXNzVG9CYXNlVVJMKCp0aGlzLCByZXNvdXJjZURpcmVjdG9yeVVS TCk7CiAgICAgICAgICAgICByZXR1cm47Cg==