201435 2019-09-03 14:19:46 -0700 REGRESSION (r249132): [macOS WK2] Layout Test inspector/layers/layerTreeDidChange.html is a flaky failure 2019-09-03 17:36:21 -0700 1 1 1 Unclassified WebKit Web Inspector Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200959 1 ryanhaddad hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1567507 0 ryanhaddad 2019-09-03 14:19:46 -0700 The following layout test is flaky on macOS WK2 bots, most frequently failing in the debug configuration. inspector/layers/layerTreeDidChange.html Probable cause: Unknown. The first failure on the dashboard blames https://trac.webkit.org/log/webkit/?verbose=on&rev=249133&stop_rev=249132 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Flayers%2FlayerTreeDidChange.html --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/inspector/layers/layerTreeDidChange-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/inspector/layers/layerTreeDidChange-actual.txt @@ -3,11 +3,14 @@ == Running test suite: LayerTree.layerTreeDidChange -- Running test case: LayerTree.layerTreeDidChange.WithRequest +Layer tree changed Creating layer... Layer tree changed Creating layer... Layer tree changed -PASS: LayerTreeDidChange should fire after layersForNode is called +FAIL: LayerTreeDidChange should fire after layersForNode is called + Expected: 2 + Actual: 3 -- Running test case: LayerTree.layerTreeDidChange.WithoutRequest Creating layer... 1567544 1 377930 hi 2019-09-03 16:26:14 -0700 Created attachment 377930 Patch 1567547 2 377930 joepeck 2019-09-03 16:27:54 -0700 Comment on attachment 377930 Patch rs=me 1567575 3 377930 commit-queue 2019-09-03 17:35:18 -0700 Comment on attachment 377930 Patch Clearing flags on attachment: 377930 Committed r249447: <https://trac.webkit.org/changeset/249447> 1567576 4 commit-queue 2019-09-03 17:35:20 -0700 All reviewed patches have been landed. Closing bug. 1567577 5 webkit-bug-importer 2019-09-03 17:36:21 -0700 <rdar://problem/54999525> 377930 2019-09-03 16:26:14 -0700 2019-09-03 17:35:18 -0700 Patch bug-201435-20190903162613.patch text/plain 3819 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMTZhOTViOGZiMDdmZjc3NzNkYmNkMGJiZWExZGQyODZkY2QxNTI1Li4yZDRjOGM0 MjJmMzY1OGZjMWFlZjE1MThmMWNiMDAzNjc3NGZiYWIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAK KzIwMTktMDktMDMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyNDkxMzIpOiBbbWFjT1MgV0syXSBMYXlvdXQgVGVzdCBpbnNwZWN0b3Iv bGF5ZXJzL2xheWVyVHJlZURpZENoYW5nZS5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxNDM1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI0OTEzMiBjaGFuZ2Vk IHRoZSBgSW5zcGVjdG9yTGF5ZXJUcmVlQWdlbnRgIHRvIHJlc2V0IHRoZSBmbGFnIHRoYXQgY29u dHJvbHMgd2hldGhlciB0aGUKKyAgICAgICAgZnJvbnRlbmQgc2hvdWxkIGJlIG5vdGlmaWVkIGFi b3V0IGxheWVyIGNoYW5nZXMgd2hlbiBgZGlzYWJsZWAgaXMgY2FsbGVkLCB3aGljaCBoYXBwZW5z IHdoZW4KKyAgICAgICAgV2ViIEluc3BlY3RvciBkaXNjb25uZWN0cy4KKworICAgICAgICBTb21l dGltZXMsIGEgbGF5ZXIgY2hhbmdlIGV2ZW50IGNhbiBiZSAiaW4gZmxpZ2h0IiB3aGVuIHRoaXMg aGFwcGVucywgbWVhbmluZyB0aGF0IHRoZSBXZWIKKyAgICAgICAgSW5zcGVjdG9yIGZyb250ZW5k IGNhbiByZWNlaXZlIGEgbGF5ZXIgY2hhbmdlIGV2ZW50IGJlZm9yZSBpdCByZXF1ZXN0cyB0aGUg bmV3IGxheWVyIGRhdGEuCisKKyAgICAgICAgVGhpcyBpcyBub3JtYWxseSBoYW5kbGVkIGJ5IHRo ZSBXZWIgSW5zcGVjdG9yIFVJLCBhcyB0aGUgYXNzb2NpYXRlZCBET00gbm9kZSB3b3VsZCBubyBs b25nZXIKKyAgICAgICAgZXhpc3QsIHNvIHRoZSBVSSBwYXRocyB3b3VsZCBlYXJseSByZXR1cm4u CisKKyAgICAgICAgKiBpbnNwZWN0b3IvbGF5ZXJzL2xheWVyVHJlZURpZENoYW5nZS5odG1sOgor ICAgICAgICBPbmx5IGxpc3RlbiBmb3IgbGF5ZXIgY2hhbmdlIGV2ZW50cyBvbmNlIHdlJ3ZlIHRy aWdnZXJlZCBhIGd1YXJhbnRlZWQgbGF5ZXIgdXBkYXRlLCBhcyBhbnkKKyAgICAgICAgImluIGZs aWdodCIgZXZlbnRzIGZyb20gcHJldmlvdXMgdGVzdHMgY291bGQgYmUgaW5jb3JyZWN0bHkgbG9n Z2VkIGFzIHBhcnQgb2YgdGhpcyB0ZXN0LgorCiAyMDE5LTA5LTAzICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVHJlYXQgYSB0d28tZmluZ2VyIHNp bmdsZSB0YXAgYXMgaWYgdGhlIHVzZXIgdGFwcGVkIHdpdGggdGhlIENtZCBrZXkgcHJlc3NlZApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2xheWVycy9sYXllclRyZWVEaWRDaGFu Z2UuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9sYXllcnMvbGF5ZXJUcmVlRGlkQ2hhbmdl Lmh0bWwKaW5kZXggNDc4YjhlOTA1MWJlZTliZDg3Mjg3ZDc5YzI3ZmQyYzBiNjBiMWI0NC4uNDMx ZjY1MmI3YWE5Njg0YmJmMmUxZmZiMzJhOTFlNDhkOTFjNzMyZCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2xheWVycy9sYXllclRyZWVEaWRDaGFuZ2UuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvbGF5ZXJzL2xheWVyVHJlZURpZENoYW5nZS5odG1sCkBAIC0zMCwy MCArMzAsOSBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgZGVzY3JpcHRpb246ICJDaGVjayB0 aGF0IGxheWVyVHJlZURpZENoYW5nZSBpcyBhYmxlIHRvIGJlIGRpc3BhdGNoZWQgb25jZSBMYXll clRyZWUuY29tbWFuZHMubGF5ZXJzRm9yTm9kZSBpcyBjYWxsZWQuIiwKICAgICAgICAgdGVzdChy ZXNvbHZlLCByZWplY3QpIHsKICAgICAgICAgICAgIGxldCBsYXllclRyZWVEaWRDaGFuZ2VDb3Vu dCA9IDA7Ci0gICAgICAgICAgICBsZXQgaGFuZGxlTGF5ZXJUcmVlRGlkQ2hhbmdlID0gV0kubGF5 ZXJUcmVlTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdJLkxheWVyVHJlZU1hbmFnZXIuRXZlbnQu TGF5ZXJUcmVlRGlkQ2hhbmdlLCAoZXZlbnQpID0+IHsKLSAgICAgICAgICAgICAgICArK2xheWVy VHJlZURpZENoYW5nZUNvdW50OwotCi0gICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2co IkxheWVyIHRyZWUgY2hhbmdlZCIpOwotCi0gICAgICAgICAgICAgICAgaWYgKGxheWVyVHJlZURp ZENoYW5nZUNvdW50ID09PSAxKSB7Ci0gICAgICAgICAgICAgICAgICAgIFdJLmxheWVyVHJlZU1h bmFnZXIubGF5ZXJzRm9yTm9kZShkb2N1bWVudE5vZGUsIChsYXllcnMpID0+IHsKLSAgICAgICAg ICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QubG9nKCJDcmVhdGluZyBsYXllci4uLiIpOwot ICAgICAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZShgYWRk Q29tcG9zaXRlZExheWVyKClgKTsKLSAgICAgICAgICAgICAgICAgICAgfSk7Ci0gICAgICAgICAg ICAgICAgfQotICAgICAgICAgICAgfSk7Ci0KICAgICAgICAgICAgIGxldCB0ZXN0UGFnZURpZEFw cGVuZENoaWxkQ291bnQgPSAwOworCisgICAgICAgICAgICBsZXQgaGFuZGxlTGF5ZXJUcmVlRGlk Q2hhbmdlID0gbnVsbDsKICAgICAgICAgICAgIGxldCBoYW5kbGVUZXN0UGFnZURpZEFwcGVuZENo aWxkID0gSW5zcGVjdG9yVGVzdC5hZGRFdmVudExpc3RlbmVyKCJUZXN0UGFnZURpZEFwcGVuZENo aWxkIiwgKGV2ZW50KSA9PiB7CiAgICAgICAgICAgICAgICAgKyt0ZXN0UGFnZURpZEFwcGVuZENo aWxkQ291bnQ7CiAKQEAgLTU4LDYgKzQ3LDE5IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAg ICAgfSk7CiAKICAgICAgICAgICAgIFdJLmxheWVyVHJlZU1hbmFnZXIubGF5ZXJzRm9yTm9kZShk b2N1bWVudE5vZGUsIChsYXllcnMpID0+IHsKKyAgICAgICAgICAgICAgICBoYW5kbGVMYXllclRy ZWVEaWRDaGFuZ2UgPSBXSS5sYXllclRyZWVNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV0kuTGF5 ZXJUcmVlTWFuYWdlci5FdmVudC5MYXllclRyZWVEaWRDaGFuZ2UsIChldmVudCkgPT4geworICAg ICAgICAgICAgICAgICAgICArK2xheWVyVHJlZURpZENoYW5nZUNvdW50OworCisgICAgICAgICAg ICAgICAgICAgIEluc3BlY3RvclRlc3QubG9nKCJMYXllciB0cmVlIGNoYW5nZWQiKTsKKworICAg ICAgICAgICAgICAgICAgICBpZiAobGF5ZXJUcmVlRGlkQ2hhbmdlQ291bnQgPT09IDEpIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIFdJLmxheWVyVHJlZU1hbmFnZXIubGF5ZXJzRm9yTm9kZShk b2N1bWVudE5vZGUsIChsYXllcnMpID0+IHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmxvZygiQ3JlYXRpbmcgbGF5ZXIuLi4iKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKGBhZGRDb21wb3NpdGVkTGF5 ZXIoKWApOworICAgICAgICAgICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgICAgICB9KTsKKwogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Qu bG9nKCJDcmVhdGluZyBsYXllci4uLiIpOwogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Qu ZXZhbHVhdGVJblBhZ2UoYGFkZENvbXBvc2l0ZWRMYXllcigpYCk7CiAgICAgICAgICAgICB9KTsK