201434 2019-09-03 13:49:49 -0700 [GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427 2019-09-04 01:30:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra bugs-noreply calvaris commit-queue pnormand sabouhallawa simon.fraser webkit-bug-importer zan oldest_to_newest 1567498 0 psaavedra 2019-09-03 13:49:49 -0700 ``` ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:179:9: error: ‘GstGLSyncMeta’ was not declared in this scope GstGLSyncMeta* meta = gst_buffer_get_gl_sync_meta(m_buffer); ^~~~~~~~~~~~~ ..``` 1567499 1 377918 psaavedra 2019-09-03 13:51:56 -0700 Created attachment 377918 patch 1567503 2 psaavedra 2019-09-03 13:57:36 -0700 The current patch fix the build but maybe the right patch for this case also it should restore the logic replaced by r249427 in L719: ``` 719 GLuint textureID = frameHolder->textureID(); 720 std::unique_ptr<TextureMapperPlatformLayerBuffer> layerBuffer; 721 if (textureID) { 722 layerBuffer = makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), frameHolder->flags(), GraphicsContext3D::RGBA); ``` https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719 1567506 3 psaavedra 2019-09-03 14:18:57 -0700 (In reply to Pablo Saavedra from comment #2) > The current patch fix the build but maybe the right patch for this case also > it should restore the logic replaced by r249427 in L719: > > ``` > 719 GLuint textureID = frameHolder->textureID(); > 720 std::unique_ptr<TextureMapperPlatformLayerBuffer> > layerBuffer; > 721 if (textureID) { > 722 layerBuffer = > makeUnique<TextureMapperPlatformLayerBuffer>(textureID, frameHolder->size(), > frameHolder->flags(), GraphicsContext3D::RGBA); > ``` > > https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/ > graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp?rev=249321#L719 Nah, only is invoked in sections of the code already safeguarded by `#if USE(GSTREAMER_GL)` 1567658 4 377957 psaavedra 2019-09-03 23:07:57 -0700 Created attachment 377957 patch 1567684 5 377957 commit-queue 2019-09-04 01:29:20 -0700 Comment on attachment 377957 patch Clearing flags on attachment: 377957 Committed r249474: <https://trac.webkit.org/changeset/249474> 1567685 6 commit-queue 2019-09-04 01:29:22 -0700 All reviewed patches have been landed. Closing bug. 1567686 7 webkit-bug-importer 2019-09-04 01:30:19 -0700 <rdar://problem/55010966> 377918 2019-09-03 13:51:56 -0700 2019-09-03 23:07:43 -0700 patch bug-201434-20190903225154.patch text/plain 1670 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDlkMDY1YzYyM2Q2OGNk YzQ1ZDQ4Y2RmMDcwZDdhODJlYTk3Yjc3Yy4uN2QxZDFmMzRlZTc1OGY1ODM1MDg0NjdlNDI3MmJl NzE4ZGU4NGY2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA5LTAzICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEJ1aWxk IGZhaWx1cmUgaW4gRGViaWFuIFN0YWJsZSBhbmQgVWJ1bnR1IExUUyBib3RzIGFmdGVyIHIyNDk0 MjcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTQz NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2Uu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3N0VmlkZW9GcmFtZUhvbGRlcjo6d2FpdEZvckNQVVN5 bmMpOgorCiAyMDE5LTA5LTAzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bVEZDXSBJbml0aWFsaXplIDx0aGVhZD48dGJvZHk+PHRmb290PiBkaXNwbGF5 IGJveGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuY3BwCmluZGV4IDc3YjdlNDMxYTZiMzQyM2FhYzAxYjUzOTJmYmQ4Y2NkYWIzMTdhOGIu LjRjYjVmZDM3YjZiMjM1MTZjNWNkYTAyMDg0NTM0NzQxZGQyNjhiMjUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTE3Niwx MiArMTc2LDE0IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCB3YWl0Rm9yQ1BVU3luYygp CiAgICAgeworI2lmIFVTRShHU1RSRUFNRVJfR0wpCiAgICAgICAgIEdzdEdMU3luY01ldGEqIG1l dGEgPSBnc3RfYnVmZmVyX2dldF9nbF9zeW5jX21ldGEobV9idWZmZXIpOwogICAgICAgICBpZiAo bWV0YSkgewogICAgICAgICAgICAgR3N0TWVtb3J5KiBtZW0gPSBnc3RfYnVmZmVyX3BlZWtfbWVt b3J5KG1fYnVmZmVyLCAwKTsKICAgICAgICAgICAgIEdzdEdMQ29udGV4dCogY29udGV4dCA9ICgo R3N0R0xCYXNlTWVtb3J5KiltZW0pLT5jb250ZXh0OwogICAgICAgICAgICAgZ3N0X2dsX3N5bmNf bWV0YV93YWl0X2NwdShtZXRhLCBjb250ZXh0KTsKICAgICAgICAgfQorI2VuZGlmIC8vIFVTRShH U1RSRUFNRVJfR0wpCiAgICAgfQogCiAgICAgY29uc3QgSW50U2l6ZSYgc2l6ZSgpIGNvbnN0IHsg cmV0dXJuIG1fc2l6ZTsgfQo= 377957 2019-09-03 23:07:57 -0700 2019-09-04 01:29:20 -0700 patch bug-201434-20190904080754.patch text/plain 3164 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDlkMDY1YzYyM2Q2OGNk YzQ1ZDQ4Y2RmMDcwZDdhODJlYTk3Yjc3Yy4uN2QxZDFmMzRlZTc1OGY1ODM1MDg0NjdlNDI3MmJl NzE4ZGU4NGY2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA5LTAzICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEJ1aWxk IGZhaWx1cmUgaW4gRGViaWFuIFN0YWJsZSBhbmQgVWJ1bnR1IExUUyBib3RzIGFmdGVyIHIyNDk0 MjcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTQz NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2Uu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3N0VmlkZW9GcmFtZUhvbGRlcjo6d2FpdEZvckNQVVN5 bmMpOgorCiAyMDE5LTA5LTAzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bVEZDXSBJbml0aWFsaXplIDx0aGVhZD48dGJvZHk+PHRmb290PiBkaXNwbGF5 IGJveGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuY3BwCmluZGV4IDc3YjdlNDMxYTZiMzQyM2FhYzAxYjUzOTJmYmQ4Y2NkYWIzMTdhOGIu LjdkM2NjMmI2Y2U3ZmZhNWUyOWU4YmIzYmFkZmUzNzRmYjYwMGIwMzcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTE3NCw2 ICsxNzQsNyBAQCBwdWJsaWM6CiAgICAgICAgIGdzdF92aWRlb19mcmFtZV91bm1hcCgmbV92aWRl b0ZyYW1lKTsKICAgICB9CiAKKyNpZiBVU0UoR1NUUkVBTUVSX0dMKQogICAgIHZpcnR1YWwgdm9p ZCB3YWl0Rm9yQ1BVU3luYygpCiAgICAgewogICAgICAgICBHc3RHTFN5bmNNZXRhKiBtZXRhID0g Z3N0X2J1ZmZlcl9nZXRfZ2xfc3luY19tZXRhKG1fYnVmZmVyKTsKQEAgLTE4Myw2ICsxODQsNyBA QCBwdWJsaWM6CiAgICAgICAgICAgICBnc3RfZ2xfc3luY19tZXRhX3dhaXRfY3B1KG1ldGEsIGNv bnRleHQpOwogICAgICAgICB9CiAgICAgfQorI2VuZGlmIC8vIFVTRShHU1RSRUFNRVJfR0wpCiAK ICAgICBjb25zdCBJbnRTaXplJiBzaXplKCkgY29uc3QgeyByZXR1cm4gbV9zaXplOyB9CiAgICAg Ym9vbCBoYXNBbHBoYUNoYW5uZWwoKSBjb25zdCB7IHJldHVybiBtX2hhc0FscGhhQ2hhbm5lbDsg fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlci5jcHAK aW5kZXggNzljZGVjZmIzYTE0MTIzNmQ0NWNmNTIwMzEwNzk5OGYyYTgyMjQ5YS4uNWVmYjE5MGNi NGQyNTMxNjdjYzU0NWVjZWI3Nzg0OWI4M2QxYjY0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVm ZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJCdWZmZXIuY3BwCkBAIC0xMDksOCArMTA5LDEwIEBAIHZv aWQgVGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJCdWZmZXI6OnBhaW50VG9UZXh0dXJlTWFwcGVy KFRleHR1cmVNYXBwZXImIHRleHR1CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyNpZiBVU0Uo R1NUUkVBTUVSX0dMKQogICAgIGlmIChtX3VubWFuYWdlZEJ1ZmZlckRhdGFIb2xkZXIpCiAgICAg ICAgIG1fdW5tYW5hZ2VkQnVmZmVyRGF0YUhvbGRlci0+d2FpdEZvckNQVVN5bmMoKTsKKyNlbmRp ZiAvLyBVU0UoR1NUUkVBTUVSX0dMKQogCiAgICAgV1RGOjpzd2l0Y2hPbihtX3ZhcmlhbnQsCiAg ICAgICAgIFsmXShjb25zdCBSR0JUZXh0dXJlJiB0ZXh0dXJlKSB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclBsYXRmb3Jt TGF5ZXJCdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlci5oCmluZGV4IDNjOGZkYzg2MjgyZjQwZWMx ZjQyNzg2ZmYzYzRkZGU1MDQ5NzFiYWUuLjMzN2E4ZGZhNWViZTI0Y2YyZmExZGYxNzg3MzgzZGM1 NDQ3NzU1M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1 ZmZlci5oCkBAIC03NCw3ICs3NCw5IEBAIHB1YmxpYzoKICAgICAgICAgVW5tYW5hZ2VkQnVmZmVy RGF0YUhvbGRlcigpID0gZGVmYXVsdDsKICAgICAgICAgdmlydHVhbCB+VW5tYW5hZ2VkQnVmZmVy RGF0YUhvbGRlcigpID0gZGVmYXVsdDsKIAorI2lmIFVTRShHU1RSRUFNRVJfR0wpCiAgICAgICAg IHZpcnR1YWwgdm9pZCB3YWl0Rm9yQ1BVU3luYygpID0gMDsKKyNlbmRpZiAvLyBVU0UoR1NUUkVB TUVSX0dMKQogICAgIH07CiAKICAgICBib29sIGhhc01hbmFnZWRUZXh0dXJlKCkgY29uc3QgeyBy ZXR1cm4gbV9oYXNNYW5hZ2VkVGV4dHVyZTsgfQo=