201392 2019-09-01 16:32:51 -0700 macCatalyst: Re-enable iOS WKWebView printing API 2019-09-04 12:38:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton aestes bdakin megan_gardner sam timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1567081 0 thorton 2019-09-01 16:32:51 -0700 macCatalyst: Re-enable iOS WKWebView printing API 1567082 1 377831 thorton 2019-09-01 16:33:02 -0700 Created attachment 377831 Patch 1567083 2 thorton 2019-09-01 16:33:05 -0700 <rdar://problem/54690252> 1567088 3 377831 sam 2019-09-01 16:44:12 -0700 Comment on attachment 377831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377831&action=review > Source/WebKit/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + * UIProcess/API/Cocoa/WKWebView.mm: Why? What has changed since it was disabled? Why was it disabled in the first place? 1567097 4 thorton 2019-09-01 20:09:22 -0700 Because UIKit bits were missing at bringup time but have long since been introduced. 1567098 5 thorton 2019-09-01 20:09:55 -0700 And “why?” -> because the API is supposed to behave identically. 1567104 6 377831 wenson_hsieh 2019-09-01 20:36:37 -0700 Comment on attachment 377831 Patch r=me, with a sentence or two in the ChangeLog 1567825 7 thorton 2019-09-04 12:38:03 -0700 https://trac.webkit.org/changeset/249492/webkit 377831 2019-09-01 16:33:02 -0700 2019-09-01 20:36:37 -0700 Patch bug-201392-20190901163302.patch text/plain 4820 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgwMzAyNTYzOWY4OGEzZDA4 ZmUzMTE2Y2RlNzRkMzAzMmQwMzgxZGUuLmMyZGQzNWMxZjI0OWFjNGVmNzBkYTc5YzA5OGM4Yzlj YzQ3YmYzNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDktMDEgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgbWFjQ2F0YWx5c3Q6IFJl LWVuYWJsZSBpT1MgV0tXZWJWaWV3IHByaW50aW5nIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMzkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81NDY5MDI1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dl YlZpZXcgX3dlYlZpZXdQcmludEZvcm1hdHRlcl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3SW50ZXJuYWwuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvX1dLV2ViVmll d1ByaW50Rm9ybWF0dGVyLm1tOgorICAgICAgICAqIFVJUHJvY2Vzcy9fV0tXZWJWaWV3UHJpbnRG b3JtYXR0ZXJJbnRlcm5hbC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll dy5tbToKKwogMjAxOS0wOS0wMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBMb25nIHByZXNzZXMgdGhhdCBpbnRlcnJ1cHQgYWNjZWxlcmF0ZWQgc2Ny b2xsaW5nIGRpc3BhdGNoIGNsaWNrcyBvbiBhcHBzIGxpbmtlZCBhZ2FpbnN0IGlPUyAxMiBvciBl YXJsaWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bQppbmRleCA0NDVlNDM5NTNkNTI3ZTgwMWNjNjMxYzRjNzViMTMzMDcwYzIwMTdkLi41NDM3OTQy ZmNkNjhmOGU5ZmExYmFlNzRhNzA1MWI1MmFmN2Q4NWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTY0MTgsMTMgKzY0MTgsOSBAQCAt IChOU1N0cmluZyAqKV9zdWdnZXN0ZWRGaWxlbmFtZUZvckRpc3BsYXllZFBERgogCiAtIChfV0tX ZWJWaWV3UHJpbnRGb3JtYXR0ZXIgKilfd2ViVmlld1ByaW50Rm9ybWF0dGVyCiB7Ci0jaWYgIVBM QVRGT1JNKE1BQ0NBVEFMWVNUKQogICAgIFVJVmlld1ByaW50Rm9ybWF0dGVyICp2aWV3UHJpbnRG b3JtYXR0ZXIgPSBzZWxmLnZpZXdQcmludEZvcm1hdHRlcjsKICAgICBBU1NFUlQoW3ZpZXdQcmlu dEZvcm1hdHRlciBpc0tpbmRPZkNsYXNzOltfV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXIgY2xhc3Nd XSk7CiAgICAgcmV0dXJuIChfV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXIgKil2aWV3UHJpbnRGb3Jt YXR0ZXI7Ci0jZWxzZQotICAgIHJldHVybiBuaWw7Ci0jZW5kaWYgLy8gUExBVEZPUk0oTUFDQ0FU QUxZU1QpCiB9CiAKIHN0YXRpYyBXZWJDb3JlOjpVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9u IHRvVXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbihVSVNlbWFudGljQ29udGVudEF0dHJpYnV0 ZSBjb250ZW50QXR0cmlidXRlKQpAQCAtNzUyOSw3ICs3NTI1LDcgQEAgQGVuZAogCiAjZW5kaWYg Ly8gUExBVEZPUk0oTUFDKQogCi0jaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRGT1JN KE1BQ0NBVEFMWVNUKQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiBAaW1wbGVtZW50YXRpb24g V0tXZWJWaWV3IChfV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXIpCiAKIC0gKENsYXNzKV9wcmludEZv cm1hdHRlckNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3SW50ZXJuYWwuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXdJbnRlcm5hbC5oCmluZGV4IDZiMjQ2MTIxZjhiNTQ1MWU4NzJjZGVkZDRmN2Ri N2MwODhhZGE3ZWUuLmM1MGE3ZTRjYWZiNmUzNDlhNjYxYjM5Njc2ZjI5YTM4OWIzZGE2NzUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdJbnRl cm5hbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdJ bnRlcm5hbC5oCkBAIC0xOTksNyArMTk5LDcgQEAgV0tXZWJWaWV3KiBmcm9tV2ViUGFnZVByb3h5 KFdlYktpdDo6V2ViUGFnZVByb3h5Jik7CiBAZW5kCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpICYmICFQTEFURk9STShNQUNDQVRBTFlTVCkKKyNpZiBQTEFURk9STShJT1NfRkFN SUxZKQogQGludGVyZmFjZSBXS1dlYlZpZXcgKF9XS1dlYlZpZXdQcmludEZvcm1hdHRlcikKIEBw cm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgaWQgPF9XS1dlYlZpZXdQcmludFByb3ZpZGVy PiBfcHJpbnRQcm92aWRlcjsKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL19XS1dlYlZpZXdQcmludEZvcm1hdHRlci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L19XS1dlYlZpZXdQcmludEZvcm1hdHRlci5tbQppbmRleCBiOWVkNmExMjI4MzY2ZWYxMGVkMzll NmUwM2ViMjJmYmM3NWJlZGI1Li41NGRjZTZkNjdjNmFjYWJiZmY0OGIzOWY3NTUwMTdlNDhiZTg0 YzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9fV0tXZWJWaWV3UHJpbnRG b3JtYXR0ZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvX1dLV2ViVmlld1ByaW50 Rm9ybWF0dGVyLm1tCkBAIC0yNiw3ICsyNiw3IEBACiAjaW1wb3J0ICJjb25maWcuaCIKICNpbXBv cnQgIl9XS1dlYlZpZXdQcmludEZvcm1hdHRlckludGVybmFsLmgiCiAKLSNpZiBQTEFURk9STShJ T1NfRkFNSUxZKSAmJiAhUExBVEZPUk0oTUFDQ0FUQUxZU1QpCisjaWYgUExBVEZPUk0oSU9TX0ZB TUlMWSkKIAogI2ltcG9ydCAiV0tXZWJWaWV3SW50ZXJuYWwuaCIKICNpbXBvcnQgIl9XS0ZyYW1l SGFuZGxlLmgiCkBAIC0xMTYsNCArMTE2LDQgQEAgLSAodm9pZClkcmF3SW5SZWN0OihDR1JlY3Qp cmVjdCBmb3JQYWdlQXRJbmRleDooTlNJbnRlZ2VyKXBhZ2VJbmRleAogCiBAZW5kCiAKLSNlbmRp ZiAvLyBQTEFURk9STShJT1NfRkFNSUxZKSAmJiAhUExBVEZPUk0oTUFDQ0FUQUxZU1QpCisjZW5k aWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL19XS1dlYlZpZXdQcmludEZvcm1hdHRlckludGVybmFsLmggYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9fV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXJJbnRlcm5hbC5oCmluZGV4IDVjMjA3 YzQwNGI0YzJmMWZhZGY5NjE0Njk0YTFjNGQwZDRmOTNlYTUuLjhjNjM0M2JhMWNmZTZmY2M1YjMz YzI5YTAxNDYwMDc5NjdmODJjZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L19XS1dlYlZpZXdQcmludEZvcm1hdHRlckludGVybmFsLmgKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvX1dLV2ViVmlld1ByaW50Rm9ybWF0dGVySW50ZXJuYWwuaApAQCAtMjUsNyArMjUs NyBAQAogCiAjaW1wb3J0ICJfV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXIuaCIKIAotI2lmIFBMQVRG T1JNKElPU19GQU1JTFkpICYmICFQTEFURk9STShNQUNDQVRBTFlTVCkKKyNpZiBQTEFURk9STShJ T1NfRkFNSUxZKQogCiBAaW50ZXJmYWNlIFVJUHJpbnRGb3JtYXR0ZXIgKCkKIC0gKENHUmVjdClf cGFnZUNvbnRlbnRSZWN0OihCT09MKWZpcnN0UGFnZTsKQEAgLTQxLDQgKzQxLDQgQEAKIEBwcm9w ZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQ0dQREZEb2N1bWVudFJlZiBfd2tfcHJpbnRlZERv Y3VtZW50OwogQGVuZAogCi0jZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRG T1JNKE1BQ0NBVEFMWVNUKQorI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCmluZGV4IGFmOTJkZDIwMDEz OTc5NWRkNjExZDI0OTc4ZjhkYjk1ZDQ0MTNlYzAuLjNhZDhkZjQ4MDhlOGRhODBhMGNiMTMzZDMw MzZmNDFhMWJlYzYyY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3Lm1tCkBAIC02ODksOCArNjg5LDYgQEAgQGVuZAogCiAjcHJhZ21hIG1hcmsgUHJpbnRp bmcKIAotI2lmICFQTEFURk9STShNQUNDQVRBTFlTVCkKLQogQGludGVyZmFjZSBXS0NvbnRlbnRW aWV3IChfV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXIpIDxfV0tXZWJWaWV3UHJpbnRQcm92aWRlcj4K IEBlbmQKIApAQCAtNzU3LDYgKzc1NSw0IEBAIC0gKENHUERGRG9jdW1lbnRSZWYpX3drX3ByaW50 ZWREb2N1bWVudAogCiBAZW5kCiAKLSNlbmRpZiAvLyAhUExBVEZPUk0oTUFDQ0FUQUxZU1QpCi0K ICNlbmRpZiAvLyBQTEFURk9STShJT1NfRkFNSUxZKQo=