20135 2008-07-22 14:33:21 -0700 onbeforeunload doesn't work when set with addEventListener 2017-02-19 18:39:37 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All NEW P2 Normal --- 1 ovafai webkit-unassigned ap cdumez dimich kangax laszlo.gombos syoichi oldest_to_newest 86679 0 ovafai 2008-07-22 14:33:21 -0700 window.addEventListener('beforeunload', function(e) { (e || window.event).returnValue = "wot?"; return "wot?"; }, true); This should popup a dialog asking if I want to leave the page when I try to navigate away. In WebKit, it only seems to do so if I set the handler using window.onbeforeunload. 86680 1 22434 ovafai 2008-07-22 14:34:40 -0700 Created attachment 22434 testcase that works in IE/FF but fails in WebKit You should see an onbeforeunload dialog, followed by an alert in the onunload handler. In WebKit, you only see the alert from the onunload handler. 98266 2 ap 2008-11-10 22:56:27 -0800 Confirmed with r38249 on Mac OS X. 162257 3 dimich 2009-11-10 15:51:57 -0800 This is fixed by the recent changes to EventTarget that unified addEventListeners and event attributes. Works with r 50777 on Mac OS X. It'd be good to have a test though. 22434 2008-07-22 14:34:40 -0700 2008-07-22 14:34:40 -0700 testcase that works in IE/FF but fails in WebKit onbeforeunload.html text/html 439 ovafai PGh0bWw+DQo8Ym9keT4NCjxzY3JpcHQ+DQpmdW5jdGlvbiBhZGRXaW5kb3dMaXN0ZW5lcihldmVu dCwgaGFuZGxlcikgew0KICBpZiAod2luZG93LmFkZEV2ZW50TGlzdGVuZXIpIHsNCiAgICB3aW5k b3cuYWRkRXZlbnRMaXN0ZW5lcihldmVudCwgaGFuZGxlciwgdHJ1ZSk7DQogIH0gZWxzZSB7DQog ICAgd2luZG93LmF0dGFjaEV2ZW50KCJvbiIgKyBldmVudCwgaGFuZGxlcik7DQogIH0NCn0NCg0K YWRkV2luZG93TGlzdGVuZXIoJ2JlZm9yZXVubG9hZCcsIGZ1bmN0aW9uKGUpIHsNCiAgKGUgfHwg d2luZG93LmV2ZW50KS5yZXR1cm5WYWx1ZSA9ICJ3b3Q/IjsNCiAgcmV0dXJuICJ3b3Q/IjsNCn0p Ow0KDQphZGRXaW5kb3dMaXN0ZW5lcigndW5sb2FkJywgZnVuY3Rpb24oZSkgew0KICBhbGVydCgn Zm9vJyk7DQp9KTsNCjwvc2NyaXB0Pg0KPC9ib2R5Pg0KPC9odG1sPg==