201347 2019-08-30 10:50:15 -0700 [iOS] Remove ubiquity client rule from sandbox 2019-12-17 10:13:46 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan ap bfulgham commit-queue webkit-bug-importer oldest_to_newest 1566725 0 pvollan 2019-08-30 10:50:15 -0700 This rule is most likely not needed, since we have already blocked all of its associated mach services, and no issues have been reported. 1566727 1 377725 pvollan 2019-08-30 10:51:48 -0700 Created attachment 377725 Patch 1567017 2 377725 ap 2019-08-31 17:22:35 -0700 Comment on attachment 377725 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377725&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-413 > - (global-name "com.apple.FileCoordination") > - (global-name "com.apple.FileProvider") Are all of these changes intended for this patch? 1580684 3 pvollan 2019-10-16 14:41:29 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 377725 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377725&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-413 > > - (global-name "com.apple.FileCoordination") > > - (global-name "com.apple.FileProvider") > > Are all of these changes intended for this patch? Yes, as part of removing the ubiquity rule, the explicit deny of these services are not needed anymore. Thanks for reviewing! 1580686 4 webkit-bug-importer 2019-10-16 14:44:07 -0700 <rdar://problem/56347708> 1580751 5 377725 bfulgham 2019-10-16 16:07:58 -0700 Comment on attachment 377725 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377725&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-456 > - (global-name "com.apple.quicklook.ThumbnailsAgent") Please make sure to test Mail.app after these changes (especially with attachments). 1580772 6 pvollan 2019-10-16 16:59:42 -0700 (In reply to Brent Fulgham from comment #5) > Comment on attachment 377725 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377725&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-456 > > - (global-name "com.apple.quicklook.ThumbnailsAgent") > > Please make sure to test Mail.app after these changes (especially with > attachments). Will do. Thanks for reviewing! 1580773 7 377725 commit-queue 2019-10-16 17:01:58 -0700 Comment on attachment 377725 Patch Rejecting attachment 377725 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 377725, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=377725&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=201347&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 377725 from bug 201347. Fetching: https://bugs.webkit.org/attachment.cgi?id=377725 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Hunk #2 succeeded at 402 (offset -4 lines). Hunk #3 FAILED at 409. Hunk #4 succeeded at 427 (offset -3 lines). Hunk #5 succeeded at 442 (offset -3 lines). 1 out of 5 hunks FAILED -- saving rejects to file Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13141008 1580780 8 381136 pvollan 2019-10-16 17:19:26 -0700 Created attachment 381136 Patch 1580794 9 381136 commit-queue 2019-10-16 17:36:59 -0700 Comment on attachment 381136 Patch Clearing flags on attachment: 381136 Committed r251219: <https://trac.webkit.org/changeset/251219> 377725 2019-08-30 10:51:48 -0700 2019-10-16 17:01:58 -0700 Patch bug-201347-20190830105147.patch text/plain 3086 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDkzMzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA4LTMwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSZW1vdmUgdWJpcXVp dHkgY2xpZW50IHJ1bGUgZnJvbSBzYW5kYm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEzNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHJ1bGUgaXMgbW9zdCBsaWtlbHkgbm90IG5lZWRlZCwg c2luY2Ugd2UgaGF2ZSBhbHJlYWR5IGJsb2NrZWQgYWxsIG9mIGl0cyBhc3NvY2lhdGVkIG1hY2gg c2VydmljZXMsCisgICAgICAgIGFuZCBubyBpc3N1ZXMgaGF2ZSBiZWVuIHJlcG9ydGVkLgorCisg ICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50LnNiOgorCiAyMDE5LTA4LTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgW1BTT05dIEJ1bXAgdGhlIFdlYlBhZ2UncyBpZGVudGlmaWVyIGV2ZXJ5 IHRpbWUgd2UgcHJvY2Vzcy1zd2FwCkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBs ZS5XZWJLaXQuV2ViQ29udGVudC5zYgkocmV2aXNpb24gMjQ5MjgwKQorKysgU291cmNlL1dlYktp dC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IJKHdvcmtpbmcgY29weSkKQEAgLTQwLDkgKzQwLDYgQEAKICAgICAoZ2xvYmFsLW5hbWUg ImNvbS5hcHBsZS5mcm9udGJvYXJkLnN5c3RlbWFwcHNlcnZpY2VzIikgICAgICAgICAgICAgICAg IDsgLVtVSVZpZXdTZXJ2aWNlSW50ZXJmYWNlIF9jcmVhdGVQcm9jZXNzQXNzZXJ0aW9uXSAtPiBT QlNQcm9jZXNzSURGb3JEaXNwbGF5SWRlbnRpZmllcigpCiAgICAgKGdsb2JhbC1uYW1lLXJlZ2V4 ICMiXmNvbVwuYXBwbGVcLnVpa2l0XC52aWV3c2VydmljZVwuLisiKSkKIAotOzsgQW55IGFwcCBj b3VsZCB1c2UgdWJpcXVpdHkuCi0odWJpcXVpdHktY2xpZW50KQotCiA7OyBBbnkgYXBwIGNhbiBw bGF5IGF1ZGlvICYgbW92aWVzLgogKHBsYXktYXVkaW8pCiAocGxheS1tZWRpYSkKQEAgLTQwOSw4 ICs0MDYsNiBAQAogOzsgZXN0YWJsaXNoZWQsIHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkzODQwCiAoZGVueSBtYWNoLWxvb2t1cAogICAgIChnbG9iYWwtbmFt ZSAiY29tLmFwcGxlLkNvcmVBdXRoZW50aWNhdGlvbi5kYWVtb24ubGlieHBjIikKLSAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5GaWxlQ29vcmRpbmF0aW9uIikKLSAgICAoZ2xvYmFsLW5hbWUg ImNvbS5hcHBsZS5GaWxlUHJvdmlkZXIiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkhv bmV5YmVlLmV2ZW50LW5vdGlmeSIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuTWVkaWFQ bGF5ZXIuUmVtb3RlUGxheWVyU2VydmljZSIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu UmVwb3J0Q3Jhc2guU2ltdWxhdGVDcmFzaCIpCkBAIC00MTgsOCArNDEzLDYgQEAKICAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5hcHBzdXBwb3J0LmNwbG9nZCIpCiAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuYXNzZXJ0aW9uZC5wcm9jZXNzYXNzZXJ0aW9uY29ubmVjdGlvbiIpCiAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8ucmVwb3J0aW5nLnhwYyIpCi0gICAgKGdsb2Jh bC1uYW1lICJjb20uYXBwbGUuYmlyZCIpCi0gICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYmly ZC50b2tlbiIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY2ZwcmVmc2QuYWdlbnQiKQog ICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvbnRhaW5lcm1hbmFnZXJkIikKICAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuYXNzZXRjYWNoZWluc3BlY3RvciIpCkBAIC00 MzcsNyArNDMwLDYgQEAKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5oYW5ndHJhY2VyZCIp CiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuaXR1bmVzY2xvdWRkLnhwYyIpCiAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuaXR1bmVzc3RvcmVkLnhwYyIpCi0gICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUubGlicmFyaWFuZCIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubG9j YXRpb25kLnNwaSIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubG9jYXRpb25kLnN5bmNo cm9ub3VzIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sc2QiKQpAQCAtNDUzLDggKzQ0 NSw2IEBACiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUucGVnYXN1cyIpCiAgICAgKGdsb2Jh bC1uYW1lICJjb20uYXBwbGUucGx1Z2lua2l0LnBrZCIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUucGx1Z2lua2l0LnBsdWdpbi1zZXJ2aWNlIikKLSAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5xdWlja2xvb2suVGh1bWJuYWlsc0FnZW50IikKLSAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5yZXZpc2lvbmQiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnNwcmluZ2JvYXJk LmJhY2tncm91bmRhcHBzZXJ2aWNlcyIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuc3lz dGVtLmxpYmluZm8ubXVzZXIiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmtpdC5j YW1lcmEiKQo= 381136 2019-10-16 17:19:26 -0700 2019-10-16 17:36:59 -0700 Patch bug-201347-20191016171925.patch text/plain 3078 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTEyMTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEwLTE2ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSZW1vdmUgdWJpcXVp dHkgY2xpZW50IHJ1bGUgZnJvbSBzYW5kYm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEzNDcKKworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBG dWxnaGFtLgorCisgICAgICAgIFRoaXMgcnVsZSBpcyBtb3N0IGxpa2VseSBub3QgbmVlZGVkLCBz aW5jZSB3ZSBoYXZlIGFscmVhZHkgYmxvY2tlZCBhbGwgb2YgaXRzIGFzc29jaWF0ZWQgbWFjaCBz ZXJ2aWNlcywKKyAgICAgICAgYW5kIG5vIGlzc3VlcyBoYXZlIGJlZW4gcmVwb3J0ZWQuCisKKyAg ICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQuc2I6CisKIDIwMTktMTAtMTYgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJlbW92ZSBzZW5kLXNpZ25hbCBmcm9tIG1hY2gtbG9v a3VwIHJ1bGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiCShyZXZpc2lvbiAyNTEyMTcpCisrKyBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgkod29ya2lu ZyBjb3B5KQpAQCAtNDAsOSArNDAsNiBAQAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmZy b250Ym9hcmQuc3lzdGVtYXBwc2VydmljZXMiKSAgICAgICAgICAgICAgICAgOyAtW1VJVmlld1Nl cnZpY2VJbnRlcmZhY2UgX2NyZWF0ZVByb2Nlc3NBc3NlcnRpb25dIC0+IFNCU1Byb2Nlc3NJREZv ckRpc3BsYXlJZGVudGlmaWVyKCkKICAgICAoZ2xvYmFsLW5hbWUtcmVnZXggIyJeY29tXC5hcHBs ZVwudWlraXRcLnZpZXdzZXJ2aWNlXC4uKyIpKQogCi07OyBBbnkgYXBwIGNvdWxkIHVzZSB1Ymlx dWl0eS4KLSh1YmlxdWl0eS1jbGllbnQpCi0KIDs7IEFueSBhcHAgY2FuIHBsYXkgYXVkaW8gJiBt b3ZpZXMuCiAocGxheS1hdWRpbykKIChwbGF5LW1lZGlhKQpAQCAtNDA1LDggKzQwMiw2IEBACiA7 OyBlc3RhYmxpc2hlZCwgc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTM4NDAKIChkZW55IG1hY2gtbG9va3VwCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu Q29yZUF1dGhlbnRpY2F0aW9uLmRhZW1vbi5saWJ4cGMiKQotICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLkZpbGVDb29yZGluYXRpb24iKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkZp bGVQcm92aWRlciIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuSG9uZXliZWUuZXZlbnQt bm90aWZ5IikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5NZWRpYVBsYXllci5SZW1vdGVQ bGF5ZXJTZXJ2aWNlIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5SZXBvcnRDcmFzaC5T aW11bGF0ZUNyYXNoIikKQEAgLTQxNSw4ICs0MTAsNiBAQAogICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmFzc2VydGlvbmQucHJvY2Vzc2Fzc2VydGlvbmNvbm5lY3Rpb24iKQogICAgIChnbG9i YWwtbmFtZSAiY29tLmFwcGxlLmF1ZGlvLnJlcG9ydGluZy54cGMiKQogICAgIChnbG9iYWwtbmFt ZSAiY29tLmFwcGxlLmJhY2tib2FyZC5oaWQuc2VydmljZXMiKQotICAgIChnbG9iYWwtbmFtZSAi Y29tLmFwcGxlLmJpcmQiKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmJpcmQudG9rZW4i KQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNmcHJlZnNkLmFnZW50IikKICAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5jb250YWluZXJtYW5hZ2VyZCIpCiAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuY29yZW1lZGlhLmFzc2V0Y2FjaGVpbnNwZWN0b3IiKQpAQCAtNDM0LDcgKzQy Nyw2IEBACiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuaGFuZ3RyYWNlcmQiKQogICAgIChn bG9iYWwtbmFtZSAiY29tLmFwcGxlLml0dW5lc2Nsb3VkZC54cGMiKQogICAgIChnbG9iYWwtbmFt ZSAiY29tLmFwcGxlLml0dW5lc3N0b3JlZC54cGMiKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLmxpYnJhcmlhbmQiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxvY2F0aW9uZC5z cGkiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmxvY2F0aW9uZC5zeW5jaHJvbm91cyIp CiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubHNkIikKQEAgLTQ1MCw4ICs0NDIsNiBAQAog ICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnBlZ2FzdXMiKQogICAgIChnbG9iYWwtbmFtZSAi Y29tLmFwcGxlLnBsdWdpbmtpdC5wa2QiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnBs dWdpbmtpdC5wbHVnaW4tc2VydmljZSIpCi0gICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUucXVp Y2tsb29rLlRodW1ibmFpbHNBZ2VudCIpCi0gICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUucmV2 aXNpb25kIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5zcHJpbmdib2FyZC5iYWNrZ3Jv dW5kYXBwc2VydmljZXMiKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnN5c3RlbS5saWJp bmZvLm11c2VyIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS53ZWJraXQuY2FtZXJhIikK