201340 2019-08-30 07:00:57 -0700 [GTK][WPE] Do not run the Bubblewrap executable when configuring for cross-compilation 2019-09-15 06:30:09 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand aperez annulen aperez bugs-noreply clopez commit-queue ews-watchlist gyuyoung.kim pgriffis pnormand rakuco ryuan.choi sergio oldest_to_newest 1566644 0 pnormand 2019-08-30 07:00:57 -0700 . 1566645 1 pgriffis 2019-08-30 07:07:16 -0700 Yes it is technically only required at runtime but there are two things gained by checking for it at build time. - We gain an absolute path to the binary we can rely on. - There will be no mistakes made by distros missing the dependency. xdg-dbus-proxy is a new project nobody packages and the sandbox is disabled by default so I guarantee all distros would skip this dependency if we didn't error loudly. 1566646 2 pnormand 2019-08-30 07:13:08 -0700 Checking for it at build-time doesn't guarantee the runtime host will have the program located at the same place though. As Adrian pointed out, the CMake stuff should allow for an option specifying the absolute path of the program. 1570897 3 aperez 2019-09-14 14:31:48 -0700 (In reply to Philippe Normand from comment #2) > Checking for it at build-time doesn't guarantee the runtime host will have > the program located at the same place though. > > As Adrian pointed out, the CMake stuff should allow for an option specifying > the absolute path of the program. I have checked things a bit in this regard. I have both “yay” and “meh” news: - The good news is that it is already possible to override the path passing “-DDBUS_PROXY_EXECUTABLE=/path/in/target/xdg-dbus-proxy” when invoking CMake—if the variable is set on the command line, then find_program() will skip guessing the location of the program. - On the other hand, we still need to avoid running programs which will be used only at run-time during CMake configuration *when cross-compiling*, because a.) they may not be installed in the build host, and b.) if they are available in the build host, they may not be the same version installed in the target. The second one is currently an issue because we are currently running “bwrap --version” from “Source/cmake/BubblewrapSandboxChecks.cmake” unconditionally. Let's re-purpose this bug for this. 1570900 4 378803 aperez 2019-09-14 14:53:39 -0700 Created attachment 378803 Patch 1570909 5 378803 annulen 2019-09-14 17:42:43 -0700 Comment on attachment 378803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378803&action=review > Source/cmake/BubblewrapSandboxChecks.cmake:26 > + string(REGEX MATCH "([0-9]+.[0-9]+.[0-9]+)" BWRAP_VERSION "${BWRAP_OUTPUT}") Seems like there is a bug in regex - it should check for literal dot in version, so dot must be escaped. 1570910 6 378803 annulen 2019-09-14 17:56:16 -0700 Comment on attachment 378803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378803&action=review >> Source/cmake/BubblewrapSandboxChecks.cmake:26 >> + string(REGEX MATCH "([0-9]+.[0-9]+.[0-9]+)" BWRAP_VERSION "${BWRAP_OUTPUT}") > > Seems like there is a bug in regex - it should check for literal dot in version, so dot must be escaped. Should be string(REGEX MATCH "[0-9]+\\.[0-9]+\\.[0-9]+" BWRAP_VERSION ${BWRAP_OUTPUT}) 1570925 7 aperez 2019-09-15 05:39:01 -0700 (In reply to Konstantin Tokarev from comment #6) > Comment on attachment 378803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378803&action=review > > >> Source/cmake/BubblewrapSandboxChecks.cmake:26 > >> + string(REGEX MATCH "([0-9]+.[0-9]+.[0-9]+)" BWRAP_VERSION "${BWRAP_OUTPUT}") > > > > Seems like there is a bug in regex - it should check for literal dot in version, so dot must be escaped. > > Should be > > string(REGEX MATCH "[0-9]+\\.[0-9]+\\.[0-9]+" BWRAP_VERSION ${BWRAP_OUTPUT}) This was already wrong before my changes. Good catch, I will fix it before landing, thanks! 1570926 8 378809 aperez 2019-09-15 05:46:35 -0700 Created attachment 378809 Patch for landing 1570929 9 378809 commit-queue 2019-09-15 06:30:07 -0700 Comment on attachment 378809 Patch for landing Clearing flags on attachment: 378809 Committed r249883: <https://trac.webkit.org/changeset/249883> 1570930 10 commit-queue 2019-09-15 06:30:09 -0700 All reviewed patches have been landed. Closing bug. 378803 2019-09-14 14:53:39 -0700 2019-09-15 05:46:30 -0700 Patch bug-201340-20190915005338.patch text/plain 3554 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvQnVi Ymxld3JhcFNhbmRib3hDaGVja3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvQnViYmxld3JhcFNhbmRi b3hDaGVja3MuY21ha2UKaW5kZXggYWM4ZmJiZjNjOGViMDE0NzUxOTFkYzdkNjJlOGRhNmJkMTk4 OTA3Ni4uMTdmNjM5YWI2NDA1Yjg3YmVmODNiYjZmNTVjZDMzMTVlYTYwN2VkOSAxMDA2NDQKLS0t IGEvU291cmNlL2NtYWtlL0J1YmJsZXdyYXBTYW5kYm94Q2hlY2tzLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9CdWJibGV3cmFwU2FuZGJveENoZWNrcy5jbWFrZQpAQCAtMywyMCArMyw2IEBAIGlm IChFTkFCTEVfQlVCQkxFV1JBUF9TQU5EQk9YKQogICAgIGlmIChOT1QgQldSQVBfRVhFQ1VUQUJM RSkKICAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiYndyYXAgZXhlY3V0YWJsZSBpcyBuZWVk ZWQgZm9yIEVOQUJMRV9CVUJCTEVXUkFQX1NBTkRCT1giKQogICAgIGVuZGlmICgpCi0gICAgYWRk X2RlZmluaXRpb25zKC1EQldSQVBfRVhFQ1VUQUJMRT0iJHtCV1JBUF9FWEVDVVRBQkxFfSIpCi0K LSAgICBleGVjdXRlX3Byb2Nlc3MoCi0gICAgICAgIENPTU1BTkQgIiR7QldSQVBfRVhFQ1VUQUJM RX0iIC0tdmVyc2lvbgotICAgICAgICBSRVNVTFRfVkFSSUFCTEUgQldSQVBfUkVUCi0gICAgICAg IE9VVFBVVF9WQVJJQUJMRSBCV1JBUF9PVVRQVVQKLSAgICApCi0gICAgaWYgKEJXUkFQX1JFVCkK LSAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiRmFpbGVkIHRvIHJ1biAke0JXUkFQX0VYRUNV VEFCTEV9IikKLSAgICBlbmRpZiAoKQotICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiKFswLTldKy5b MC05XSsuWzAtOV0rKSIgQldSQVBfVkVSU0lPTiAiJHtCV1JBUF9PVVRQVVR9IikKLSAgICBpZiAo Tk9UICIke0JXUkFQX1ZFUlNJT059IiBWRVJTSU9OX0dSRUFURVJfRVFVQUwgIjAuMy4xIikKLSAg ICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiYndyYXAgbXVzdCBiZSA+PSAwLjMuMSBidXQgJHtC V1JBUF9WRVJTSU9OfSBmb3VuZCIpCi0gICAgZW5kaWYgKCkKIAogICAgIGZpbmRfcGFja2FnZShM aWJzZWNjb21wKQogICAgIGlmIChOT1QgTElCU0VDQ09NUF9GT1VORCkKQEAgLTI3LDUgKzEzLDMy IEBAIGlmIChFTkFCTEVfQlVCQkxFV1JBUF9TQU5EQk9YKQogICAgIGlmIChOT1QgREJVU19QUk9Y WV9FWEVDVVRBQkxFKQogICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJ4ZGctZGJ1cy1wcm94 eSBub3QgZm91bmQgYW5kIGlzIG5lZWRlZCBmb3IgRU5BQkxFX0JVQkJMRVdSQVBfU0FOREJPWCIp CiAgICAgZW5kaWYgKCkKKworICAgIGlmIChOT1QgQ01BS0VfQ1JPU1NDT01QSUxJTkcpCisgICAg ICAgIGV4ZWN1dGVfcHJvY2VzcygKKyAgICAgICAgICAgIENPTU1BTkQgIiR7QldSQVBfRVhFQ1VU QUJMRX0iIC0tdmVyc2lvbgorICAgICAgICAgICAgUkVTVUxUX1ZBUklBQkxFIEJXUkFQX1JFVAor ICAgICAgICAgICAgT1VUUFVUX1ZBUklBQkxFIEJXUkFQX09VVFBVVAorICAgICAgICApCisgICAg ICAgIGlmIChCV1JBUF9SRVQpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJGYWls ZWQgdG8gcnVuICR7QldSQVBfRVhFQ1VUQUJMRX0iKQorICAgICAgICBlbmRpZiAoKQorICAgICAg ICBzdHJpbmcoUkVHRVggTUFUQ0ggIihbMC05XSsuWzAtOV0rLlswLTldKykiIEJXUkFQX1ZFUlNJ T04gIiR7QldSQVBfT1VUUFVUfSIpCisgICAgICAgIGlmIChOT1QgIiR7QldSQVBfVkVSU0lPTn0i IFZFUlNJT05fR1JFQVRFUl9FUVVBTCAiMC4zLjEiKQorICAgICAgICAgICAgbWVzc2FnZShGQVRB TF9FUlJPUiAiYndyYXAgbXVzdCBiZSA+PSAwLjMuMSBidXQgJHtCV1JBUF9WRVJTSU9OfSBmb3Vu ZCIpCisgICAgICAgIGVuZGlmICgpCisgICAgZWxzZWlmIChOT1QgU0lMRU5DRV9DUk9TU19DT01Q SUxBVElPTl9OT1RJQ0VTKQorICAgICAgICBtZXNzYWdlKE5PVElDRQorICAgICAgICAgICAgIioq Ki0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t KioqXG4iCisgICAgICAgICAgICAiKioqICBDYW5ub3QgY2hlY2sgQnViYmxld3JhcCB2ZXJzaW9u IHdoZW4gY3Jvc3MtY29tcGlsaW5nLiAqKipcbiIKKyAgICAgICAgICAgICIqKiogIFRoZSB0YXJn ZXQgc3lzdGVtIE1VU1QgaGF2ZSB2ZXJzaW9uIDAuMy4xIG9yIG5ld2VyLiAgICoqKlxuIgorICAg ICAgICAgICAgIioqKiAgVXNlIHRoZSBCV1JBUF9FWEVDVVRBQkxFIGFuZCBEQlVTX1BST1hZX0VY RUNVVEFCTEUgICAgKioqXG4iCisgICAgICAgICAgICAiKioqICB2YXJpYWJsZXMgdG8gc2V0IHRo ZSBydW4tdGltZSBwYXRocyBmb3IgdGhlICdid3JhcCcgICAqKipcbiIKKyAgICAgICAgICAgICIq KiogIGFuZCAneGRnLWRidXMtcHJveHknIHByb2dyYW1zLiAgICAgICAgICAgICAgICAgICAgICAg ICoqKlxuIgorICAgICAgICAgICAgIioqKi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKioqIgorICAgICAgICApCisgICAgZW5kaWYgKCkKKwor ICAgIGFkZF9kZWZpbml0aW9ucygtREJXUkFQX0VYRUNVVEFCTEU9IiR7QldSQVBfRVhFQ1VUQUJM RX0iKQogICAgIGFkZF9kZWZpbml0aW9ucygtRERCVVNfUFJPWFlfRVhFQ1VUQUJMRT0iJHtEQlVT X1BST1hZX0VYRUNVVEFCTEV9IikKIGVuZGlmICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D aGFuZ2VMb2cKaW5kZXggNjZmNTRhNDI4NWZlOTJkNTFlNjFhNjc3ODNhZTdkZDliOGY4ODBkYS4u NTkyMDNmN2ViYjkwNGM2OTBjZjUxMWJhYTA2NGUzNjJiMjE5MjlhMyAxMDA2NDQKLS0tIGEvQ2hh bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA5LTE0ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V1BFXSBEbyBub3QgcnVuIHRoZSBCdWJibGV3cmFwIGV4ZWN1dGFibGUgd2hlbiBjb25maWd1cmlu ZyBmb3IgY3Jvc3MtY29tcGlsYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMTM0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0J1YmJsZXdyYXBTYW5kYm94Q2hlY2tzLmNt YWtlOiBEbyBub3QgcnVuIHRoZQorICAgICAgICBCdWJibGV3cmFwIGV4ZWN1dGFibGUgd2hlbiBj cm9zcy1jb21waWxpbmcgdG8gZ3Vlc3MgaXRzIHZlcnNpb24uCisgICAgICAgIEVtaXQgYSB3YXJu aW5nIGluc3RlYWQgYW5kIHRydXN0IHRoYXQgdmFsaWQgcnVuLXRpbWUgcGF0aHMgd2lsbAorICAg ICAgICBiZSBzZXQgdXNpbmcgdGhlIEJXUkFQX0VYRUNVVEFCTEUgYW5kIERCVVNfUFJPWFlfRVhF Q1VUQUJMRQorICAgICAgICB2YXJpYWJsZXMuCisKIDIwMTktMDktMDkgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEJ1bXAg R1RLIHZlcnNpb24gbnVtYmVycwo= 378809 2019-09-15 05:46:35 -0700 2019-09-15 06:30:07 -0700 Patch for landing bug-201340-20190915154634.patch text/plain 3693 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvQnVi Ymxld3JhcFNhbmRib3hDaGVja3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvQnViYmxld3JhcFNhbmRi b3hDaGVja3MuY21ha2UKaW5kZXggYWM4ZmJiZjNjOGViMDE0NzUxOTFkYzdkNjJlOGRhNmJkMTk4 OTA3Ni4uNzNjZjRmZmVkMzU3NDIyMzMyZDQ0YzZjNzdmMzcxN2JjMmUzYzNlMyAxMDA2NDQKLS0t IGEvU291cmNlL2NtYWtlL0J1YmJsZXdyYXBTYW5kYm94Q2hlY2tzLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9CdWJibGV3cmFwU2FuZGJveENoZWNrcy5jbWFrZQpAQCAtMywyMCArMyw2IEBAIGlm IChFTkFCTEVfQlVCQkxFV1JBUF9TQU5EQk9YKQogICAgIGlmIChOT1QgQldSQVBfRVhFQ1VUQUJM RSkKICAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiYndyYXAgZXhlY3V0YWJsZSBpcyBuZWVk ZWQgZm9yIEVOQUJMRV9CVUJCTEVXUkFQX1NBTkRCT1giKQogICAgIGVuZGlmICgpCi0gICAgYWRk X2RlZmluaXRpb25zKC1EQldSQVBfRVhFQ1VUQUJMRT0iJHtCV1JBUF9FWEVDVVRBQkxFfSIpCi0K LSAgICBleGVjdXRlX3Byb2Nlc3MoCi0gICAgICAgIENPTU1BTkQgIiR7QldSQVBfRVhFQ1VUQUJM RX0iIC0tdmVyc2lvbgotICAgICAgICBSRVNVTFRfVkFSSUFCTEUgQldSQVBfUkVUCi0gICAgICAg IE9VVFBVVF9WQVJJQUJMRSBCV1JBUF9PVVRQVVQKLSAgICApCi0gICAgaWYgKEJXUkFQX1JFVCkK LSAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiRmFpbGVkIHRvIHJ1biAke0JXUkFQX0VYRUNV VEFCTEV9IikKLSAgICBlbmRpZiAoKQotICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiKFswLTldKy5b MC05XSsuWzAtOV0rKSIgQldSQVBfVkVSU0lPTiAiJHtCV1JBUF9PVVRQVVR9IikKLSAgICBpZiAo Tk9UICIke0JXUkFQX1ZFUlNJT059IiBWRVJTSU9OX0dSRUFURVJfRVFVQUwgIjAuMy4xIikKLSAg ICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiYndyYXAgbXVzdCBiZSA+PSAwLjMuMSBidXQgJHtC V1JBUF9WRVJTSU9OfSBmb3VuZCIpCi0gICAgZW5kaWYgKCkKIAogICAgIGZpbmRfcGFja2FnZShM aWJzZWNjb21wKQogICAgIGlmIChOT1QgTElCU0VDQ09NUF9GT1VORCkKQEAgLTI3LDUgKzEzLDMy IEBAIGlmIChFTkFCTEVfQlVCQkxFV1JBUF9TQU5EQk9YKQogICAgIGlmIChOT1QgREJVU19QUk9Y WV9FWEVDVVRBQkxFKQogICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJ4ZGctZGJ1cy1wcm94 eSBub3QgZm91bmQgYW5kIGlzIG5lZWRlZCBmb3IgRU5BQkxFX0JVQkJMRVdSQVBfU0FOREJPWCIp CiAgICAgZW5kaWYgKCkKKworICAgIGlmIChOT1QgQ01BS0VfQ1JPU1NDT01QSUxJTkcpCisgICAg ICAgIGV4ZWN1dGVfcHJvY2VzcygKKyAgICAgICAgICAgIENPTU1BTkQgIiR7QldSQVBfRVhFQ1VU QUJMRX0iIC0tdmVyc2lvbgorICAgICAgICAgICAgUkVTVUxUX1ZBUklBQkxFIEJXUkFQX1JFVAor ICAgICAgICAgICAgT1VUUFVUX1ZBUklBQkxFIEJXUkFQX09VVFBVVAorICAgICAgICApCisgICAg ICAgIGlmIChCV1JBUF9SRVQpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJGYWls ZWQgdG8gcnVuICR7QldSQVBfRVhFQ1VUQUJMRX0iKQorICAgICAgICBlbmRpZiAoKQorICAgICAg ICBzdHJpbmcoUkVHRVggTUFUQ0ggIlswLTldK1xcLlswLTldK1xcLlswLTldKyIgQldSQVBfVkVS U0lPTiAiJHtCV1JBUF9PVVRQVVR9IikKKyAgICAgICAgaWYgKE5PVCAiJHtCV1JBUF9WRVJTSU9O fSIgVkVSU0lPTl9HUkVBVEVSX0VRVUFMICIwLjMuMSIpCisgICAgICAgICAgICBtZXNzYWdlKEZB VEFMX0VSUk9SICJid3JhcCBtdXN0IGJlID49IDAuMy4xIGJ1dCAke0JXUkFQX1ZFUlNJT059IGZv dW5kIikKKyAgICAgICAgZW5kaWYgKCkKKyAgICBlbHNlaWYgKE5PVCBTSUxFTkNFX0NST1NTX0NP TVBJTEFUSU9OX05PVElDRVMpCisgICAgICAgIG1lc3NhZ2UoTk9USUNFCisgICAgICAgICAgICAi KioqLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0qKipcbiIKKyAgICAgICAgICAgICIqKiogIENhbm5vdCBjaGVjayBCdWJibGV3cmFwIHZlcnNp b24gd2hlbiBjcm9zcy1jb21waWxpbmcuICoqKlxuIgorICAgICAgICAgICAgIioqKiAgVGhlIHRh cmdldCBzeXN0ZW0gTVVTVCBoYXZlIHZlcnNpb24gMC4zLjEgb3IgbmV3ZXIuICAgKioqXG4iCisg ICAgICAgICAgICAiKioqICBVc2UgdGhlIEJXUkFQX0VYRUNVVEFCTEUgYW5kIERCVVNfUFJPWFlf RVhFQ1VUQUJMRSAgICAqKipcbiIKKyAgICAgICAgICAgICIqKiogIHZhcmlhYmxlcyB0byBzZXQg dGhlIHJ1bi10aW1lIHBhdGhzIGZvciB0aGUgJ2J3cmFwJyAgICoqKlxuIgorICAgICAgICAgICAg IioqKiAgYW5kICd4ZGctZGJ1cy1wcm94eScgcHJvZ3JhbXMuICAgICAgICAgICAgICAgICAgICAg ICAgKioqXG4iCisgICAgICAgICAgICAiKioqLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0qKioiCisgICAgICAgICkKKyAgICBlbmRpZiAoKQor CisgICAgYWRkX2RlZmluaXRpb25zKC1EQldSQVBfRVhFQ1VUQUJMRT0iJHtCV1JBUF9FWEVDVVRB QkxFfSIpCiAgICAgYWRkX2RlZmluaXRpb25zKC1EREJVU19QUk9YWV9FWEVDVVRBQkxFPSIke0RC VVNfUFJPWFlfRVhFQ1VUQUJMRX0iKQogZW5kaWYgKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCA2NmY1NGE0Mjg1ZmU5MmQ1MWU2MWE2Nzc4M2FlN2RkOWI4Zjg4MGRh Li5jNWI4YWVhMTBjYThhNWNhZGViZmVkMjRkYWZkNWExMmY4NzNkMWJhIDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDktMTQgIEFk cmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XVtXUEVdIERvIG5vdCBydW4gdGhlIEJ1YmJsZXdyYXAgZXhlY3V0YWJsZSB3aGVuIGNvbmZpZ3Vy aW5nIGZvciBjcm9zcy1jb21waWxhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMzQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS29uc3RhbnRp biBUb2thcmV2LgorCisgICAgICAgICogU291cmNlL2NtYWtlL0J1YmJsZXdyYXBTYW5kYm94Q2hl Y2tzLmNtYWtlOiBEbyBub3QgcnVuIHRoZQorICAgICAgICBCdWJibGV3cmFwIGV4ZWN1dGFibGUg d2hlbiBjcm9zcy1jb21waWxpbmcgdG8gZ3Vlc3MgaXRzIHZlcnNpb24uCisgICAgICAgIEVtaXQg YSB3YXJuaW5nIGluc3RlYWQgYW5kIHRydXN0IHRoYXQgdmFsaWQgcnVuLXRpbWUgcGF0aHMgd2ls bAorICAgICAgICBiZSBzZXQgdXNpbmcgdGhlIEJXUkFQX0VYRUNVVEFCTEUgYW5kIERCVVNfUFJP WFlfRVhFQ1VUQUJMRQorICAgICAgICB2YXJpYWJsZXMuIFdoaWxlIGF0IGl0LCBmaXggdGhlIHJl Z3VsYXIgZXhwcmVzc2lvbiB1c2VkIHRvIG1hdGNoCisgICAgICAgIHRoZSB2ZXJzaW9uIHN0cmlu ZyBpbiB0aGUgQnViYmxld3JhcCBvdXRwdXQgd2hlbiBub3QgY3Jvc3MtY29tcGlsaW5nLgorCiAy MDE5LTA5LTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLiBCdW1wIEdUSyB2ZXJzaW9uIG51bWJlcnMK