201320 2019-08-29 16:50:25 -0700 Invalid XPCServices symlinks are being created 2019-08-29 18:57:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue darin ddkilzer mitz webkit-bug-importer oldest_to_newest 1566460 0 krollin 2019-08-29 16:50:25 -0700 When performing incremental builds, errant XPCServices symlinks can be created. For example, in the following, the second symlink is the correct one. The first symlink gets created when the build process tries to create the symlink and it already exists. When it already exists, the command to create the symlink actually follows the existing symlink and creates the (second) symlink at the location where the first symlink points. WebKit.framework/Versions/A/XPCServices/XPCServices@ -> Versions/Current/XPCServices WebKit.framework/XPCServices@ -> Versions/Current/XPCServices Address this by first removing any previous symlink before creating the new one. <rdar://problem/54719612> 1566462 1 mitz 2019-08-29 16:51:51 -0700 (In reply to Keith Rollin from comment #0) > Address this by first removing any previous symlink before creating the new > one. The -f option to ln(3) should do this. Perhaps it’s not being specified. 1566463 2 mitz 2019-08-29 16:52:18 -0700 (In reply to mitz from comment #1) > The -f option to ln(3) should do this. Perhaps it’s not being specified. I meant ln(1). 1566464 3 mitz 2019-08-29 16:52:57 -0700 Oh but we should also be specifying -h in that case. 1566465 4 krollin 2019-08-29 16:55:15 -0700 We were specifying -f. I'll use the solution with -h. 1566471 5 377654 krollin 2019-08-29 17:00:19 -0700 Created attachment 377654 Patch 1566514 6 377654 commit-queue 2019-08-29 18:57:07 -0700 Comment on attachment 377654 Patch Clearing flags on attachment: 377654 Committed r249308: <https://trac.webkit.org/changeset/249308> 1566515 7 commit-queue 2019-08-29 18:57:09 -0700 All reviewed patches have been landed. Closing bug. 377654 2019-08-29 17:00:19 -0700 2019-08-29 18:57:07 -0700 Patch bug-201320-20190829170018.patch text/plain 2718 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0NGUxNGM2ZTRjOGU4YzU4 YjljMjMzZjAxODQ0MDNlMzUyZDVlYmYuLjY0NDI5N2E1NWRmZWQzMjdlNjU4NDdmNDE3YzM1OTRk MTE2ZGFhMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTktMDgtMjkgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEludmFsaWQgWFBDU2VydmljZXMg c3ltbGlua3MgYXJlIGJlaW5nIGNyZWF0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMTMyMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ3MTk2 MTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBwZXJmb3JtaW5nIGluY3JlbWVudGFsIGJ1aWxkcywgZXJyYW50IFhQQ1NlcnZpY2VzIHN5bWxp bmtzIGNhbiBiZQorICAgICAgICBjcmVhdGVkLiBGb3IgZXhhbXBsZSwgaW4gdGhlIGZvbGxvd2lu ZywgdGhlIHNlY29uZCBzeW1saW5rIGlzIHRoZQorICAgICAgICBjb3JyZWN0IG9uZS4gVGhlIGZp cnN0IHN5bWxpbmsgZ2V0cyBjcmVhdGVkIHdoZW4gdGhlIGJ1aWxkIHByb2Nlc3MKKyAgICAgICAg dHJpZXMgdG8gY3JlYXRlIHRoZSBzeW1saW5rIGFuZCBpdCBhbHJlYWR5IGV4aXN0cy4gV2hlbiBp dCBhbHJlYWR5CisgICAgICAgIGV4aXN0cywgdGhlIGNvbW1hbmQgdG8gY3JlYXRlIHRoZSBzeW1s aW5rIGFjdHVhbGx5IGZvbGxvd3MgdGhlCisgICAgICAgIGV4aXN0aW5nIHN5bWxpbmsgYW5kIGNy ZWF0ZXMgdGhlIChzZWNvbmQpIHN5bWxpbmsgYXQgdGhlIGxvY2F0aW9uCisgICAgICAgIHdoZXJl IHRoZSBmaXJzdCBzeW1saW5rIHBvaW50cy4KKworICAgICAgICAgICAgV2ViS2l0LmZyYW1ld29y ay9WZXJzaW9ucy9BL1hQQ1NlcnZpY2VzL1hQQ1NlcnZpY2VzQCAtPiBWZXJzaW9ucy9DdXJyZW50 L1hQQ1NlcnZpY2VzCisgICAgICAgICAgICBXZWJLaXQuZnJhbWV3b3JrL1hQQ1NlcnZpY2VzQCAt PiBWZXJzaW9ucy9DdXJyZW50L1hQQ1NlcnZpY2VzCisKKyAgICAgICAgQWRkcmVzcyB0aGlzIGJ5 IHNwZWNpZnlpbmcgLWggdG8gdGhlIGBsbmAgY29tbWFuZCwgd2hpY2ggd2lsbCBjYXVzZSBpdAor ICAgICAgICB0byBub3QgZm9sbG93IHN5bWxpbmtzIGlmIHRoZXkgYWxyZWFkeSBleGlzdCBhdCB0 aGUgdGFyZ2V0LgorCisgICAgICAgIEFsc28sIGZpeCBhIGJlbmlnbiBpc3N1ZSB3aGVyZSB0aGUg WGNvZGUgYnVpbGQgdmFyaWFibGUgV1JBUFBFUl9OQU1FCisgICAgICAgIHdhcyBiZWluZyByZWZl cmVuY2VkIGluIGEgY29udGV4dCB3aGVyZSBpdCB3YXNuJ3QgZGVmaW5lZC4KKworICAgICAgICAq IFdlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDE5LTA4LTI4ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgTnVsbCBjaGVjayB3 ZWJGcmFtZSB3aGVuIGNyZWF0aW5nIGEgcHJpbnQgcHJldmlldyB0byBwcmV2ZW50IGEgY3Jhc2gu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhw cm9qIGIvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRl eCAwMjZmODU3YWZkMzQyM2Q2Zjc3ZDc0ZDFhZmFmOWExOWZjZGZkOGU4Li4yMzAwYmM5NTE2ZGIx YWQ1M2ZkMmQ3Mzc2NmNhMWZkMjFkYzJmNjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dl YktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViS2l0 Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTExMDgyLDExICsxMTA4MiwxMSBAQAogCQkJ KTsKIAkJCW5hbWUgPSAiQWRkIFhQQ1NlcnZpY2VzIHN5bWxpbmsiOwogCQkJb3V0cHV0UGF0aHMg PSAoCi0JCQkJIiQoQlVJTFRfUFJPRFVDVFNfRElSKS8kKFdSQVBQRVJfTkFNRSkvV2ViS2l0LmZy YW1ld29yay9YUENTZXJ2aWNlcyIsCisJCQkJIiQoQlVJTFRfUFJPRFVDVFNfRElSKS9XZWJLaXQu ZnJhbWV3b3JrL1hQQ1NlcnZpY2VzIiwKIAkJCSk7CiAJCQlydW5Pbmx5Rm9yRGVwbG95bWVudFBv c3Rwcm9jZXNzaW5nID0gMDsKIAkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7Ci0JCQlzaGVsbFNjcmlw dCA9ICJpZiBbWyAke1dLX1BMQVRGT1JNX05BTUV9ID09IG1hY29zeCBdXTsgdGhlblxuICAgIGxu IC1zZiBcIlZlcnNpb25zL0N1cnJlbnQvWFBDU2VydmljZXNcIiBcIiR7QlVJTFRfUFJPRFVDVFNf RElSfS9XZWJLaXQuZnJhbWV3b3JrL1hQQ1NlcnZpY2VzXCI7XG5maVxuIjsKKwkJCXNoZWxsU2Ny aXB0ID0gImlmIFtbICR7V0tfUExBVEZPUk1fTkFNRX0gPT0gbWFjb3N4IF1dOyB0aGVuXG4gICAg bG4gLXNmaCBcIlZlcnNpb25zL0N1cnJlbnQvWFBDU2VydmljZXNcIiBcIiR7QlVJTFRfUFJPRFVD VFNfRElSfS9XZWJLaXQuZnJhbWV3b3JrL1hQQ1NlcnZpY2VzXCI7XG5maVxuIjsKIAkJfTsKIAkJ QzBDRTcyODQxMjQ3RTY2ODAwQkMwRUM0IC8qIEdlbmVyYXRlIERlcml2ZWQgU291cmNlcyAqLyA9 IHsKIAkJCWlzYSA9IFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsK