201301 2019-08-29 06:53:30 -0700 [WPE][Qt] loadingChanged signal parameter is unusable 2019-08-30 01:29:58 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand bugs-noreply cgarcia ews-watchlist glenn oldest_to_newest 1566207 0 pnormand 2019-08-29 06:53:30 -0700 The WPEQtView class can't rely on the readability/parameter_name rule, because omitting parameter names for QML signals leads to runtime errors. 1566210 1 377578 pnormand 2019-08-29 06:56:50 -0700 Created attachment 377578 Patch 1566596 2 pnormand 2019-08-30 01:29:58 -0700 Committed r249318: <https://trac.webkit.org/changeset/249318> 377578 2019-08-29 06:56:50 -0700 2019-08-29 23:26:40 -0700 Patch bug-201301-20190829145649.patch text/plain 3553 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmNWY5NTBlZjlmYzg5MzNj NTBhNmUxOGQwZTEzMzk4MjUzNzc4ZTguLjA2MTBjZDRiNjRjYjIzYWU3NzFhNzE3ODFmNzM2NmYw YzhiN2I3NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDgtMjkgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW1F0XSBsb2Fk aW5nQ2hhbmdlZCBzaWduYWwgcGFyYW1ldGVyIGlzIHVudXNhYmxlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEzMDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQ RVF0Vmlldy5oOiBFeHBsaWNpdGVseSBuYW1lIHNpZ25hbAorICAgICAgICBwYXJhbWV0ZXIuIEl0 IGlzIGEgcnVudGltZSByZXF1aXJlbWVudCBmb3IgUU1MLgorCiAyMDE5LTA4LTI4ICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbG9hZGluZyBhIHdl YiB2aWV3IHdpdGggYSBmaXhlZC13aWR0aCB2aWV3cG9ydCBhbmQgdmFyaWFibGUgY29udGVudCB3 aWR0aCByZXN0b3JlcyB0aGUgcHJldmlvdXMgcGFnZSBzY2FsZSwgc2hvdWxkbid0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5oIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuaAppbmRleCAxYWY4ZTFj NjE0YTJlMDk3ZmM3MTQ4YjkyZTVkNjNhNzI2ZDRmNTE0Li4wZjI4MmJkMmFiYzkzYzE5NTY1YTRi NzJjMjAzZjU0OWYxOTFlNThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvd3BlL3F0L1dQRVF0Vmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93 cGUvcXQvV1BFUXRWaWV3LmgKQEAgLTc3LDcgKzc3LDcgQEAgUV9TSUdOQUxTOgogICAgIHZvaWQg d2ViVmlld0NyZWF0ZWQoKTsKICAgICB2b2lkIHVybENoYW5nZWQoKTsKICAgICB2b2lkIHRpdGxl Q2hhbmdlZCgpOwotICAgIHZvaWQgbG9hZGluZ0NoYW5nZWQoV1BFUXRWaWV3TG9hZFJlcXVlc3Qq KTsKKyAgICB2b2lkIGxvYWRpbmdDaGFuZ2VkKFdQRVF0Vmlld0xvYWRSZXF1ZXN0KiBsb2FkUmVx dWVzdCk7CiAgICAgdm9pZCBsb2FkUHJvZ3Jlc3NDaGFuZ2VkKCk7CiAKIHByb3RlY3RlZDoKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0YjM4NWNh ZjNlZTdmYjZiOGQ2ODcwNTBhODA1MzM3MDE4YmE2Njk5Li4zOGYxOTJjZTg0MGY0ZTE3NzQ3NzEw NjgwMjIzZjBjMTEzMTAyZTFlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMjkgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW1F0XSBsb2FkaW5nQ2hh bmdlZCBzaWduYWwgcGFyYW1ldGVyIGlzIHVudXNhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEzMDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL3dwZS9xdC9tYWluLnFtbDog QWRkIGEgYmFzaWMgbG9hZGluZ0NoYW5nZSBzaWduYWwgaGFuZGxlci4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6IFdoaXRlLWxpc3QgV1BFUXRWaWV3LmggZm9y CisgICAgICAgIHJlYWRhYmxpdHkvcGFyYW1ldGVyX25hbWUgY29kZSBzdHlsIGNoZWNrZXIgcnVs ZS4KKwogMjAxOS0wOC0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNv bT4KIAogICAgICAgICBbV2luXSBNaW5pQnJvd3NlciBjcmFzaGVzIGluIFdLVVJMQ29weVN0cmlu ZyBpZiBXS1BhZ2VDb3B5QWN0aXZlVVJMIHJldHVybnMgbnVsbApkaWZmIC0tZ2l0IGEvVG9vbHMv TWluaUJyb3dzZXIvd3BlL3F0L21haW4ucW1sIGIvVG9vbHMvTWluaUJyb3dzZXIvd3BlL3F0L21h aW4ucW1sCmluZGV4IGE0MDVkNzZjMGU0M2U0M2JhZGEzZjFkMGVmMWMyNGJmNGNjOTA5NTEuLjY3 NDIwYTQ3MDhjNjEzYWFjNzIxOGYwZmI3NWE3OWNiMjk2YzcxNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L01pbmlCcm93c2VyL3dwZS9xdC9tYWluLnFtbAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci93cGUv cXQvbWFpbi5xbWwKQEAgLTE2LDUgKzE2LDkgQEAgV2luZG93IHsKICAgICAgICAgb25UaXRsZUNo YW5nZWQ6IHsKICAgICAgICAgICAgIG1haW5fd2luZG93LnRpdGxlID0gdGl0bGU7CiAgICAgICAg IH0KKyAgICAgICAgb25Mb2FkaW5nQ2hhbmdlZDogeworICAgICAgICAgICAgaWYgKGxvYWRSZXF1 ZXN0LmVycm9yU3RyaW5nKQorICAgICAgICAgICAgICAgIGNvbnNvbGUubG9nKCdXUEVWaWV3IGVy cm9yOiAnICsgbG9hZFJlcXVlc3QuZXJyb3JTdHJpbmcpCisgICAgICAgIH0KICAgICB9CiB9CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggZGMwODhlOTBhM2VmZjFm YTZmZTkwOTI0NGU0NWYwYjUyN2ZmMGFlNi4uOTQ2Y2EyZjBmZTA3NDQzNzRiNjkzNzYzNGYzZjhi YmE0YmY5ZDcyNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAt MTUzLDYgKzE1MywxNCBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICBvcy5wYXRo LmpvaW4oJ1Rvb2xzJywgJ1Rlc3RXZWJLaXRBUEknKV0sCiAgICAgIFsiLXJlYWRhYmlsaXR5L25h bWluZyJdKSwKIAorICAgIChbCisgICAgICAjIFRoZSBXUEVRdFZpZXcgY2xhc3MgY2FuJ3QgcmVs eSBvbiB0aGUgcmVhZGFiaWxpdHkvcGFyYW1ldGVyX25hbWUgcnVsZSwKKyAgICAgICMgYmVjYXVz ZSBvbWl0dGluZyBwYXJhbWV0ZXIgbmFtZXMgZm9yIFFNTCBzaWduYWxzIGxlYWRzIHRvIHJ1bnRp bWUKKyAgICAgICMgZXJyb3JzLgorICAgICAgb3MucGF0aC5qb2luKCdTb3VyY2UnLCAnV2ViS2l0 JywgJ1VJUHJvY2VzcycsICdBUEknLCAnd3BlJywgJ3F0JywgJ1dQRVF0Vmlldy5oJyksCisgICAg XSwKKyAgICBbIi1yZWFkYWJpbGl0eS9wYXJhbWV0ZXJfbmFtZSJdKSwKKwogICAgIChbCiAgICAg ICAjIFRoZSBHVEsrIGFuZCBXUEUgQVBJcyB1c2UgdXBwZXIgY2FzZSwgdW5kZXJzY29yZSBzZXBh cmF0ZWQsIHdvcmRzIGluCiAgICAgICAjIGNlcnRhaW4gdHlwZXMgb2YgZW51bXMgKGUuZy4gc2ln bmFscywgcHJvcGVydGllcykuCg==