201286 2019-08-28 21:21:20 -0700 Simplify PLATFORM expression 2019-08-30 08:44:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200694 InRadar P2 Normal --- 1 krollin krollin commit-queue darin jer.noble webkit-bug-importer oldest_to_newest 1566087 0 krollin 2019-08-28 21:21:20 -0700 The preprocessor expression conditionalizing the inclusion of the body of ExitFullscreenOnEnterPiP.mm evolved into: #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)) Simplify this to just: #if !PLATFORM(IOS_FAMILY_SIMULATOR) 1566088 1 webkit-bug-importer 2019-08-28 21:21:33 -0700 <rdar://problem/54822347> 1566436 2 377645 krollin 2019-08-29 15:53:02 -0700 Created attachment 377645 Patch 1566517 3 377645 ap 2019-08-29 19:29:30 -0700 Comment on attachment 377645 Patch I suspect that this conditional was meant for iOS only, and “family” came from a global rename. 1566666 4 377645 commit-queue 2019-08-30 08:44:46 -0700 Comment on attachment 377645 Patch Clearing flags on attachment: 377645 Committed r249328: <https://trac.webkit.org/changeset/249328> 1566667 5 commit-queue 2019-08-30 08:44:48 -0700 All reviewed patches have been landed. Closing bug. 377645 2019-08-29 15:53:02 -0700 2019-08-30 08:44:46 -0700 Patch bug-201286-20190829155302.patch text/plain 1537 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5Mjg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjRkMzU3YTA1MmFiODljYWJhNjIzZDI4ZjNkMjExOTNh YzIzNmZhYi4uOWUxOTJkM2I5NTRiMmJkMjU2MmU4OTRhZTc5NTZlMTVlMmJmMjViOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE5LTA4LTI4ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBTaW1wbGlmeSBQTEFURk9STSBleHByZXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU0ODIyMzQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBwcmVwcm9jZXNzb3IgZXhwcmVzc2lvbiBjb25kaXRpb25hbGl6aW5nIHRoZSBpbmNs dXNpb24gb2YgdGhlIGJvZHkKKyAgICAgICAgb2YgRXhpdEZ1bGxzY3JlZW5PbkVudGVyUGlQLm1t IGV2b2x2ZWQgaW50bzoKKworICAgICAgICAgICAgI2lmIFBMQVRGT1JNKE1BQykgfHwgKFBMQVRG T1JNKElPU19GQU1JTFkpICYmICFQTEFURk9STShJT1NfRkFNSUxZX1NJTVVMQVRPUikpCisKKyAg ICAgICAgU2ltcGxpZnkgdGhpcyB0byBqdXN0OgorCisgICAgICAgICAgICAjaWYgIVBMQVRGT1JN KElPU19GQU1JTFlfU0lNVUxBVE9SKQorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9FeGl0RnVsbHNjcmVlbk9uRW50ZXJQaVAubW06CisKIDIwMTktMDgtMjggIEtl aXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBBcHBLaXRD b21wYXRpYmlsaXR5RGVjbGFyYXRpb25zLmgKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvRXhpdEZ1bGxzY3JlZW5PbkVudGVyUGlQLm1tIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9FeGl0RnVsbHNjcmVlbk9uRW50ZXJQaVAu bW0KaW5kZXggMWU4YWRmM2I0OGNmMDdiZGI2N2Q2MjA4MjYyMTIxOGFlMGQ4YzVhYS4uOTlmMjY5 NTE0ZDM4NzdjMjI2NTM2MGZmNDYxY2UzNTU3N2YwZmM3YiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9FeGl0RnVsbHNjcmVlbk9uRW50ZXJQaVAubW0K KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9FeGl0RnVsbHNjcmVl bk9uRW50ZXJQaVAubW0KQEAgLTI1LDcgKzI1LDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgog Ci0jaWYgUExBVEZPUk0oTUFDKSB8fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRGT1JN KElPU19GQU1JTFlfU0lNVUxBVE9SKSkKKyNpZiAhUExBVEZPUk0oSU9TX0ZBTUlMWV9TSU1VTEFU T1IpCiAKICNpbXBvcnQgIlBsYXRmb3JtVXRpbGl0aWVzLmgiCiAjaW1wb3J0ICJUZXN0LmgiCg==