201282 2019-08-28 20:46:28 -0700 Remove 32-bit macOS support 2019-08-29 17:39:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200694 InRadar P2 Normal --- 1 krollin krollin achristensen andersca benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1566078 0 krollin 2019-08-28 20:46:28 -0700 WebKit doesn’t support 32-bit Mac any more, so remove checks and code for that platform. 1566079 1 webkit-bug-importer 2019-08-28 20:46:42 -0700 <rdar://problem/54821667> 1566432 2 377642 krollin 2019-08-29 15:49:39 -0700 Created attachment 377642 Patch 1566437 3 377642 andersca 2019-08-29 15:55:24 -0700 Comment on attachment 377642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377642&action=review > Source/JavaScriptCore/API/JSBase.h:149 > #define JSC_OBJC_API_ENABLED 1 Does this mean that JSC_OBJC_API_ENABLED is always 1 now? 1566438 4 krollin 2019-08-29 15:58:40 -0700 (In reply to Anders Carlsson from comment #3) > Comment on attachment 377642 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377642&action=review > > > Source/JavaScriptCore/API/JSBase.h:149 > > #define JSC_OBJC_API_ENABLED 1 > > Does this mean that JSC_OBJC_API_ENABLED is always 1 now? It looks like it is for Cocoa. We can clean up the conditional around that in a follow-up patch. 1566491 5 377642 commit-queue 2019-08-29 17:39:38 -0700 Comment on attachment 377642 Patch Clearing flags on attachment: 377642 Committed r249304: <https://trac.webkit.org/changeset/249304> 1566492 6 commit-queue 2019-08-29 17:39:40 -0700 All reviewed patches have been landed. Closing bug. 377642 2019-08-29 15:49:39 -0700 2019-08-29 17:39:38 -0700 Patch bug-201282-20190829154938.patch text/plain 3679 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NmU4MzQ0NTE2MWM1MmJhYmU4ZWQyZjNjMjBiMDJjNTJmMWJmYTgzLi41YmQxN2M5M2U3YzM0YTQz NjYxYWNmOGViYjBjNDk2MmM1NWI2NWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wOC0yOCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+ CisKKyAgICAgICAgUmVtb3ZlIDMyLWJpdCBtYWNPUyBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyODIKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzU0ODIxNjY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlYktpdCBkb2VzbuKAmXQgc3VwcG9ydCAzMi1iaXQgTWFjIGFueSBtb3JlLCBz byByZW1vdmUgY2hlY2tzIGFuZCBjb2RlCisgICAgICAgIGZvciB0aGF0IHBsYXRmb3JtLgorCisg ICAgICAgICogQVBJL0pTQmFzZS5oOgorICAgICAgICAqIHJ1bnRpbWUvVk0uaDoKKwogMjAxOS0w OC0xNCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRl IC54Y2NvbmZpZyBzeW1ib2xzIHRvIHJlZmxlY3QgdGhlIGN1cnJlbnQgc2V0IG9mIHBhc3QgYW5k IGZ1dHVyZSBwcm9kdWN0IHZlcnNpb25zLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAzNGY1YmFjNzYxZjBhMDc4MjdhOWVjYTIy OWMwNzA2ZjQyMDk3ZWZkLi5hMWQ2YzI0MTlhMWFjMGU4NThmY2JjNGVkOWFlYTU3MzlmZjZkOTg5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA4LTI4ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGlu QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgMzItYml0IG1hY09TIHN1cHBvcnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTI4MgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTQ4MjE2Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IGRvZXNu4oCZdCBzdXBwb3J0IDMyLWJpdCBNYWMg YW55IG1vcmUsIHNvIHJlbW92ZSBjaGVja3MgYW5kIGNvZGUKKyAgICAgICAgZm9yIHRoYXQgcGxh dGZvcm0uCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxOS0wOC0yOCAgS2VpdGgg Um9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIEhBVkVfUEFTU0tJ VF9HUkFOVUxBUl9FUlJPUlMgY29uZGl0aW9uYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5o CmluZGV4IDAxYzFiMjg2ZWJkNmM3MGJiZjJkNjA0ZDAwYWY1ZDYwOGYxZGMzNjMuLmRiZTExZTRk MTRlNjg0ODc0NDJhMDJlZGU2MjBhYTExYzg3ODdhNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvSlNCYXNlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U0Jhc2UuaApAQCAtMTQ1LDcgKzE0NSw3IEBAIEpTX0VYUE9SVCB2b2lkIEpTR2FyYmFnZUNvbGxl Y3QoSlNDb250ZXh0UmVmIGN0eCk7CiAKIC8qIEVuYWJsZSB0aGUgT2JqZWN0aXZlLUMgQVBJIGZv ciBwbGF0Zm9ybXMgd2l0aCBhIG1vZGVybiBydW50aW1lLiBOT1RFOiBUaGlzIGlzIGR1cGxpY2F0 ZWQgaW4gVk0uaC4gKi8KICNpZiAhZGVmaW5lZChKU0NfT0JKQ19BUElfRU5BQkxFRCkKLSNpZiAo ZGVmaW5lZChfX2NsYW5nX18pICYmIGRlZmluZWQoX19BUFBMRV9fKSAmJiAoKGRlZmluZWQoX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCkgJiYgIWRlZmluZWQoX19pMzg2X18pKSB8fCAo ZGVmaW5lZChUQVJHRVRfT1NfSVBIT05FKSAmJiBUQVJHRVRfT1NfSVBIT05FKSkpCisjaWYgKGRl ZmluZWQoX19jbGFuZ19fKSAmJiBkZWZpbmVkKF9fQVBQTEVfXykgJiYgKGRlZmluZWQoX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCkgfHwgKGRlZmluZWQoVEFSR0VUX09TX0lQSE9ORSkg JiYgVEFSR0VUX09TX0lQSE9ORSkpKQogI2RlZmluZSBKU0NfT0JKQ19BUElfRU5BQkxFRCAxCiAj ZWxzZQogI2RlZmluZSBKU0NfT0JKQ19BUElfRU5BQkxFRCAwCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk0uaAppbmRleCAzYmI4NzUyOTVlYTJlMzg2NzJhNzFlMzc2M2Q4MDBlMWRkNGE4ZjFjLi5l MDdkODY1NDA1ZjA1ZTIxMDE4NmNkYzM3YjI1YzhjZjU2MmI3NjZiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1ZNLmgKQEAgLTg1LDcgKzg1LDcgQEAKIC8vIEVuYWJsZSB0aGUgT2JqZWN0aXZl LUMgQVBJIGZvciBwbGF0Zm9ybXMgd2l0aCBhIG1vZGVybiBydW50aW1lLiBUaGlzIGhhcyB0byBt YXRjaCBleGFjdGx5IHdoYXQgd2UKIC8vIGhhdmUgaW4gSlNCYXNlLmguCiAjaWYgIWRlZmluZWQo SlNDX09CSkNfQVBJX0VOQUJMRUQpCi0jaWYgKGRlZmluZWQoX19jbGFuZ19fKSAmJiBkZWZpbmVk KF9fQVBQTEVfXykgJiYgKChkZWZpbmVkKF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQp ICYmICFkZWZpbmVkKF9faTM4Nl9fKSkgfHwgKGRlZmluZWQoVEFSR0VUX09TX0lQSE9ORSkgJiYg VEFSR0VUX09TX0lQSE9ORSkpKQorI2lmIChkZWZpbmVkKF9fY2xhbmdfXykgJiYgZGVmaW5lZChf X0FQUExFX18pICYmIChkZWZpbmVkKF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQpIHx8 IChkZWZpbmVkKFRBUkdFVF9PU19JUEhPTkUpICYmIFRBUkdFVF9PU19JUEhPTkUpKSkKICNkZWZp bmUgSlNDX09CSkNfQVBJX0VOQUJMRUQgMQogI2Vsc2UKICNkZWZpbmUgSlNDX09CSkNfQVBJX0VO QUJMRUQgMApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggMGU2ZmFhYThiMTNkYzFlMDkyNzY5OGE0NTAxZWM0Yzkw YjA3ZWE5OS4uNWRmZTc3ZDRiNGM2MmQ2ZGYyM2YzMDlmYWRiOWI4Njk0OWIwNTNiZSAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCkBAIC0xNDgxLDcgKzE0ODEsNyBAQAogI2RlZmluZSBIQVZFX1NBRkFSSV9TRVJWSUNF U19GUkFNRVdPUksgMQogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiAhZGVmaW5lZChf X2kzODZfXykpIHx8IFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0oV0FUQ0hPUykKKyNpZiBQTEFU Rk9STShNQUMpIHx8IFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0oV0FUQ0hPUykKICNkZWZpbmUg SEFWRV9TQUZFX0JST1dTSU5HIDEKICNlbmRpZgogCg==