201280 2019-08-28 20:31:13 -0700 Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional 2019-08-30 13:27:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200694 InRadar P2 Normal --- 1 krollin achristensen achristensen benjamin cdumez cmarcelo darin dbates ews-watchlist webkit-bug-importer youennf oldest_to_newest 1566073 0 krollin 2019-08-28 20:31:13 -0700 HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT is always True, so remove the conditional tests, keeping the True branches and removing the False branches. 1566075 1 webkit-bug-importer 2019-08-28 20:31:23 -0700 <rdar://problem/54821367> 1566219 2 377583 achristensen 2019-08-29 07:35:49 -0700 Created attachment 377583 Patch 1566256 3 377583 darin 2019-08-29 08:59:18 -0700 Comment on attachment 377583 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377583&action=review > Source/WTF/wtf/Platform.h:-1444 > -/* FIXME: Does this work, and is this needed on other iOS family platforms? */ Do you know the answer to this? 1566557 4 377583 achristensen 2019-08-29 22:23:30 -0700 Comment on attachment 377583 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377583&action=review >> Source/WTF/wtf/Platform.h:-1444 >> -/* FIXME: Does this work, and is this needed on other iOS family platforms? */ > > Do you know the answer to this? "git show cf848588" in CFNetwork indicates there's nothing platform specific about this. Alexey added this question in r238785 and I believe it was because he removed a respondsToSelector check which is indeed not needed on any platform. 1566782 5 achristensen 2019-08-30 13:27:51 -0700 https://trac.webkit.org/changeset/249343/webkit 377583 2019-08-29 07:35:49 -0700 2019-08-30 08:41:09 -0700 Patch bug-201280-20190829073548.patch text/plain 4531 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ0YjhkZDEyZGM0NzZlODllY2MyYmJk Nzc3OWU1OTFmMWZmYzg2MzcuLjIxMDE4NGY3ZmIyN2YzZTE5MDgxYmIwZjRjZDY1ZjNjM2ZlYTNm YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDgtMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgSEFWRV9DRk5FVFdPUktf V0lUSF9BVVRPX0FEREVEX0hUVFBfSEVBREVSX1NVUFBSRVNTSU9OX1NVUFBPUlQgY29uZGl0aW9u YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTI4 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L1BsYXRmb3JtLmg6CisKIDIwMTktMDgtMjUgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVq aWlAc29ueS5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbihyMjQ4NTMzKSBBc3NlcnRpb24gaGl0 IGluIGlzTWFpblRocmVhZCgpIGZvciBzb21lIGNsaWVudHMgdXNpbmcgV1RGIGJlY2F1c2UgdGhl IG1haW4gdGhyZWFkIGlzIG5vdCBpbml0aWFsaXplZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKaW5kZXggZmIw OTE1YTNiMDkyYTRkNjU0NTA2YTVmNTllMzA1OTAwYmI1Y2I5Ni4uYzY3MjMwNGYwNjY2MjMzYmEz ZDkxZDUxYzJlMTJmNmM5OGVkZjNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUEFML0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTktMDgtMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9y Zz4KKworICAgICAgICBSZW1vdmUgSEFWRV9DRk5FVFdPUktfV0lUSF9BVVRPX0FEREVEX0hUVFBf SEVBREVSX1NVUFBSRVNTSU9OX1NVUFBPUlQgY29uZGl0aW9uYWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTI4MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEku aDoKKwogMjAxOS0wOC0yMiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAg ICAgW3dhdGNoT1NdIERpc2FibGUgQ29udGVudCBGaWx0ZXJpbmcgaW4gdGhlIHNpbXVsYXRvciBi dWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZwppbmRleCBlNjQyNTEyYTdjMGM0ZDUwMWRlZWJlMGEwOGI4NjY2YmFhODc4NTc0 Li45ZjRhMzQzNjUxNzk3YzNhMzY3MTExMGM1MWYyODAzZWM5ZDEzM2UxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDE5LTA4LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIEhBVkVfQ0ZORVRXT1JLX1dJVEhfQVVUT19B RERFRF9IVFRQX0hFQURFUl9TVVBQUkVTU0lPTl9TVVBQT1JUIGNvbmRpdGlvbmFsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyODAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtT ZXNzaW9uQ29jb2E6Ok5ldHdvcmtTZXNzaW9uQ29jb2EpOgorCiAyMDE5LTA4LTI2ICBSdXNzZWxs IEVwc3RlaW4gIDxyZXBzdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjI0ODk2MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDBlNmZhYWE4YjEzZGMxZTA5Mjc2OThh NDUwMWVjNGM5MGIwN2VhOTkuLjRlY2FjZWYyYmMxNTYxM2ZlZjIwMDllMDhjMGJjNmQyMmI2OWNl ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dU Ri93dGYvUGxhdGZvcm0uaApAQCAtMTQzOSwxNCArMTQzOSw2IEBACiAjZGVmaW5lIEhBVkVfQ0ZO RVRXT1JLX1dJVEhfSUdOT1JFX0hTVFMgMQogI2VuZGlmCiAKLSNpZiBQTEFURk9STShNQUMpIHx8 IFBMQVRGT1JNKElPU19GQU1JTFkpCi0jZGVmaW5lIEhBVkVfQ0ZORVRXT1JLX1dJVEhfQVVUT19B RERFRF9IVFRQX0hFQURFUl9TVVBQUkVTU0lPTl9TVVBQT1JUIDEKLS8qIEZJWE1FOiBEb2VzIHRo aXMgd29yaywgYW5kIGlzIHRoaXMgbmVlZGVkIG9uIG90aGVyIGlPUyBmYW1pbHkgcGxhdGZvcm1z PyAqLwotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oSU9TKQotI2RlZmluZSBVU0VfQ0ZO RVRXT1JLX0FVVE9fQURERURfSFRUUF9IRUFERVJfU1VQUFJFU1NJT04gMQotI2VuZGlmCi0jZW5k aWYKLQogI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTAxNDAwKSB8fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSB8fCBQTEFURk9STShHVEspCiAjZGVmaW5lIEhB VkVfT1NfREFSS19NT0RFX1NVUFBPUlQgMQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9QQUwvcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9w YWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oCmluZGV4IGVmYzBjMDRmMTZkMzU2YTY4N2I2NDUxOTI5 YzgzNWNjM2Q1MzQ5NTkuLjBiZjBiYjhiMzdiZTZiMTdjMGRhNGU1MzAzN2Q3MjgyNWJmNzAzNGQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oCkBAIC0x OTIsOSArMTkyLDcgQEAgdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgTlNVUkxTZXNzaW9uQ29t cGFuaW9uUHJveHlQcmVmZXJlbmNlKSB7CiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKIEBwcm9w ZXJ0eSAobnVsbGFibGUsIGNvcHkpIE5TU3RyaW5nICpfQ1REYXRhQ29ubmVjdGlvblNlcnZpY2VU eXBlOwogI2VuZGlmCi0jaWYgSEFWRShDRk5FVFdPUktfV0lUSF9BVVRPX0FEREVEX0hUVFBfSEVB REVSX1NVUFBSRVNTSU9OX1NVUFBPUlQpCiBAcHJvcGVydHkgKG51bGxhYmxlLCBjb3B5KSBOU1Nl dCAqX3N1cHByZXNzZWRBdXRvQWRkZWRIVFRQSGVhZGVyczsKLSNlbmRpZgogI2lmIFBMQVRGT1JN KFdBVENIT1MpCiBAcHJvcGVydHkgTlNVUkxTZXNzaW9uQ29tcGFuaW9uUHJveHlQcmVmZXJlbmNl IF9jb21wYW5pb25Qcm94eVByZWZlcmVuY2U7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbSBiL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQppbmRl eCA5NWZiNzgzYTQ1OWExMTUzN2JkMDE1MjVhODVjYTc2YTJlMDc0OGE2Li4xYmNkMGI0OWJlNWYy NjBjZjQyNzA4MDY3NjAxMzhkNGJjZjAwZjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCkBAIC05NTIs MTAgKzk1Miw4IEBAIE5ldHdvcmtTZXNzaW9uQ29jb2E6Ok5ldHdvcmtTZXNzaW9uQ29jb2EoTmV0 d29ya1Byb2Nlc3MmIG5ldHdvcmtQcm9jZXNzLCBOZXR3b3JrCiAgICAgY29uZmlndXJhdGlvbi5f cHJldmVudHNBcHBTU08gPSB0cnVlOwogI2VuZGlmCiAKLSNpZiBVU0UoQ0ZORVRXT1JLX0FVVE9f QURERURfSFRUUF9IRUFERVJfU1VQUFJFU1NJT04pCiAgICAgLy8gV2l0aG91dCB0aGlzLCBDRk5l dHdvcmsgd291bGQgc29tZXRpbWVzIGFkZCBhIENvbnRlbnQtVHlwZSBoZWFkZXIgdG8gb3VyIHJl cXVlc3RzIChyZGFyOi8vcHJvYmxlbS8zNDc0ODQ3MCkuCiAgICAgY29uZmlndXJhdGlvbi5fc3Vw cHJlc3NlZEF1dG9BZGRlZEhUVFBIZWFkZXJzID0gW05TU2V0IHNldFdpdGhPYmplY3Q6QCJDb250 ZW50LVR5cGUiXTsKLSNlbmRpZgogCiAgICAgaWYgKHBhcmFtZXRlcnMuYWxsb3dzQ2VsbHVsYXJB Y2Nlc3MgPT0gQWxsb3dzQ2VsbHVsYXJBY2Nlc3M6Ok5vKQogICAgICAgICBjb25maWd1cmF0aW9u LmFsbG93c0NlbGx1bGFyQWNjZXNzID0gTk87Cg==