201241 2019-08-28 15:21:03 -0700 WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations 2019-08-28 17:01:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner repstein thorton webkit-bug-importer oldest_to_newest 1565905 0 wenson_hsieh 2019-08-28 15:21:03 -0700 <rdar://problem/54317588> 1565915 1 377497 wenson_hsieh 2019-08-28 15:45:02 -0700 Created attachment 377497 Patch 1565919 2 thorton 2019-08-28 15:50:07 -0700 Could also be “send drag updates till you get the reply you expect” 1565920 3 wenson_hsieh 2019-08-28 15:53:54 -0700 (In reply to Tim Horton from comment #2) > Could also be “send drag updates till you get the reply you expect” It could! But it seems a bit cumbersome for each test to need to tell the harness what kind of UIDropOperation it expects. That said, most of the drag and drop tests that involve drop sessions probably end up expecting UIDropOperationCopy. 1565966 4 377497 commit-queue 2019-08-28 17:01:10 -0700 Comment on attachment 377497 Patch Clearing flags on attachment: 377497 Committed r249226: <https://trac.webkit.org/changeset/249226> 1565967 5 commit-queue 2019-08-28 17:01:11 -0700 All reviewed patches have been landed. Closing bug. 377497 2019-08-28 15:45:02 -0700 2019-08-28 17:01:10 -0700 Patch bug-201241-20190828154501.patch text/plain 2386 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzcwNjE2YWQzOGZkMGMxYjgzZTZlMzUxNDU5Njg4YzRj MjJjMzA2My4uNDI1NGRhZmVlNDA2ZDg5NDU0MTlhNzY2ZmY1NWIzZjA0Njg2N2IwMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE5LTA4LTI4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFdLQXR0YWNobWVudFRlc3RzLkRyb3BGb2xkZXJBc0F0dGFjaG1lbnRBbmRNb3Zl QnlEcmFnZ2luZyBmYWlscyBpbiBzb21lIGlPUyBzaW11bGF0b3IgY29uZmlndXJhdGlvbnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTI0MQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTQzMTc1ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHJlYXNvbnMgdGhhdCBhcmUgc3RpbGwgdW5rbm93 biwgaXQncyBwb3NzaWJsZSBmb3IgaU9TIDEzIHNpbXVsYXRvcnMgdG8gZ2V0IGludG8gYSBzdGF0 ZSB3aGVyZSB0aGUgSVBDCisgICAgICAgIGNvbW11bmljYXRpb24gZGVsYXkgYmV0d2VlbiB0aGUg d2ViIGFuZCBVSSBwcm9jZXNzZXMgY2FuIGJlY29tZSBleHRyYW9yZGluYXJpbHkgbG9uZy4gVW5k ZXIgdGhlc2UgY2lyY3Vtc3RhbmNlcywKKyAgICAgICAgdGhlIGRyYWcgYW5kIGRyb3AgaGFybmVz cyBmYWlscyB0byBzaW11bGF0ZSBhIGRyb3AsIHNpbmNlIGl0IGVuZHMgdXAgZmlyaW5nIGFsbCBz Y2hlZHVsZWQgY2FsbHMgdG8KKyAgICAgICAgLWRyb3BJbnRlcmFjdGlvbjpzZXNzaW9uRGlkVXBk YXRlOiBiZWZvcmUgdGhlIGZpcnN0IHJlc3BvbnNlIGZyb20gdGhlIHdlYiBwcm9jZXNzIGFycml2 ZXMgaW4gdGhlIFVJIHByb2Nlc3MsIHNvCisgICAgICAgIGl0IGJlbGlldmVzIHRoYXQgdGhlIHdl YiB2aWV3IGhhcyByZWplY3RlZCB0aGUgZHJvcCBmcm9tIGJlaW5nIGhhbmRsZWQuCisKKyAgICAg ICAgSW5zdGVhZCwgbWFrZSB0aGUgZHJhZyBhbmQgZHJvcCBzaW11bGF0b3Igcm9idXN0IGJ5IGVu c3VyaW5nIGEgcHJlc2VudGF0aW9uIHVwZGF0ZSBiZXR3ZWVuIGRyb3Agc2Vzc2lvbiB1cGRhdGVz LAorICAgICAgICB0byBtYWtlIHN1cmUgdGhhdCB0aGUgd2ViIHByb2Nlc3MgaGFzIGhhZCB0aW1l IHRvIHNlbmQgYSByZXNwb25zZSBhZnRlciBlYWNoIHVwZGF0ZS4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvaW9zL0RyYWdBbmREcm9wU2ltdWxhdG9ySU9TLm1tOgorICAgICAgICAoLVtEcmFn QW5kRHJvcFNpbXVsYXRvciBfYWR2YW5jZVByb2dyZXNzXSk6CisKIDIwMTktMDgtMjcgIEphbWVz IERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBGaXggYXBwbHlp bmcgZGlmZnMgdGhhdCBvbmx5IGNoYW5nZSBmaWxlIG1vZGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvaW9zL0RyYWdBbmREcm9wU2ltdWxhdG9ySU9TLm1tIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9pb3MvRHJhZ0FuZERyb3BTaW11bGF0b3JJT1MubW0KaW5kZXggYjIxNTdlMGM3MGQ2 YTUzYTYyMThlNGQyYTkwOWM3NjgyMjc2MGRlMi4uNTU1NTdiYWNkMDczMTcyZTRkNjcwMTBjMTI4 YWEyNmRjYTJlY2RiNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvRHJhZ0Fu ZERyb3BTaW11bGF0b3JJT1MubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvRHJhZ0Fu ZERyb3BTaW11bGF0b3JJT1MubW0KQEAgLTYyNCw2ICs2MjQsNyBAQCAtICh2b2lkKV9hZHZhbmNl UHJvZ3Jlc3MKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBEcmFnQW5kRHJvcFBoYXNlRW50ZXJl ZDogewogICAgICAgICBfbGFzdEtub3duRHJvcFByb3Bvc2FsID0gW1tfd2ViVmlldyBkcm9wSW50 ZXJhY3Rpb25EZWxlZ2F0ZV0gZHJvcEludGVyYWN0aW9uOltfd2ViVmlldyBkcm9wSW50ZXJhY3Rp b25dIHNlc3Npb25EaWRVcGRhdGU6X2Ryb3BTZXNzaW9uLmdldCgpXTsKKyAgICAgICAgW193ZWJW aWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsKICAgICAgICAgaWYgKCFbc2VsZiBz aG91bGRBbGxvd01vdmVPcGVyYXRpb25dICYmIFtfbGFzdEtub3duRHJvcFByb3Bvc2FsIG9wZXJh dGlvbl0gPT0gVUlEcm9wT3BlcmF0aW9uTW92ZSkKICAgICAgICAgICAgIF9sYXN0S25vd25Ecm9w UHJvcG9zYWwgPSBhZG9wdE5TKFtbVUlEcm9wUHJvcG9zYWwgYWxsb2NdIGluaXRXaXRoRHJvcE9w ZXJhdGlvbjpVSURyb3BPcGVyYXRpb25DYW5jZWxdKTsKICAgICAgICAgYnJlYWs7Cg==