201238 2019-08-28 14:15:25 -0700 [LFC][BFC] BlockFormattingContext::usedAvailableWidthForFloatAvoider should only be called on float avoiders. 2019-08-29 14:26:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1565881 0 zalan 2019-08-28 14:15:25 -0700 Makes the code more explicit/readable. 1565882 1 webkit-bug-importer 2019-08-28 14:15:45 -0700 <rdar://problem/54807663> 1565883 2 377484 zalan 2019-08-28 14:17:39 -0700 Created attachment 377484 Patch 1566388 3 377484 commit-queue 2019-08-29 14:26:29 -0700 Comment on attachment 377484 Patch Clearing flags on attachment: 377484 Committed r249292: <https://trac.webkit.org/changeset/249292> 1566389 4 commit-queue 2019-08-29 14:26:31 -0700 All reviewed patches have been landed. Closing bug. 377484 2019-08-28 14:17:39 -0700 2019-08-29 14:26:29 -0700 Patch bug-201238-20190828141738.patch text/plain 3017 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI1MmE1YzRjZmY2YjA3 ZmQwMjkwNmM5NWMyZTExOWFiMzNlZDU1Ni4uNTliMGQ2NDk4MzY0MTJlMTE2OTY2OWI2NjY5OTVh NDBlNTY5ZjM2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA4LTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBCbG9ja0Zv cm1hdHRpbmdDb250ZXh0Ojp1c2VkQXZhaWxhYmxlV2lkdGhGb3JGbG9hdEF2b2lkZXIgc2hvdWxk IG9ubHkgYmUgY2FsbGVkIG9uIGZsb2F0IGF2b2lkZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMjM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81NDgwNzY2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNYWtlIHRoZSBob3Jpem9udGFsIGF2YWlsYWJsZSBzcGFjZSBsb2dpYyBmb3IgZmxvYXQg YXZvaWRlcnMgbW9yZSBleHBsaWNpdC9yZWFkYWJsZS4gCisKKyAgICAgICAgKiBsYXlvdXQvYmxv Y2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojp1c2VkQXZhaWxhYmxlV2lkdGhGb3JG bG9hdEF2b2lkZXIgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1h dHRpbmdDb250ZXh0OjpsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFJvb3QgY29uc3QpOgorCiAyMDE5 LTA4LTI4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10g SW5saW5lIGNvbnRlbnQgbG9nZ2luZyBzaG91bGQgaGF2ZSBzb21lIGV4dHJhIHNwYWNlIGZvciBi ZXR0ZXIgcmVhZGFiaWxpdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9j a2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IDA0 NDMyY2E1ZWY3ZmFlNTNmZjdiZWQzMThlNzEwZTUyOGIzZjAwMGIuLmI1ZjBmZGEwNmNjNThlZGEy ZmZkYTEwYmM4ZWM2MWZhNzk5MTRhNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNw cApAQCAtMTIyLDggKzEyMiw3IEBAIE9wdGlvbmFsPExheW91dFVuaXQ+IEJsb2NrRm9ybWF0dGlu Z0NvbnRleHQ6OnVzZWRBdmFpbGFibGVXaWR0aEZvckZsb2F0QXZvaWRlcihjCiB7CiAgICAgLy8g Tm9ybWFsbHkgdGhlIGF2YWlsYWJsZSB3aWR0aCBmb3IgYW4gaW4tZmxvdyBibG9jayBsZXZlbCBi b3ggaXMgdGhlIHdpZHRoIG9mIHRoZSBjb250YWluaW5nIGJsb2NrJ3MgY29udGVudCBib3guCiAg ICAgLy8gSG93ZXZlciAoYW5kIGNhbid0IGZpbmQgaXQgYW55d2hlcmUgaW4gdGhlIHNwZWMpIG5v bi1mbG9hdGluZyBwb3NpdGlvbmVkIGZsb2F0IGF2b2lkZXIgYmxvY2sgbGV2ZWwgYm94ZXMgYXJl IGNvbnN0cmFpbmVkIGJ5IGV4aXN0aW5nIGZsb2F0cy4KLSAgICBpZiAoIWxheW91dEJveC5pc0Zs b2F0QXZvaWRlcigpIHx8IGxheW91dEJveC5pc0Zsb2F0aW5nUG9zaXRpb25lZCgpKQotICAgICAg ICByZXR1cm4geyB9OworICAgIEFTU0VSVChsYXlvdXRCb3guaXNGbG9hdEF2b2lkZXIoKSk7CiAg ICAgYXV0byYgZmxvYXRpbmdTdGF0ZSA9IGZsb2F0aW5nQ29udGV4dC5mbG9hdGluZ1N0YXRlKCk7 CiAgICAgaWYgKGZsb2F0aW5nU3RhdGUuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4geyB9OwpA QCAtMTYzLDcgKzE2MiwxMSBAQCB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dEZv cm1hdHRpbmdDb250ZXh0Um9vdChGbG9hdGluZ0NvbnRleHQmIGZsb2F0aQogICAgIGNvbXB1dGVC b3JkZXJBbmRQYWRkaW5nKGxheW91dEJveCk7CiAgICAgY29tcHV0ZVN0YXRpY1ZlcnRpY2FsUG9z aXRpb24oZmxvYXRpbmdDb250ZXh0LCBsYXlvdXRCb3gpOwogCi0gICAgY29tcHV0ZVdpZHRoQW5k TWFyZ2luKGxheW91dEJveCwgdXNlZEF2YWlsYWJsZVdpZHRoRm9yRmxvYXRBdm9pZGVyKGZsb2F0 aW5nQ29udGV4dCwgbGF5b3V0Qm94KSk7CisgICAgT3B0aW9uYWw8TGF5b3V0VW5pdD4gdXNlZEF2 YWlsYWJsZVdpZHRoRm9yRmxvYXRBdm9pZGVyOworICAgIGF1dG8gaG9yaXpvbnRhbEF2YWlsYWJs ZVNwYWNlSXNDb25zdHJhaW5lZEJ5RXhpc3RpbmdGbG9hdHMgPSBsYXlvdXRCb3guaXNGbG9hdEF2 b2lkZXIoKSAmJiAhbGF5b3V0Qm94LmlzRmxvYXRpbmdQb3NpdGlvbmVkKCk7CisgICAgaWYgKGhv cml6b250YWxBdmFpbGFibGVTcGFjZUlzQ29uc3RyYWluZWRCeUV4aXN0aW5nRmxvYXRzKQorICAg ICAgICB1c2VkQXZhaWxhYmxlV2lkdGhGb3JGbG9hdEF2b2lkZXIgPSB0aGlzLT51c2VkQXZhaWxh YmxlV2lkdGhGb3JGbG9hdEF2b2lkZXIoZmxvYXRpbmdDb250ZXh0LCBsYXlvdXRCb3gpOworICAg IGNvbXB1dGVXaWR0aEFuZE1hcmdpbihsYXlvdXRCb3gsIHVzZWRBdmFpbGFibGVXaWR0aEZvckZs b2F0QXZvaWRlcik7CiAgICAgY29tcHV0ZVN0YXRpY0hvcml6b250YWxQb3NpdGlvbihsYXlvdXRC b3gpOwogICAgIC8vIFN3aWNoIG92ZXIgdG8gdGhlIG5ldyBmb3JtYXR0aW5nIGNvbnRleHQgKHRo ZSBvbmUgdGhhdCB0aGUgcm9vdCBjcmVhdGVzKS4KICAgICBhdXRvIGZvcm1hdHRpbmdDb250ZXh0 ID0gbGF5b3V0U3RhdGUoKS5jcmVhdGVGb3JtYXR0aW5nQ29udGV4dChsYXlvdXRCb3gpOwo=