201237 2019-08-28 14:10:21 -0700 Null check webFrame when creating a print preview to prevent a crash. 2019-08-28 16:07:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1565877 0 megan_gardner 2019-08-28 14:10:21 -0700 Null check webFrame when creating a print preview to prevent a crash. 1565887 1 377486 megan_gardner 2019-08-28 14:21:28 -0700 Created attachment 377486 Patch 1565888 2 377487 megan_gardner 2019-08-28 14:22:37 -0700 Created attachment 377487 Patch 1565892 3 377487 thorton 2019-08-28 14:28:25 -0700 Comment on attachment 377487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377487&action=review > Source/WebKit/UIProcess/mac/WKPrintingView.mm:508 > + // Preview isn't available yet, request it asynchronously. This comment should stay where it was! This isn't about the early return, it's about the else case in the inner if. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:436 > + auto delegate = adoptNS([[PrintDelegate alloc] init]); > + [webView setUIDelegate:delegate.get()]; > + [webView loadHTMLString:@"<head><title>test_title</title></head><body onload='print()'>hello world!</body>" baseURL:[NSURL URLWithString:@"http://example.com/"]]; > + TestWebKitAPI::Util::run(&done); You can replace these four lines with one: [webView synchronouslyLoadHTMLString:@"<head><title>test_title</title></head><body onload='print()'>hello world!</body>"]; > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:439 > + // Circumvents Assertion in WebKit. Nevermind, I lied, kill this comment with fire. 1565893 4 thorton 2019-08-28 14:28:49 -0700 Wait no! 1565894 5 377487 thorton 2019-08-28 14:29:10 -0700 Comment on attachment 377487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377487&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:436 >> + TestWebKitAPI::Util::run(&done); > > You can replace these four lines with one: > > [webView synchronouslyLoadHTMLString:@"<head><title>test_title</title></head><body onload='print()'>hello world!</body>"]; NEVERMIND I forgot that it is on print() not on load. Leave it be 1565904 6 wenson_hsieh 2019-08-28 15:20:11 -0700 <rdar://problem/51618863> 1565909 7 377494 megan_gardner 2019-08-28 15:24:04 -0700 Created attachment 377494 Patch for landing 1565930 8 377494 commit-queue 2019-08-28 16:07:47 -0700 Comment on attachment 377494 Patch for landing Clearing flags on attachment: 377494 Committed r249224: <https://trac.webkit.org/changeset/249224> 1565931 9 commit-queue 2019-08-28 16:07:48 -0700 All reviewed patches have been landed. Closing bug. 377486 2019-08-28 14:21:28 -0700 2019-08-28 14:22:35 -0700 Patch bug-201237-20190828142127.patch text/plain 4209 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg3NzhhNGRlZjcwM2QxZjM1 NzQxMzU5OTQ1MzcxMzEzYTUxNzlmNDIuLjY2MWExYmNiZjQ1MjJiZGRjZjRlZjI2MjQ3Yjg1MWY0 ZDExNmQ1OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMjggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsIGNoZWNrIHdl YkZyYW1lIHdoZW4gY3JlYXRpbmcgYSBwcmludCBwcmV2aWV3IHRvIHByZXZlbnQgYSBjcmFzaC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTIzNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgYW5k IGV4cGVuZCBhIG51bGwgY2hlY2sgdG8ga2VlcCBmcm9tIGNyYXNoaW5nIHdoZW4gbWFraW5nIGEg cHJpbnQgcHJldmlldy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tQcmludGluZ1ZpZXcu bW06CisgICAgICAgICgtW1dLUHJpbnRpbmdWaWV3IF9kcmF3UHJldmlldzpdKToKKyAgICAgICAg KC1bV0tQcmludGluZ1ZpZXcgZHJhd1JlY3Q6XSk6CisKIDIwMTktMDgtMjggIFNhaWQgQWJvdS1I YWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGwgaW1hZ2UgZHJh d2luZyBmdW5jdGlvbnMgc2hvdWxkIHRha2UgYW4gYXJndW1lbnQgb2YgdHlwZSBJbWFnZVBhaW50 aW5nT3B0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLUHJp bnRpbmdWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLUHJpbnRpbmdWaWV3 Lm1tCmluZGV4IGIzZGI2MjQ3ZGYyNzIzOWQyMjM4MzY3NjllNWQyM2JiOGUxZjdiODkuLmM0YmEx OTZiMDVjZWU5N2Y4MmU3YzVmNjRhODNiMGZjM2VjMzI5ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL21hYy9XS1ByaW50aW5nVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9tYWMvV0tQcmludGluZ1ZpZXcubW0KQEAgLTUwNCw2ICs1MDQsMTAgQEAgLSAo dm9pZClfZHJhd1BERkRvY3VtZW50OihQREZEb2N1bWVudCAqKXBkZkRvY3VtZW50IHBhZ2U6KHVu c2lnbmVkKXBhZ2UgYXRQb2ludDoKIC0gKHZvaWQpX2RyYXdQcmV2aWV3OihOU1JlY3QpbnNSZWN0 CiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICAKKyAgICAvLyBQcmV2aWV3 IGlzbid0IGF2YWlsYWJsZSB5ZXQsIHJlcXVlc3QgaXQgYXN5bmNocm9ub3VzbHkuCisgICAgaWYg KCFfd2ViRnJhbWUgfHwgIV93ZWJGcmFtZS0+cGFnZSgpKQorICAgICAgICByZXR1cm47CiAKICAg ICBXZWJDb3JlOjpJbnRSZWN0IHNjYWxlZFByaW50aW5nUmVjdChuc1JlY3QpOwogICAgIHNjYWxl ZFByaW50aW5nUmVjdC5zY2FsZSgxIC8gX3RvdGFsU2NhbGVGYWN0b3JGb3JQcmludGluZyk7CkBA IC01MTgsMTAgKzUyMiw2IEBAIC0gKHZvaWQpX2RyYXdQcmV2aWV3OihOU1JlY3QpbnNSZWN0CiAg ICAgICAgICAgICAgICAgLy8gVGhlcmUgaXMgbm8gbmVlZCB0byBhc2sgYWdhaW4uCiAgICAgICAg ICAgICAgICAgX2xhdGVzdEV4cGVjdGVkUHJldmlld0NhbGxiYWNrID0gZXhpc3RpbmdDYWxsYmFj azsKICAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgLy8gUHJldmlldyBpc24n dCBhdmFpbGFibGUgeWV0LCByZXF1ZXN0IGl0IGFzeW5jaHJvbm91c2x5LgotICAgICAgICAgICAg ICAgIGlmICghX3dlYkZyYW1lLT5wYWdlKCkpCi0gICAgICAgICAgICAgICAgICAgIHJldHVybjsK LQogICAgICAgICAgICAgICAgIC8vIFJldHVybiB0byBwcmludGluZyBtb2RlIGlmIHdlJ3JlIGFs cmVhZHkgYmFjayB0byBzY3JlZW4gKGUuZy4gZHVlIHRvIHdpbmRvdyByZXNpemluZykuCiAgICAg ICAgICAgICAgICAgX3dlYkZyYW1lLT5wYWdlKCktPmJlZ2luUHJpbnRpbmcoX3dlYkZyYW1lLmdl dCgpLCBXZWJLaXQ6OlByaW50SW5mbyhbX3ByaW50T3BlcmF0aW9uIHByaW50SW5mb10pKTsKIApk aWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDQzOGFk MjJkM2Y1YmUzZDlmZDcyOWM0M2Y0OGEwMjgzZTIzNjdhNDguLjZiNzRkOWMyZTk1NzA4NzQ0OTZl ZDJiMTQxNzYxNDY5ZmJlMzZjNWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wOC0yOCAgTWVnYW4gR2FyZG5l ciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgorCisgICAgICAgIE51bGwgY2hlY2sgd2ViRnJh bWUgd2hlbiBjcmVhdGluZyBhIHByaW50IHByZXZpZXcgdG8gcHJldmVudCBhIGNyYXNoLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMjM3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB0byB2ZXJp ZnkgdGhhdCBpZiB3ZSBkb24ndCBoYXZlIHRoZSBXZWJQYWdlUHJveHksIHdlIHdpbGwgbm90IGNy YXNoIHdoZW4gbWFraW5nIGEgcHJpbnQgcHJldmlldy4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvVUlEZWxlZ2F0ZS5tbToKKyAgICAgICAgKFRFU1QpOgorCiAy MDE5LTA4LTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAg ICByZXN1bHRzLndlYmtpdC5vcmc6IE1vdmUgZHJhd2VyIHRvIHRoZSByaWdodCwgb3BlbiBieSBk ZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1VJRGVsZWdhdGUubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1VJ RGVsZWdhdGUubW0KaW5kZXggMmMzMWFiYjk0NDI3ODhhMTEwNmY5Y2NlYzA1MmZiMWJmYTE3NjMx MS4uZTQyOGMyNTgwOTZkYWQ2ODdiOGQ4MGM4MDE5MTIzZTE1MWEzYzBmYiAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVUlEZWxlZ2F0ZS5tbQpAQCAt NDI3LDYgKzQyNywyMiBAQCBURVNUKFdlYktpdCwgUHJpbnRGcmFtZSkKICAgICBUZXN0V2ViS2l0 QVBJOjpVdGlsOjpydW4oJmRyYXdGb290ZXJDYWxsZWQpOwogfQogCitURVNUKFdlYktpdCwgUHJp bnRQcmV2aWV3KQoreworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3 IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7CisgICAg YXV0byBkZWxlZ2F0ZSA9IGFkb3B0TlMoW1tQcmludERlbGVnYXRlIGFsbG9jXSBpbml0XSk7Cisg ICAgW3dlYlZpZXcgc2V0VUlEZWxlZ2F0ZTpkZWxlZ2F0ZS5nZXQoKV07CisgICAgW3dlYlZpZXcg bG9hZEhUTUxTdHJpbmc6QCI8aGVhZD48dGl0bGU+dGVzdF90aXRsZTwvdGl0bGU+PC9oZWFkPjxi b2R5IG9ubG9hZD0ncHJpbnQoKSc+aGVsbG8gd29ybGQhPC9ib2R5PiIgYmFzZVVSTDpbTlNVUkwg VVJMV2l0aFN0cmluZzpAImh0dHA6Ly9leGFtcGxlLmNvbS8iXV07CisgICAgVGVzdFdlYktpdEFQ STo6VXRpbDo6cnVuKCZkb25lKTsKKworICAgIE5TUHJpbnRPcGVyYXRpb24gKm9wZXJhdGlvbiA9 IFt3ZWJWaWV3IF9wcmludE9wZXJhdGlvbldpdGhQcmludEluZm86W05TUHJpbnRJbmZvIHNoYXJl ZFByaW50SW5mb11dOworICAgIC8vIENpcmN1bXZlbnRzIEFzc2VydGlvbiBpbiBXZWJLaXQuCisg ICAgTlNQcmludE9wZXJhdGlvbi5jdXJyZW50T3BlcmF0aW9uID0gb3BlcmF0aW9uOworICAgIGF1 dG8gcHJldmlld1ZpZXcgPSBbb3BlcmF0aW9uIHZpZXddOworICAgIFt3ZWJWaWV3IF9jbG9zZV07 CisgICAgW3ByZXZpZXdWaWV3IGRyYXdSZWN0OkNHUmVjdE1ha2UoMCwgMCwgMTAsIDEwKV07Cit9 CisKIEBpbnRlcmZhY2UgTm90aWZpY2F0aW9uRGVsZWdhdGUgOiBOU09iamVjdCA8V0tVSURlbGVn YXRlUHJpdmF0ZT4gewogICAgIGJvb2wgX2FsbG93Tm90aWZpY2F0aW9uczsKIH0K 377487 2019-08-28 14:22:37 -0700 2019-08-28 15:24:02 -0700 Patch bug-201237-20190828142236.patch text/plain 4279 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg3NzhhNGRlZjcwM2QxZjM1 NzQxMzU5OTQ1MzcxMzEzYTUxNzlmNDIuLjE4YzIwMWJhNzlhYTY0NTM1ZjAxZDM3ZGNiYzkzZGRj NDJkMGQwMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsIGNoZWNrIHdl YkZyYW1lIHdoZW4gY3JlYXRpbmcgYSBwcmludCBwcmV2aWV3IHRvIHByZXZlbnQgYSBjcmFzaC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTIzNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE2MTg4NjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBhbmQgZXhwZW5kIGEgbnVsbCBjaGVjayB0 byBrZWVwIGZyb20gY3Jhc2hpbmcgd2hlbiBtYWtpbmcgYSBwcmludCBwcmV2aWV3LgorCisgICAg ICAgICogVUlQcm9jZXNzL21hYy9XS1ByaW50aW5nVmlldy5tbToKKyAgICAgICAgKC1bV0tQcmlu dGluZ1ZpZXcgX2RyYXdQcmV2aWV3Ol0pOgorICAgICAgICAoLVtXS1ByaW50aW5nVmlldyBkcmF3 UmVjdDpdKToKKwogMjAxOS0wOC0yOCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FA YXBwbGUuY29tPgogCiAgICAgICAgIEFsbCBpbWFnZSBkcmF3aW5nIGZ1bmN0aW9ucyBzaG91bGQg dGFrZSBhbiBhcmd1bWVudCBvZiB0eXBlIEltYWdlUGFpbnRpbmdPcHRpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tQcmludGluZ1ZpZXcubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tQcmludGluZ1ZpZXcubW0KaW5kZXggYjNkYjYyNDdkZjI3 MjM5ZDIyMzgzNjc2OWU1ZDIzYmI4ZTFmN2I4OS4uYzRiYTE5NmIwNWNlZTk3ZjgyZTdjNWY2NGE4 M2IwZmMzZWMzMjllNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dL UHJpbnRpbmdWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1ByaW50 aW5nVmlldy5tbQpAQCAtNTA0LDYgKzUwNCwxMCBAQCAtICh2b2lkKV9kcmF3UERGRG9jdW1lbnQ6 KFBERkRvY3VtZW50ICopcGRmRG9jdW1lbnQgcGFnZToodW5zaWduZWQpcGFnZSBhdFBvaW50Ogog LSAodm9pZClfZHJhd1ByZXZpZXc6KE5TUmVjdCluc1JlY3QKIHsKICAgICBBU1NFUlQoUnVuTG9v cDo6aXNNYWluKCkpOworICAgIAorICAgIC8vIFByZXZpZXcgaXNuJ3QgYXZhaWxhYmxlIHlldCwg cmVxdWVzdCBpdCBhc3luY2hyb25vdXNseS4KKyAgICBpZiAoIV93ZWJGcmFtZSB8fCAhX3dlYkZy YW1lLT5wYWdlKCkpCisgICAgICAgIHJldHVybjsKIAogICAgIFdlYkNvcmU6OkludFJlY3Qgc2Nh bGVkUHJpbnRpbmdSZWN0KG5zUmVjdCk7CiAgICAgc2NhbGVkUHJpbnRpbmdSZWN0LnNjYWxlKDEg LyBfdG90YWxTY2FsZUZhY3RvckZvclByaW50aW5nKTsKQEAgLTUxOCwxMCArNTIyLDYgQEAgLSAo dm9pZClfZHJhd1ByZXZpZXc6KE5TUmVjdCluc1JlY3QKICAgICAgICAgICAgICAgICAvLyBUaGVy ZSBpcyBubyBuZWVkIHRvIGFzayBhZ2Fpbi4KICAgICAgICAgICAgICAgICBfbGF0ZXN0RXhwZWN0 ZWRQcmV2aWV3Q2FsbGJhY2sgPSBleGlzdGluZ0NhbGxiYWNrOwogICAgICAgICAgICAgfSBlbHNl IHsKLSAgICAgICAgICAgICAgICAvLyBQcmV2aWV3IGlzbid0IGF2YWlsYWJsZSB5ZXQsIHJlcXVl c3QgaXQgYXN5bmNocm9ub3VzbHkuCi0gICAgICAgICAgICAgICAgaWYgKCFfd2ViRnJhbWUtPnBh Z2UoKSkKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwotCiAgICAgICAgICAgICAgICAgLy8g UmV0dXJuIHRvIHByaW50aW5nIG1vZGUgaWYgd2UncmUgYWxyZWFkeSBiYWNrIHRvIHNjcmVlbiAo ZS5nLiBkdWUgdG8gd2luZG93IHJlc2l6aW5nKS4KICAgICAgICAgICAgICAgICBfd2ViRnJhbWUt PnBhZ2UoKS0+YmVnaW5QcmludGluZyhfd2ViRnJhbWUuZ2V0KCksIFdlYktpdDo6UHJpbnRJbmZv KFtfcHJpbnRPcGVyYXRpb24gcHJpbnRJbmZvXSkpOwogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDM4YWQyMmQzZjViZTNkOWZkNzI5YzQzZjQ4 YTAyODNlMjM2N2E0OC4uZDlhOTEzNjIwY2QxOTc3MDg3MzAxN2UwOTllYjNhOGViM2ExNjY0OSAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA4LTI4ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgTnVsbCBjaGVjayB3ZWJGcmFtZSB3aGVuIGNyZWF0aW5nIGEgcHJp bnQgcHJldmlldyB0byBwcmV2ZW50IGEgY3Jhc2guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyMzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUx NjE4ODYzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3QgdG8gdmVyaWZ5IHRoYXQgaWYgd2UgZG9uJ3QgaGF2ZSB0aGUgV2ViUGFnZVByb3h5LCB3 ZSB3aWxsIG5vdCBjcmFzaCB3aGVuIG1ha2luZyBhIHByaW50IHByZXZpZXcuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1VJRGVsZWdhdGUubW06CisgICAgICAg IChURVNUKToKKwogMjAxOS0wOC0yOCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5j b20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBNb3ZlIGRyYXdlciB0byB0aGUgcmln aHQsIG9wZW4gYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tCmluZGV4IDJjMzFhYmI5NDQyNzg4YTExMDZmOWNjZWMw NTJmYjFiZmExNzYzMTEuLmU0MjhjMjU4MDk2ZGFkNjg3YjhkODBjODAxOTEyM2UxNTFhM2MwZmIg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVUlEZWxl Z2F0ZS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1VJRGVs ZWdhdGUubW0KQEAgLTQyNyw2ICs0MjcsMjIgQEAgVEVTVChXZWJLaXQsIFByaW50RnJhbWUpCiAg ICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkcmF3Rm9vdGVyQ2FsbGVkKTsKIH0KIAorVEVT VChXZWJLaXQsIFByaW50UHJldmlldykKK3sKKyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtb VGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwg NjAwKV0pOworICAgIGF1dG8gZGVsZWdhdGUgPSBhZG9wdE5TKFtbUHJpbnREZWxlZ2F0ZSBhbGxv Y10gaW5pdF0pOworICAgIFt3ZWJWaWV3IHNldFVJRGVsZWdhdGU6ZGVsZWdhdGUuZ2V0KCldOwor ICAgIFt3ZWJWaWV3IGxvYWRIVE1MU3RyaW5nOkAiPGhlYWQ+PHRpdGxlPnRlc3RfdGl0bGU8L3Rp dGxlPjwvaGVhZD48Ym9keSBvbmxvYWQ9J3ByaW50KCknPmhlbGxvIHdvcmxkITwvYm9keT4iIGJh c2VVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJodHRwOi8vZXhhbXBsZS5jb20vIl1dOworICAg IFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZG9uZSk7CisKKyAgICBOU1ByaW50T3BlcmF0aW9u ICpvcGVyYXRpb24gPSBbd2ViVmlldyBfcHJpbnRPcGVyYXRpb25XaXRoUHJpbnRJbmZvOltOU1By aW50SW5mbyBzaGFyZWRQcmludEluZm9dXTsKKyAgICAvLyBDaXJjdW12ZW50cyBBc3NlcnRpb24g aW4gV2ViS2l0LgorICAgIE5TUHJpbnRPcGVyYXRpb24uY3VycmVudE9wZXJhdGlvbiA9IG9wZXJh dGlvbjsKKyAgICBhdXRvIHByZXZpZXdWaWV3ID0gW29wZXJhdGlvbiB2aWV3XTsKKyAgICBbd2Vi VmlldyBfY2xvc2VdOworICAgIFtwcmV2aWV3VmlldyBkcmF3UmVjdDpDR1JlY3RNYWtlKDAsIDAs IDEwLCAxMCldOworfQorCiBAaW50ZXJmYWNlIE5vdGlmaWNhdGlvbkRlbGVnYXRlIDogTlNPYmpl Y3QgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+IHsKICAgICBib29sIF9hbGxvd05vdGlmaWNhdGlvbnM7 CiB9Cg== 377494 2019-08-28 15:24:04 -0700 2019-08-28 16:07:47 -0700 Patch for landing bug-201237-20190828152403.patch text/plain 4113 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg3NzhhNGRlZjcwM2QxZjM1 NzQxMzU5OTQ1MzcxMzEzYTUxNzlmNDIuLjc0NGUxNGM2ZTRjOGU4YzU4YjljMjMzZjAxODQ0MDNl MzUyZDVlYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsIGNoZWNrIHdl YkZyYW1lIHdoZW4gY3JlYXRpbmcgYSBwcmludCBwcmV2aWV3IHRvIHByZXZlbnQgYSBjcmFzaC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTIzNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE2MTg4NjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg VGltIEhvcnRvbi4KKworICAgICAgICBNb3ZlIGFuZCBleHBlbmQgYSBudWxsIGNoZWNrIHRvIGtl ZXAgZnJvbSBjcmFzaGluZyB3aGVuIG1ha2luZyBhIHByaW50IHByZXZpZXcuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvbWFjL1dLUHJpbnRpbmdWaWV3Lm1tOgorICAgICAgICAoLVtXS1ByaW50aW5n VmlldyBfZHJhd1ByZXZpZXc6XSk6CisgICAgICAgICgtW1dLUHJpbnRpbmdWaWV3IGRyYXdSZWN0 Ol0pOgorCiAyMDE5LTA4LTI4ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBs ZS5jb20+CiAKICAgICAgICAgQWxsIGltYWdlIGRyYXdpbmcgZnVuY3Rpb25zIHNob3VsZCB0YWtl IGFuIGFyZ3VtZW50IG9mIHR5cGUgSW1hZ2VQYWludGluZ09wdGlvbnMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1ByaW50aW5nVmlldy5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL21hYy9XS1ByaW50aW5nVmlldy5tbQppbmRleCBiM2RiNjI0N2RmMjcyMzlk MjIzODM2NzY5ZTVkMjNiYjhlMWY3Yjg5Li5hOGNiYTg5ZWMwZjdmNzM4YWUzMDA3OTQxYmJlMTc0 Y2U0NWNiZDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tQcmlu dGluZ1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLUHJpbnRpbmdW aWV3Lm1tCkBAIC01MDQsNiArNTA0LDkgQEAgLSAodm9pZClfZHJhd1BERkRvY3VtZW50OihQREZE b2N1bWVudCAqKXBkZkRvY3VtZW50IHBhZ2U6KHVuc2lnbmVkKXBhZ2UgYXRQb2ludDoKIC0gKHZv aWQpX2RyYXdQcmV2aWV3OihOU1JlY3QpbnNSZWN0CiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6Omlz TWFpbigpKTsKKyAgICAKKyAgICBpZiAoIV93ZWJGcmFtZSB8fCAhX3dlYkZyYW1lLT5wYWdlKCkp CisgICAgICAgIHJldHVybjsKIAogICAgIFdlYkNvcmU6OkludFJlY3Qgc2NhbGVkUHJpbnRpbmdS ZWN0KG5zUmVjdCk7CiAgICAgc2NhbGVkUHJpbnRpbmdSZWN0LnNjYWxlKDEgLyBfdG90YWxTY2Fs ZUZhY3RvckZvclByaW50aW5nKTsKQEAgLTUxOSw5ICs1MjIsNiBAQCAtICh2b2lkKV9kcmF3UHJl dmlldzooTlNSZWN0KW5zUmVjdAogICAgICAgICAgICAgICAgIF9sYXRlc3RFeHBlY3RlZFByZXZp ZXdDYWxsYmFjayA9IGV4aXN0aW5nQ2FsbGJhY2s7CiAgICAgICAgICAgICB9IGVsc2UgewogICAg ICAgICAgICAgICAgIC8vIFByZXZpZXcgaXNuJ3QgYXZhaWxhYmxlIHlldCwgcmVxdWVzdCBpdCBh c3luY2hyb25vdXNseS4KLSAgICAgICAgICAgICAgICBpZiAoIV93ZWJGcmFtZS0+cGFnZSgpKQot ICAgICAgICAgICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgICAgICAgICAvLyBSZXR1cm4g dG8gcHJpbnRpbmcgbW9kZSBpZiB3ZSdyZSBhbHJlYWR5IGJhY2sgdG8gc2NyZWVuIChlLmcuIGR1 ZSB0byB3aW5kb3cgcmVzaXppbmcpLgogICAgICAgICAgICAgICAgIF93ZWJGcmFtZS0+cGFnZSgp LT5iZWdpblByaW50aW5nKF93ZWJGcmFtZS5nZXQoKSwgV2ViS2l0OjpQcmludEluZm8oW19wcmlu dE9wZXJhdGlvbiBwcmludEluZm9dKSk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0MzhhZDIyZDNmNWJlM2Q5ZmQ3MjljNDNmNDhhMDI4M2Uy MzY3YTQ4Li5kNzA0Y2Y2MTBhMGY2OWViZWMzNWQ0ZjQ2NmFiYmM2NGRkMTI3NjcxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTktMDgtMjggIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4K KworICAgICAgICBOdWxsIGNoZWNrIHdlYkZyYW1lIHdoZW4gY3JlYXRpbmcgYSBwcmludCBwcmV2 aWV3IHRvIHByZXZlbnQgYSBjcmFzaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMTIzNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE2MTg4NjM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBUZXN0IHRvIHZl cmlmeSB0aGF0IGlmIHdlIGRvbid0IGhhdmUgdGhlIFdlYlBhZ2VQcm94eSwgd2Ugd2lsbCBub3Qg Y3Jhc2ggd2hlbiBtYWtpbmcgYSBwcmludCBwcmV2aWV3LgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tOgorICAgICAgICAoVEVTVCk6CisK IDIwMTktMDgtMjggIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAg ICAgIHJlc3VsdHMud2Via2l0Lm9yZzogTW92ZSBkcmF3ZXIgdG8gdGhlIHJpZ2h0LCBvcGVuIGJ5 IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvVUlEZWxlZ2F0ZS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev VUlEZWxlZ2F0ZS5tbQppbmRleCAyYzMxYWJiOTQ0Mjc4OGExMTA2ZjljY2VjMDUyZmIxYmZhMTc2 MzExLi5kZjIxZjFkNWNlMzE2ZDFiNGRjN2RjYTBjMWU2NzgxMDBlMjQ4NDE1IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1VJRGVsZWdhdGUubW0KKysr IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tCkBA IC00MjcsNiArNDI3LDIxIEBAIFRFU1QoV2ViS2l0LCBQcmludEZyYW1lKQogICAgIFRlc3RXZWJL aXRBUEk6OlV0aWw6OnJ1bigmZHJhd0Zvb3RlckNhbGxlZCk7CiB9CiAKK1RFU1QoV2ViS2l0LCBQ cmludFByZXZpZXcpCit7CisgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZp ZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCldKTsKKyAg ICBhdXRvIGRlbGVnYXRlID0gYWRvcHROUyhbW1ByaW50RGVsZWdhdGUgYWxsb2NdIGluaXRdKTsK KyAgICBbd2ViVmlldyBzZXRVSURlbGVnYXRlOmRlbGVnYXRlLmdldCgpXTsKKyAgICBbd2ViVmll dyBsb2FkSFRNTFN0cmluZzpAIjxoZWFkPjx0aXRsZT50ZXN0X3RpdGxlPC90aXRsZT48L2hlYWQ+ PGJvZHkgb25sb2FkPSdwcmludCgpJz5oZWxsbyB3b3JsZCE8L2JvZHk+IiBiYXNlVVJMOltOU1VS TCBVUkxXaXRoU3RyaW5nOkAiaHR0cDovL2V4YW1wbGUuY29tLyJdXTsKKyAgICBUZXN0V2ViS2l0 QVBJOjpVdGlsOjpydW4oJmRvbmUpOworCisgICAgTlNQcmludE9wZXJhdGlvbiAqb3BlcmF0aW9u ID0gW3dlYlZpZXcgX3ByaW50T3BlcmF0aW9uV2l0aFByaW50SW5mbzpbTlNQcmludEluZm8gc2hh cmVkUHJpbnRJbmZvXV07CisgICAgTlNQcmludE9wZXJhdGlvbi5jdXJyZW50T3BlcmF0aW9uID0g b3BlcmF0aW9uOworICAgIGF1dG8gcHJldmlld1ZpZXcgPSBbb3BlcmF0aW9uIHZpZXddOworICAg IFt3ZWJWaWV3IF9jbG9zZV07CisgICAgW3ByZXZpZXdWaWV3IGRyYXdSZWN0OkNHUmVjdE1ha2Uo MCwgMCwgMTAsIDEwKV07Cit9CisKIEBpbnRlcmZhY2UgTm90aWZpY2F0aW9uRGVsZWdhdGUgOiBO U09iamVjdCA8V0tVSURlbGVnYXRlUHJpdmF0ZT4gewogICAgIGJvb2wgX2FsbG93Tm90aWZpY2F0 aW9uczsKIH0K