201231 2019-08-28 13:47:25 -0700 Devirtualize RenderBox::visualOverflowRect() 2019-08-28 15:33:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1565857 0 simon.fraser 2019-08-28 13:47:25 -0700 Devirtualize RenderBox::visualOverflowRect() 1565860 1 377474 simon.fraser 2019-08-28 13:54:15 -0700 Created attachment 377474 Patch 1565879 2 377474 zalan 2019-08-28 14:12:08 -0700 Comment on attachment 377474 Patch v.nice 1565911 3 377474 commit-queue 2019-08-28 15:32:09 -0700 Comment on attachment 377474 Patch Clearing flags on attachment: 377474 Committed r249222: <https://trac.webkit.org/changeset/249222> 1565912 4 commit-queue 2019-08-28 15:32:10 -0700 All reviewed patches have been landed. Closing bug. 1565913 5 webkit-bug-importer 2019-08-28 15:33:19 -0700 <rdar://problem/54811609> 377474 2019-08-28 13:54:15 -0700 2019-08-28 15:32:09 -0700 Patch bug-201231-20190828135414.patch text/plain 5764 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzc4YzYyOWQ0YjJhOTFl OTU4YjU2MTA1ODRlZGI1MmM5NDQ4NzkxZi4uMTY2ODFlZTM0M2ZlNTMzOTgwOTNlMzIwOTI4Y2I1 OTEzZjI5Mzc5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTA4LTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERldmlydHVhbGl6 ZSBSZW5kZXJCb3g6OnZpc3VhbE92ZXJmbG93UmVjdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyMzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb25seSBvdmVycmlkZSBvZiBSZW5kZXJCb3g6 OnZpc3VhbE92ZXJmbG93UmVjdCgpIHdhcyBpbiBSZW5kZXJWaWV3LCBmb3IgInBhaW50c0VudGly ZUNvbnRlbnRzIiB2aWV3cywgYW5kIGFzCisgICAgICAgIGZhciBhcyBJIGNhbiB0ZWxsIHRoaXMg aXMgbm90IG5lY2Vzc2FyeS4gdmlzdWFsT3ZlcmZsb3dSZWN0KCkgaXMgaG90IHdoZW4gY2FsbGVk IGZyb20gUmVuZGVyTGF5ZXI6OmxvY2FsQm91bmRpbmdCb3goKSAtLQorICAgICAgICB0aGlzIHNo b3dzIGluIHByb2ZpbGVzIHdoZW4gc2Nyb2xsaW5nIGxhcmdlIHBhdGNoIHJldmlld3MsIHNvIG1h a2luZyBpdCBub24tdmlydHVhbCBpcyBhIHBlcmZvcm1hbmNlIGVuaGFuY2VtZW50LgorICAgICAg ICAKKyAgICAgICAgUmVuZGVyTGF5ZXI6OmxvY2FsQm91bmRpbmdCb3goKSBjYW4gYWxzbyBqdXN0 IGNhbGwgdmlzdWFsT3ZlcmZsb3dSZWN0KCksIHNpbmNlIHRoYXQgcmV0dXJucyBib3JkZXJCb3hS ZWN0KCkKKyAgICAgICAgd2hlbiB0aGVyZSBpcyBubyBvdmVyZmxvdy4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6dmlzdWFs T3ZlcmZsb3dSZWN0IGNvbnN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6cGVyZm9ybU92ZXJsYXBUZXN0cyk6IE1pbm9yIG9wdGltaXph dGlvbiB0byBhdm9pZCBhIGNhbGwgdG8gYm91bmRpbmdCb3goKS4KKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckxheWVyOjpjYWxjdWxhdGVDbGlwUmVjdHMgY29uc3QpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnZpc3Vh bE92ZXJmbG93UmVjdCBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clZpZXcuaDoKKwogMjAxOS0wOC0yNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBIYXZlIFJlbmRlclNWR0Jsb2NrIGNvbXB1dGUgdmlzdWFsIG92ZXJm bG93IGp1c3QgbGlrZSBldmVyeW9uZSBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmgKaW5kZXggMTRhNTUyMjAxZmRmNTQxZWFiZGEyOTM5MDNmN2VkYjgyMmFkZTc4Ni4uODg2ZTk3 Yjg0M2Q4ZmRhYjdlYWMxNzEyNmJiYWExMzMzYzE1Nzk2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guaApAQCAtMTkxLDcgKzE5MSw3IEBAIHB1YmxpYzoKICAgICBMYXlvdXRVbml0 IGxvZ2ljYWxMZWZ0TGF5b3V0T3ZlcmZsb3coKSBjb25zdCB7IHJldHVybiBzdHlsZSgpLmlzSG9y aXpvbnRhbFdyaXRpbmdNb2RlKCkgPyBsYXlvdXRPdmVyZmxvd1JlY3QoKS54KCkgOiBsYXlvdXRP dmVyZmxvd1JlY3QoKS55KCk7IH0KICAgICBMYXlvdXRVbml0IGxvZ2ljYWxSaWdodExheW91dE92 ZXJmbG93KCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5pc0hvcml6b250YWxXcml0aW5nTW9kZSgp ID8gbGF5b3V0T3ZlcmZsb3dSZWN0KCkubWF4WCgpIDogbGF5b3V0T3ZlcmZsb3dSZWN0KCkubWF4 WSgpOyB9CiAgICAgCi0gICAgdmlydHVhbCBMYXlvdXRSZWN0IHZpc3VhbE92ZXJmbG93UmVjdCgp IGNvbnN0IHsgcmV0dXJuIG1fb3ZlcmZsb3cgPyBtX292ZXJmbG93LT52aXN1YWxPdmVyZmxvd1Jl Y3QoKSA6IGJvcmRlckJveFJlY3QoKTsgfQorICAgIExheW91dFJlY3QgdmlzdWFsT3ZlcmZsb3dS ZWN0KCkgY29uc3QgeyByZXR1cm4gbV9vdmVyZmxvdyA/IG1fb3ZlcmZsb3ctPnZpc3VhbE92ZXJm bG93UmVjdCgpIDogYm9yZGVyQm94UmVjdCgpOyB9CiAgICAgTGF5b3V0VW5pdCBsb2dpY2FsTGVm dFZpc3VhbE92ZXJmbG93KCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5pc0hvcml6b250YWxXcml0 aW5nTW9kZSgpID8gdmlzdWFsT3ZlcmZsb3dSZWN0KCkueCgpIDogdmlzdWFsT3ZlcmZsb3dSZWN0 KCkueSgpOyB9CiAgICAgTGF5b3V0VW5pdCBsb2dpY2FsUmlnaHRWaXN1YWxPdmVyZmxvdygpIGNv bnN0IHsgcmV0dXJuIHN0eWxlKCkuaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/IHZpc3VhbE92 ZXJmbG93UmVjdCgpLm1heFgoKSA6IHZpc3VhbE92ZXJmbG93UmVjdCgpLm1heFkoKTsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA0ZjA4Y2VhZWI4ZGJi YjU5Mzk5MjRiYjYwMjEyYmI5NDdmYmYyY2MzLi42ZmI5ODRkYzVmNjQ1ZTQ5YzBjYmEyZTZjMmFm MzM3N2UxYjJkODA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK QEAgLTQwOTQsNiArNDA5NCw5IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnJlc3RvcmVDbGlwKEdyYXBo aWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgTGF5ZXJQYWludGluZ0luZm8mCiAKIHN0YXRpYyB2 b2lkIHBlcmZvcm1PdmVybGFwVGVzdHMoT3ZlcmxhcFRlc3RSZXF1ZXN0TWFwJiBvdmVybGFwVGVz dFJlcXVlc3RzLCBjb25zdCBSZW5kZXJMYXllciogcm9vdExheWVyLCBjb25zdCBSZW5kZXJMYXll ciogbGF5ZXIpCiB7CisgICAgaWYgKG92ZXJsYXBUZXN0UmVxdWVzdHMuaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm47CisKICAgICBWZWN0b3I8T3ZlcmxhcFRlc3RSZXF1ZXN0Q2xpZW50Kj4gb3Zl cmxhcHBlZFJlcXVlc3RDbGllbnRzOwogICAgIExheW91dFJlY3QgYm91bmRpbmdCb3ggPSBsYXll ci0+Ym91bmRpbmdCb3gocm9vdExheWVyLCBsYXllci0+b2Zmc2V0RnJvbUFuY2VzdG9yKHJvb3RM YXllcikpOwogICAgIGZvciAoYXV0byYgcmVxdWVzdCA6IG92ZXJsYXBUZXN0UmVxdWVzdHMpIHsK QEAgLTU5MzQsMTMgKzU5MzcsOCBAQCBMYXlvdXRSZWN0IFJlbmRlckxheWVyOjpsb2NhbEJvdW5k aW5nQm94KE9wdGlvblNldDxDYWxjdWxhdGVMYXllckJvdW5kc0ZsYWc+IGZsYQogICAgICAgICBp ZiAoIShmbGFncyAmIERvbnRDb25zdHJhaW5Gb3JNYXNrKSAmJiBib3gtPmhhc01hc2soKSkgewog ICAgICAgICAgICAgcmVzdWx0ID0gYm94LT5tYXNrQ2xpcFJlY3QoTGF5b3V0UG9pbnQoKSk7CiAg ICAgICAgICAgICBib3gtPmZsaXBGb3JXcml0aW5nTW9kZShyZXN1bHQpOyAvLyBUaGUgbWFzayBj bGlwIHJlY3QgaXMgaW4gcGh5c2ljYWwgY29vcmRpbmF0ZXMsIHNvIHdlIGhhdmUgdG8gZmxpcCwg c2luY2UgbG9jYWxCb3VuZGluZ0JveCBpcyBub3QuCi0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAg ICAgICBMYXlvdXRSZWN0IGJib3ggPSBib3gtPmJvcmRlckJveFJlY3QoKTsKLSAgICAgICAgICAg IHJlc3VsdCA9IGJib3g7Ci0gICAgICAgICAgICBMYXlvdXRSZWN0IG92ZXJmbG93UmVjdCA9IGJv eC0+dmlzdWFsT3ZlcmZsb3dSZWN0KCk7Ci0gICAgICAgICAgICBpZiAoYmJveCAhPSBvdmVyZmxv d1JlY3QpCi0gICAgICAgICAgICAgICAgcmVzdWx0LnVuaXRlKG92ZXJmbG93UmVjdCk7Ci0gICAg ICAgIH0KKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICByZXN1bHQgPSBib3gtPnZpc3VhbE92 ZXJmbG93UmVjdCgpOwogICAgIH0KICAgICByZXR1cm4gcmVzdWx0OwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCmluZGV4IDVmZWM2NzhjNmJiNWRmMGU0OTIyYjAxMmMz ZjI2OGRiYWI0YTdiNmEuLmU1NjU5NjA4OWVhMDg5YjJjZDA2ZTY0MjFjMzZiYmRlYzZhY2ZmNzkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAgLTUxNCwxNCArNTE0 LDYgQEAgdm9pZCBSZW5kZXJWaWV3OjpyZXBhaW50Vmlld0FuZENvbXBvc2l0ZWRMYXllcnMoKQog ICAgICAgICBjb21wb3NpdG9yLnJlcGFpbnRDb21wb3NpdGVkTGF5ZXJzKCk7CiB9CiAKLUxheW91 dFJlY3QgUmVuZGVyVmlldzo6dmlzdWFsT3ZlcmZsb3dSZWN0KCkgY29uc3QKLXsKLSAgICBpZiAo ZnJhbWVWaWV3KCkucGFpbnRzRW50aXJlQ29udGVudHMoKSkKLSAgICAgICAgcmV0dXJuIGxheW91 dE92ZXJmbG93UmVjdCgpOwotCi0gICAgcmV0dXJuIFJlbmRlckJsb2NrRmxvdzo6dmlzdWFsT3Zl cmZsb3dSZWN0KCk7Ci19Ci0KIE9wdGlvbmFsPExheW91dFJlY3Q+IFJlbmRlclZpZXc6OmNvbXB1 dGVWaXNpYmxlUmVjdEluQ29udGFpbmVyKGNvbnN0IExheW91dFJlY3QmIHJlY3QsIGNvbnN0IFJl bmRlckxheWVyTW9kZWxPYmplY3QqIGNvbnRhaW5lciwgVmlzaWJsZVJlY3RDb250ZXh0IGNvbnRl eHQpIGNvbnN0CiB7CiAgICAgLy8gSWYgYSBjb250YWluZXIgd2FzIHNwZWNpZmllZCwgYW5kIHdh cyBub3QgbnVsbHB0ciBvciB0aGUgUmVuZGVyVmlldywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlldy5oCmluZGV4IDk4NWJmZTZkNmIwZGQxZTA1MzU3ZTAyNjcyYmQ5NGJhYzFmMDJiZTgu LjliOTZmMTYxZmNhNmE1YjMzZDQ1ODI0NjYyNmQyODM4MDA1OTQyMGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuaApAQCAtNjgsNyArNjgsNiBAQCBwdWJsaWM6CiAKICAgICBG cmFtZVZpZXcmIGZyYW1lVmlldygpIGNvbnN0IHsgcmV0dXJuIG1fZnJhbWVWaWV3OyB9CiAKLSAg ICBMYXlvdXRSZWN0IHZpc3VhbE92ZXJmbG93UmVjdCgpIGNvbnN0IG92ZXJyaWRlOwogICAgIE9w dGlvbmFsPExheW91dFJlY3Q+IGNvbXB1dGVWaXNpYmxlUmVjdEluQ29udGFpbmVyKGNvbnN0IExh eW91dFJlY3QmLCBjb25zdCBSZW5kZXJMYXllck1vZGVsT2JqZWN0KiBjb250YWluZXIsIFZpc2li bGVSZWN0Q29udGV4dCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdm9pZCByZXBhaW50Um9vdENvbnRl bnRzKCk7CiAgICAgdm9pZCByZXBhaW50Vmlld1JlY3RhbmdsZShjb25zdCBMYXlvdXRSZWN0Jikg Y29uc3Q7Cg==