<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>201227</bug_id>
          
          <creation_ts>2019-08-28 10:42:29 -0700</creation_ts>
          <short_desc>XLinkNames namespace is required before the &apos;href&apos; attribute of SVG animate elements</short_desc>
          <delta_ts>2019-09-06 10:17:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=153854</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=189499</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=195802</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>rniwa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1565794</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-08-28 10:42:29 -0700</bug_when>
    <thetext>Open the attached test case.

Result: One red rectangle and one green rectangle.
Expected: Tow green rectangles.

In the test case there are two SVG &lt;rect&gt; elements. The two &lt;rect&gt; elements are referenced by two &lt;set&gt; elements to change their &quot;fill&quot; attribute from &quot;red&quot; to &quot;green&quot;. The first &lt;set&gt; element has the attribute &quot;href&quot; set to &quot;#rect&quot;. The second &lt;set&gt; element has the attribute &quot;xlink:href&quot; set to &quot;#rect2&quot;. The first &lt;set&gt; element fails to set its target correctly while the second succeeds to set its target correctly.

This is a left over work from r234683.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565795</commentid>
    <comment_count>1</comment_count>
      <attachid>377460</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-08-28 10:42:59 -0700</bug_when>
    <thetext>Created attachment 377460
test case</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565797</commentid>
    <comment_count>2</comment_count>
      <attachid>377461</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-08-28 10:51:28 -0700</bug_when>
    <thetext>Created attachment 377461
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565813</commentid>
    <comment_count>3</comment_count>
      <attachid>377467</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-08-28 12:27:46 -0700</bug_when>
    <thetext>Created attachment 377467
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565835</commentid>
    <comment_count>4</comment_count>
      <attachid>377467</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-28 12:57:06 -0700</bug_when>
    <thetext>Comment on attachment 377467
Patch

Clearing flags on attachment: 377467

Committed r249216: &lt;https://trac.webkit.org/changeset/249216&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565836</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-28 12:57:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565837</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-08-28 12:58:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/54803998&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565849</commentid>
    <comment_count>7</comment_count>
      <attachid>377467</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-28 13:33:06 -0700</bug_when>
    <thetext>Comment on attachment 377467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377467&amp;action=review

&gt; LayoutTests/svg/custom/href-svg-namespace-animate-target.svg:2
&gt; +    &lt;desc&gt;Verify the XLinkNames namespace is not requried before the &apos;href&apos; attribute of the SVG animate elements.&lt;/desc&gt;

Typoe &quot;requried&quot;.

Also, is &lt;desc&gt; the best way to add comments to SVG? Since this ends up just serving as a comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565852</commentid>
    <comment_count>8</comment_count>
      <attachid>377467</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-28 13:36:01 -0700</bug_when>
    <thetext>Comment on attachment 377467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377467&amp;action=review

&gt; LayoutTests/svg/custom/href-svg-namespace-animate-target.svg:6
&gt; +    &lt;rect id=&quot;rect1&quot; width=&quot;100&quot; height=&quot;100&quot; fill=&quot;red&quot;/&gt;
&gt; +    &lt;set id=&quot;set&quot; attributeName=&quot;fill&quot; attributeType=&quot;CSS&quot; href=&quot;#rect1&quot;  to=&quot;green&quot; begin=&quot;0s&quot; fill=&quot;freeze&quot;/&gt; 
&gt; +    &lt;rect id=&quot;rect2&quot; x=&quot;110&quot; width=&quot;100&quot; height=&quot;100&quot; fill=&quot;red&quot;/&gt;
&gt; +    &lt;set id=&quot;set&quot; attributeName=&quot;fill&quot; attributeType=&quot;CSS&quot; xlink:href=&quot;#rect2&quot;  to=&quot;green&quot; begin=&quot;0s&quot; fill=&quot;freeze&quot;/&gt; 

I think we should consider more test coverage: tests that check which attribute is respected if multiple are present in various orders. The code currently will prioritize href over xlink:href no matter what order the attributes appear in, and I’d like to see tests that check that because those are the kinds of things that can become interoperability problems between web browsers. I’d also be interested in at least some tests that check if the elements respond properly if the attributes are changed dynamically by script.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565970</commentid>
    <comment_count>9</comment_count>
      <attachid>377467</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-08-28 17:10:06 -0700</bug_when>
    <thetext>Comment on attachment 377467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377467&amp;action=review

&gt;&gt; LayoutTests/svg/custom/href-svg-namespace-animate-target.svg:2
&gt;&gt; +    &lt;desc&gt;Verify the XLinkNames namespace is not requried before the &apos;href&apos; attribute of the SVG animate elements.&lt;/desc&gt;
&gt; 
&gt; Typoe &quot;requried&quot;.
&gt; 
&gt; Also, is &lt;desc&gt; the best way to add comments to SVG? Since this ends up just serving as a comment.

I will fix the typo in a followup patch.

&gt;&gt; LayoutTests/svg/custom/href-svg-namespace-animate-target.svg:6
&gt;&gt; +    &lt;set id=&quot;set&quot; attributeName=&quot;fill&quot; attributeType=&quot;CSS&quot; xlink:href=&quot;#rect2&quot;  to=&quot;green&quot; begin=&quot;0s&quot; fill=&quot;freeze&quot;/&gt; 
&gt; 
&gt; I think we should consider more test coverage: tests that check which attribute is respected if multiple are present in various orders. The code currently will prioritize href over xlink:href no matter what order the attributes appear in, and I’d like to see tests that check that because those are the kinds of things that can become interoperability problems between web browsers. I’d also be interested in at least some tests that check if the elements respond properly if the attributes are changed dynamically by script.

This is true. We are not compliant with the specs in what to be respected when both href and xlink:href exist. For example, this SVG will display a red circle in WebKit although it should show a green rectangle:

&lt;svg xmlns=&quot;http://www.w3.org/2000/svg&quot; xmlns:xlink=&quot;http://www.w3.org/1999/xlink&quot;&gt;
    &lt;defs&gt;
        &lt;circle id=&quot;circle&quot; cx=&quot;50&quot; cy=&quot;50&quot; r=&quot;50&quot; fill=&quot;red&quot;/&gt;
        &lt;rect id=&quot;rect&quot; width=&quot;100&quot; height=&quot;100&quot; fill=&quot;green&quot;/&gt;
    &lt;/defs&gt;
    &lt;use href=&quot;#rect&quot; xlink:href=&quot;#circle&quot;/&gt;
&lt;/svg&gt;

This issue was reported in https://bugs.webkit.org/show_bug.cgi?id=195802 which I am going to use to address your comments and to ensure we are compliant with the specs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1568570</commentid>
    <comment_count>10</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2019-09-06 10:17:08 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #7)
&gt; Comment on attachment 377467 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=377467&amp;action=review
&gt; 
&gt; &gt; LayoutTests/svg/custom/href-svg-namespace-animate-target.svg:2
&gt; &gt; +    &lt;desc&gt;Verify the XLinkNames namespace is not requried before the &apos;href&apos; attribute of the SVG animate elements.&lt;/desc&gt;
&gt; 
&gt; Typoe &quot;requried&quot;.
&gt; 
&gt; Also, is &lt;desc&gt; the best way to add comments to SVG? Since this ends up just
&gt; serving as a comment.

The typo and the &lt;desc&gt; issue were fixed in &lt;https://trac.webkit.org/changeset/249579&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>377460</attachid>
            <date>2019-08-28 10:42:59 -0700</date>
            <delta_ts>2019-08-28 10:42:59 -0700</delta_ts>
            <desc>test case</desc>
            <filename>href-svg-namespace-animate-target.svg</filename>
            <type>image/svg+xml</type>
            <size>568</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw
Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KICAgIDxkZXNjPlZlcmlmeSB0aGUgWExpbmtOYW1l
cyBuYW1lc3BhY2UgaXMgbm90IHJlcXVyaWVkIGJlZm9yZSB0aGUgJ2hyZWYnIGF0dHJpYnV0ZSBv
ZiB0aGUgJmx0O3NldCZndDsgZWxlbWVudC48L2Rlc2M+CiAgICA8cmVjdCBpZD0icmVjdCIgd2lk
dGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9InJlZCIvPgogICAgPHNldCBpZD0ic2V0IiBhdHRy
aWJ1dGVOYW1lPSJmaWxsIiBhdHRyaWJ1dGVUeXBlPSJDU1MiIGhyZWY9IiNyZWN0IiAgdG89Imdy
ZWVuIiBiZWdpbj0iMHMiIGZpbGw9ImZyZWV6ZSIvPiAKICAgIDxyZWN0IGlkPSJyZWN0MiIgeD0i
MTEwIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0icmVkIi8+CiAgICA8c2V0IGlkPSJz
ZXQiIGF0dHJpYnV0ZU5hbWU9ImZpbGwiIGF0dHJpYnV0ZVR5cGU9IkNTUyIgeGxpbms6aHJlZj0i
I3JlY3QyIiAgdG89ImdyZWVuIiBiZWdpbj0iMHMiIGZpbGw9ImZyZWV6ZSIvPiAKPC9zdmc+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377461</attachid>
            <date>2019-08-28 10:51:28 -0700</date>
            <delta_ts>2019-08-28 12:27:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201227-20190828105127.patch</filename>
            <type>text/plain</type>
            <size>3595</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTIwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA4LTI4ICBTYWlkIEFi
b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgWExpbmtOYW1l
cyBuYW1lc2FwY2UgaXMgcmVxdWlyZWQgYmVmb3JlIHRoZSAnaHJlZicgYXR0cmlidXRlIG9mIFNW
RyBhbmltYXRlIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0yMDEyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBUbyBnZXQgdGhlIGFuaW1hdGlvbiB0YXJnZXQgZWxlbWVudCwgZ2V0IHRoZSB2
YWx1ZSBvZiB0aGUgImhyZWYiIGF0dHJpYnV0ZQorICAgICAgICBvciB0aGUgInhsaW5rOmhyZWYi
IGF0dHJpYnV0ZS4KKworICAgICAgICBUZXN0czogc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3Bh
Y2UtYW5pbWF0ZS10YXJnZXQuc3ZnCisKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9uL1NWR1NNSUxF
bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NNSUxFbGVtZW50OjpidWlsZFBlbmRp
bmdSZXNvdXJjZSk6CisKIDIwMTktMDgtMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv
bT4KIAogICAgICAgICBnZW9sb2NhdGlvbi53YXRjaFBvc2l0aW9uKCkgLyBnZXRDdXJyZW50UG9z
aXRpb24oKSBzaG91bGQgcmV0dXJuIFBFUk1JU1NJT05fREVOSUVEIHdoZW4gY29udGV4dCBpcyBu
b3Qgc2VjdXJlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVt
ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NN
SUxFbGVtZW50LmNwcAkocmV2aXNpb24gMjQ5MjAyKQorKysgU291cmNlL1dlYkNvcmUvc3ZnL2Fu
aW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4MSw3ICsxODEs
NyBAQCB2b2lkIFNWR1NNSUxFbGVtZW50OjpidWlsZFBlbmRpbmdSZXNvdXJjCiAKICAgICBTdHJp
bmcgaWQ7CiAgICAgUmVmUHRyPEVsZW1lbnQ+IHRhcmdldDsKLSAgICBhdXRvJiBocmVmID0gZ2V0
QXR0cmlidXRlKFhMaW5rTmFtZXM6OmhyZWZBdHRyKTsKKyAgICBhdXRvJiBocmVmID0gZ2V0QXR0
cmlidXRlKFNWR05hbWVzOjpocmVmQXR0ciwgWExpbmtOYW1lczo6aHJlZkF0dHIpOwogICAgIGlm
IChocmVmLmlzRW1wdHkoKSkKICAgICAgICAgdGFyZ2V0ID0gcGFyZW50RWxlbWVudCgpOwogICAg
IGVsc2UgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91
dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ5MjAyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDgtMjggIFNhaWQgQWJv
dS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KKworICAgICAgICBYTGlua05hbWVz
IG5hbWVzYXBjZSBpcyByZXF1aXJlZCBiZWZvcmUgdGhlICdocmVmJyBhdHRyaWJ1dGUgb2YgU1ZH
IGFuaW1hdGUgZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMTIyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3BhY2UtYW5pbWF0ZS10YXJnZXQt
ZXhwZWN0ZWQuc3ZnOiBBZGRlZC4KKyAgICAgICAgKiBzdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVz
cGFjZS1hbmltYXRlLXRhcmdldC5zdmc6IEFkZGVkLgorCiAyMDE5LTA4LTI4ICBKZXIgTm9ibGUg
IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEZsYWt5IFRlc3Q6IGZ1bGxzY3JlZW4v
ZnVsbC1zY3JlZW4tcmVxdWVzdC1yZW1vdmVkLXdpdGgtcmFmLmh0bWwKSW5kZXg6IExheW91dFRl
c3RzL3N2Zy9jdXN0b20vaHJlZi1zdmctbmFtZXNwYWNlLWFuaW1hdGUtdGFyZ2V0LWV4cGVjdGVk
LnN2Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVz
cGFjZS1hbmltYXRlLXRhcmdldC1leHBlY3RlZC5zdmcJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0
VGVzdHMvc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3BhY2UtYW5pbWF0ZS10YXJnZXQtZXhwZWN0
ZWQuc3ZnCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNCBAQAorPHN2ZyB4bWxucz0iaHR0cDov
L3d3dy53My5vcmcvMjAwMC9zdmciPgorICAgIDxyZWN0IHdpZHRoPSIxMDAiIGhlaWdodD0iMTAw
IiBmaWxsPSJncmVlbiIvPgorICAgIDxyZWN0IHg9IjExMCIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIx
MDAiIGZpbGw9ImdyZWVuIi8+Cis8L3N2Zz4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9jdXN0b20v
aHJlZi1zdmctbmFtZXNwYWNlLWFuaW1hdGUtdGFyZ2V0LnN2Zwo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv
dXRUZXN0cy9zdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVzcGFjZS1hbmltYXRlLXRhcmdldC5zdmcJ
KG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3Bh
Y2UtYW5pbWF0ZS10YXJnZXQuc3ZnCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNyBAQAorPHN2
ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8v
d3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKyAgICA8ZGVzYz5WZXJpZnkgdGhlIFhMaW5rTmFtZXMg
bmFtZXNwYWNlIGlzIG5vdCByZXF1cmllZCBiZWZvcmUgdGhlICdocmVmJyBhdHRyaWJ1dGUgb2Yg
dGhlIFNWRyBhbmltYXRlIGVsZW1lbnRzLjwvZGVzYz4KKyAgICA8cmVjdCBpZD0icmVjdDEiIHdp
ZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJyZWQiLz4KKyAgICA8c2V0IGlkPSJzZXQiIGF0
dHJpYnV0ZU5hbWU9ImZpbGwiIGF0dHJpYnV0ZVR5cGU9IkNTUyIgaHJlZj0iI3JlY3QxIiAgdG89
ImdyZWVuIiBiZWdpbj0iMHMiIGZpbGw9ImZyZWV6ZSIvPiAKKyAgICA8cmVjdCBpZD0icmVjdDIi
IHg9IjExMCIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9InJlZCIvPgorICAgIDxzZXQg
aWQ9InNldCIgYXR0cmlidXRlTmFtZT0iZmlsbCIgYXR0cmlidXRlVHlwZT0iQ1NTIiB4bGluazpo
cmVmPSIjcmVjdDIiICB0bz0iZ3JlZW4iIGJlZ2luPSIwcyIgZmlsbD0iZnJlZXplIi8+IAorPC9z
dmc+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377467</attachid>
            <date>2019-08-28 12:27:46 -0700</date>
            <delta_ts>2019-08-28 12:57:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201227-20190828122745.patch</filename>
            <type>text/plain</type>
            <size>3647</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTIxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA4LTI4ICBTYWlkIEFi
b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgWExpbmtOYW1l
cyBuYW1lc3BhY2UgaXMgcmVxdWlyZWQgYmVmb3JlIHRoZSAnaHJlZicgYXR0cmlidXRlIG9mIFNW
RyBhbmltYXRlIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0yMDEyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisK
KyAgICAgICAgVG8gZ2V0IHRoZSBhbmltYXRpb24gdGFyZ2V0IGVsZW1lbnQsIGdldCB0aGUgdmFs
dWUgb2YgdGhlICJocmVmIiBhdHRyaWJ1dGUKKyAgICAgICAgb3IgdGhlICJ4bGluazpocmVmIiBh
dHRyaWJ1dGUuCisKKyAgICAgICAgVGVzdHM6IHN2Zy9jdXN0b20vaHJlZi1zdmctbmFtZXNwYWNl
LWFuaW1hdGUtdGFyZ2V0LnN2ZworCisgICAgICAgICogc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxl
bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdTTUlMRWxlbWVudDo6YnVpbGRQZW5kaW5n
UmVzb3VyY2UpOgorCiAyMDE5LTA4LTI4ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4K
IAogICAgICAgICBbV0hMU0xdIElubGluZSB0eXBlZGVmJ2QgdHlwZXMgZHVyaW5nIE1ldGFsIGNv
ZGUgZ2VuZXJhdGlvbiB0byBzaW1wbGlmeSBnZW5lcmF0ZWQgY29kZSB3aGlsZSBhbHNvIG1ha2lu
ZyBpdCBlYXNpZXIgdG8gcmVhZApJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9T
VkdTTUlMRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1h
dGlvbi9TVkdTTUlMRWxlbWVudC5jcHAJKHJldmlzaW9uIDI0OTIxMCkKKysrIFNvdXJjZS9XZWJD
b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x
ODEsNyArMTgxLDcgQEAgdm9pZCBTVkdTTUlMRWxlbWVudDo6YnVpbGRQZW5kaW5nUmVzb3VyYwog
CiAgICAgU3RyaW5nIGlkOwogICAgIFJlZlB0cjxFbGVtZW50PiB0YXJnZXQ7Ci0gICAgYXV0byYg
aHJlZiA9IGdldEF0dHJpYnV0ZShYTGlua05hbWVzOjpocmVmQXR0cik7CisgICAgYXV0byYgaHJl
ZiA9IGdldEF0dHJpYnV0ZShTVkdOYW1lczo6aHJlZkF0dHIsIFhMaW5rTmFtZXM6OmhyZWZBdHRy
KTsKICAgICBpZiAoaHJlZi5pc0VtcHR5KCkpCiAgICAgICAgIHRhcmdldCA9IHBhcmVudEVsZW1l
bnQoKTsKICAgICBlbHNlIHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTIxMCkKKysrIExheW91dFRl
c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTI4
ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAg
WExpbmtOYW1lcyBuYW1lc3BhY2UgaXMgcmVxdWlyZWQgYmVmb3JlIHRoZSAnaHJlZicgYXR0cmli
dXRlIG9mIFNWRyBhbmltYXRlIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtl
IE5pd2EuCisKKyAgICAgICAgKiBzdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVzcGFjZS1hbmltYXRl
LXRhcmdldC1leHBlY3RlZC5zdmc6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vaHJlZi1z
dmctbmFtZXNwYWNlLWFuaW1hdGUtdGFyZ2V0LnN2ZzogQWRkZWQuCisKIDIwMTktMDgtMjggIENo
cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBnZW9sb2NhdGlvbi53YXRj
aFBvc2l0aW9uKCkgLyBnZXRDdXJyZW50UG9zaXRpb24oKSBzaG91bGQgcmV0dXJuIFBFUk1JU1NJ
T05fREVOSUVEIHdoZW4gY29udGV4dCBpcyBub3Qgc2VjdXJlCkluZGV4OiBMYXlvdXRUZXN0cy9z
dmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVzcGFjZS1hbmltYXRlLXRhcmdldC1leHBlY3RlZC5zdmcK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3BhY2Ut
YW5pbWF0ZS10YXJnZXQtZXhwZWN0ZWQuc3ZnCShub25leGlzdGVudCkKKysrIExheW91dFRlc3Rz
L3N2Zy9jdXN0b20vaHJlZi1zdmctbmFtZXNwYWNlLWFuaW1hdGUtdGFyZ2V0LWV4cGVjdGVkLnN2
Zwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQgQEAKKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cu
dzMub3JnLzIwMDAvc3ZnIj4KKyAgICA8cmVjdCB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmls
bD0iZ3JlZW4iLz4KKyAgICA8cmVjdCB4PSIxMTAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBm
aWxsPSJncmVlbiIvPgorPC9zdmc+CkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2hyZWYt
c3ZnLW5hbWVzcGFjZS1hbmltYXRlLXRhcmdldC5zdmcKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz
dHMvc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3BhY2UtYW5pbWF0ZS10YXJnZXQuc3ZnCShub25l
eGlzdGVudCkKKysrIExheW91dFRlc3RzL3N2Zy9jdXN0b20vaHJlZi1zdmctbmFtZXNwYWNlLWFu
aW1hdGUtdGFyZ2V0LnN2Zwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDcgQEAKKzxzdmcgeG1s
bnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53
My5vcmcvMTk5OS94bGluayI+CisgICAgPGRlc2M+VmVyaWZ5IHRoZSBYTGlua05hbWVzIG5hbWVz
cGFjZSBpcyBub3QgcmVxdXJpZWQgYmVmb3JlIHRoZSAnaHJlZicgYXR0cmlidXRlIG9mIHRoZSBT
VkcgYW5pbWF0ZSBlbGVtZW50cy48L2Rlc2M+CisgICAgPHJlY3QgaWQ9InJlY3QxIiB3aWR0aD0i
MTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0icmVkIi8+CisgICAgPHNldCBpZD0ic2V0IiBhdHRyaWJ1
dGVOYW1lPSJmaWxsIiBhdHRyaWJ1dGVUeXBlPSJDU1MiIGhyZWY9IiNyZWN0MSIgIHRvPSJncmVl
biIgYmVnaW49IjBzIiBmaWxsPSJmcmVlemUiLz4gCisgICAgPHJlY3QgaWQ9InJlY3QyIiB4PSIx
MTAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJyZWQiLz4KKyAgICA8c2V0IGlkPSJz
ZXQiIGF0dHJpYnV0ZU5hbWU9ImZpbGwiIGF0dHJpYnV0ZVR5cGU9IkNTUyIgeGxpbms6aHJlZj0i
I3JlY3QyIiAgdG89ImdyZWVuIiBiZWdpbj0iMHMiIGZpbGw9ImZyZWV6ZSIvPiAKKzwvc3ZnPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>