201226 2019-08-28 10:23:57 -0700 Web Inspector: REGRESSION(r249078): JavaScript autocomplete doesn't work when evaluating properties of values 2019-08-28 23:47:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1565778 0 hi 2019-08-28 10:23:57 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Console 3. type "window." => completions shown 3. type "r" => completions disappear 1565784 1 377459 hi 2019-08-28 10:34:41 -0700 Created attachment 377459 Patch 1566097 2 377459 joepeck 2019-08-28 22:38:23 -0700 Comment on attachment 377459 Patch r=me 1566119 3 377459 commit-queue 2019-08-28 23:46:33 -0700 Comment on attachment 377459 Patch Clearing flags on attachment: 377459 Committed r249246: <https://trac.webkit.org/changeset/249246> 1566120 4 commit-queue 2019-08-28 23:46:35 -0700 All reviewed patches have been landed. Closing bug. 1566121 5 webkit-bug-importer 2019-08-28 23:47:17 -0700 <rdar://problem/54825751> 377459 2019-08-28 10:34:41 -0700 2019-08-28 23:46:33 -0700 Patch bug-201226-20190828103440.patch text/plain 6007 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU5MTAwMmI0YTY5NGJkMzllYWJkYzY4OTllOWMx ZGRkNGJiNWY5MTUuLmMwY2Y2NjA4N2RhOTc3MzZlZTQyMWEyZDliY2FhYTI3ODQwZDdjNWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA4LTI4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDkwNzgpOiBKYXZhU2NyaXB0IGF1dG9jb21wbGV0ZSBkb2Vzbid0IHdvcmsg d2hlbiBldmFsdWF0aW5nIHByb3BlcnRpZXMgb2YgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyMjYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjQ5MDc4IG1vZGlmaWVkIGBXSS5KYXZhU2Ny aXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlcmAgdG8gdXNlIGFycmF5cyBvZiBwcm9wZXJ0eSBu YW1lcworICAgICAgICBpbnN0ZWFkIG9mIG9iamVjdHMgZm9yIGNvbXBsZXRpb24sIGJ1dCBhIGZl dyBjb2RlIHBhdGhzIHdlcmUgbWlzc2VkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9KYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlci5qczoKKyAgICAgICAg KFdJLkphdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVyLnByb3RvdHlwZS5jb21wbGV0 aW9uQ29udHJvbGxlckNvbXBsZXRpb25zTmVlZGVkLmV2YWx1YXRlZCk6CisgICAgICAgIChXSS5K YXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlci5wcm90b3R5cGUuY29tcGxldGlvbkNv bnRyb2xsZXJDb21wbGV0aW9uc05lZWRlZC5yZWNlaXZlZFByb3BlcnR5TmFtZXNGcm9tRXZhbHVh dGUpOgorICAgICAgICAoV0kuSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9uUHJvdmlkZXIucHJv dG90eXBlLmNvbXBsZXRpb25Db250cm9sbGVyQ29tcGxldGlvbnNOZWVkZWQucmVjZWl2ZWRPYmpl Y3RQcm9wZXJ0eU5hbWVzKTogQWRkZWQuCisgICAgICAgIChXSS5KYXZhU2NyaXB0UnVudGltZUNv bXBsZXRpb25Qcm92aWRlci5wcm90b3R5cGUuY29tcGxldGlvbkNvbnRyb2xsZXJDb21wbGV0aW9u c05lZWRlZC5yZWNlaXZlZEFycmF5UHJvcGVydHlOYW1lcyk6CisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL01vZGVscy9DYWxsRnJhbWUuanM6CisgICAgICAgIChXSS5DYWxsRnJhbWUucHJvdG90 eXBlLmNvbGxlY3RTY29wZUNoYWluVmFyaWFibGVOYW1lcyk6CisgICAgICAgIChXSS5DYWxsRnJh bWUucHJvdG90eXBlLmNvbGxlY3RTY29wZUNoYWluVmFyaWFibGVOYW1lcy5wcm9wZXJ0aWVzQ29s bGVjdGVkKToKKwogMjAxOS0wOC0yNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVwbGFjZSB1c2VzIG9mIGFkZGVkIHV0aWxpdHkg YEFycmF5LnByb3RvdHlwZS5rZXlTZXRgIHdpdGggYW4gYWN0dWFsIGBTZXRgCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2Ny aXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3Zp ZGVyLmpzCmluZGV4IGU1MjI3M2MyOTdhM2NjZjczNDVhZTE0M2E4M2RmNjAzNDQyZDc1MmIuLjE0 ZmQyYmE5NDRhOTg4ZTYyM2YxMGYxYWIzNjRhMjQ1MGVjMzg0ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50 aW1lQ29tcGxldGlvblByb3ZpZGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVy LmpzCkBAIC0xNjUsNyArMTY1LDcgQEAgV0kuSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9uUHJv dmlkZXIgPSBjbGFzcyBKYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWQKICAgICAgICAg ICAgIGlmICh3YXNUaHJvd24gfHwgIXJlc3VsdCB8fCByZXN1bHQudHlwZSA9PT0gInVuZGVmaW5l ZCIgfHwgKHJlc3VsdC50eXBlID09PSAib2JqZWN0IiAmJiByZXN1bHQuc3VidHlwZSA9PT0gIm51 bGwiKSkgewogICAgICAgICAgICAgICAgIFdJLnJ1bnRpbWVNYW5hZ2VyLmFjdGl2ZUV4ZWN1dGlv bkNvbnRleHQudGFyZ2V0LlJ1bnRpbWVBZ2VudC5yZWxlYXNlT2JqZWN0R3JvdXAoImNvbXBsZXRp b24iKTsKIAotICAgICAgICAgICAgICAgIHVwZGF0ZUxhc3RQcm9wZXJ0eU5hbWVzLmNhbGwodGhp cywge30pOworICAgICAgICAgICAgICAgIHVwZGF0ZUxhc3RQcm9wZXJ0eU5hbWVzLmNhbGwodGhp cywgW10pOwogICAgICAgICAgICAgICAgIGNvbXBsZXRpb25Db250cm9sbGVyLnVwZGF0ZUNvbXBs ZXRpb25zKGRlZmF1bHRDb21wbGV0aW9ucyk7CiAKICAgICAgICAgICAgICAgICByZXR1cm47CkBA IC0yMjYsNyArMjI2LDcgQEAgV0kuSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9uUHJvdmlkZXIg PSBjbGFzcyBKYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWQKICAgICAgICAgICAgIGlm IChyZXN1bHQuc3VidHlwZSA9PT0gImFycmF5IikKICAgICAgICAgICAgICAgICByZXN1bHQuY2Fs bEZ1bmN0aW9uSlNPTihpbnNwZWN0ZWRQYWdlX2V2YWxSZXN1bHRfZ2V0QXJyYXlDb21wbGV0aW9u cywgdW5kZWZpbmVkLCByZWNlaXZlZEFycmF5UHJvcGVydHlOYW1lcy5iaW5kKHRoaXMpKTsKICAg ICAgICAgICAgIGVsc2UgaWYgKHJlc3VsdC50eXBlID09PSAib2JqZWN0IiB8fCByZXN1bHQudHlw ZSA9PT0gImZ1bmN0aW9uIikKLSAgICAgICAgICAgICAgICByZXN1bHQuY2FsbEZ1bmN0aW9uSlNP TihpbnNwZWN0ZWRQYWdlX2V2YWxSZXN1bHRfZ2V0Q29tcGxldGlvbnMsIHVuZGVmaW5lZCwgcmVj ZWl2ZWRQcm9wZXJ0eU5hbWVzLmJpbmQodGhpcykpOworICAgICAgICAgICAgICAgIHJlc3VsdC5j YWxsRnVuY3Rpb25KU09OKGluc3BlY3RlZFBhZ2VfZXZhbFJlc3VsdF9nZXRDb21wbGV0aW9ucywg dW5kZWZpbmVkLCByZWNlaXZlZE9iamVjdFByb3BlcnR5TmFtZXMuYmluZCh0aGlzKSk7CiAgICAg ICAgICAgICBlbHNlIGlmIChyZXN1bHQudHlwZSA9PT0gInN0cmluZyIgfHwgcmVzdWx0LnR5cGUg PT09ICJudW1iZXIiIHx8IHJlc3VsdC50eXBlID09PSAiYm9vbGVhbiIgfHwgcmVzdWx0LnR5cGUg PT09ICJzeW1ib2wiKSB7CiAgICAgICAgICAgICAgICAgbGV0IG9wdGlvbnMgPSB7b2JqZWN0R3Jv dXA6ICJjb21wbGV0aW9uIiwgaW5jbHVkZUNvbW1hbmRMaW5lQVBJOiBmYWxzZSwgZG9Ob3RQYXVz ZU9uRXhjZXB0aW9uc0FuZE11dGVDb25zb2xlOiB0cnVlLCByZXR1cm5CeVZhbHVlOiB0cnVlLCBn ZW5lcmF0ZVByZXZpZXc6IGZhbHNlLCBzYXZlUmVzdWx0OiBmYWxzZX07CiAgICAgICAgICAgICAg ICAgV0kucnVudGltZU1hbmFnZXIuZXZhbHVhdGVJbkluc3BlY3RlZFdpbmRvdygiKCIgKyBpbnNw ZWN0ZWRQYWdlX2V2YWxSZXN1bHRfZ2V0Q29tcGxldGlvbnMgKyAiKShcIiIgKyByZXN1bHQudHlw ZSArICJcIikiLCBvcHRpb25zLCByZWNlaXZlZFByb3BlcnR5TmFtZXNGcm9tRXZhbHVhdGUuYmlu ZCh0aGlzKSk7CkBAIC0yMzYsNyArMjM2LDEyIEBAIFdJLkphdmFTY3JpcHRSdW50aW1lQ29tcGxl dGlvblByb3ZpZGVyID0gY2xhc3MgSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9uUHJvdmlkCiAK ICAgICAgICAgZnVuY3Rpb24gcmVjZWl2ZWRQcm9wZXJ0eU5hbWVzRnJvbUV2YWx1YXRlKG9iamVj dCwgd2FzVGhyb3duLCByZXN1bHQpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHJlY2VpdmVkUHJv cGVydHlOYW1lcy5jYWxsKHRoaXMsIHJlc3VsdCAmJiAhd2FzVGhyb3duID8gcmVzdWx0LnZhbHVl IDogbnVsbCk7CisgICAgICAgICAgICByZWNlaXZlZFByb3BlcnR5TmFtZXMuY2FsbCh0aGlzLCBy ZXN1bHQgJiYgIXdhc1Rocm93biA/IE9iamVjdC5rZXlzKHJlc3VsdC52YWx1ZSkgOiBudWxsKTsK KyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIHJlY2VpdmVkT2JqZWN0UHJvcGVydHlOYW1l cyhwcm9wZXJ0eU5hbWVzKQorICAgICAgICB7CisgICAgICAgICAgICByZWNlaXZlZFByb3BlcnR5 TmFtZXMuY2FsbCh0aGlzLCBPYmplY3Qua2V5cyhwcm9wZXJ0eU5hbWVzKSk7CiAgICAgICAgIH0K IAogICAgICAgICBmdW5jdGlvbiByZWNlaXZlZEFycmF5UHJvcGVydHlOYW1lcyhwcm9wZXJ0eU5h bWVzKQpAQCAtMjUwLDEyICsyNTUsMTMgQEAgV0kuSmF2YVNjcmlwdFJ1bnRpbWVDb21wbGV0aW9u UHJvdmlkZXIgPSBjbGFzcyBKYXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWQKICAgICAg ICAgICAgICAgICAgICAgcHJvcGVydHlOYW1lc1tpXSA9IHRydWU7CiAgICAgICAgICAgICB9CiAK LSAgICAgICAgICAgIHJlY2VpdmVkUHJvcGVydHlOYW1lcy5jYWxsKHRoaXMsIHByb3BlcnR5TmFt ZXMpOworICAgICAgICAgICAgcmVjZWl2ZWRPYmplY3RQcm9wZXJ0eU5hbWVzLmNhbGwodGhpcywg cHJvcGVydHlOYW1lcyk7CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiByZWNlaXZlZFBy b3BlcnR5TmFtZXMocHJvcGVydHlOYW1lcykKICAgICAgICAgewotICAgICAgICAgICAgcHJvcGVy dHlOYW1lcyA9IHByb3BlcnR5TmFtZXMgPyBPYmplY3Qua2V5cyhwcm9wZXJ0eU5hbWVzKSA6IFtd OworICAgICAgICAgICAgY29uc29sZS5hc3NlcnQoIXByb3BlcnR5TmFtZXMgfHwgQXJyYXkuaXNB cnJheShwcm9wZXJ0eU5hbWVzKSk7CisgICAgICAgICAgICBwcm9wZXJ0eU5hbWVzID0gcHJvcGVy dHlOYW1lcyB8fCBbXTsKIAogICAgICAgICAgICAgdXBkYXRlTGFzdFByb3BlcnR5TmFtZXMuY2Fs bCh0aGlzLCBwcm9wZXJ0eU5hbWVzKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NhbGxGcmFtZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DYWxsRnJhbWUuanMKaW5kZXggYTg3NzU4MjExZTU5 MGIxNjZhYjkxY2RlOTllZWM5NTM3NDdiNDUxMS4uMTdjNmQ4OTJiMmMzODVmYTc1NTIxYzQ3MmYz YzlhZGQyMDk5MmVkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0NhbGxGcmFtZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvQ2FsbEZyYW1lLmpzCkBAIC03MCwxNCArNzAsMTQgQEAgV0kuQ2Fs bEZyYW1lID0gY2xhc3MgQ2FsbEZyYW1lCiAKICAgICBjb2xsZWN0U2NvcGVDaGFpblZhcmlhYmxl TmFtZXMoY2FsbGJhY2spCiAgICAgewotICAgICAgICB2YXIgcmVzdWx0ID0ge3RoaXM6IHRydWUs IF9fcHJvdG9fXzogbnVsbH07CisgICAgICAgIGxldCByZXN1bHQgPSBbInRoaXMiLCAiX19wcm90 b19fIl07CiAKICAgICAgICAgdmFyIHBlbmRpbmdSZXF1ZXN0cyA9IHRoaXMuX3Njb3BlQ2hhaW4u bGVuZ3RoOwogCiAgICAgICAgIGZ1bmN0aW9uIHByb3BlcnRpZXNDb2xsZWN0ZWQocHJvcGVydGll cykKICAgICAgICAgewogICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IHByb3BlcnRpZXMgJiYg aSA8IHByb3BlcnRpZXMubGVuZ3RoOyArK2kpCi0gICAgICAgICAgICAgICAgcmVzdWx0W3Byb3Bl cnRpZXNbaV0ubmFtZV0gPSB0cnVlOworICAgICAgICAgICAgICAgIHJlc3VsdC5wdXNoKHByb3Bl cnRpZXNbaV0ubmFtZSk7CiAKICAgICAgICAgICAgIGlmICgtLXBlbmRpbmdSZXF1ZXN0cykKICAg ICAgICAgICAgICAgICByZXR1cm47Cg==