<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>201220</bug_id>
          
          <creation_ts>2019-08-28 08:48:27 -0700</creation_ts>
          <short_desc>[GStreamer] Do not use makeWeakPtr from streaming thread.</short_desc>
          <delta_ts>2019-08-29 09:14:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Charlie Turner">cturner</reporter>
          <assigned_to name="Charlie Turner">cturner</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>calvaris</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1565732</commentid>
    <comment_count>0</comment_count>
    <who name="Charlie Turner">cturner</who>
    <bug_when>2019-08-28 08:48:27 -0700</bug_when>
    <thetext>[GStreamer] Do not use makeWeakPtr from streaming thread.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565738</commentid>
    <comment_count>1</comment_count>
      <attachid>377448</attachid>
    <who name="Charlie Turner">cturner</who>
    <bug_when>2019-08-28 09:01:29 -0700</bug_when>
    <thetext>Created attachment 377448
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1565809</commentid>
    <comment_count>2</comment_count>
      <attachid>377448</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-08-28 11:38:54 -0700</bug_when>
    <thetext>Comment on attachment 377448
Patch

This is what WeakPtrFactoryInitialization::Eager is for.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1566173</commentid>
    <comment_count>3</comment_count>
      <attachid>377565</attachid>
    <who name="Charlie Turner">cturner</who>
    <bug_when>2019-08-29 03:22:56 -0700</bug_when>
    <thetext>Created attachment 377565
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1566261</commentid>
    <comment_count>4</comment_count>
      <attachid>377565</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-29 09:14:13 -0700</bug_when>
    <thetext>Comment on attachment 377565
Patch

Clearing flags on attachment: 377565

Committed r249276: &lt;https://trac.webkit.org/changeset/249276&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1566262</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-29 09:14:15 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377448</attachid>
            <date>2019-08-28 09:01:29 -0700</date>
            <delta_ts>2019-08-29 03:22:53 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201220-20190828170128.patch</filename>
            <type>text/plain</type>
            <size>3360</size>
            <attacher name="Charlie Turner">cturner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU4ZGYxODUzZTJiZThh
ZDljNDhmNmMyMTVhYzAxYzk3MWJkOTFlZS4uZWRlZjRiZTg3NWQ4ODg0OGY0ZmY5ZDllZTYxYTE0
ZDc4Y2JmODk1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA4LTI4ICBDaGFy
bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBE
byBub3QgdXNlIG1ha2VXZWFrUHRyIGZyb20gc3RyZWFtaW5nIHRocmVhZC4KKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTIyMAorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGltcG9ydGVkL3czYy93
ZWItcGxhdGZvcm0tdGVzdHMvZW5jcnlwdGVkLW1lZGlhL2NsZWFya2V5LW1wNC1wbGF5YmFjay1y
ZXRyaWV2ZS1wZXJzaXN0ZW50LWxpY2Vuc2UuaHR0cHMuaHRtbAorCisgICAgICAgIFJlY2VudGx5
IHNvbWUgYXNzZXJ0cyB3ZXJlIGFkZGVkIHRoYXQgeW91IGNhbid0IGNyZWF0ZSBXZWFrUHRyJ3MK
KyAgICAgICAgZnJvbSBzdHJlYW1pbmcgdGhyZWFkcyB3aGVuIHRoZSBmYWN0b3J5IGlzIGNyZWF0
ZWQgb24gdGhlCisgICAgICAgIG1haW4tdGhyZWFkLiBGaXggdGhhdCBpbiBvdXIgYmFzZSBwbGF5
ZXIgYnkgY3JlYXRpbmcgYSB3ZWFrCisgICAgICAgIHJlZmVyZW5jZSBhaGVhZC1vZi10aW1lIG9u
IHRoZSBtYWluLXRocmVhZCBhbmQgdXNpbmcgaXQgZnJvbSBvdXIKKyAgICAgICAgZGlzcGF0Y2hl
cnMgaW4gdGhlIHN0cmVhbWluZyB0aHJlYWRzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp
Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6TWVkaWFQbGF5ZXJQ
cml2YXRlR1N0cmVhbWVyQmFzZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh
dGVHU3RyZWFtZXJCYXNlOjppbml0aWFsaXphdGlvbkRhdGFFbmNvdW50ZXJlZCk6CisgICAgICAg
ICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l
ckJhc2UuaDoKKwogMjAxOS0wOC0xNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+
CiAKICAgICAgICAgQ29udGVudCBpbiA8aWZyYW1lPiBzaG91bGQgb3ZlcnJpZGUgInRvdWNoLWFj
dGlvbiIgc2V0IGluIGVtYmVkZGluZyBkb2N1bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l
ckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l
ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IGNlODczNGVmN2RjYjM2M2U3
NjU4YjFkZWYzYTdhN2IzNjY0Y2EyNjMuLjM2YjBkMzNkNGZiZDFmYjk3MTU3MGZlZTRhNzg3NDhm
YzJlZmQ0NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0
cmVhbWVyQmFzZS5jcHAKQEAgLTIyMCw2ICsyMjAsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0
ZUdTdHJlYW1lckJhc2U6OmluaXRpYWxpemVEZWJ1Z0NhdGVnb3J5KCkKIE1lZGlhUGxheWVyUHJp
dmF0ZUdTdHJlYW1lckJhc2U6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UoTWVkaWFQ
bGF5ZXIqIHBsYXllcikKICAgICA6IG1fbm90aWZpZXIoTWFpblRocmVhZE5vdGlmaWVyPE1haW5U
aHJlYWROb3RpZmljYXRpb24+OjpjcmVhdGUoKSkKICAgICAsIG1fcGxheWVyKHBsYXllcikKKyAg
ICAsIG1fd2Vha1RoaXMobWFrZVdlYWtQdHIoKnRoaXMpKQogICAgICwgbV9mcHNTaW5rKG51bGxw
dHIpCiAgICAgLCBtX3JlYWR5U3RhdGUoTWVkaWFQbGF5ZXI6OkhhdmVOb3RoaW5nKQogICAgICwg
bV9uZXR3b3JrU3RhdGUoTWVkaWFQbGF5ZXI6OkVtcHR5KQpAQCAtMTI3NSw3ICsxMjc2LDcgQEAg
dm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjppbml0aWFsaXphdGlvbkRhdGFF
bmNvdW50ZXJlZChJbml0RGF0YSYmIGkKIHsKICAgICBBU1NFUlQoIWlzTWFpblRocmVhZCgpKTsK
IAotICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigq
dGhpcyksIGluaXREYXRhID0gV1RGTW92ZShpbml0RGF0YSldIHsKKyAgICBSdW5Mb29wOjptYWlu
KCkuZGlzcGF0Y2goW3dlYWtUaGlzID0gbV93ZWFrVGhpcywgaW5pdERhdGEgPSBXVEZNb3ZlKGlu
aXREYXRhKV0gewogICAgICAgICBpZiAoIXdlYWtUaGlzKQogICAgICAgICAgICAgcmV0dXJuOwog
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv
TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaApp
bmRleCBlMjYwNGM0YWUzYjA1OWNlMWZiNmUwNGQ1NjhmMWE4MzZhMjMwNGE0Li4wZWIyM2EzM2Jm
YTJiZWVkOTAyMDdhYzIxYmViNzE0NTA1YjhmMWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy
QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmgKQEAgLTI2Miw2ICsyNjIsNyBAQCBwcm90
ZWN0ZWQ6CiAKICAgICBSZWY8TWFpblRocmVhZE5vdGlmaWVyPE1haW5UaHJlYWROb3RpZmljYXRp
b24+PiBtX25vdGlmaWVyOwogICAgIE1lZGlhUGxheWVyKiBtX3BsYXllcjsKKyAgICBXZWFrUHRy
PE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U+IG1fd2Vha1RoaXM7CiAgICAgR1JlZlB0
cjxHc3RFbGVtZW50PiBtX3BpcGVsaW5lOwogICAgIEdSZWZQdHI8R3N0U3RyZWFtVm9sdW1lPiBt
X3ZvbHVtZUVsZW1lbnQ7CiAgICAgR1JlZlB0cjxHc3RFbGVtZW50PiBtX3ZpZGVvU2luazsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>377565</attachid>
            <date>2019-08-29 03:22:56 -0700</date>
            <delta_ts>2019-08-29 09:14:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-201220-20190829112255.patch</filename>
            <type>text/plain</type>
            <size>2182</size>
            <attacher name="Charlie Turner">cturner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU4ZGYxODUzZTJiZThh
ZDljNDhmNmMyMTVhYzAxYzk3MWJkOTFlZS4uZjc0MGZlNDc4MjkyNjE3Y2MzZGEyZGQxODdjZTlh
OWM2YmVhYjZjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA4LTI4ICBDaGFy
bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBE
byBub3QgdXNlIG1ha2VXZWFrUHRyIGZyb20gc3RyZWFtaW5nIHRocmVhZC4KKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTIyMAorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGltcG9ydGVkL3czYy93
ZWItcGxhdGZvcm0tdGVzdHMvZW5jcnlwdGVkLW1lZGlhL2NsZWFya2V5LW1wNC1wbGF5YmFjay1y
ZXRyaWV2ZS1wZXJzaXN0ZW50LWxpY2Vuc2UuaHR0cHMuaHRtbAorCisgICAgICAgIFJlY2VudGx5
IHNvbWUgYXNzZXJ0cyB3ZXJlIGFkZGVkIHRoYXQgeW91IGNhbid0IGNyZWF0ZSBXZWFrUHRyJ3MK
KyAgICAgICAgZnJvbSBzdHJlYW1pbmcgdGhyZWFkcyB3aGVuIHRoZSBmYWN0b3J5IGlzIGNyZWF0
ZWQgb24gdGhlCisgICAgICAgIG1haW4tdGhyZWFkLiBUaGUgZml4IGlzIHRvIGVhZ2VybHkgY3Jl
YXRlIHRoZSBXZWFrUHRyIGF0IHBsYXllcgorICAgICAgICBpbml0aWFsaXphdGlvbiB0aW1lLCBy
YXRoZXIgdGhhbiBsYXppbHkgd2hlbiB0aGUgc3RyZWFtaW5nIHRocmVhZAorICAgICAgICBmaXJz
dCBhc2tzIGZvciBpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmg6CisKIDIwMTktMDgtMTYgIEFudHRpIEtv
aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENvbnRlbnQgaW4gPGlmcmFtZT4g
c2hvdWxkIG92ZXJyaWRlICJ0b3VjaC1hY3Rpb24iIHNldCBpbiBlbWJlZGRpbmcgZG9jdW1lbnQK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCmlu
ZGV4IGUyNjA0YzRhZTNiMDU5Y2UxZmI2ZTA0ZDU2OGYxYTgzNmEyMzA0YTQuLjMyODUxZTA3ZmRm
OTJiMzFiYWFkZWRiMjZkZWVlMDYzMWE4OGJlYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC
YXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l
ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaApAQCAtODgsNyArODgsOCBAQCBjbGFzcyBU
ZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllclByb3h5OwogCiB2b2lkIHJlZ2lzdGVyV2ViS2l0R1N0
cmVhbWVyRWxlbWVudHMoKTsKIAotY2xhc3MgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz
ZSA6IHB1YmxpYyBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UsIHB1YmxpYyBDYW5NYWtlV2Vh
a1B0cjxNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlPgorLy8gVXNlIGVhZ2VyIGluaXRp
YWxpemF0aW9uIGZvciB0aGUgV2Vha1B0ckZhY3Rvcnkgc2luY2Ugd2UgY2FsbCBtYWtlV2Vha1B0
cigpIGZyb20gYW5vdGhlciB0aHJlYWQuCitjbGFzcyBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt
ZXJCYXNlIDogcHVibGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSwgcHVibGljIENhbk1h
a2VXZWFrUHRyPE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UsIFdlYWtQdHJGYWN0b3J5
SW5pdGlhbGl6YXRpb246OkVhZ2VyPgogI2lmIFVTRShURVhUVVJFX01BUFBFUl9HTCkKICNpZiBV
U0UoTklDT1NJQSkKICAgICAsIHB1YmxpYyBOaWNvc2lhOjpDb250ZW50TGF5ZXJUZXh0dXJlTWFw
cGVySW1wbDo6Q2xpZW50Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>