201215 2019-08-28 04:44:40 -0700 [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null 2019-08-28 23:28:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead ross.kirsling webkit-bug-importer oldest_to_newest 1565686 0 fujii 2019-08-28 04:44:40 -0700 [WebKit] WKURLCopyString crashes if null WKURL is passed WKPageCopyActiveURL returns null WKURL if MiniBrowser.exe is executed with an invalid URL. .\WebKitBuild\Release\bin64\MiniBrowser.exe http://abcdefg.hijklm Callstack: > WTF.dll!WTF::String::isolatedCopy() Line 635 C++ > [Inline Frame] WebKit2.dll!API::String::create(const WTF::String &) Line 47 C++ > [Inline Frame] WebKit2.dll!WebKit::toCopiedAPI(const WTF::String &) Line 165 C++ > WebKit2.dll!WKURLCopyString(const OpaqueWKURL * url) Line 48 C++ > [Inline Frame] MiniBrowserLib.dll!createString(const OpaqueWKURL *) Line 53 C++ > MiniBrowserLib.dll!WebKitBrowserWindow::didChangeActiveURL(const void * clientInfo) Line 331 C++ > WebKit2.dll!WebKit::PageLoadState::callObserverCallback(void(WebKit::PageLoadState::Observer::*)() callback) Line 454 C++ > WebKit2.dll!WebKit::PageLoadState::commitChanges() Line 140 C++ > WebKit2.dll!WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared(WTF::Ref<WebKit::WebProcessProxy,WTF::DumbPtrTraits<WebKit::WebProcessProxy> > && process, WTF::ObjectIdentifier<enum WebCore::FrameIdentifierType> frameID, const WebCore::SecurityOriginData & frameSecurityOrigin, unsigned __int64 navigationID, const WTF::String & provisionalURL, const WebCore::ResourceError & error, WebCore::WillContinueLoading willContinueLoading, const WebKit::UserData & userData) Line 4181 C++ > WebKit2.dll!WebKit::WebPageProxy::didFailProvisionalLoadForFrame(WTF::ObjectIdentifier<enum WebCore::FrameIdentifierType> frameID, const WebCore::SecurityOriginData & frameSecurityOrigin, unsigned __int64 navigationID, const WTF::String & provisionalURL, const WebCore::ResourceError & error, WebCore::WillContinueLoading willContinueLoading, const WebKit::UserData & userData) Line 4145 C++ > [Inline Frame] WebKit2.dll!IPC::callMemberFunctionImpl(WebKit::WebPageProxy *) C++ > [Inline Frame] WebKit2.dll!IPC::callMemberFunction(std::tuple<WTF::ObjectIdentifier<enum WebCore::FrameIdentifierType>,WebCore::SecurityOriginData,unsigned __int64,WTF::String,WebCore::ResourceError,enum WebCore::WillContinueLoading,WebKit::UserData> &&) C++ > WebKit2.dll!IPC::handleMessage<Messages::WebPageProxy::DidFailProvisionalLoadForFrame,WebKit::WebPageProxy,void (__cdecl WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<enum WebCore::FrameIdentifierType>,WebCore::SecurityOriginData const &,unsigned __int64,WTF::String const &,WebCore::ResourceError const &,enum WebCore::WillContinueLoading,WebKit::UserData const &)>(IPC::Decoder & decoder, WebKit::WebPageProxy * object, void(WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<enum WebCore::FrameIdentifierType>, const WebCore::SecurityOriginData &, unsigned __int64, const WTF::String &, const WebCore::ResourceError &, WebCore::WillContinueLoading, const WebKit::UserData &) function) Line 121 C++ > WebKit2.dll!WebKit::WebPageProxy::didReceiveMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 1010 C++ > WebKit2.dll!IPC::MessageReceiverMap::dispatchMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 128 C++ > WebKit2.dll!WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 657 C++ > WebKit2.dll!IPC::Connection::dispatchMessage(IPC::Decoder & decoder) Line 939 C++ > WebKit2.dll!IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder,std::default_delete<IPC::Decoder> > message) Line 993 C++ > WebKit2.dll!IPC::Connection::dispatchIncomingMessages() Line 1097 C++ > [Inline Frame] WebKit2.dll!IPC::Connection::enqueueIncomingMessage::__l2::<lambda_358f200b3b860a7bdb941200db902cbe>::operator()() C++ > WebKit2.dll!WTF::Detail::CallableWrapper<<lambda_358f200b3b860a7bdb941200db902cbe>,void>::call() Line 52 C++ > [Inline Frame] WTF.dll!WTF::Function<void __cdecl(void)>::operator()() C++ > WTF.dll!WTF::RunLoop::performWork() Line 108 C++ > [Inline Frame] WTF.dll!WTF::RunLoop::wndProc(HWND__ *) Line 57 C++ > WTF.dll!WTF::RunLoop::RunLoopWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 39 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 89 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 99 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 232 C++ > [External Code] 1566076 1 377542 fujii 2019-08-28 20:33:11 -0700 Created attachment 377542 Patch 1566115 2 377542 fujii 2019-08-28 23:27:07 -0700 Comment on attachment 377542 Patch Clearing flags on attachment: 377542 Committed r249245: <https://trac.webkit.org/changeset/249245> 1566116 3 fujii 2019-08-28 23:27:10 -0700 All reviewed patches have been landed. Closing bug. 1566117 4 webkit-bug-importer 2019-08-28 23:28:17 -0700 <rdar://problem/54825374> 377542 2019-08-28 20:33:11 -0700 2019-08-28 23:27:07 -0700 Patch bug-201215-20190829123310.patch text/plain 1475 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MjMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzk4OGI5OTIxN2Y1MGY4ZjE3MWIwZGY5OGNiODYyNTRl MjM3YjcyNC4uMzJhZDA4MWY4MjFmMTdkM2E5NGU5MGExMmUwN2RiYzU1ZTE3NTZmNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE5LTA4LTI4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIE1pbmlCcm93c2VyIGNyYXNoZXMgaW4gV0tVUkxDb3B5U3RyaW5n IGlmIFdLUGFnZUNvcHlBY3RpdmVVUkwgcmV0dXJucyBudWxsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEyMTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNaW5pQnJvd3NlciBjcmFzaGVkIGlmIGl0IHdh cyBnb2luZyB0byBnbyB0byBhIHVucmVhY2hhYmxlIHBhZ2UKKyAgICAgICAgYmVjYXVzZSBXS1Bh Z2VDb3B5QWN0aXZlVVJMIHJldHVybmVkIGEgbnVsbHB0ci4KKworICAgICAgICAqIE1pbmlCcm93 c2VyL3dpbi9XZWJLaXRCcm93c2VyV2luZG93LmNwcDoKKyAgICAgICAgKGNyZWF0ZVN0cmluZyk6 IEFkZGVkIG51bGwgY2hlY2tpbmcgb2YgdGhlIGFyZ3VtZW50LgorCiAyMDE5LTA4LTI4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbG9hZGluZyBh IHdlYiB2aWV3IHdpdGggYSBmaXhlZC13aWR0aCB2aWV3cG9ydCBhbmQgdmFyaWFibGUgY29udGVu dCB3aWR0aCByZXN0b3JlcyB0aGUgcHJldmlvdXMgcGFnZSBzY2FsZSwgc2hvdWxkbid0CmRpZmYg LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5jcHAgYi9U b29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5jcHAKaW5kZXggMmRlNzY2 ZDNhMmIyYjQyZjY1NGU3ZGIyMTAzOGUzM2EyYmY0YjFiNi4uY2FmYWFhNDE2MWYzMGY3NDUzNjY3 ZjJhZTQ0NThhZDQ1NDk5YTkxZiAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL1dl YktpdEJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9XZWJLaXRC cm93c2VyV2luZG93LmNwcApAQCAtNDksNiArNDksOCBAQCBzdGQ6OndzdHJpbmcgY3JlYXRlU3Ry aW5nKFdLU3RyaW5nUmVmIHdrU3RyaW5nKQogCiBzdGQ6OndzdHJpbmcgY3JlYXRlU3RyaW5nKFdL VVJMUmVmIHdrVVJMKQogeworICAgIGlmICghd2tVUkwpCisgICAgICAgIHJldHVybiB7IH07CiAg ICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHVybCA9IGFkb3B0V0soV0tVUkxDb3B5U3RyaW5n KHdrVVJMKSk7CiAgICAgcmV0dXJuIGNyZWF0ZVN0cmluZyh1cmwuZ2V0KCkpOwogfQo=