201196 2019-08-27 13:02:24 -0700 constructFunctionSkippingEvalEnabledCheck() should use tryMakeString() and check for OOM. 2019-08-27 13:11:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1565483 0 mark.lam 2019-08-27 13:02:24 -0700 <rdar://problem/54703775> 1565488 1 377369 mark.lam 2019-08-27 13:05:11 -0700 Created attachment 377369 proposed patch. 1565491 2 377371 mark.lam 2019-08-27 13:07:33 -0700 Created attachment 377371 proposed patch. 1565492 3 377371 ysuzuki 2019-08-27 13:08:58 -0700 Comment on attachment 377371 proposed patch. r=me 1565493 4 mark.lam 2019-08-27 13:11:21 -0700 Thanks for the review. Landed in r249164: <http://trac.webkit.org/r249164>. 377369 2019-08-27 13:05:11 -0700 2019-08-27 13:07:33 -0700 proposed patch. bug-201196.patch text/plain 2880 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDkxNjMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBjb25zdHJ1Y3RGdW5jdGlvblNraXBwaW5nRXZhbEVuYWJsZWRDaGVjaygp IHNob3VsZCB1c2UgdHJ5TWFrZVN0cmluZygpIGFuZCBjaGVjayBmb3IgT09NLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMTk2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81NDcwMzc3NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHN0cmVzcy9jb25zdHJ1Y3RGdW5jdGlvblNraXBwaW5nRXZhbEVu YWJsZWRDaGVjay1zaG91bGQtdGhyb3ctb3V0LW9mLW1lbW9yeS1lcnJvci5qczogQWRkZWQuCisK IDIwMTktMDgtMjYgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAg ICAgICAgIFtKU0NdIEVuc3VyZSB4Py55ID8/IHogaXMgZmFzdApJbmRleDogSlNUZXN0cy9zdHJl c3MvY29uc3RydWN0RnVuY3Rpb25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2stc2hvdWxkLXRocm93 LW91dC1vZi1tZW1vcnktZXJyb3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvY29u c3RydWN0RnVuY3Rpb25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2stc2hvdWxkLXRocm93LW91dC1v Zi1tZW1vcnktZXJyb3IuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvY29uc3Ry dWN0RnVuY3Rpb25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2stc2hvdWxkLXRocm93LW91dC1vZi1t ZW1vcnktZXJyb3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAordmFyIGV4Y2Vw dGlvbjsKK3RyeSB7CisgICAgRnVuY3Rpb24oJ2EnLnJlcGVhdCgyMTQ3NDgzNjIzKSk7Cit9IGNh dGNoIChlKSB7CisgICAgZXhjZXB0aW9uID0gZTsKK30KKworaWYgKGV4Y2VwdGlvbiAhPSAiRXJy b3I6IE91dCBvZiBtZW1vcnkiKQorICAgIHRocm93ICJGQUlMRUQiOworCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTE2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wOC0yNyAg TWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgY29uc3RydWN0RnVuY3Rp b25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2soKSBzaG91bGQgdXNlIHRyeU1ha2VTdHJpbmcoKSBh bmQgY2hlY2sgZm9yIE9PTS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMTE5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ3MDM3NzU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0Z1 bmN0aW9uQ29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpjb25zdHJ1Y3RGdW5jdGlvblNr aXBwaW5nRXZhbEVuYWJsZWRDaGVjayk6CisKIDIwMTktMDgtMjcgIEtlaXRoIE1pbGxlciAgPGtl aXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2hlbiBkdW1waW5nIEFpciBHcmFwaHMg QkJRIHNob3VsZCBkdW1wIHBhdGNocG9pbnRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRnVuY3Rpb25Db25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRnVuY3Rpb25Db25zdHJ1Y3Rvci5jcHAJKHJldmlzaW9uIDI0 OTE2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Z1bmN0aW9uQ29uc3RydWN0 b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDksNyArMTA5LDExIEBAIEpTT2JqZWN0KiBjb25z dHJ1Y3RGdW5jdGlvblNraXBwaW5nRXZhbEUKICAgICBlbHNlIGlmIChhcmdzLnNpemUoKSA9PSAx KSB7CiAgICAgICAgIGF1dG8gYm9keSA9IGFyZ3MuYXQoMCkudG9XVEZTdHJpbmcoZXhlYyk7CiAg ICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIG51bGxwdHIpOwotICAgICAgICBwcm9n cmFtID0gbWFrZVN0cmluZyhwcmVmaXgsIGZ1bmN0aW9uTmFtZS5zdHJpbmcoKSwgIigpIHtcbiIs IGJvZHksICJcbn0iKTsKKyAgICAgICAgcHJvZ3JhbSA9IHRyeU1ha2VTdHJpbmcocHJlZml4LCBm dW5jdGlvbk5hbWUuc3RyaW5nKCksICIoKSB7XG4iLCBib2R5LCAiXG59Iik7CisgICAgICAgIGlm ICghcHJvZ3JhbSkgeworICAgICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMsIHNj b3BlKTsKKyAgICAgICAgICAgIHJldHVybiBudWxscHRyOworICAgICAgICB9CiAgICAgfSBlbHNl IHsKICAgICAgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyKFN0cmluZ0J1aWxkZXI6Ok92ZXJmbG93 SGFuZGxlcjo6UmVjb3JkT3ZlcmZsb3cpOwogICAgICAgICBidWlsZGVyLmFwcGVuZChwcmVmaXgs IGZ1bmN0aW9uTmFtZS5zdHJpbmcoKSwgJygnKTsK 377371 2019-08-27 13:07:33 -0700 2019-08-27 13:08:58 -0700 proposed patch. bug-201196.patch text/plain 3679 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDkxNjMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBjb25zdHJ1Y3RGdW5jdGlvblNraXBwaW5nRXZhbEVuYWJsZWRDaGVjaygp IHNob3VsZCB1c2UgdHJ5TWFrZVN0cmluZygpIGFuZCBjaGVjayBmb3IgT09NLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMTk2CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81NDcwMzc3NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHN0cmVzcy9jb25zdHJ1Y3RGdW5jdGlvblNraXBwaW5nRXZhbEVu YWJsZWRDaGVjay1zaG91bGQtdGhyb3ctb3V0LW9mLW1lbW9yeS1lcnJvci5qczogQWRkZWQuCisK IDIwMTktMDgtMjYgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAg ICAgICAgIFtKU0NdIEVuc3VyZSB4Py55ID8/IHogaXMgZmFzdApJbmRleDogSlNUZXN0cy9zdHJl c3MvY29uc3RydWN0RnVuY3Rpb25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2stc2hvdWxkLXRocm93 LW91dC1vZi1tZW1vcnktZXJyb3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvY29u c3RydWN0RnVuY3Rpb25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2stc2hvdWxkLXRocm93LW91dC1v Zi1tZW1vcnktZXJyb3IuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvY29uc3Ry dWN0RnVuY3Rpb25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2stc2hvdWxkLXRocm93LW91dC1vZi1t ZW1vcnktZXJyb3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAordmFyIGV4Y2Vw dGlvbjsKK3RyeSB7CisgICAgRnVuY3Rpb24oJ2EnLnJlcGVhdCgyMTQ3NDgzNjIzKSk7Cit9IGNh dGNoIChlKSB7CisgICAgZXhjZXB0aW9uID0gZTsKK30KKworaWYgKGV4Y2VwdGlvbiAhPSAiRXJy b3I6IE91dCBvZiBtZW1vcnkiKQorICAgIHRocm93ICJGQUlMRUQiOworCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTE2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wOC0yNyAg TWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgY29uc3RydWN0RnVuY3Rp b25Ta2lwcGluZ0V2YWxFbmFibGVkQ2hlY2soKSBzaG91bGQgdXNlIHRyeU1ha2VTdHJpbmcoKSBh bmQgY2hlY2sgZm9yIE9PTS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMTE5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ3MDM3NzU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0Z1 bmN0aW9uQ29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpjb25zdHJ1Y3RGdW5jdGlvblNr aXBwaW5nRXZhbEVuYWJsZWRDaGVjayk6CisKIDIwMTktMDgtMjcgIEtlaXRoIE1pbGxlciAgPGtl aXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2hlbiBkdW1waW5nIEFpciBHcmFwaHMg QkJRIHNob3VsZCBkdW1wIHBhdGNocG9pbnRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRnVuY3Rpb25Db25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRnVuY3Rpb25Db25zdHJ1Y3Rvci5jcHAJKHJldmlzaW9uIDI0 OTE2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Z1bmN0aW9uQ29uc3RydWN0 b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDksNyArMTA5LDExIEBAIEpTT2JqZWN0KiBjb25z dHJ1Y3RGdW5jdGlvblNraXBwaW5nRXZhbEUKICAgICBlbHNlIGlmIChhcmdzLnNpemUoKSA9PSAx KSB7CiAgICAgICAgIGF1dG8gYm9keSA9IGFyZ3MuYXQoMCkudG9XVEZTdHJpbmcoZXhlYyk7CiAg ICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIG51bGxwdHIpOwotICAgICAgICBwcm9n cmFtID0gbWFrZVN0cmluZyhwcmVmaXgsIGZ1bmN0aW9uTmFtZS5zdHJpbmcoKSwgIigpIHtcbiIs IGJvZHksICJcbn0iKTsKKyAgICAgICAgcHJvZ3JhbSA9IHRyeU1ha2VTdHJpbmcocHJlZml4LCBm dW5jdGlvbk5hbWUuc3RyaW5nKCksICIoKSB7XG4iLCBib2R5LCAiXG59Iik7CisgICAgICAgIGlm IChVTkxJS0VMWSghcHJvZ3JhbSkpIHsKKyAgICAgICAgICAgIHRocm93T3V0T2ZNZW1vcnlFcnJv cihleGVjLCBzY29wZSk7CisgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICAgICAgfQog ICAgIH0gZWxzZSB7CiAgICAgICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcihTdHJpbmdCdWlsZGVy OjpPdmVyZmxvd0hhbmRsZXI6OlJlY29yZE92ZXJmbG93KTsKICAgICAgICAgYnVpbGRlci5hcHBl bmQocHJlZml4LCBmdW5jdGlvbk5hbWUuc3RyaW5nKCksICcoJyk7CkBAIC0xMjIsNyArMTI2LDcg QEAgSlNPYmplY3QqIGNvbnN0cnVjdEZ1bmN0aW9uU2tpcHBpbmdFdmFsRQogICAgICAgICAgICAg UkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgbnVsbHB0cik7CiAgICAgICAgICAgICBidWlsZGVy LmFwcGVuZCgiLCAiLCB2aWV3V2l0aFN0cmluZy52aWV3KTsKICAgICAgICAgfQotICAgICAgICBp ZiAoYnVpbGRlci5oYXNPdmVyZmxvd2VkKCkpIHsKKyAgICAgICAgaWYgKFVOTElLRUxZKGJ1aWxk ZXIuaGFzT3ZlcmZsb3dlZCgpKSkgewogICAgICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9y KGV4ZWMsIHNjb3BlKTsKICAgICAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgICAgICB9CkBA IC0xMzIsNyArMTM2LDcgQEAgSlNPYmplY3QqIGNvbnN0cnVjdEZ1bmN0aW9uU2tpcHBpbmdFdmFs RQogICAgICAgICBhdXRvIGJvZHkgPSBhcmdzLmF0KGFyZ3Muc2l6ZSgpIC0gMSkudG9TdHJpbmco ZXhlYyktPnZpZXdXaXRoVW5kZXJseWluZ1N0cmluZyhleGVjKTsKICAgICAgICAgUkVUVVJOX0lG X0VYQ0VQVElPTihzY29wZSwgbnVsbHB0cik7CiAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCIpIHtc biIsIGJvZHkudmlldywgIlxufSIpOwotICAgICAgICBpZiAoYnVpbGRlci5oYXNPdmVyZmxvd2Vk KCkpIHsKKyAgICAgICAgaWYgKFVOTElLRUxZKGJ1aWxkZXIuaGFzT3ZlcmZsb3dlZCgpKSkgewog ICAgICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMsIHNjb3BlKTsKICAgICAgICAg ICAgIHJldHVybiBudWxscHRyOwogICAgICAgICB9Cg==