201179 2019-08-27 04:21:07 -0700 [ews-build] Use update-webkit script in Apply-WatchList EWS 2019-08-27 10:19:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193196 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1565319 0 aakash_jain 2019-08-27 04:21:07 -0700 Similar to https://bugs.webkit.org/show_bug.cgi?id=193196, we need to run Tools/Scripts/update-webkit for Apply-WatchList. update-webkit will do 'git pull'. By default, Buildbot updates the repo in a weird manner, and doesn't update the source completely. It only does a 'git fetch', not 'git pull'. It results in origin/master never being updated. Therefore 'git status' shows: "Your branch is ahead of 'origin/master' by x commits." This cause the apply-watchlist command to generate the incorrect cc list based on the previous commits as well. 1565320 1 377336 aakash_jain 2019-08-27 04:26:18 -0700 Created attachment 377336 Patch 1565381 2 377336 commit-queue 2019-08-27 10:18:24 -0700 Comment on attachment 377336 Patch Clearing flags on attachment: 377336 Committed r249148: <https://trac.webkit.org/changeset/249148> 1565382 3 commit-queue 2019-08-27 10:18:25 -0700 All reviewed patches have been landed. Closing bug. 1565383 4 webkit-bug-importer 2019-08-27 10:19:17 -0700 <rdar://problem/54752732> 377336 2019-08-27 04:26:18 -0700 2019-08-27 10:18:24 -0700 Patch bug-201179-20190827072617.patch text/plain 2420 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0OTEzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA4LTI3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVc2UgdXBkYXRlLXdlYmtpdCBzY3JpcHQgaW4gQXBw bHktV2F0Y2hMaXN0IEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAxMTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5OgorICAg ICAgICAoV2F0Y2hMaXN0RmFjdG9yeSk6IFVwZGF0ZWQgdG8gdXNlIENoZWNrT3V0U291cmNlIHN0 ZXAgYXMgd2VsbC4KKwogMjAxOS0wOC0yNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgVUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50QXRIdW1h blNwZWVkCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVz LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0 b3JpZXMucHkJKHJldmlzaW9uIDI0OTEzOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9mYWN0b3JpZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDE4IEBAIGNs YXNzIFN0eWxlRmFjdG9yeShmYWN0b3J5LkJ1aWxkRmFjdG9yeSkKICAgICAgICAgc2VsZi5hZGRT dGVwKENoZWNrU3R5bGUoKSkKIAogCitjbGFzcyBXYXRjaExpc3RGYWN0b3J5KGZhY3RvcnkuQnVp bGRGYWN0b3J5KToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRp b249Tm9uZSwgYXJjaGl0ZWN0dXJlcz1Ob25lLCB0cmlnZ2Vycz1Ob25lLCBhZGRpdGlvbmFsQXJn dW1lbnRzPU5vbmUsICoqa3dhcmdzKToKKyAgICAgICAgZmFjdG9yeS5CdWlsZEZhY3RvcnkuX19p bml0X18oc2VsZikKKyAgICAgICAgc2VsZi5hZGRTdGVwKENvbmZpZ3VyZUJ1aWxkKHBsYXRmb3Jt LCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgdHJpZ2dlcnMsIGFkZGl0aW9u YWxBcmd1bWVudHMpKQorICAgICAgICBzZWxmLmFkZFN0ZXAoVmFsaWRhdGVQYXRjaCgpKQorICAg ICAgICBzZWxmLmFkZFN0ZXAoUHJpbnRDb25maWd1cmF0aW9uKCkpCisgICAgICAgIHNlbGYuYWRk U3RlcChDaGVja091dFNvdXJjZSgpKQorICAgICAgICBzZWxmLmFkZFN0ZXAoVXBkYXRlV29ya2lu Z0RpcmVjdG9yeSgpKQorICAgICAgICBzZWxmLmFkZFN0ZXAoQXBwbHlQYXRjaCgpKQorICAgICAg ICBzZWxmLmFkZFN0ZXAoQXBwbHlXYXRjaExpc3QoKSkKKworCiBjbGFzcyBCaW5kaW5nc0ZhY3Rv cnkoRmFjdG9yeSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0 aW9uPU5vbmUsIGFyY2hpdGVjdHVyZXM9Tm9uZSwgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCAq Kmt3YXJncyk6CiAgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZp Z3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlvbmFsQXJndW1lbnRzLCBjaGVj a1JlbGV2YW5jZT1UcnVlKQpAQCAtMTc1LDkgKzE4NywzIEBAIGNsYXNzIFNlcnZpY2VzRmFjdG9y eShGYWN0b3J5KToKICAgICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29u ZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgRmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVudHMsIGNo ZWNrUmVsZXZhbmNlPVRydWUpCiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5FV1NVbml0VGVzdHMo KSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkVXU0J1aWxkYm90Q2hlY2tDb25maWcoKSkKLQot Ci1jbGFzcyBXYXRjaExpc3RGYWN0b3J5KEZhY3RvcnkpOgotICAgIGRlZiBfX2luaXRfXyhzZWxm LCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbj1Ob25lLCBhcmNoaXRlY3R1cmVzPU5vbmUsIHRyaWdn ZXJzPU5vbmUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSwgKiprd2FyZ3MpOgotICAgICAgICBG YWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1 cmVzLCBGYWxzZSwgdHJpZ2dlcnMsIGFkZGl0aW9uYWxBcmd1bWVudHMpCi0gICAgICAgIHNlbGYu YWRkU3RlcChBcHBseVdhdGNoTGlzdCgpKQo=