201146 2019-08-26 13:13:19 -0700 Drop WEBCORE_EXPORT from ChromeClient class 2019-08-26 15:17:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue webkit-bug-importer oldest_to_newest 1565055 0 cdumez 2019-08-26 13:13:19 -0700 Drop WEBCORE_EXPORT from ChromeClient class. All its methods and either pure virtual or inlined in the header. 1565056 1 377264 cdumez 2019-08-26 13:14:19 -0700 Created attachment 377264 Patch 1565099 2 377264 achristensen 2019-08-26 14:32:20 -0700 Comment on attachment 377264 Patch r=me, but what does this help? 1565100 3 cdumez 2019-08-26 14:33:01 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 377264 [details] > Patch > > r=me, but what does this help? It helps my sanity. Right now, the style checker keeps complaining about this every time I add a new method to this class :) 1565101 4 cdumez 2019-08-26 14:34:21 -0700 (In reply to Chris Dumez from comment #3) > (In reply to Alex Christensen from comment #2) > > Comment on attachment 377264 [details] > > Patch > > > > r=me, but what does this help? > > It helps my sanity. Right now, the style checker keeps complaining about > this every time I add a new method to this class :) ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] 1565116 5 377264 commit-queue 2019-08-26 15:16:31 -0700 Comment on attachment 377264 Patch Clearing flags on attachment: 377264 Committed r249119: <https://trac.webkit.org/changeset/249119> 1565117 6 commit-queue 2019-08-26 15:16:33 -0700 All reviewed patches have been landed. Closing bug. 1565118 7 webkit-bug-importer 2019-08-26 15:17:23 -0700 <rdar://problem/54724331> 377264 2019-08-26 13:14:19 -0700 2019-08-26 15:16:31 -0700 Patch bug-201146-20190826131418.patch text/plain 1193 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYyYjY3ZGI0NWI5ZjZi MjEzMDQyNTQ1MzNhYTQ0YTE2MWJhNTdlNy4uYzE4MjYzNzc5MWJkMTZmOGJhZGFmNjIxMzkxMmY0 MWI2ZGE5NWU2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA4LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBXRUJDT1JFX0VYUE9S VCBmcm9tIENocm9tZUNsaWVudCBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRHJvcCBXRUJDT1JFX0VYUE9SVCBmcm9tIENocm9tZUNsaWVudCBj bGFzcy4gQWxsIGl0cyBtZXRob2RzIGFuZCBlaXRoZXIgcHVyZSB2aXJ0dWFsIG9yIGlubGluZWQg aW4gdGhlIGhlYWRlci4KKworICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6CisKIDIwMTkt MDgtMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2Ug ZGVmYXVsdCB2YWx1ZSBvZiB3aW5kb3cub3BlbigpJ3MgdXJsIGFyZ3VtZW50CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9DaHJvbWVDbGllbnQuaAppbmRleCBlOGE1ZGUzM2VkMTc5MjZjOWFhODU2YjA4MTZiNGVlY2Y4 MmM5NGY1Li40NGJiNGI5Y2FiZTQxMGFjN2MxNzcyNmM5MzVkZTg5YjIxZjUxYjM3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKQEAgLTExNyw3ICsxMTcsNyBAQCBzdHJ1Y3QgV2luZG93 RmVhdHVyZXM7CiAKIGVudW0gY2xhc3MgUm91dGVTaGFyaW5nUG9saWN5IDogdWludDhfdDsKIAot Y2xhc3MgV0VCQ09SRV9FWFBPUlQgQ2hyb21lQ2xpZW50IHsKK2NsYXNzIENocm9tZUNsaWVudCB7 CiBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGNocm9tZURlc3Ryb3llZCgpID0gMDsKIAo=