201140 2019-08-26 08:47:37 -0700 [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot 2019-08-26 10:49:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1564953 0 aakash_jain 2019-08-26 08:47:37 -0700 In various build-steps in EWS, there is a custom failure message (e.g.: 2 style errors), however an additional (failure) is appended at the end (making it: 2 style errors (failure)). The additional (failure) string in unnecessary and makes the text less readable. We should remove this additional string. Other example: 3 api tests failed or timed out (failure) 1564956 1 377248 aakash_jain 2019-08-26 09:03:14 -0700 Created attachment 377248 Patch 1564957 2 ews-watchlist 2019-08-26 09:05:30 -0700 Attachment 377248 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:507: [TestWithFailureCount.getResultSummary] Instance of 'TestWithFailureCount' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:261: [TestCheckStyle.test_failures_with_style_issues] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:261: [TestCheckStyle.test_failures_with_style_issues] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1832: [TestRunAPITests.test_one_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1832: [TestRunAPITests.test_one_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1888: [TestRunAPITests.test_multiple_failures_and_timeouts] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1888: [TestRunAPITests.test_multiple_failures_and_timeouts] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1564958 3 aakash_jain 2019-08-26 09:06:45 -0700 Sample run: Without this patch: https://ews-build.webkit-uat.org/#/builders/5/builds/4968 With this patch: https://ews-build.webkit-uat.org/#/builders/5/builds/4969 1564963 4 377248 jbedard 2019-08-26 09:23:34 -0700 Comment on attachment 377248 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377248&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:509 > + return {u'step': unicode(status)} What prompted this change? Do we have an example of status being something other than ASCII? 1564969 5 377248 aakash_jain 2019-08-26 09:40:28 -0700 Comment on attachment 377248 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377248&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:509 >> + return {u'step': unicode(status)} > > What prompted this change? Do we have an example of status being something other than ASCII? The above code refactoring prompted this. Earlier the 'status' variable was always unicode. After this change, in case of self.failedTestCount, 'status' is not unicode, so we need to convert it to unicode. Buildbot expects the returned status to be unicode (and throws an exception if it's not a unicode). 1565004 6 377248 commit-queue 2019-08-26 10:48:18 -0700 Comment on attachment 377248 Patch Clearing flags on attachment: 377248 Committed r249104: <https://trac.webkit.org/changeset/249104> 1565005 7 commit-queue 2019-08-26 10:48:19 -0700 All reviewed patches have been landed. Closing bug. 1565006 8 webkit-bug-importer 2019-08-26 10:49:19 -0700 <rdar://problem/54713089> 377248 2019-08-26 09:03:14 -0700 2019-08-26 10:48:18 -0700 Patch bug-201140-20190826120313.patch text/plain 3200 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0OTA5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA4LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBEbyBub3QgYXBwZW5kIGFkZGl0aW9uYWwgJyhmYWlsdXJlKScg c3RyaW5nIGF0IHRoZSBlbmQgb2YgY3VzdG9tIGZhaWx1cmUgbWVzc2FnZSBpbiBFV1MgQnVpbGRi b3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTE0 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoVGVzdFdpdGhGYWls dXJlQ291bnQuZ2V0UmVzdWx0U3VtbWFyeSk6IERvIG5vdCBhcHBlbmQgKGZhaWx1cmUpIHdoZW4g aW4gY2FzZSBvZiBjdXN0b20gc3RhdHVzLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9zdGVwc191bml0dGVzdC5weTogVXBkYXRlZCB1bml0LXRlc3RzIGFjY29yZGluZ2x5 LgorCiAyMDE5LTA4LTI2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgYSBXZWJzaXRlRGF0YVN0b3JlIGRlbGVnYXRlIHRvIGhhbmRsZSBBdXRoZW50aWNh dGlvbkNoYWxsZW5nZSB0aGF0IGRvIG5vdCBjb21lIGZyb20gcGFnZXMKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0OTA5NykKKysr IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5 KQpAQCAtNTAwLDEzICs1MDAsMTMgQEAgY2xhc3MgVGVzdFdpdGhGYWlsdXJlQ291bnQoc2hlbGwu VGVzdCk6CiAgICAgZGVmIGdldFJlc3VsdFN1bW1hcnkoc2VsZik6CiAgICAgICAgIHN0YXR1cyA9 IHNlbGYubmFtZQogCi0gICAgICAgIGlmIHNlbGYucmVzdWx0cyAhPSBTVUNDRVNTIGFuZCBzZWxm LmZhaWxlZFRlc3RDb3VudDoKLSAgICAgICAgICAgIHN0YXR1cyA9IHNlbGYuZmFpbGVkVGVzdHNG b3JtYXRTdHJpbmcgJSAoc2VsZi5mYWlsZWRUZXN0Q291bnQsIHNlbGYuZmFpbGVkVGVzdFBsdXJh bFN1ZmZpeCkKLQogICAgICAgICBpZiBzZWxmLnJlc3VsdHMgIT0gU1VDQ0VTUzoKLSAgICAgICAg ICAgIHN0YXR1cyArPSB1JyAoe30pJy5mb3JtYXQoUmVzdWx0c1tzZWxmLnJlc3VsdHNdKQorICAg ICAgICAgICAgaWYgc2VsZi5mYWlsZWRUZXN0Q291bnQ6CisgICAgICAgICAgICAgICAgc3RhdHVz ID0gc2VsZi5mYWlsZWRUZXN0c0Zvcm1hdFN0cmluZyAlIChzZWxmLmZhaWxlZFRlc3RDb3VudCwg c2VsZi5mYWlsZWRUZXN0UGx1cmFsU3VmZml4KQorICAgICAgICAgICAgZWxzZToKKyAgICAgICAg ICAgICAgICBzdGF0dXMgKz0gdScgKHt9KScuZm9ybWF0KFJlc3VsdHNbc2VsZi5yZXN1bHRzXSkK IAotICAgICAgICByZXR1cm4ge3Unc3RlcCc6IHN0YXR1c30KKyAgICAgICAgcmV0dXJuIHt1J3N0 ZXAnOiB1bmljb2RlKHN0YXR1cyl9CiAKIAogY2xhc3MgQ2hlY2tTdHlsZShUZXN0V2l0aEZhaWx1 cmVDb3VudCk6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNf dW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNDkwOTcpCisrKyBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAg LTI1OCw3ICsyNTgsNyBAQCBFUlJPUjogU291cmNlL1dlYkNvcmUvbGF5b3V0L1ZlcmlmaWNhdGlv CiBUb3RhbCBlcnJvcnMgZm91bmQ6IDggaW4gNDggZmlsZXMnJycpCiAgICAgICAgICAgICArIDIs CiAgICAgICAgICkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBz dGF0ZV9zdHJpbmc9Jzggc3R5bGUgZXJyb3JzIChmYWlsdXJlKScpCisgICAgICAgIHNlbGYuZXhw ZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSc4IHN0eWxlIGVycm9ycycp CiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAgICAgZGVmIHRlc3RfZmFpbHVyZXNf bm9fc3R5bGVfaXNzdWVzKHNlbGYpOgpAQCAtMTgyOSw3ICsxODI5LDcgQEAgVGVzdGluZyBjb21w bGV0ZWQsIEV4aXQgc3RhdHVzOiAzCiAnJycpCiAgICAgICAgICAgICArIDEsCiAgICAgICAgICkK LSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9 JzEgYXBpIHRlc3QgZmFpbGVkIG9yIHRpbWVkIG91dCAoZmFpbHVyZSknKQorICAgICAgICBzZWxm LmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nMSBhcGkgdGVzdCBm YWlsZWQgb3IgdGltZWQgb3V0JykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKICAg ICBkZWYgdGVzdF9tdWx0aXBsZV9mYWlsdXJlc19hbmRfdGltZW91dHMoc2VsZik6CkBAIC0xODg1 LDcgKzE4ODUsNyBAQCBUZXN0aW5nIGNvbXBsZXRlZCwgRXhpdCBzdGF0dXM6IDMKICcnJykKICAg ICAgICAgICAgICsgNCwKICAgICAgICAgKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVz dWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nNCBhcGkgdGVzdHMgZmFpbGVkIG9yIHRpbWVkIG91 dCAoZmFpbHVyZSknKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUs IHN0YXRlX3N0cmluZz0nNCBhcGkgdGVzdHMgZmFpbGVkIG9yIHRpbWVkIG91dCcpCiAgICAgICAg IHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAgICAgZGVmIHRlc3RfdW5leHBlY3RlZF9mYWlsdXJl KHNlbGYpOgo=