201139 2019-08-26 07:50:58 -0700 run-webkit-tests: Cap the number of automatically booted simulators at 12 2019-08-26 10:22:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dino ews-watchlist glenn rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1564940 0 jbedard 2019-08-26 07:50:58 -0700 It seems that with a larger number of cores and memory, simulators start to be bound by some other system resource. In particular, contributors with iMac Pros and 128 GB of RAM will boot between 16 and 20 simulators, and begin to see diminishing returns on how fast simulator tests are run. By default, we should cap the number of simulators we automatically boot at 12. Note that this change will not have an effect on the number of simulators booted unless a machine is automatically booting more than 12 simulators. 1564941 1 377245 jbedard 2019-08-26 07:58:26 -0700 Created attachment 377245 Patch 1564946 2 jbedard 2019-08-26 08:05:14 -0700 In particular, some testing a year or two back indicated that RAM was usually the bottleneck when booting simulators, and 128 GB of RAM could boot up to 21 simulators...if you have that much RAM, CPU will usually be considered the bottleneck, which would leave you with 18, in most cases. Getting some feedback from different folks, it seems like this is rarely desired. 1564947 3 377245 aakash_jain 2019-08-26 08:07:42 -0700 Comment on attachment 377245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377245&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:422 > + max_supported_simulators_for_hardware = min(host.executive.cpu_count() // 2, host.platform.total_bytes_memory() // SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE, 12) Please store 12 in a separate variable, something like MAX_NUMBER_OF_SIMULATORS. 1564950 4 377246 jbedard 2019-08-26 08:27:20 -0700 Created attachment 377246 Patch 1564987 5 377246 commit-queue 2019-08-26 10:21:34 -0700 Comment on attachment 377246 Patch Clearing flags on attachment: 377246 Committed r249102: <https://trac.webkit.org/changeset/249102> 1564988 6 commit-queue 2019-08-26 10:21:36 -0700 All reviewed patches have been landed. Closing bug. 1564990 7 webkit-bug-importer 2019-08-26 10:22:18 -0700 <rdar://problem/54711790> 377245 2019-08-26 07:58:26 -0700 2019-08-26 08:27:18 -0700 Patch bug-201139-20190826075825.patch text/plain 1968 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0OTA5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA4LTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBDYXAgdGhlIG51bWJlciBvZiBhdXRvbWF0 aWNhbGx5IGJvb3RlZCBzaW11bGF0b3JzIGF0IDEyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDExMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUbyBtYWtlIGxvY2FsIGRldmVsb3BtZW50IHdpdGggc2lt dWxhdG9ycyBtb3JlIHBsZWFzYW50LCBtYWNoaW5lcyBzaG91bGQKKyAgICAgICAgbmV2ZXIgYXV0 b21hdGljYWxseSBib290IG1vcmUgdGhhbiAxMiBzaW11bGF0b3JzLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxh dGVkRGV2aWNlTWFuYWdlci5tYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnMpOgorCiAyMDE5LTA4LTIz ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBJbmNyZWFz ZSBsb2cgbGV2ZWwgZm9yIHdhdGNobGlzdCByZXN1bHQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDI0OTA5NCkK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29y a2luZyBjb3B5KQpAQCAtNDE3LDcgKzQxNyw5IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFn ZXIob2JqZWN0KToKICAgICAgICAgZXhjZXB0IChWYWx1ZUVycm9yLCBTY3JpcHRFcnJvcik6CiAg ICAgICAgICAgICByZXR1cm4gMAogCi0gICAgICAgIG1heF9zdXBwb3J0ZWRfc2ltdWxhdG9yc19m b3JfaGFyZHdhcmUgPSBtaW4oaG9zdC5leGVjdXRpdmUuY3B1X2NvdW50KCkgLyAyLCBob3N0LnBs YXRmb3JtLnRvdGFsX2J5dGVzX21lbW9yeSgpIC8vIFNpbXVsYXRlZERldmljZU1hbmFnZXIuTUVN T1JZX0VTVElNQVRFX1BFUl9TSU1VTEFUT1JfSU5TVEFOQ0UpCisgICAgICAgICMgVGVzdGluZyBv biBpTWFjIFByb3MgaGFzIGluZGljYXRlZCB0aGF0IG1vcmUgdGhhbiAxMiBzaW11bGF0b3JzLCBl dmVuIGlmIHdlIHNlZW0gdG8gaGF2ZSBlbm91Z2ggcmVzb3VyY2VzIGZvciB0aGVtLAorICAgICAg ICAjIHJlc3VsdHMgaW4gZGltaW5pc2hpbmcgcmV0dXJucy4KKyAgICAgICAgbWF4X3N1cHBvcnRl ZF9zaW11bGF0b3JzX2Zvcl9oYXJkd2FyZSA9IG1pbihob3N0LmV4ZWN1dGl2ZS5jcHVfY291bnQo KSAvLyAyLCBob3N0LnBsYXRmb3JtLnRvdGFsX2J5dGVzX21lbW9yeSgpIC8vIFNpbXVsYXRlZERl dmljZU1hbmFnZXIuTUVNT1JZX0VTVElNQVRFX1BFUl9TSU1VTEFUT1JfSU5TVEFOQ0UsIDEyKQog ICAgICAgICBtYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnNfbG9jYWxseSA9IChzeXN0ZW1fcHJvY2Vz c19jb3VudF9saW1pdCAtIGN1cnJlbnRfcHJvY2Vzc19jb3VudCkgLy8gU2ltdWxhdGVkRGV2aWNl TWFuYWdlci5QUk9DRVNTX0NPVU5UX0VTVElNQVRFX1BFUl9TSU1VTEFUT1JfSU5TVEFOQ0UKIAog ICAgICAgICBpZiAobWF4X3N1cHBvcnRlZF9zaW11bGF0b3JzX2xvY2FsbHkgPCBtYXhfc3VwcG9y dGVkX3NpbXVsYXRvcnNfZm9yX2hhcmR3YXJlKToK 377246 2019-08-26 08:27:20 -0700 2019-08-26 10:21:34 -0700 Patch bug-201139-20190826082719.patch text/plain 2498 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0OTA5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA4LTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBDYXAgdGhlIG51bWJlciBvZiBhdXRvbWF0 aWNhbGx5IGJvb3RlZCBzaW11bGF0b3JzIGF0IDEyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDExMzkKKworICAgICAgICBSZXZpZXdlZCBieSBBYWth c2ggSmFpbi4KKworICAgICAgICBUbyBtYWtlIGxvY2FsIGRldmVsb3BtZW50IHdpdGggc2ltdWxh dG9ycyBtb3JlIHBsZWFzYW50LCBtYWNoaW5lcyBzaG91bGQKKyAgICAgICAgbmV2ZXIgYXV0b21h dGljYWxseSBib290IG1vcmUgdGhhbiAxMiBzaW11bGF0b3JzLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVk RGV2aWNlTWFuYWdlci5tYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnMpOgorCiAyMDE5LTA4LTI2ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBXZWJzaXRl RGF0YVN0b3JlIGRlbGVnYXRlIHRvIGhhbmRsZSBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSB0aGF0 IGRvIG5vdCBjb21lIGZyb20gcGFnZXMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNv ZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDI0OTA5NykKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQkod29ya2luZyBjb3B5 KQpAQCAtNjcsNiArNjcsMTAgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3Qp OgogICAgIE1FTU9SWV9FU1RJTUFURV9QRVJfU0lNVUxBVE9SX0lOU1RBTkNFID0gNiAqICgxMDI0 ICoqIDMpICAjIDZHQiBhIHNpbXVsYXRvci4KICAgICBQUk9DRVNTX0NPVU5UX0VTVElNQVRFX1BF Ul9TSU1VTEFUT1JfSU5TVEFOQ0UgPSAxMjUKIAorICAgICMgVGVzdGluZyBvbiBpTWFjIFByb3Mg aGFzIGluZGljYXRlZCB0aGF0IG1vcmUgdGhhbiAxMiBzaW11bGF0b3JzLCBldmVuIGlmIHdlIHNl ZW0gdG8gaGF2ZSBlbm91Z2ggcmVzb3VyY2VzIGZvciB0aGVtLAorICAgICMgcmVzdWx0cyBpbiBk aW1pbmlzaGluZyByZXR1cm5zLgorICAgIE1BWF9OVU1CRVJfT0ZfU0lNVUxBVE9SUyA9IDEyCisK ICAgICB4Y3J1biA9ICcvdXNyL2Jpbi94Y3J1bicKICAgICBzaW11bGF0b3JfZGV2aWNlX3BhdGgg PSAnfi9MaWJyYXJ5L0RldmVsb3Blci9Db3JlU2ltdWxhdG9yL0RldmljZXMnCiAgICAgc2ltdWxh dG9yX2J1bmRsZV9pZCA9ICdjb20uYXBwbGUuaXBob25lc2ltdWxhdG9yJwpAQCAtNDE3LDcgKzQy MSwxMSBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIGV4 Y2VwdCAoVmFsdWVFcnJvciwgU2NyaXB0RXJyb3IpOgogICAgICAgICAgICAgcmV0dXJuIDAKIAot ICAgICAgICBtYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnNfZm9yX2hhcmR3YXJlID0gbWluKGhvc3Qu ZXhlY3V0aXZlLmNwdV9jb3VudCgpIC8gMiwgaG9zdC5wbGF0Zm9ybS50b3RhbF9ieXRlc19tZW1v cnkoKSAvLyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLk1FTU9SWV9FU1RJTUFURV9QRVJfU0lNVUxB VE9SX0lOU1RBTkNFKQorICAgICAgICBtYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnNfZm9yX2hhcmR3 YXJlID0gbWluKAorICAgICAgICAgICAgaG9zdC5leGVjdXRpdmUuY3B1X2NvdW50KCkgLy8gMiwK KyAgICAgICAgICAgIGhvc3QucGxhdGZvcm0udG90YWxfYnl0ZXNfbWVtb3J5KCkgLy8gU2ltdWxh dGVkRGV2aWNlTWFuYWdlci5NRU1PUllfRVNUSU1BVEVfUEVSX1NJTVVMQVRPUl9JTlNUQU5DRSwK KyAgICAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIuTUFYX05VTUJFUl9PRl9TSU1VTEFU T1JTLAorICAgICAgICApCiAgICAgICAgIG1heF9zdXBwb3J0ZWRfc2ltdWxhdG9yc19sb2NhbGx5 ID0gKHN5c3RlbV9wcm9jZXNzX2NvdW50X2xpbWl0IC0gY3VycmVudF9wcm9jZXNzX2NvdW50KSAv LyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLlBST0NFU1NfQ09VTlRfRVNUSU1BVEVfUEVSX1NJTVVM QVRPUl9JTlNUQU5DRQogCiAgICAgICAgIGlmIChtYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnNfbG9j YWxseSA8IG1heF9zdXBwb3J0ZWRfc2ltdWxhdG9yc19mb3JfaGFyZHdhcmUpOgo=