201107 2019-08-23 16:55:17 -0700 REGRESSION (18E140): String check: “realtime” Suggesting “real time” 2019-08-28 19:40:44 -0700 1 1 1 Unclassified WebKit Media Safari 12 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 commit-queue eric.carlson ews-watchlist jer.noble peng.liu6 webkit-bug-importer oldest_to_newest 1564697 0 peng.liu6 2019-08-23 16:55:17 -0700 INSTRUCTIONS: Please check following strings in glossaries. ACTUAL RESULTS: realtime SUGGESTION: real time SUMMARY: OED has only a double word ‘real time’ should this string be two words? DATA: key id: return to realtime origin: WebCore/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Resources/en.lproj/Localizable.strings note: accessibility label for return to real time button source: return to realtime 1564702 1 webkit-bug-importer 2019-08-23 16:59:41 -0700 <rdar://problem/54660521> 1564708 2 peng.liu6 2019-08-23 17:14:20 -0700 <rdar://problem/46372620> 1564733 3 377188 peng.liu6 2019-08-23 17:56:07 -0700 Created attachment 377188 A patch 1564738 4 377192 peng.liu6 2019-08-23 18:13:22 -0700 Created attachment 377192 A updated patch 1566053 5 377192 commit-queue 2019-08-28 19:40:43 -0700 Comment on attachment 377192 A updated patch Clearing flags on attachment: 377192 Committed r249233: <https://trac.webkit.org/changeset/249233> 1566054 6 commit-queue 2019-08-28 19:40:44 -0700 All reviewed patches have been landed. Closing bug. 377188 2019-08-23 17:56:07 -0700 2019-08-23 18:13:22 -0700 A patch 201107.patch text/plain 2236 peng.liu6 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZmIyM2U3OTUzNi4uM2UxNGE2M2Q3Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wOC0yMyAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT046IFN0cmluZyBjaGVjazog4oCccmVhbHRpbWXigJ0gU3VnZ2Vz dGluZyDigJxyZWFsIHRpbWXigJ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMTEwNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYzNzI2MjA+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3QuCisKKyAgICAgICAgKiBlbi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzOgorICAgICAgICAq IHBsYXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxp emVkTWVkaWFDb250cm9sRWxlbWVudFN0cmluZyk6CisKIDIwMTktMDgtMjEgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNMXSBJbXByb3ZlIGRlZmF1bHQg Y29uc3RydWN0b3IgYW5kIGVtaXQgZmV3ZXIgcG9pbnRlcnMgaW4gbWV0YWwgY29kZWdlbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncyBiL1Nv dXJjZS9XZWJDb3JlL2VuLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggZTU3YTc3OWYx ZmMuLjU5NWI0NGRkYmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9Mb2Nh bGl6YWJsZS5zdHJpbmdzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VuLmxwcm9qL0xvY2FsaXphYmxl LnN0cmluZ3MKQEAgLTEzMTksNyArMTMxOSw3IEBACiAicmV0dXJuIHN0cmVhbWluZyBtb3ZpZSB0 byByZWFsIHRpbWUiID0gInJldHVybiBzdHJlYW1pbmcgbW92aWUgdG8gcmVhbCB0aW1lIjsKIAog LyogYWNjZXNzaWJpbGl0eSBsYWJlbCBmb3IgcmV0dXJuIHRvIHJlYWwgdGltZSBidXR0b24gKi8K LSJyZXR1cm4gdG8gcmVhbHRpbWUiID0gInJldHVybiB0byByZWFsdGltZSI7CisicmV0dXJuIHRv IHJlYWwgdGltZSIgPSAicmV0dXJuIHRvIHJlYWwgdGltZSI7CiAKIC8qIEFuIEFSSUEgYWNjZXNz aWJpbGl0eSBncm91cCB0aGF0IGNvbnRhaW5zIGEgc2VhcmNoIGZlYXR1cmUgb2YgYSB3ZWJzaXRl LiAqLwogInNlYXJjaCIgPSAic2VhcmNoIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9j YWxpemVkU3RyaW5ncy5jcHAKaW5kZXggNjhjMjU5OWQzZGUuLjg5MWZmMGZlYTI0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcApAQCAtNzgzLDcgKzc4 Myw3IEBAIFN0cmluZyBsb2NhbGl6ZWRNZWRpYUNvbnRyb2xFbGVtZW50U3RyaW5nKGNvbnN0IFN0 cmluZyYgbmFtZSkKICAgICBpZiAobmFtZSA9PSAiUmV3aW5kQnV0dG9uIikKICAgICAgICAgcmV0 dXJuIFdFQl9VSV9TVFJJTkcoImJhY2sgMzAgc2Vjb25kcyIsICJhY2Nlc3NpYmlsaXR5IGxhYmVs IGZvciBzZWVrIGJhY2sgMzAgc2Vjb25kcyBidXR0b24iKTsKICAgICBpZiAobmFtZSA9PSAiUmV0 dXJuVG9SZWFsdGltZUJ1dHRvbiIpCi0gICAgICAgIHJldHVybiBXRUJfVUlfU1RSSU5HKCJyZXR1 cm4gdG8gcmVhbHRpbWUiLCAiYWNjZXNzaWJpbGl0eSBsYWJlbCBmb3IgcmV0dXJuIHRvIHJlYWwg dGltZSBidXR0b24iKTsKKyAgICAgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkcoInJldHVybiB0byBy ZWFsIHRpbWUiLCAiYWNjZXNzaWJpbGl0eSBsYWJlbCBmb3IgcmV0dXJuIHRvIHJlYWwgdGltZSBi dXR0b24iKTsKICAgICBpZiAobmFtZSA9PSAiQ3VycmVudFRpbWVEaXNwbGF5IikKICAgICAgICAg cmV0dXJuIFdFQl9VSV9TVFJJTkcoImVsYXBzZWQgdGltZSIsICJhY2Nlc3NpYmlsaXR5IGxhYmVs IGZvciBlbGFwc2VkIHRpbWUgZGlzcGxheSIpOwogICAgIGlmIChuYW1lID09ICJUaW1lUmVtYWlu aW5nRGlzcGxheSIpCg== 377192 2019-08-23 18:13:22 -0700 2019-08-28 19:40:43 -0700 A updated patch 201107.patch text/plain 2275 peng.liu6 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZmIyM2U3OTUzNi4uNzI3Y2M1ZWI0MWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wOC0yMyAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT046IFN0cmluZyBjaGVjazog4oCccmVhbHRpbWXigJ0gU3VnZ2Vz dGluZyDigJxyZWFsIHRpbWXigJ0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMTEwNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYzNzI2MjA+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIExv Y2FsaXphYmxlLnN0cmluZ3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3QuCisKKyAgICAgICAgKiBl bi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzOgorICAgICAgICAqIHBsYXRmb3JtL0xvY2FsaXpl ZFN0cmluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVkTWVkaWFDb250cm9sRWxl bWVudFN0cmluZyk6CisKIDIwMTktMDgtMjEgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5j b20+CiAKICAgICAgICAgW1dITFNMXSBJbXByb3ZlIGRlZmF1bHQgY29uc3RydWN0b3IgYW5kIGVt aXQgZmV3ZXIgcG9pbnRlcnMgaW4gbWV0YWwgY29kZWdlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncyBiL1NvdXJjZS9XZWJDb3JlL2VuLmxw cm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggZTU3YTc3OWYxZmMuLjU5NWI0NGRkYmM4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2VuLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKQEAgLTEzMTks NyArMTMxOSw3IEBACiAicmV0dXJuIHN0cmVhbWluZyBtb3ZpZSB0byByZWFsIHRpbWUiID0gInJl dHVybiBzdHJlYW1pbmcgbW92aWUgdG8gcmVhbCB0aW1lIjsKIAogLyogYWNjZXNzaWJpbGl0eSBs YWJlbCBmb3IgcmV0dXJuIHRvIHJlYWwgdGltZSBidXR0b24gKi8KLSJyZXR1cm4gdG8gcmVhbHRp bWUiID0gInJldHVybiB0byByZWFsdGltZSI7CisicmV0dXJuIHRvIHJlYWwgdGltZSIgPSAicmV0 dXJuIHRvIHJlYWwgdGltZSI7CiAKIC8qIEFuIEFSSUEgYWNjZXNzaWJpbGl0eSBncm91cCB0aGF0 IGNvbnRhaW5zIGEgc2VhcmNoIGZlYXR1cmUgb2YgYSB3ZWJzaXRlLiAqLwogInNlYXJjaCIgPSAi c2VhcmNoIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXplZFN0 cmluZ3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHAK aW5kZXggNjhjMjU5OWQzZGUuLjg5MWZmMGZlYTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcApAQCAtNzgzLDcgKzc4Myw3IEBAIFN0cmluZyBsb2Nh bGl6ZWRNZWRpYUNvbnRyb2xFbGVtZW50U3RyaW5nKGNvbnN0IFN0cmluZyYgbmFtZSkKICAgICBp ZiAobmFtZSA9PSAiUmV3aW5kQnV0dG9uIikKICAgICAgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkco ImJhY2sgMzAgc2Vjb25kcyIsICJhY2Nlc3NpYmlsaXR5IGxhYmVsIGZvciBzZWVrIGJhY2sgMzAg c2Vjb25kcyBidXR0b24iKTsKICAgICBpZiAobmFtZSA9PSAiUmV0dXJuVG9SZWFsdGltZUJ1dHRv biIpCi0gICAgICAgIHJldHVybiBXRUJfVUlfU1RSSU5HKCJyZXR1cm4gdG8gcmVhbHRpbWUiLCAi YWNjZXNzaWJpbGl0eSBsYWJlbCBmb3IgcmV0dXJuIHRvIHJlYWwgdGltZSBidXR0b24iKTsKKyAg ICAgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkcoInJldHVybiB0byByZWFsIHRpbWUiLCAiYWNjZXNz aWJpbGl0eSBsYWJlbCBmb3IgcmV0dXJuIHRvIHJlYWwgdGltZSBidXR0b24iKTsKICAgICBpZiAo bmFtZSA9PSAiQ3VycmVudFRpbWVEaXNwbGF5IikKICAgICAgICAgcmV0dXJuIFdFQl9VSV9TVFJJ TkcoImVsYXBzZWQgdGltZSIsICJhY2Nlc3NpYmlsaXR5IGxhYmVsIGZvciBlbGFwc2VkIHRpbWUg ZGlzcGxheSIpOwogICAgIGlmIChuYW1lID09ICJUaW1lUmVtYWluaW5nRGlzcGxheSIpCg==