201106 2019-08-23 16:51:07 -0700 [LFC] Box::isAnonymous() can not rely on the lack of ElementType. 2019-08-24 06:34:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1564694 0 zalan 2019-08-23 16:51:07 -0700 TableWrapperBox is an anonymous box with "TableWrapperBox" element type. 1564695 1 webkit-bug-importer 2019-08-23 16:52:30 -0700 <rdar://problem/54660287> 1564698 2 377182 zalan 2019-08-23 16:55:33 -0700 Created attachment 377182 Patch 1564781 3 377182 koivisto 2019-08-24 00:03:01 -0700 Comment on attachment 377182 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377182&action=review > Source/WebCore/layout/layouttree/LayoutBox.h:202 > + bool m_isAnonymous { false }; > + > unsigned m_baseTypeFlags : 6; > bool m_hasRareData : 1; Could include this to the bitfield below. 1564809 4 zalan 2019-08-24 06:34:54 -0700 Committed r249085: <https://trac.webkit.org/changeset/249085> 377182 2019-08-23 16:55:33 -0700 2019-08-24 00:01:12 -0700 Patch bug-201106-20190823165532.patch text/plain 4254 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE4ZjEwNjA5NGU5MWMy NTMzNTNmMmFlMTZiM2Q3MTY1OTk5Zjg5ZS4uMjA5Mzg0NjcyNTVlOWM4NjA4Y2FhNDBjYWUyYjkz MTVhZDZjYWU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA4LTIzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQm94Ojppc0Fub255 bW91cygpIGNhbiBub3QgcmVseSBvbiB0aGUgbGFjayBvZiBFbGVtZW50VHlwZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTEwNgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTQ2NjAyODc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIGJvb2wgbV9pc0Fub255bW91cyBtZW1iZXIgdG8gbWFyayBh bm9ueW1vdXMgbGF5b3V0IGJveGVzLiBBbm9ueW1vdXMgYm94ZXMgYXJlIG5vdCByYXJlIGVub3Vn aCB0byBpbmNsdWRlIHRoaXMgdmFyaWFibGUgaW4gUmFyZURhdGEuICAKKworICAgICAgICAqIGxh eW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpC b3g6OnNldElzQW5vbnltb3VzKToKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRU cmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRyZWVCdWlsZGVyOjpj cmVhdGVMYXlvdXRCb3gpOgorCiAyMDE5LTA4LTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXSBOb24taW5saW5lIGZvcm1hdHRpbmcgY29udGV4 dCh0YWJsZSwgZ3JpZCBldGMpIHJvb3QgY29udGFpbmVyIHNob3VsZCBub3QgY29sbGFwc2UgdGhy b3VnaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91 dEJveC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmgKaW5k ZXggYTQxYzBjNjkzZDViODgzOWY5YmVkNjVhNmQ2MGUzZmEwYjA2ODFkOS4uMGZiNzg5ZTNhOTFi ZmNlOWRjOWRmZWM5NWRkYTI1ODJlMjI5NmE0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2xheW91dHRyZWUvTGF5b3V0Qm94LmgKQEAgLTQ1LDcgKzQ1LDcgQEAgcHVibGljOgogICAgIGVu dW0gY2xhc3MgRWxlbWVudFR5cGUgewogICAgICAgICBEb2N1bWVudCwKICAgICAgICAgQm9keSwK LSAgICAgICAgVGFibGVXcmFwcGVyQm94LCAvLyBUaGUgdGFibGUgZ2VuZXJhdGVzIGEgcHJpbmNp cGFsIGJsb2NrIGNvbnRhaW5lciBib3ggY2FsbGVkIHRoZSB0YWJsZSB3cmFwcGVyIGJveCB0aGF0 IGNvbnRhaW5zIHRoZSB0YWJsZSBib3ggYW5kIGFueSBjYXB0aW9uIGJveGVzLiAKKyAgICAgICAg VGFibGVXcmFwcGVyQm94LCAvLyBUaGUgdGFibGUgZ2VuZXJhdGVzIGEgcHJpbmNpcGFsIGJsb2Nr IGNvbnRhaW5lciBib3ggY2FsbGVkIHRoZSB0YWJsZSB3cmFwcGVyIGJveCB0aGF0IGNvbnRhaW5z IHRoZSB0YWJsZSBib3ggYW5kIGFueSBjYXB0aW9uIGJveGVzLgogICAgICAgICBUYWJsZUJveCwg Ly8gVGhlIHRhYmxlIGJveCBpcyBhIGJsb2NrLWxldmVsIGJveCB0aGF0IGNvbnRhaW5zIHRoZSB0 YWJsZSdzIGludGVybmFsIHRhYmxlIGJveGVzLgogICAgICAgICBUYWJsZUNvbHVtbiwKICAgICAg ICAgVGFibGVSb3csCkBAIC0xNjAsNiArMTYwLDggQEAgcHVibGljOgogICAgIHZvaWQgc2V0TmV4 dFNpYmxpbmcoQm94JiBuZXh0U2libGluZykgeyBtX25leHRTaWJsaW5nID0gJm5leHRTaWJsaW5n OyB9CiAgICAgdm9pZCBzZXRQcmV2aW91c1NpYmxpbmcoQm94JiBwcmV2aW91c1NpYmxpbmcpIHsg bV9wcmV2aW91c1NpYmxpbmcgPSAmcHJldmlvdXNTaWJsaW5nOyB9CiAKKyAgICB2b2lkIHNldElz QW5vbnltb3VzKCkgeyBtX2lzQW5vbnltb3VzID0gdHJ1ZTsgfQorCiBwcm90ZWN0ZWQ6CiAgICAg Qm94KE9wdGlvbmFsPEVsZW1lbnRBdHRyaWJ1dGVzPiwgUmVuZGVyU3R5bGUmJiwgQmFzZVR5cGVG bGFncyk7CiAKQEAgLTE5NCw2ICsxOTYsOCBAQCBwcml2YXRlOgogICAgIEJveCogbV9wcmV2aW91 c1NpYmxpbmcgeyBudWxscHRyIH07CiAgICAgQm94KiBtX25leHRTaWJsaW5nIHsgbnVsbHB0ciB9 OwogCisgICAgYm9vbCBtX2lzQW5vbnltb3VzIHsgZmFsc2UgfTsKKwogICAgIHVuc2lnbmVkIG1f YmFzZVR5cGVGbGFncyA6IDY7CiAgICAgYm9vbCBtX2hhc1JhcmVEYXRhIDogMTsKIH07CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRl ci5jcHAKaW5kZXggYWIyODRlYTA5OWI4ZmEzZmZhNzI3NGUwNmU0Y2VjY2FmODQ3NDMwNy4uOTJm YmUyMWE3NTZjOGU0NzczNWU4NzI0ZjgxYmQ1NjllNDc4ODUxNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dFRyZWVCdWlsZGVyLmNwcApAQCAt MTMzLDYgKzEzMyw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxCb3g+IFRyZWVCdWlsZGVyOjpjcmVhdGVM YXlvdXRCb3goY29uc3QgUmVuZGVyRWxlbWVudCYgcGFyZW50UmVuCiAgICAgICAgICAgICBjaGls ZExheW91dEJveCA9IHN0ZDo6bWFrZV91bmlxdWU8Qm94Pihkb3duY2FzdDxSZW5kZXJUZXh0Pihj aGlsZFJlbmRlcmVyKS5vcmlnaW5hbFRleHQoKSwgUmVuZGVyU3R5bGU6OmNsb25lKHBhcmVudFJl bmRlcmVyLnN0eWxlKCkpKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgY2hpbGRMYXlvdXRC b3ggPSBzdGQ6Om1ha2VfdW5pcXVlPEJveD4oZG93bmNhc3Q8UmVuZGVyVGV4dD4oY2hpbGRSZW5k ZXJlcikub3JpZ2luYWxUZXh0KCksIFJlbmRlclN0eWxlOjpjcmVhdGVBbm9ueW1vdXNTdHlsZVdp dGhEaXNwbGF5KHBhcmVudFJlbmRlcmVyLnN0eWxlKCksIERpc3BsYXlUeXBlOjpJbmxpbmUpKTsK KyAgICAgICAgY2hpbGRMYXlvdXRCb3gtPnNldElzQW5vbnltb3VzKCk7CiAgICAgICAgIHJldHVy biBjaGlsZExheW91dEJveDsKICAgICB9CiAKQEAgLTE0NCw2ICsxNDUsNyBAQCBzdGQ6OnVuaXF1 ZV9wdHI8Qm94PiBUcmVlQnVpbGRlcjo6Y3JlYXRlTGF5b3V0Qm94KGNvbnN0IFJlbmRlckVsZW1l bnQmIHBhcmVudFJlbgogICAgIGlmIChpczxSZW5kZXJUYWJsZT4ocmVuZGVyZXIpKSB7CiAgICAg ICAgIC8vIENvbnN0cnVjdCB0aGUgcHJpbmNpcGFsIHRhYmxlIHdyYXBwZXIgYm94IChhbmQgbm90 IHRoZSB0YWJsZSBib3ggaXRzZWxmKS4KICAgICAgICAgY2hpbGRMYXlvdXRCb3ggPSBzdGQ6Om1h a2VfdW5pcXVlPENvbnRhaW5lcj4oQm94OjpFbGVtZW50QXR0cmlidXRlcyB7IEJveDo6RWxlbWVu dFR5cGU6OlRhYmxlV3JhcHBlckJveCB9LCBSZW5kZXJTdHlsZTo6Y2xvbmUocmVuZGVyZXIuc3R5 bGUoKSkpOworICAgICAgICBjaGlsZExheW91dEJveC0+c2V0SXNBbm9ueW1vdXMoKTsKICAgICB9 IGVsc2UgaWYgKGlzPFJlbmRlclJlcGxhY2VkPihyZW5kZXJlcikpIHsKICAgICAgICAgaWYgKGRp c3BsYXlUeXBlID09IERpc3BsYXlUeXBlOjpCbG9jaykKICAgICAgICAgICAgIGNoaWxkTGF5b3V0 Qm94ID0gc3RkOjptYWtlX3VuaXF1ZTxCb3g+KGVsZW1lbnRBdHRyaWJ1dGVzKHJlbmRlcmVyKSwg UmVuZGVyU3R5bGU6OmNsb25lKHJlbmRlcmVyLnN0eWxlKCkpKTsKQEAgLTE5Miw2ICsxOTQsOSBA QCBzdGQ6OnVuaXF1ZV9wdHI8Qm94PiBUcmVlQnVpbGRlcjo6Y3JlYXRlTGF5b3V0Qm94KGNvbnN0 IFJlbmRlckVsZW1lbnQmIHBhcmVudFJlbgogICAgICAgICAgICAgY2hpbGRMYXlvdXRCb3gtPnNl dENvbHVtblNwYW4oY29sdW1uU3Bhbik7CiAgICAgfQogCisgICAgaWYgKGNoaWxkUmVuZGVyZXIu aXNBbm9ueW1vdXMoKSkKKyAgICAgICAgY2hpbGRMYXlvdXRCb3gtPnNldElzQW5vbnltb3VzKCk7 CisKICAgICByZXR1cm4gY2hpbGRMYXlvdXRCb3g7CiB9CiAK