201095 2019-08-23 15:25:53 -0700 Web Inspector: "Copy Rule" menu item does not propagate comments properly 2019-08-24 11:22:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1564638 0 joepeck 2019-08-23 15:25:53 -0700 "Copy Rule" menu item does not propagate comments properly Steps to Reproduce: 1. Inspect <body> on about:blank 2. Add some properties 3. Disable some properties 4. Click Rule Icon > Copy Rule 5. Paste => Disabled "commented out" properties are not commented out 1564671 1 377173 hi 2019-08-23 16:12:51 -0700 Created attachment 377173 Patch 1564819 2 377173 joepeck 2019-08-24 10:38:50 -0700 Comment on attachment 377173 Patch r=me 1564825 3 377173 commit-queue 2019-08-24 11:21:10 -0700 Comment on attachment 377173 Patch Clearing flags on attachment: 377173 Committed r249089: <https://trac.webkit.org/changeset/249089> 1564826 4 commit-queue 2019-08-24 11:21:12 -0700 All reviewed patches have been landed. Closing bug. 1564828 5 webkit-bug-importer 2019-08-24 11:22:20 -0700 <rdar://problem/54673898> 377173 2019-08-23 16:12:51 -0700 2019-08-24 11:21:10 -0700 Patch bug-201095-20190823161250.patch text/plain 7440 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJlOWMxMGMzMzc5NjcwODY3MWM5M2U2MWY4NDVk MmQ5YzE0Y2FiNTEuLjM4NjQ4ZTU4ZDVlMDg5M2ZiMDRhNTJjZjFkYzI0NGFkY2YzZGZiMGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA4LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiAi Q29weSBSdWxlIiBtZW51IGl0ZW0gZG9lcyBub3QgcHJvcGFnYXRlIGNvbW1lbnRzIHByb3Blcmx5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEwOTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvTW9kZWxzL0NTU1Byb3BlcnR5LmpzOgorICAgICAgICAoV0kuQ1NTUHJvcGVydHku cHJvdG90eXBlLmNvbW1lbnRPdXQpOgorICAgICAgICAoV0kuQ1NTUHJvcGVydHkucHJvdG90eXBl LmdldCBmb3JtYXR0ZWRUZXh0KToKKyAgICAgICAgV3JhcCB0aGUgYHRleHRgIGluIGAvKiAke3Rl eHR9ICovYCBpZiB0aGUgYFdJLkNTU1Byb3BlcnR5YCBpc24ndCBgZW5hYmxlZGAgKGUuZy4gY29t bWVudGVkIG91dCkuCisKIDIwMTktMDgtMjIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnNvbGU6IGF1dG9tYXRpY2FsbHkgc2Vs ZWN0IHRoZSAiRXZhbHVhdGlvbnMiIGZpbHRlciB3aGVuZXZlciBydW5uaW5nIGNvbW1hbmRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NT UHJvcGVydHkuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv Q1NTUHJvcGVydHkuanMKaW5kZXggNGY4ZjBkZjY1OWQ3NWM5M2M2OWZjODQxNWJjNDgzNGIwZTIw OGE5NC4uZDgxMmQ4MTgzZWUyODZhOGNhNzM5YWI1OTQwZGYzZTU2OGUzNjg2NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU1Byb3BlcnR5 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NQ cm9wZXJ0eS5qcwpAQCAtMTQ5LDYgKzE0OSw3IEBAIFdJLkNTU1Byb3BlcnR5ID0gY2xhc3MgQ1NT UHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIGNvbW1lbnRPdXQoZGlzYWJsZWQpCiAg ICAgeworICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLmVkaXRhYmxlKTsKICAgICAgICAgaWYg KHRoaXMuX2VuYWJsZWQgPT09ICFkaXNhYmxlZCkKICAgICAgICAgICAgIHJldHVybjsKIApAQCAt MTgxLDcgKzE4MiwxMCBAQCBXSS5DU1NQcm9wZXJ0eSA9IGNsYXNzIENTU1Byb3BlcnR5IGV4dGVu ZHMgV0kuT2JqZWN0CiAgICAgICAgIGlmICghdGhpcy5fbmFtZSkKICAgICAgICAgICAgIHJldHVy biAiIjsKIAotICAgICAgICByZXR1cm4gYCR7dGhpcy5fbmFtZX06ICR7dGhpcy5fcmF3VmFsdWV9 O2A7CisgICAgICAgIGxldCB0ZXh0ID0gYCR7dGhpcy5fbmFtZX06ICR7dGhpcy5fcmF3VmFsdWV9 O2A7CisgICAgICAgIGlmICghdGhpcy5fZW5hYmxlZCkKKyAgICAgICAgICAgIHRleHQgPSAiLyog IiArIHRleHQgKyAiICovIjsKKyAgICAgICAgcmV0dXJuIHRleHQ7CiAgICAgfQogCiAgICAgZ2V0 IG1vZGlmaWVkKCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCBlYTVjZmFhYjA4ZmExMDk0YWJlMDA3ZjNlNjBmNzAyMWY3MGUw OGY5Li40ZjRmNTk0ODI3YzkwMDQwMjQ4OWI1NWY3OGE1ZDM4OTZmNjZmNWE5IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTktMDgtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6ICJDb3B5IFJ1bGUiIG1lbnUgaXRlbSBkb2VzIG5v dCBwcm9wYWdhdGUgY29tbWVudHMgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTA5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Nzcy9nZW5lcmF0ZUNTU1J1bGVTdHJp bmcuaHRtbDoKKyAgICAgICAgKiBpbnNwZWN0b3IvY3NzL2dlbmVyYXRlQ1NTUnVsZVN0cmluZy1l eHBlY3RlZC50eHQ6CisKIDIwMTktMDgtMjIgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVq aWlAc29ueS5jb20+CiAKICAgICAgICAgW1NWR10gLXdlYmtpdC1jbGlwLXBhdGggdHJlYXRzIHVy bChhYmMjeHl6KSBhcyB1cmwoI3h5eikgYmVjYXVzZSBpdCBjaGVja3Mgb25seSBVUkwgZnJhZ21l bnQgcGFydApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9nZW5lcmF0ZUNT U1J1bGVTdHJpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9nZW5l cmF0ZUNTU1J1bGVTdHJpbmctZXhwZWN0ZWQudHh0CmluZGV4IGQzNzc5NzQxY2MxOTZjM2I2OWMw MDg5YjIxOTY0MjY4ZGE1NmQ5MGQuLmFlOWUwNThkNzk0N2Y4NDkyNWIyODU1Njg2MmJhZGZhZTgy NDg4ZjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3MvZ2VuZXJhdGVDU1NS dWxlU3RyaW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY3NzL2dl bmVyYXRlQ1NTUnVsZVN0cmluZy1leHBlY3RlZC50eHQKQEAgLTQsMzggKzQsODQgQEAgVGVzdGlu ZyB0aGF0IGdlbmVyYXRlZCBDU1MgcnVsZSBzdHJpbmdzIGhhdmUgcHJvcGVyIGZvcm1hdHRpbmcu CiA9PSBSdW5uaW5nIHRlc3Qgc3VpdGU6IENTUy5nZW5lcmF0ZUNTU1J1bGVTdHJpbmcKIC0tIFJ1 bm5pbmcgdGVzdCBjYXNlOiBDU1MuZ2VuZXJhdGVDU1NSdWxlU3RyaW5nLklubGluZVN0eWxlCiAj dGVzdC1ub2RlIHsKLSAgICBhLWI6IDE7Ci0gICAgYy1kOiAyOworICAgIGE6IDE7CisgICAgYjog MjsKKyAgICBjOiAzOworfQorCistLSBSdW5uaW5nIHRlc3QgY2FzZTogQ1NTLmdlbmVyYXRlQ1NT UnVsZVN0cmluZy5JbmxpbmVTdHlsZS5XaXRoQ29tbWVudGVkUHJvcGVydHkKKyN0ZXN0LW5vZGUg eworICAgIGE6IDE7CisgICAgLyogYjogMjsgKi8KKyAgICBjOiAzOwogfQogCiAtLSBSdW5uaW5n IHRlc3QgY2FzZTogQ1NTLmdlbmVyYXRlQ1NTUnVsZVN0cmluZy5NYXRjaGVkUnVsZXMKIEBtZWRp YSBvbmx5IHNjcmVlbiBhbmQgKG1pbi13aWR0aDogMHB4KSB7CiAgICAgQG1lZGlhIG9ubHkgc2Ny ZWVuIGFuZCAobWluLWhlaWdodDogMHB4KSB7CiAgICAgICAgIGJvZHkgPiBkaXYjdGVzdC1ub2Rl IHsKLSAgICAgICAgICAgIGEtYjogMTsKLSAgICAgICAgICAgIGMtZDogMjsKKyAgICAgICAgICAg IGE6IDE7CisgICAgICAgICAgICBiOiAyOworICAgICAgICAgICAgYzogMzsKICAgICAgICAgfQog ICAgIH0KIH0KIEBtZWRpYSBvbmx5IHNjcmVlbiBhbmQgKG1pbi13aWR0aDogMHB4KSB7CiAgICAg Ym9keSA+ICN0ZXN0LW5vZGUgewotICAgICAgICBhLWI6IDE7Ci0gICAgICAgIGMtZDogMjsKKyAg ICAgICAgYTogMTsKKyAgICAgICAgYjogMjsKKyAgICAgICAgYzogMzsKICAgICB9CiB9CiBib2R5 ID4gZGl2IHsKLSAgICBhLWI6IDE7Ci0gICAgYy1kOiAyOworICAgIGE6IDE7CisgICAgYjogMjsK KyAgICBjOiAzOwogfQogYm9keSA+ICogewotICAgIGEtYjogMTsKLSAgICBjLWQ6IDI7CisgICAg YTogMTsKKyAgICBiOiAyOworICAgIGM6IDM7CiB9CiAqIHsKLSAgICBhLWI6IDE7Ci0gICAgYy1k OiAyOworICAgIGE6IDE7CisgICAgYjogMjsKKyAgICBjOiAzOwogfQogYWRkcmVzcywgYXJ0aWNs ZSwgYXNpZGUsIGRpdiwgZm9vdGVyLCBoZWFkZXIsIGhncm91cCwgbGF5ZXIsIG1haW4sIG5hdiwg c2VjdGlvbiB7CiAgICAgZGlzcGxheTogYmxvY2s7CiB9CiAKKy0tIFJ1bm5pbmcgdGVzdCBjYXNl OiBDU1MuZ2VuZXJhdGVDU1NSdWxlU3RyaW5nLk1hdGNoZWRSdWxlcy5XaXRoQ29tbWVudGVkUHJv cGVydGllcworQG1lZGlhIG9ubHkgc2NyZWVuIGFuZCAobWluLXdpZHRoOiAwcHgpIHsKKyAgICBA bWVkaWEgb25seSBzY3JlZW4gYW5kIChtaW4taGVpZ2h0OiAwcHgpIHsKKyAgICAgICAgYm9keSA+ IGRpdiN0ZXN0LW5vZGUgeworICAgICAgICAgICAgYTogMTsKKyAgICAgICAgICAgIC8qIGI6IDI7 ICovCisgICAgICAgICAgICBjOiAzOworICAgICAgICB9CisgICAgfQorfQorQG1lZGlhIG9ubHkg c2NyZWVuIGFuZCAobWluLXdpZHRoOiAwcHgpIHsKKyAgICBib2R5ID4gI3Rlc3Qtbm9kZSB7Cisg ICAgICAgIGE6IDE7CisgICAgICAgIC8qIGI6IDI7ICovCisgICAgICAgIGM6IDM7CisgICAgfQor fQorYm9keSA+IGRpdiB7CisgICAgYTogMTsKKyAgICAvKiBiOiAyOyAqLworICAgIGM6IDM7Cit9 Citib2R5ID4gKiB7CisgICAgYTogMTsKKyAgICAvKiBiOiAyOyAqLworICAgIGM6IDM7Cit9Cisq IHsKKyAgICBhOiAxOworICAgIC8qIGI6IDI7ICovCisgICAgYzogMzsKK30KKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9nZW5lcmF0ZUNTU1J1bGVTdHJpbmcuaHRtbCBi L0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3MvZ2VuZXJhdGVDU1NSdWxlU3RyaW5nLmh0bWwKaW5k ZXggZjg3NjI0ZGRmYzYyMTIyM2Y5M2ZlYTI1ZjRjMWVkY2I0MDZkYjk0OS4uZGJiNTViM2M1ZTcz YWUzMmM1OWZlZDA5ZjEzYjMyMzJhNzc2MGMyNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2Nzcy9nZW5lcmF0ZUNTU1J1bGVTdHJpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvY3NzL2dlbmVyYXRlQ1NTUnVsZVN0cmluZy5odG1sCkBAIC0yLDExICsyLDExIEBA CiA8aHRtbD4KIDxoZWFkPgogPHN0eWxlPgotKnthLWI6MTtjLWQ6Mn0KLWJvZHk+KnthLWI6MTtj LWQ6Mn0KLUBtZWRpYSBhbGwge2JvZHk+ZGl2e2EtYjoxO2MtZDoyfX0KLUBtZWRpYSBvbmx5IHNj cmVlbiBhbmQgKG1pbi13aWR0aDowcHgpIHtib2R5PiN0ZXN0LW5vZGV7YS1iOjE7Yy1kOjJ9fQot QG1lZGlhIG9ubHkgc2NyZWVuIGFuZCAobWluLXdpZHRoOjBweCkge0BtZWRpYSBvbmx5IHNjcmVl biBhbmQgKG1pbi1oZWlnaHQ6MHB4KSB7Ym9keT5kaXYjdGVzdC1ub2Rle2EtYjoxO2MtZDoyfX19 Cisqe2E6MTtiOjI7YzozfQorYm9keT4qe2E6MTtiOjI7YzozfQorQG1lZGlhIGFsbCB7Ym9keT5k aXZ7YToxO2I6MjtjOjN9fQorQG1lZGlhIG9ubHkgc2NyZWVuIGFuZCAobWluLXdpZHRoOjBweCkg e2JvZHk+I3Rlc3Qtbm9kZXthOjE7YjoyO2M6M319CitAbWVkaWEgb25seSBzY3JlZW4gYW5kICht aW4td2lkdGg6MHB4KSB7QG1lZGlhIG9ubHkgc2NyZWVuIGFuZCAobWluLWhlaWdodDowcHgpIHti b2R5PmRpdiN0ZXN0LW5vZGV7YToxO2I6MjtjOjN9fX0KIDwvc3R5bGU+CiA8c2NyaXB0IHNyYz0i Li4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzIj48 L3NjcmlwdD4KIDxzY3JpcHQ+CkBAIC0yMyw2ICsyMywxNSBAQCBmdW5jdGlvbiB0ZXN0KCkgewog ICAgICAgICB9CiAgICAgfSk7CiAKKyAgICBzdWl0ZS5hZGRUZXN0Q2FzZSh7CisgICAgICAgIG5h bWU6ICJDU1MuZ2VuZXJhdGVDU1NSdWxlU3RyaW5nLklubGluZVN0eWxlLldpdGhDb21tZW50ZWRQ cm9wZXJ0eSIsCisgICAgICAgIGRlc2NyaXB0aW9uOiAiQ2hlY2sgdGhlIGZvcm1hdHRpbmcgb2Yg dGhlIGdlbmVyYXRlZCBpbmxpbmUgc3R5bGUgc3RyaW5nIGlmIGEgcHJvcGVydHkgaXMgY29tbWVu dGVkIG91dC4iLAorICAgICAgICB0ZXN0KCkgeworICAgICAgICAgICAgbm9kZVN0eWxlcy5pbmxp bmVTdHlsZS5wcm9wZXJ0aWVzWzFdLmNvbW1lbnRPdXQodHJ1ZSk7CisgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmxvZyhub2RlU3R5bGVzLmlubGluZVN0eWxlLmdlbmVyYXRlQ1NTUnVsZVN0cmlu ZygpKTsKKyAgICAgICAgfSwKKyAgICB9KTsKKwogICAgIHN1aXRlLmFkZFRlc3RDYXNlKHsKICAg ICAgICAgbmFtZTogIkNTUy5nZW5lcmF0ZUNTU1J1bGVTdHJpbmcuTWF0Y2hlZFJ1bGVzIiwKICAg ICAgICAgZGVzY3JpcHRpb246ICJDaGVjayB0aGUgZm9ybWF0dGluZyBvZiB0aGUgZ2VuZXJhdGVk IHN0cmluZyBmb3IgYWxsIG1hdGNoZWQgQ1NTIHJ1bGVzLiIsCkBAIC0zMiw2ICs0MSwyMCBAQCBm dW5jdGlvbiB0ZXN0KCkgewogICAgICAgICB9CiAgICAgfSk7CiAKKyAgICBzdWl0ZS5hZGRUZXN0 Q2FzZSh7CisgICAgICAgIG5hbWU6ICJDU1MuZ2VuZXJhdGVDU1NSdWxlU3RyaW5nLk1hdGNoZWRS dWxlcy5XaXRoQ29tbWVudGVkUHJvcGVydGllcyIsCisgICAgICAgIGRlc2NyaXB0aW9uOiAiQ2hl Y2sgdGhlIGZvcm1hdHRpbmcgb2YgdGhlIGdlbmVyYXRlZCBzdHJpbmcgZm9yIGFsbCBtYXRjaGVk IENTUyBydWxlcyBpZiBhIHByb3BlcnR5IGlzIGNvbW1lbnRlZCBvdXQgaW4gZWFjaC4iLAorICAg ICAgICB0ZXN0KCkgeworICAgICAgICAgICAgZm9yIChsZXQgcnVsZSBvZiBub2RlU3R5bGVzLm1h dGNoZWRSdWxlcykgeworICAgICAgICAgICAgICAgIGlmICghcnVsZS5zdHlsZS5lZGl0YWJsZSkK KyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgICAgICAgICBydWxlLnN0 eWxlLnByb3BlcnRpZXNbMV0uY29tbWVudE91dCh0cnVlKTsKKyAgICAgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmxvZyhydWxlLnN0eWxlLmdlbmVyYXRlQ1NTUnVsZVN0cmluZygpKTsKKyAgICAg ICAgICAgIH0KKyAgICAgICAgfQorICAgIH0pOworCiAgICAgV0kuZG9tTWFuYWdlci5yZXF1ZXN0 RG9jdW1lbnQoKGRvY3VtZW50Tm9kZSkgPT4gewogICAgICAgICBXSS5kb21NYW5hZ2VyLnF1ZXJ5 U2VsZWN0b3IoZG9jdW1lbnROb2RlLmlkLCAiI3Rlc3Qtbm9kZSIsIGFzeW5jIChjb250ZW50Tm9k ZUlkKSA9PiB7CiAgICAgICAgICAgICBpZiAoIWNvbnRlbnROb2RlSWQpIHsKQEAgLTUzLDYgKzc2 LDYgQEAgZnVuY3Rpb24gdGVzdCgpIHsKIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0icnVuVGVzdCgp Ij4KICAgICA8cD5UZXN0aW5nIHRoYXQgZ2VuZXJhdGVkIENTUyBydWxlIHN0cmluZ3MgaGF2ZSBw cm9wZXIgZm9ybWF0dGluZy48L3A+Ci0gICAgPGRpdiBpZD0idGVzdC1ub2RlIiBzdHlsZT0iYS1i OjE7Yy1kOjIiPjwvZGl2PgorICAgIDxkaXYgaWQ9InRlc3Qtbm9kZSIgc3R5bGU9ImE6MTtiOjI7 YzozIj48L2Rpdj4KIDwvYm9keT4KIDwvaHRtbD4K