201083 2019-08-23 12:09:14 -0700 Regression(r248533) Assertion hit in isMainThread() for some clients using WTF because the main thread is not initialized 2019-09-18 15:05:05 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201947 InRadar P2 Normal --- 200507 1 cdumez cdumez achristensen beidson benjamin cmarcelo commit-queue dbates ews-watchlist fujii ggaren jeffm rniwa webkit-bug-importer youennf oldest_to_newest 1564550 0 cdumez 2019-08-23 12:09:14 -0700 An assertion is hit in isMainThread() for some clients using WTF because the main thread is not initialized, since r248533. 1564551 1 cdumez 2019-08-23 12:10:30 -0700 Clients can work around this by calling WTF::initializeMainThread() before using WTF but it seems unfortunate to force them to do so. I propose we disable the assertion until the main thread is initialized. 1564552 2 377148 cdumez 2019-08-23 12:11:53 -0700 Created attachment 377148 Patch 1564554 3 cdumez 2019-08-23 12:14:40 -0700 See <rdar://problem/54616639> & <rdar://problem/54323901>. 1564574 4 377148 commit-queue 2019-08-23 13:31:15 -0700 Comment on attachment 377148 Patch Clearing flags on attachment: 377148 Committed r249064: <https://trac.webkit.org/changeset/249064> 1564575 5 commit-queue 2019-08-23 13:31:16 -0700 All reviewed patches have been landed. Closing bug. 1564576 6 webkit-bug-importer 2019-08-23 13:32:17 -0700 <rdar://problem/54651993> 1564878 7 fujii 2019-08-25 18:52:31 -0700 Committed r249092: <https://trac.webkit.org/changeset/249092> 1564961 8 cdumez 2019-08-26 09:16:44 -0700 (In reply to Fujii Hironori from comment #7) > Committed r249092: <https://trac.webkit.org/changeset/249092> Thanks for the build fox :D 377148 2019-08-23 12:11:53 -0700 2019-08-23 13:31:15 -0700 Patch bug-201083-20190823121152.patch text/plain 4395 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZlNzk1N2M0MGQzMGVlZTVmYjMzOTE4 N2VmYWNmNmZhOTlkMGRiNGYuLjQ0MTRkNjZhMDhlZWY5NzE1ZWNlNGJjOGQxZWY4ZTg3NzdiZjMw NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDgtMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNDg1MzMpIEFzc2VydGlvbiBoaXQg aW4gaXNNYWluVGhyZWFkKCkgZm9yIHNvbWUgY2xpZW50cyB1c2luZyBXVEYgYmVjYXVzZSB0aGUg bWFpbiB0aHJlYWQgaXMgbm90IGluaXRpYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDEwODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBbiBhc3NlcnRpb24gaXMgaGl0IGluIGlzTWFpblRocmVh ZCgpIGZvciBzb21lIGNsaWVudHMgdXNpbmcgV1RGIGJlY2F1c2UgdGhlIG1haW4gdGhyZWFkIGlz IG5vdCBpbml0aWFsaXplZCwgc2luY2UgcjI0ODUzMy4KKyAgICAgICAgQ2xpZW50cyBjYW4gd29y ayBhcm91bmQgdGhpcyBieSBjYWxsaW5nIFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWQoKSBiZWZv cmUgdXNpbmcgV1RGIGJ1dCBpdCBzZWVtcyB1bmZvcnR1bmF0ZSB0byBmb3JjZSB0aGVtCisgICAg ICAgIHRvIGRvIHNvLiBJIHByb3Bvc2Ugd2UgZGlzYWJsZSB0aGUgYXNzZXJ0aW9uIHVudGlsIHRo ZSBtYWluIHRocmVhZCBpcyBpbml0aWFsaXplZC4KKworICAgICAgICAqIHd0Zi9NYWluVGhyZWFk Lmg6CisgICAgICAgICogd3RmL1JlZkNvdW50ZWQuaDoKKyAgICAgICAgKFdURjo6UmVmQ291bnRl ZEJhc2U6OlJlZkNvdW50ZWRCYXNlKToKKyAgICAgICAgKFdURjo6UmVmQ291bnRlZEJhc2U6OmFw cGx5UmVmRGVyZWZUaHJlYWRpbmdDaGVjayBjb25zdCk6CisgICAgICAgICogd3RmL2NvY29hL01h aW5UaHJlYWRDb2NvYS5tbToKKyAgICAgICAgKFdURjo6aXNNYWluVGhyZWFkSW5pdGlhbGl6ZWQp OgorICAgICAgICAqIHd0Zi9nZW5lcmljL01haW5UaHJlYWRHZW5lcmljLmNwcDoKKyAgICAgICAg KFdURjo6aXNNYWluVGhyZWFkSW5pdGlhbGl6ZWQpOgorCiAyMDE5LTA4LTIyICBBbmR5IEVzdGVz ICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbd2F0Y2hPU10gRGlzYWJsZSBDb250ZW50 IEZpbHRlcmluZyBpbiB0aGUgc2ltdWxhdG9yIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9NYWluVGhyZWFkLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmgKaW5kZXggMTJi ZmFlNDQ4NmUyMGE1ZGQ4OWU1YmQzMTZlYjA1ZjFmMWY2NGZlYS4uNzg1YWVmYmM4ZTRiNjgzZTBl MjFmZTI5ZjdlOWFlYTI4MTEwZTAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWFpblRo cmVhZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuaApAQCAtNTQsNiArNTQsNyBA QCBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkKGJv b2wgcGF1c2VkKTsKIAogV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgaXNNYWluVGhyZWFkKCk7CiBX VEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBpc01haW5UaHJlYWRJZkluaXRpYWxpemVkKCk7CitXVEZf RVhQT1JUX1BSSVZBVEUgYm9vbCBpc01haW5UaHJlYWRJbml0aWFsaXplZCgpOwogCiBXVEZfRVhQ T1JUX1BSSVZBVEUgYm9vbCBjYW5BY2Nlc3NUaHJlYWRMb2NhbERhdGFGb3JUaHJlYWQoVGhyZWFk Jik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1JlZkNvdW50ZWQuaCBiL1NvdXJjZS9X VEYvd3RmL1JlZkNvdW50ZWQuaAppbmRleCA5YmNmNWViNDcyZTUyMjZmNjRmZGRiY2E1MWMxYTcz ZGI1Nzc4MjQxLi4xMzMzMzg3OTEyYjc2MjZkMjk4MWJkOGY5ZGZlZjg2N2RkNTg4N2NmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9SZWZDb3VudGVkLmgKKysrIGIvU291cmNlL1dURi93dGYv UmVmQ291bnRlZC5oCkBAIC05MSw3ICs5MSw4IEBAIHByb3RlY3RlZDoKICAgICBSZWZDb3VudGVk QmFzZSgpCiAgICAgICAgIDogbV9yZWZDb3VudCgxKQogI2lmICFBU1NFUlRfRElTQUJMRUQKLSAg ICAgICAgLCBtX2lzT3duZWRCeU1haW5UaHJlYWQoaXNNYWluVGhyZWFkKCkpCisgICAgICAgICwg bV9pc093bmVkQnlNYWluVGhyZWFkKGlzTWFpblRocmVhZElmSW5pdGlhbGl6ZWQoKSkKKyAgICAg ICAgLCBtX2FyZVRocmVhZGluZ0NoZWNrc0VuYWJsZWQoaXNNYWluVGhyZWFkSW5pdGlhbGl6ZWQo KSkKICNlbmRpZgogI2lmIENIRUNLX1JFRl9DT1VOVEVEX0xJRkVDWUNMRQogICAgICAgICAsIG1f ZGVsZXRpb25IYXNCZWd1bihmYWxzZSkKQEAgLTEwNSw3ICsxMDYsNyBAQCBwcm90ZWN0ZWQ6CiAj aWYgIUFTU0VSVF9ESVNBQkxFRAogICAgICAgICBpZiAoaGFzT25lUmVmKCkpIHsKICAgICAgICAg ICAgIC8vIExpa2VseSBhbiBvd25lcnNoaXAgdHJhbnNmZXIgYWNyb3NzIHRocmVhZHMgdGhhdCBt YXkgYmUgc2FmZS4KLSAgICAgICAgICAgIG1faXNPd25lZEJ5TWFpblRocmVhZCA9IGlzTWFpblRo cmVhZCgpOworICAgICAgICAgICAgbV9pc093bmVkQnlNYWluVGhyZWFkID0gaXNNYWluVGhyZWFk SWZJbml0aWFsaXplZCgpOwogICAgICAgICB9IGVsc2UgaWYgKGFyZVRocmVhZGluZ0NoZWNrc0Vu YWJsZWRHbG9iYWxseSAmJiBtX2FyZVRocmVhZGluZ0NoZWNrc0VuYWJsZWQpIHsKICAgICAgICAg ICAgIC8vIElmIHlvdSBoaXQgdGhpcyBhc3NlcnRpb24sIGl0IG1lYW5zIHRoYXQgdGhlIFJlZkNv dW50ZWQgb2JqZWN0IHdhcyByZWYvZGVyZWYnZAogICAgICAgICAgICAgLy8gZnJvbSBib3RoIHRo ZSBtYWluIHRocmVhZCBhbmQgYW5vdGhlciBpbiBhIHdheSB0aGF0IGlzIGxpa2VseSBjb25jdXJy ZW50IGFuZCB1bnNhZmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9NYWluVGhy ZWFkQ29jb2EubW0gYi9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9NYWluVGhyZWFkQ29jb2EubW0KaW5k ZXggYmU3ZWE0NTIxNDA5MTliNDYzYWQwNmJmODExZjVlOGQ2MDlhM2E2Ni4uNThiNmY5MWExNmEy ZjYyNWVlNTU4OWRhMjUxZDhjYmQ3MGQ4NzMyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv Y29jb2EvTWFpblRocmVhZENvY29hLm1tCisrKyBiL1NvdXJjZS9XVEYvd3RmL2NvY29hL01haW5U aHJlYWRDb2NvYS5tbQpAQCAtMTgxLDYgKzE4MSwxMSBAQCBib29sIGlzTWFpblRocmVhZElmSW5p dGlhbGl6ZWQoKQogICAgIHJldHVybiBpc01haW5UaHJlYWQoKTsKIH0KIAorYm9vbCBpc01haW5U aHJlYWRJbml0aWFsaXplZCgpCit7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIGJvb2wgaXNVSVRo cmVhZCgpCiB7CiAgICAgcmV0dXJuIHB0aHJlYWRfbWFpbl9ucCgpOwpAQCAtMjM5LDYgKzI0NCwx MSBAQCBib29sIGlzTWFpblRocmVhZElmSW5pdGlhbGl6ZWQoKQogICAgIHJldHVybiBwdGhyZWFk X2VxdWFsKHB0aHJlYWRfc2VsZigpLCBtYWluVGhyZWFkUHRocmVhZCk7CiB9CiAKK2Jvb2wgaXNN YWluVGhyZWFkSW5pdGlhbGl6ZWQoKQoreworICAgIHJldHVybiBtYWluVGhyZWFkRXN0YWJsaXNo ZWRBc1B0aHJlYWRNYWluIHx8IG1haW5UaHJlYWRQdGhyZWFkOworfQorCiAjZW5kaWYgLy8gVVNF KFdFQl9USFJFQUQpCiAKIH0gLy8gbmFtZXNwYWNlIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvZ2VuZXJpYy9NYWluVGhyZWFkR2VuZXJpYy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9nZW5l cmljL01haW5UaHJlYWRHZW5lcmljLmNwcAppbmRleCBhMzY2MTAxZDk3ZTdlZTAzM2MyMDY2ZTI1 ZGVhNDU5ZjgxMjVkM2EwLi5mYzMxYzgwYzA2OGFhMDFhOTRmOWI5M2QyYTY5MjY4YTU5MzE5MWFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nZW5lcmljL01haW5UaHJlYWRHZW5lcmljLmNw cAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9nZW5lcmljL01haW5UaHJlYWRHZW5lcmljLmNwcApAQCAt OTIsNiArOTIsMTEgQEAgYm9vbCBpc01haW5UaHJlYWRJZkluaXRpYWxpemVkKCkKICAgICByZXR1 cm4gaXNNYWluVGhyZWFkKCk7CiB9CiAKK2Jvb2wgaXNNYWluVGhyZWFkSW5pdGlhbGl6ZWQoKQor eworICAgIHJldHVybiB0cnVlOworfQorCiB2b2lkIHNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNP bk1haW5UaHJlYWQoKQogewogICAgIC8vIFVzZSBhIFJ1bkxvb3A6OlRpbWVyIGluc3RlYWQgb2Yg UnVuTG9vcDo6ZGlzcGF0Y2goKSB0byBiZSBhYmxlIHRvIHVzZSBhIGRpZmZlcmVudCBwcmlvcml0 eSBhbmQK