201062 2019-08-22 18:38:00 -0700 VirtualRegister::dump() can use more informative CallFrame header slot names. 2019-08-23 11:06:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1564346 0 mark.lam 2019-08-22 18:38:00 -0700 For example, it currently dumps head3 instead of callee. 1564350 1 377088 mark.lam 2019-08-22 18:49:16 -0700 Created attachment 377088 proposed patch. 1564477 2 377088 tzagallo 2019-08-23 09:48:53 -0700 Comment on attachment 377088 proposed patch. r=me 1564478 3 377088 tzagallo 2019-08-23 09:50:02 -0700 Comment on attachment 377088 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=377088&action=review > Source/JavaScriptCore/ChangeLog:3 > + VirtualRegister::dump() can be use more informative CallFrame header slot names. typo: s/can be use/can use/ 1564495 4 mark.lam 2019-08-23 10:27:28 -0700 Thanks for the review. Landed in r249052: <http://trac.webkit.org/r249052>. 1564496 5 webkit-bug-importer 2019-08-23 10:28:18 -0700 <rdar://problem/54645167> 1564512 6 377088 saam 2019-08-23 11:06:08 -0700 Comment on attachment 377088 proposed patch. Nice 377088 2019-08-22 18:49:16 -0700 2019-08-23 10:18:54 -0700 proposed patch. bug-201062.patch text/plain 2649 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ5MDM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE5LTA4LTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBW aXJ0dWFsUmVnaXN0ZXI6OmR1bXAoKSBjYW4gYmUgdXNlIG1vcmUgaW5mb3JtYXRpdmUgQ2FsbEZy YW1lIGhlYWRlciBzbG90IG5hbWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAxMDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRm9yIGV4YW1wbGUsIGl0IGN1cnJlbnRseSBkdW1wcyBoZWFkMyBpbnN0 ZWFkIG9mIGNhbGxlZS4gIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUKKyAgICAgICAgZHVtcCBhcyBm b2xsb3dzIChmb3IgNjQtYml0IGFkZHJlc3NpbmcpOgorICAgICAgICAgICAgaGVhZDAgPT4gY2Fs bGVyRnJhbWUKKyAgICAgICAgICAgIGhlYWQxID0+IHJldHVyblBDCisgICAgICAgICAgICBoZWFk MiA9PiBjb2RlQmxvY2sKKyAgICAgICAgICAgIGhlYWQzID0+IGNhbGxlZQorICAgICAgICAgICAg aGVhZDQgPT4gYXJndW1lbnRDb3VudAorCisgICAgICAgIE5vdywgb25lIG1pZ2h0IGJlIHdvbmRl cmluZyB3aGVuIHdvdWxkIGJ5dGVjb2RlIGV2ZXIgYWNjZXNzIGNhbGxlckZyYW1lIGFuZAorICAg ICAgICByZXR1cm5QQz8gIFRoZSBhbnN3ZXIgaXMgbmV2ZXIuICBIb3dldmVyLCBJIGRvbid0IHRo aW5rIGl0cyB0aGUgcm9sZSBvZiB0aGUKKyAgICAgICAgZHVtcGVyIHRvIGNhdGNoIGEgYnVnIHdo ZXJlIHRoZXNlIGhlYWRlciBzbG90cyBhcmUgYmVpbmcgdXNlZC4gIFRoZSBkdW1wZXIncyByb2xl CisgICAgICAgIGlzIHRvIGNsZWFybHkgcmVwb3J0IHRoZW0gc28gdGhhdCB3ZSBjYW4gc2VlIHRo YXQgdGhlc2UgdW5leHBlY3RlZCB2YWx1ZXMgYXJlCisgICAgICAgIGJlaW5nIHVzZWQuCisKKyAg ICAgICAgKiBieXRlY29kZS9WaXJ0dWFsUmVnaXN0ZXIuY3BwOgorICAgICAgICAoSlNDOjpWaXJ0 dWFsUmVnaXN0ZXI6OmR1bXAgY29uc3QpOgorCiAyMDE5LTA4LTIyICBBbmR5IEVzdGVzICA8YWVz dGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbd2F0Y2hPU10gRGlzYWJsZSBDb250ZW50IEZpbHRl cmluZyBpbiB0aGUgc2ltdWxhdG9yIGJ1aWxkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvVmlydHVhbFJlZ2lzdGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvVmlydHVhbFJlZ2lzdGVyLmNwcAkocmV2aXNpb24gMjQ5MDM2KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ZpcnR1YWxSZWdpc3Rlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDExLCAy MDE1IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAx MS0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucwpAQCAtMzgsNyArMzgsMjEgQEAgdm9pZCBWaXJ0dWFsUmVnaXN0ZXI6OmR1 bXAoUHJpbnRTdHJlYW0mIAogICAgIH0KICAgICAKICAgICBpZiAoaXNIZWFkZXIoKSkgewotICAg ICAgICBvdXQucHJpbnQoImhlYWQiLCBtX3ZpcnR1YWxSZWdpc3Rlcik7CisgICAgICAgIGlmICht X3ZpcnR1YWxSZWdpc3RlciA9PSBDYWxsRnJhbWVTbG90Ojpjb2RlQmxvY2spCisgICAgICAgICAg ICBvdXQucHJpbnQoImNvZGVCbG9jayIpOworICAgICAgICBlbHNlIGlmIChtX3ZpcnR1YWxSZWdp c3RlciA9PSBDYWxsRnJhbWVTbG90OjpjYWxsZWUpCisgICAgICAgICAgICBvdXQucHJpbnQoImNh bGxlZSIpOworICAgICAgICBlbHNlIGlmIChtX3ZpcnR1YWxSZWdpc3RlciA9PSBDYWxsRnJhbWVT bG90Ojphcmd1bWVudENvdW50KQorICAgICAgICAgICAgb3V0LnByaW50KCJhcmd1bWVudENvdW50 Iik7CisjaWYgQ1BVKEFERFJFU1M2NCkKKyAgICAgICAgZWxzZSBpZiAoIW1fdmlydHVhbFJlZ2lz dGVyKQorICAgICAgICAgICAgb3V0LnByaW50KCJjYWxsZXJGcmFtZSIpOworICAgICAgICBlbHNl IGlmIChtX3ZpcnR1YWxSZWdpc3RlciA9PSAxKQorICAgICAgICAgICAgb3V0LnByaW50KCJyZXR1 cm5QQyIpOworI2Vsc2UKKyAgICAgICAgZWxzZSBpZiAoIW1fdmlydHVhbFJlZ2lzdGVyKQorICAg ICAgICAgICAgb3V0LnByaW50KCJjYWxsZXJGcmFtZUFuZFJldHVyblBDIik7CisjZW5kaWYKICAg ICAgICAgcmV0dXJuOwogICAgIH0KICAgICAK