201052 2019-08-22 14:00:34 -0700 Remove logging that contains a URL 2019-08-22 14:44:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1564208 0 krollin 2019-08-22 14:00:34 -0700 checkURLReceivedFromWebProcess in WebProcessProxy.cpp contains an old logging line that logs a URL. We don't log URLs any more for privacy reasons, so remove this. A search for WTFLogAlways.*url turns up other matches, but those are either false positives or cases where the URLs are logged only on demand by the developer as part of debugging. checkURLReceivedFromWebProcess is the only place where a URL is logged as a matter of course. 1564209 1 webkit-bug-importer 2019-08-22 14:00:52 -0700 <rdar://problem/54613204> 1564211 2 377042 krollin 2019-08-22 14:02:42 -0700 Created attachment 377042 Patch 1564213 3 377042 cdumez 2019-08-22 14:08:53 -0700 Comment on attachment 377042 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377042&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:-561 > - WTFLogAlways("Received an unexpected URL from the web process: '%s'\n", url.string().utf8().data()); Shouldn't we keep the logging though? How to we know now that's why the load is failing? 1564214 4 377043 krollin 2019-08-22 14:12:44 -0700 Created attachment 377043 Patch 1564238 5 377043 commit-queue 2019-08-22 14:44:00 -0700 Comment on attachment 377043 Patch Clearing flags on attachment: 377043 Committed r249029: <https://trac.webkit.org/changeset/249029> 1564239 6 commit-queue 2019-08-22 14:44:01 -0700 All reviewed patches have been landed. Closing bug. 377042 2019-08-22 14:02:42 -0700 2019-08-22 14:12:43 -0700 Patch bug-201052-20190822140241.patch text/plain 1882 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmZjc4ZmJmNGRlMmNjODlk YTZkNjM3ODY5MDFjOTk0ZTdkMDJlMWYuLmMzYTUxYmNlOTJjZDZiNzA3N2U5OGRjMmMxMWIyYWQ0 MzA4N2U2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDgtMjIgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBsb2dnaW5nIHRoYXQg Y29udGFpbnMgYSBVUkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMTA1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ2MTMyMDQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY2hlY2tVUkxSZWNlaXZl ZEZyb21XZWJQcm9jZXNzIGluIFdlYlByb2Nlc3NQcm94eS5jcHAgY29udGFpbnMgYW4gb2xkCisg ICAgICAgIGxvZ2dpbmcgbGluZSB0aGF0IGxvZ3MgYSBVUkwuIFdlIGRvbid0IGxvZyBVUkxzIGFu eSBtb3JlIGZvciBwcml2YWN5CisgICAgICAgIHJlYXNvbnMsIHNvIHJlbW92ZSB0aGlzLgorCisg ICAgICAgIEEgc2VhcmNoIGZvciBXVEZMb2dBbHdheXMuKnVybCB0dXJucyB1cCBvdGhlciBtYXRj aGVzLCBidXQgdGhvc2UgYXJlCisgICAgICAgIGVpdGhlciBmYWxzZSBwb3NpdGl2ZXMgb3IgY2Fz ZXMgd2hlcmUgdGhlIFVSTHMgYXJlIGxvZ2dlZCBvbmx5IG9uCisgICAgICAgIGRlbWFuZCBieSB0 aGUgZGV2ZWxvcGVyIGFzIHBhcnQgb2YgZGVidWdnaW5nLgorICAgICAgICBjaGVja1VSTFJlY2Vp dmVkRnJvbVdlYlByb2Nlc3MgaXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgYSBVUkwgaXMgbG9nZ2Vk CisgICAgICAgIGFzIGEgbWF0dGVyIG9mIGNvdXJzZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmNo ZWNrVVJMUmVjZWl2ZWRGcm9tV2ViUHJvY2Vzcyk6CisKIDIwMTktMDgtMjIgIEFkcmlhbiBQZXJl eiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEZp eGVzIGZvciBub24tdW5pZmllZCBidWlsZHMgYWZ0ZXIgcjI0ODU0NwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKaW5kZXggYmNmZGYzYTM4ZDdiYzc5NjZjZDg3 NGVkMDJiYTAzNmRmZjNjNGE5My4uYmU1YWFjNTc3OWM3OTQzOTBjMWRmMDg4NjZlYzQ2ZWVjNWQ1 YWYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCkBA IC01NTgsNyArNTU4LDYgQEAgYm9vbCBXZWJQcm9jZXNzUHJveHk6OmNoZWNrVVJMUmVjZWl2ZWRG cm9tV2ViUHJvY2Vzcyhjb25zdCBVUkwmIHVybCkKICAgICB9CiAKICAgICAvLyBBIFdlYiBwcm9j ZXNzIHRoYXQgd2FzIG5ldmVyIGFza2VkIHRvIGxvYWQgYSBmaWxlIFVSTCBzaG91bGQgbm90IGV2 ZXIgYXNrIHVzIHRvIGRvIGFueXRoaW5nIHdpdGggYSBmaWxlIFVSTC4KLSAgICBXVEZMb2dBbHdh eXMoIlJlY2VpdmVkIGFuIHVuZXhwZWN0ZWQgVVJMIGZyb20gdGhlIHdlYiBwcm9jZXNzOiAnJXMn XG4iLCB1cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQog Cg== 377043 2019-08-22 14:12:44 -0700 2019-08-22 14:44:00 -0700 Patch bug-201052-20190822141243.patch text/plain 1966 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmZjc4ZmJmNGRlMmNjODlk YTZkNjM3ODY5MDFjOTk0ZTdkMDJlMWYuLmMzYTUxYmNlOTJjZDZiNzA3N2U5OGRjMmMxMWIyYWQ0 MzA4N2U2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDgtMjIgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBsb2dnaW5nIHRoYXQg Y29udGFpbnMgYSBVUkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMTA1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQ2MTMyMDQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY2hlY2tVUkxSZWNlaXZl ZEZyb21XZWJQcm9jZXNzIGluIFdlYlByb2Nlc3NQcm94eS5jcHAgY29udGFpbnMgYW4gb2xkCisg ICAgICAgIGxvZ2dpbmcgbGluZSB0aGF0IGxvZ3MgYSBVUkwuIFdlIGRvbid0IGxvZyBVUkxzIGFu eSBtb3JlIGZvciBwcml2YWN5CisgICAgICAgIHJlYXNvbnMsIHNvIHJlbW92ZSB0aGlzLgorCisg ICAgICAgIEEgc2VhcmNoIGZvciBXVEZMb2dBbHdheXMuKnVybCB0dXJucyB1cCBvdGhlciBtYXRj aGVzLCBidXQgdGhvc2UgYXJlCisgICAgICAgIGVpdGhlciBmYWxzZSBwb3NpdGl2ZXMgb3IgY2Fz ZXMgd2hlcmUgdGhlIFVSTHMgYXJlIGxvZ2dlZCBvbmx5IG9uCisgICAgICAgIGRlbWFuZCBieSB0 aGUgZGV2ZWxvcGVyIGFzIHBhcnQgb2YgZGVidWdnaW5nLgorICAgICAgICBjaGVja1VSTFJlY2Vp dmVkRnJvbVdlYlByb2Nlc3MgaXMgdGhlIG9ubHkgcGxhY2Ugd2hlcmUgYSBVUkwgaXMgbG9nZ2Vk CisgICAgICAgIGFzIGEgbWF0dGVyIG9mIGNvdXJzZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmNo ZWNrVVJMUmVjZWl2ZWRGcm9tV2ViUHJvY2Vzcyk6CisKIDIwMTktMDgtMjIgIEFkcmlhbiBQZXJl eiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEZp eGVzIGZvciBub24tdW5pZmllZCBidWlsZHMgYWZ0ZXIgcjI0ODU0NwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKaW5kZXggYmNmZGYzYTM4ZDdiYzc5NjZjZDg3 NGVkMDJiYTAzNmRmZjNjNGE5My4uMTA4ZDFlOTQyMzFhNGI0ZjdlZjM3NTE4ZjMyMGEwYzc2ZjE0 ZTQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCkBA IC01NTgsNyArNTU4LDcgQEAgYm9vbCBXZWJQcm9jZXNzUHJveHk6OmNoZWNrVVJMUmVjZWl2ZWRG cm9tV2ViUHJvY2Vzcyhjb25zdCBVUkwmIHVybCkKICAgICB9CiAKICAgICAvLyBBIFdlYiBwcm9j ZXNzIHRoYXQgd2FzIG5ldmVyIGFza2VkIHRvIGxvYWQgYSBmaWxlIFVSTCBzaG91bGQgbm90IGV2 ZXIgYXNrIHVzIHRvIGRvIGFueXRoaW5nIHdpdGggYSBmaWxlIFVSTC4KLSAgICBXVEZMb2dBbHdh eXMoIlJlY2VpdmVkIGFuIHVuZXhwZWN0ZWQgVVJMIGZyb20gdGhlIHdlYiBwcm9jZXNzOiAnJXMn XG4iLCB1cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisgICAgUkVMRUFTRV9MT0dfRVJST1Io TG9hZGluZywgIlJlY2VpdmVkIGFuIHVuZXhwZWN0ZWQgVVJMIGZyb20gdGhlIHdlYiBwcm9jZXNz Iik7CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCg==