201042 2019-08-22 09:46:02 -0700 Web Inspector: REGRESSION(r248485): stack overflow when viewing a source map generated from inline content 2019-08-22 18:07:50 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue graouts hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1564089 0 hi 2019-08-22 09:46:02 -0700 RangeError:​ Maximum call stack size exceeded. (at Object.js:​172:​17)​ dispatchEventToListeners @ Object.js:​172:​17 markAsFinished @ Resource.js:​894:​38 sourceMapResourceLoaded @ SourceMapResource.js:​121:​32 requestContent @ SourceCode.js:​140:​100 _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:​371:​38 _resourceLoadingDidFinish @ ResourceClusterContentView.js:​331:​49 dispatch @ Object.js:​165:​30 dispatchEventToListeners @ Object.js:​172:​17 markAsFinished @ Resource.js:​894:​38 sourceMapResourceLoaded @ SourceMapResource.js:​121:​32 requestContent @ SourceCode.js:​140:​100 _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:​371:​38 _resourceLoadingDidFinish @ ResourceClusterContentView.js:​331:​49 dispatch @ Object.js:​165:​30 dispatchEventToListeners @ Object.js:​172:​17 markAsFinished @ Resource.js:​894:​38 ... 1564090 1 hi 2019-08-22 09:46:12 -0700 <rdar://problem/54509750> 1564099 2 377019 hi 2019-08-22 10:01:46 -0700 Created attachment 377019 Patch I haven't tested this, as I am in the middle of a build, but logically this should work :P 1564206 3 377019 joepeck 2019-08-22 13:57:54 -0700 Comment on attachment 377019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377019&action=review > Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:87 > + return Promise.resolve().then(sourceMapResourceLoaded.bind(this, {content: inlineContent, mimeType: this.mimeType, statusCode: 200})); I like this solution! I noticed this the other day and did something similar but this is even better! 1564343 4 377019 commit-queue 2019-08-22 18:07:48 -0700 Comment on attachment 377019 Patch Clearing flags on attachment: 377019 Committed r249037: <https://trac.webkit.org/changeset/249037> 1564344 5 commit-queue 2019-08-22 18:07:50 -0700 All reviewed patches have been landed. Closing bug. 377019 2019-08-22 10:01:46 -0700 2019-08-22 18:07:48 -0700 Patch 201042.diff text/plain 2562 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFmYzg4ZDA3ODFiLi42OTg3Nzg5NWU0NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTktMDgtMjIgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT04ocjI0ODQ4NSk6IHN0YWNrIG92ZXJmbG93IHdoZW4gdmlld2luZyBhIHNvdXJjZSBt YXAgZ2VuZXJhdGVkIGZyb20gaW5saW5lIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMTA0MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NTQ1MDk3NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW4gcjI0ODQ4NSwgYFdJLlJlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3YCB3YXMgY2hhbmdl ZCB0byBgcmVxdWVzdENvbnRlbnRgIHdoZW5ldmVyIHRoZQorICAgICAgICBnaXZlbiByZXNvdXJj ZSBmaW5pc2hlZCBsb2FkaW5nIChieSBsaXN0ZW5pbmcgZm9yIGBXSS5SZXNvdXJjZS5FdmVudC5M b2FkaW5nRGlkRmluaXNoYCkuCisKKyAgICAgICAgRXZlbiB0aG91Z2ggcmV0cmlldmluZyBhIHNv dXJjZSBtYXAncyBjb250ZW50cyB1c2VzIGBQcm9taXNlYHMsIGluIHRoZSBjYXNlIHRoYXQgdGhl IGNvbnRlbnQKKyAgICAgICAgd2FzIGlubGluZWQgaW4gdGhlICJvcmlnaW5hbCIgc291cmNlIGNv ZGUsIHRoZSBjb2RlIHBhdGggd291bGQgbWFyayB0aGUgc291cmNlIG1hcCBhcyBiZWluZworICAg ICAgICBmaW5pc2hlZCAod2hpY2ggd291bGQgZmlyZSBhIGBXSS5SZXNvdXJjZS5FdmVudC5Mb2Fk aW5nRGlkRmluaXNoYCkgX2JlZm9yZV8gaXQgY291bGQgcmV0dXJuCisgICAgICAgIGEgYFByb21p c2VgLCB3aGljaCB3b3VsZCd2ZSBiZWVuIGNhY2hlZCAoYFdJLlNvdXJjZUNvZGUucHJvdG90eXBl LnJlcXVlc3RDb250ZW50YCkgYW5kCisgICAgICAgIHByZXZlbnRlbmQgYW55IHJlZW50cmFuY3ku CisKKyAgICAgICAgV3JhcHBpbmcgdGhlIGlubGluZSBjb2RlIHBhdGggaW4gYSBgUHJvbWlzZS5y ZXNvbHZlKClgIGdpdmVzIHRoZSBgV0kuU291cmNlQ29kZWAgYSBjaGFuY2UgdG8KKyAgICAgICAg Y2FjaGUgdGhlIGBQcm9taXNlYCBiZWZvcmUgYW55IGV2ZW50cyBhcmUgZmlyZWQuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qczoKKyAgICAgICAg KFdJLlNvdXJjZU1hcFJlc291cmNlLnByb3RvdHlwZS5yZXF1ZXN0Q29udGVudEZyb21CYWNrZW5k KToKKwogMjAxOS0wOC0yMSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSVEw6IERPTSBvdXRsaW5lIGluIEVsZW1lbnRzIHRh YiBzaG91bGQgYmUgTFRSCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvU291cmNlTWFwUmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNlTWFwUmVzb3VyY2UuanMKaW5kZXggY2MwOGRl NTQ2M2MuLmUxMzMzYTRkNzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvU291cmNlTWFwUmVzb3VyY2UuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzCkBAIC04 NCw3ICs4NCw3IEBAIFdJLlNvdXJjZU1hcFJlc291cmNlID0gY2xhc3MgU291cmNlTWFwUmVzb3Vy Y2UgZXh0ZW5kcyBXSS5SZXNvdXJjZQogICAgICAgICAgICAgLy8gRm9yY2UgaW5saW5lIGNvbnRl bnQgdG8gYmUgYXN5bmNocm9ub3VzIHRvIG1hdGNoIHRoZSBleHBlY3RlZCBsb2FkIHBhdHRlcm4u CiAgICAgICAgICAgICAvLyBGSVhNRTogV2UgZG9uJ3Qga25vdyB0aGUgTUlNRS10eXBlIGZvciBp bmxpbmUgY29udGVudC4gR3Vlc3MgYnkgYW5hbHl6aW5nIHRoZSBjb250ZW50PwogICAgICAgICAg ICAgLy8gUmV0dXJucyBhIHByb21pc2UuCi0gICAgICAgICAgICByZXR1cm4gc291cmNlTWFwUmVz b3VyY2VMb2FkZWQuY2FsbCh0aGlzLCB7Y29udGVudDogaW5saW5lQ29udGVudCwgbWltZVR5cGU6 IHRoaXMubWltZVR5cGUsIHN0YXR1c0NvZGU6IDIwMH0pOworICAgICAgICAgICAgcmV0dXJuIFBy b21pc2UucmVzb2x2ZSgpLnRoZW4oc291cmNlTWFwUmVzb3VyY2VMb2FkZWQuYmluZCh0aGlzLCB7 Y29udGVudDogaW5saW5lQ29udGVudCwgbWltZVR5cGU6IHRoaXMubWltZVR5cGUsIHN0YXR1c0Nv ZGU6IDIwMH0pKTsKICAgICAgICAgfQogCiAgICAgICAgIGZ1bmN0aW9uIHNvdXJjZU1hcFJlc291 cmNlTm90QXZhaWxhYmxlKGVycm9yLCBjb250ZW50LCBtaW1lVHlwZSwgc3RhdHVzQ29kZSkK