201040 2019-08-22 08:58:43 -0700 Make MediaStreamTrackPrivate RefCounted 2019-08-27 00:39:20 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez commit-queue darin eric.carlson webkit-bug-importer youennf oldest_to_newest 1564067 0 youennf 2019-08-22 08:58:43 -0700 There is no need to ref MediaStreamTrackPrivate on a background thread 1564069 1 377013 youennf 2019-08-22 09:00:47 -0700 Created attachment 377013 Patch 1564502 2 377013 darin 2019-08-23 10:42:37 -0700 Comment on attachment 377013 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377013&action=review I’m going to say review+, but I am just taking your word for it that this is correct. > Source/WebCore/ChangeLog:3 > + Make MediaStreamTrackPrivate RefCounted Really need a "why" comment in the change log. I think it’s "MediaStreamTrackPrivate does not need to be ThreadSafeRefCounted because all use of these objects including ref/deref is on the main thread." 1564924 3 377240 youennf 2019-08-26 05:58:37 -0700 Created attachment 377240 Improved change log 1565277 4 377240 commit-queue 2019-08-27 00:38:47 -0700 Comment on attachment 377240 Improved change log Clearing flags on attachment: 377240 Committed r249134: <https://trac.webkit.org/changeset/249134> 1565278 5 commit-queue 2019-08-27 00:38:49 -0700 All reviewed patches have been landed. Closing bug. 1565279 6 webkit-bug-importer 2019-08-27 00:39:20 -0700 <rdar://problem/54738510> 377013 2019-08-22 09:00:47 -0700 2019-08-26 05:58:33 -0700 Patch bug-201040-20190822180046.patch text/plain 1655 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY2MzVlZTkyNjJmMDk0 ZmY5NjJiZDU4MTQ5NmUzNzM0NzE0ZjNiMC4uNTgyZGMyNzllNTY5NTYxZmU1N2MzZDU1N2E1MDMy NTdiYzM3MDZmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA4LTIyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIE1lZGlhU3RyZWFt VHJhY2tQcml2YXRlIFJlZkNvdW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMTA0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG9ic2VydmFibGUgY2hhbmdlIG9mIGJlaGF2aW9yLgorCisgICAg ICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuaDoKKwog MjAxOS0wOC0yMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSBXZWFrUHRyRmFjdG9yeUluaXRpYWxpemF0aW9u OjpFYWdlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh c3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmgKaW5kZXggNTczN2U0MDEzOWQyYzc3NGJl MmZlMDJjM2MyYWQwYTJmMjkyNjQxMC4uOTI1ZDg3ODk5YmUzM2YzODZiMzgxODJhNzMwMTk3OGI0 YjViOTdjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZS5oCkBAIC0zMSw2ICszMSw3IEBACiAK ICNpbmNsdWRlICJSZWFsdGltZU1lZGlhU291cmNlLmgiCiAjaW5jbHVkZSA8d3RmL0xvZ2dlckhl bHBlci5oPgorI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAjaW5jbHVkZSA8d3RmL1dlYWtQ dHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNDIsNyArNDMsNyBAQCBjbGFzcyBSZWFs dGltZU1lZGlhU291cmNlQ2FwYWJpbGl0aWVzOwogY2xhc3MgV2ViQXVkaW9Tb3VyY2VQcm92aWRl cjsKIAogY2xhc3MgTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUgZmluYWwKLSAgICA6IHB1YmxpYyBU aHJlYWRTYWZlUmVmQ291bnRlZDxNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSwgV1RGOjpEZXN0cnVj dGlvblRocmVhZDo6TWFpbj4KKyAgICA6IHB1YmxpYyBSZWZDb3VudGVkPE1lZGlhU3RyZWFtVHJh Y2tQcml2YXRlPgogICAgICwgcHVibGljIENhbk1ha2VXZWFrUHRyPE1lZGlhU3RyZWFtVHJhY2tQ cml2YXRlLCBXZWFrUHRyRmFjdG9yeUluaXRpYWxpemF0aW9uOjpFYWdlcj4KICAgICAsIHB1Ymxp YyBSZWFsdGltZU1lZGlhU291cmNlOjpPYnNlcnZlcgogI2lmICFSRUxFQVNFX0xPR19ESVNBQkxF RAo= 377240 2019-08-26 05:58:37 -0700 2019-08-27 00:38:47 -0700 Improved change log bug-201040-20190826145836.patch text/plain 1974 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5MDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ2NjdiMTVmMjZiZmE4 NmRiNWYyMDFlYTlmZmQ1NzExZjM1MGQyMy4uODE2OGI3YWU0MDM3YjVlOTUwZGVjMGZjMTg3ZmQx Yjg3OWJmYmU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA4LTI2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIE1lZGlhU3RyZWFt VHJhY2tQcml2YXRlIFJlZkNvdW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMTA0MAorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgIE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlIHNob3VsZCBub3QgYmUgcmVmL2Rl cmVmIGV4Y2VwdCBmcm9tIHRoZSBtYWluIHRocmVhZC4KKyAgICAgICAgVGhlIG9ubHkgbWV0aG9k IGNhbGxlZCBmcm9tIGEgYmFja2dyb3VuZCB0aHJlYWQgaXMgYXVkaW9TYW1wbGVzQXZhaWxhYmxl IGluIHdoaWNoCisgICAgICAgIGl0IGlzIHVuc2FmZSB0byByZWYgYSBNZWRpYVN0cmVhbVRyYWNr UHJpdmF0ZS4KKyAgICAgICAgTWFrZSB0aGUgdHJhY2sgUmVmQ291bnRlZCB3aWxsIGVuc3VyZSB0 aGF0IG5vIHJlZi9kZXJlZiBpcyBtYWRlIGluIGJhY2tncm91bmQgdGhyZWFkcy4KKyAgICAgICAg Tm8gb2JzZXJ2YWJsZSBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZS5oOgorCiAyMDE5LTA4LTI2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBNZXNzYWdlUG9ydCBzaG91 bGQgYmUgV2Vha1B0ckZhY3RvcnlJbml0aWFsaXphdGlvbjo6RWFnZXIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRl LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNr UHJpdmF0ZS5oCmluZGV4IDU3MzdlNDAxMzlkMmM3NzRiZTJmZTAyYzNjMmFkMGEyZjI5MjY0MTAu LjkyNWQ4Nzg5OWJlMzNmMzg2YjM4MTgyYTczMDE5NzhiNGI1Yjk3YzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1U cmFja1ByaXZhdGUuaApAQCAtMzEsNiArMzEsNyBAQAogCiAjaW5jbHVkZSAiUmVhbHRpbWVNZWRp YVNvdXJjZS5oIgogI2luY2x1ZGUgPHd0Zi9Mb2dnZXJIZWxwZXIuaD4KKyNpbmNsdWRlIDx3dGYv UmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9XZWFrUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKQEAgLTQyLDcgKzQzLDcgQEAgY2xhc3MgUmVhbHRpbWVNZWRpYVNvdXJjZUNhcGFiaWxp dGllczsKIGNsYXNzIFdlYkF1ZGlvU291cmNlUHJvdmlkZXI7CiAKIGNsYXNzIE1lZGlhU3RyZWFt VHJhY2tQcml2YXRlIGZpbmFsCi0gICAgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8TWVk aWFTdHJlYW1UcmFja1ByaXZhdGUsIFdURjo6RGVzdHJ1Y3Rpb25UaHJlYWQ6Ok1haW4+CisgICAg OiBwdWJsaWMgUmVmQ291bnRlZDxNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZT4KICAgICAsIHB1Ymxp YyBDYW5NYWtlV2Vha1B0cjxNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSwgV2Vha1B0ckZhY3RvcnlJ bml0aWFsaXphdGlvbjo6RWFnZXI+CiAgICAgLCBwdWJsaWMgUmVhbHRpbWVNZWRpYVNvdXJjZTo6 T2JzZXJ2ZXIKICNpZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQK