201019 2019-08-21 18:43:08 -0700 Migrate from m_styleRecalcTimer to scheduled rendering updates 2026-01-12 09:08:41 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=201018 https://bugs.webkit.org/show_bug.cgi?id=208780 https://bugs.webkit.org/show_bug.cgi?id=222655 P2 Normal --- 202843 1 simon.fraser webkit-unassigned bfulgham ggaren graouts koivisto rniwa sabouhallawa simon.fraser zalan oldest_to_newest 1563884 0 simon.fraser 2019-08-21 18:43:08 -0700 We should be able to remove the m_styleRecalcTimer and just schedule rendering updates now (via RenderingUpdateScheduler). 1716297 1 simon.fraser 2020-12-22 11:55:22 -0800 There's a problem with this. We rely on style updates from this timer to reach the "visually non-empty" state, which is necessary to unfreeze the layer tree. When the layer tree is frozen, TiledCoreAnimationDrawingArea::triggerRenderingUpdate() bails early so we get stuck. 1716300 2 simon.fraser 2020-12-22 11:57:26 -0800 I think we’d have to move layer tree freezing into webcore, and have Page::updateRendering() do the first layout, but bail early when the tree is frozen 1716311 3 rniwa 2020-12-22 12:20:54 -0800 (In reply to Simon Fraser (smfr) from comment #2) > I think we’d have to move layer tree freezing into webcore, and have > Page::updateRendering() do the first layout, but bail early when the tree is > frozen I think this is backwards. Instead of moving layer tree freezing into WebCore and letting TiledCoreAnimationDrawingArea::triggerRenderingUpdate invoke updateRendering just to make a progress in the "visually non-empty" state, TiledCoreAnimationDrawingArea::updateRendering should just know this is happening and trigger the initial layout anyway. So add something like Page::updateRenderingForFirstTimeIfNeeded and always call that when the layer tree is frozen. 1716342 4 simon.fraser 2020-12-22 13:13:38 -0800 But why not make layer tree freezing (bad name) a webcore feature, rather than a webkit feature? All ports could benefit. 1716363 5 simon.fraser 2020-12-22 13:47:13 -0800 fast/events/onunload-not-on-body.html is the test that broke 1716437 6 rniwa 2020-12-23 00:23:34 -0800 (In reply to Simon Fraser (smfr) from comment #4) > But why not make layer tree freezing (bad name) a webcore feature, rather > than a webkit feature? All ports could benefit. You mean the logic to avoid painting when there is a page load happening? Don't we also use it for other purposes too? It's unclear to me what we call as layer tree freezing is what we want across all the ports. I suspect there is a subset of things it does like skipping rendering updating steps and/or painting that might be beneficial across ports. If you're talking about extracting it and moving it to WebCore, that does seem reasonable but it would be a lot bigger engineering task then.