201012 2019-08-21 16:26:15 -0700 perf/clone-with-focus.html is a flaky failure 2019-08-21 22:56:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 repstein rniwa ap cdumez dino koivisto rniwa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1563793 0 repstein 2019-08-21 16:26:15 -0700 The following layout test is a flaky failure on iOS: perf/clone-with-focus.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=perf%2Fclone-with-focus.html We have some failures such as: -PASS. Cloning elements takes roughly as long with as without focus. +FAIL. Cloning 1000 elements with focus took 1ms, without took 0ms. Where a difference of 1ms leads to a fail, leading to flakiness, which seems wrong given the nature of the test. Other failures (such as the provided diff) have slightly larger time differences. Spoke with Ryosuke offline, who said the following: "I think the test is written to fail when cloning with focus is twice is as slow as closing without focus. However, the issue is that the bot / WebKit has gotten fast enough that cloning without focus finishes within 0ms. So twice of that is still 0ms. We need to increase the number of cloning steps such that the measurement for cloning without focus is at least 10ms." Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/perf/clone-with-focus-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/perf/clone-with-focus-actual.txt @@ -1,2 +1,2 @@ -PASS. Cloning elements takes roughly as long with as without focus. +FAIL. Cloning 1000 elements with focus took 5ms, without took 2ms. 1563794 1 webkit-bug-importer 2019-08-21 16:26:51 -0700 <rdar://problem/54577399> 1563795 2 webkit-bug-importer 2019-08-21 16:26:54 -0700 <rdar://problem/54577402> 1563818 3 376951 rniwa 2019-08-21 17:10:59 -0700 Created attachment 376951 Fixes the test 1563819 4 376951 rniwa 2019-08-21 17:11:30 -0700 Comment on attachment 376951 Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=376951&action=review > LayoutTests/perf/clone-with-focus.html:34 > + listElement.appendChild(originalItem); This makes the test run faster. 1563960 5 rniwa 2019-08-21 22:50:22 -0700 Thanks! 1563961 6 rniwa 2019-08-21 22:51:55 -0700 Committed r248996: <https://trac.webkit.org/changeset/248996> 376951 2019-08-21 17:10:59 -0700 2019-08-21 21:59:23 -0700 Fixes the test bug-201012-20190821171059.patch text/plain 2991 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI0ODk3NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA4LTIxICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIExheW91dCBUZXN0IHBlcmYvY2xvbmUtd2l0aC1m b2N1cy5odG1sIGlzIGEgRmxha3kgRmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAxMDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGZsYWtpbmVzcyB3YXMgb2JzZXJ2ZWQgd2hlbiB0aGUg dGltZSB0byBjbG9uZSBlbGVtZW50cyB3aXRob3V0IGZvY3VzIGlzIDBtcworICAgICAgICBidXQg dGhlIHRpbWUgdG8gY2xvbmUgZWxlbWVudHMgd2l0aCBmb2N1cyBpcyAxbXMgb3IgZ3JlYXRlci4K KworICAgICAgICBUaGUgdGVzdCB0cmllcyB0byBtYWtlIHN1cmUgdGhlIHRpbWUgdG8gY2xvbmUg ZWxlbWVudHMgd2l0aCBmb3VjcyBpcyBsZXNzIHRoYW4gMngKKyAgICAgICAgb2YgdGhlIHRpbWUg dG8gY2xvbmUgZWxlbWVudHMgd2l0aG91dCBmb2N1cy4gV2hlbiB0aGUgdGltZSB0byBjbG9uZSB3 aXRob3V0IGZvY3VzCisgICAgICAgIGlzIDBtcywgYW55IGRpZmZlcmVuY2UgaXMgYWx3YXlzIG1v cmUgdGhhbiAyeCBsYXJnZXIuCisKKyAgICAgICAgRml4ZWQgdGhlIHRlc3QgYnkgaW5jcmVhc2lu ZyB0aGUgbnVtYmVyIG9mIGVsZW1lbnRzIHVudGlsIHRoZSB0aW1lIHRvIGNsb25lIHdpdGhvdXQK KyAgICAgICAgZm9jdXMgdGFrZXMgYXQgbGVhc3QgNW1zLgorCisgICAgICAgICogcGVyZi9jbG9u ZS13aXRoLWZvY3VzLmh0bWw6CisKIDIwMTktMDgtMjEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01haWxdIFRhcHBpbmcgdG9wIG9mIG1lc3NhZ2Ug c2Nyb2xscyBiYWNrIHRvIGNvcGllZCB0ZXh0IGluc3RlYWQgb2YgdG9wIG9mIHRoZSBtZXNzYWdl CkluZGV4OiBMYXlvdXRUZXN0cy9wZXJmL2Nsb25lLXdpdGgtZm9jdXMuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wZXJmL2Nsb25lLXdpdGgtZm9jdXMuaHRtbAkocmV2aXNpb24gMjQ4 OTMzKQorKysgTGF5b3V0VGVzdHMvcGVyZi9jbG9uZS13aXRoLWZvY3VzLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTE3LDIxICsxNywyMiBAQAogICAgICAgICB7CiAgICAgICAgICAgICBpZiAoZm9j dXNJbnB1dCkKICAgICAgICAgICAgICAgICBpbnB1dEVsZW1lbnQuZm9jdXMoKTsKLSAgICAgICAg ICAgICAgICAKLSAgICAgICAgICAgIHZhciBzdGFydFRpbWUgPSBEYXRlLm5vdygpOworCisgICAg ICAgICAgICB2YXIgc3RhcnRUaW1lID0gcGVyZm9ybWFuY2Uubm93KCk7CiAgICAgICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IG51bWJlck9mRWxlbWVudHM7IGkrKykgewogICAgICAgICAgICAg ICAgIHZhciBjbG9uZSA9IHRlbXBsYXRlRWxlbWVudC5jbG9uZU5vZGUodHJ1ZSk7CiAgICAgICAg ICAgICAgICAgY2xvbmUuY2hpbGROb2Rlc1swXS50ZXh0Q29udGVudCA9IGk7CiAgICAgICAgICAg ICAgICAgbGlzdEVsZW1lbnQuYXBwZW5kQ2hpbGQoY2xvbmUpOwogICAgICAgICAgICAgfQotICAg ICAgICAgICAgdmFyIGVuZFRpbWUgPSBEYXRlLm5vdygpOwotICAgICAgICAgICAgCisgICAgICAg ICAgICB2YXIgZW5kVGltZSA9IHBlcmZvcm1hbmNlLm5vdygpOworCiAgICAgICAgICAgICBpZiAo Zm9jdXNJbnB1dCkKICAgICAgICAgICAgICAgICBpbnB1dEVsZW1lbnQuYmx1cigpOwotICAgICAg ICAgICAgICAgIAotICAgICAgICAgICAgd2hpbGUgKGxpc3RFbGVtZW50LmZpcnN0Q2hpbGQgIT0g bGlzdEVsZW1lbnQubGFzdENoaWxkKQotICAgICAgICAgICAgICAgIGxpc3RFbGVtZW50LnJlbW92 ZUNoaWxkKGxpc3RFbGVtZW50Lmxhc3RDaGlsZCk7Ci0gICAgICAgICAgICAKKworICAgICAgICAg ICAgY29uc3Qgb3JpZ2luYWxJdGVtID0gbGlzdEVsZW1lbnQuZmlyc3RDaGlsZDsKKyAgICAgICAg ICAgIGxpc3RFbGVtZW50LnRleHRDb250ZW50ID0gJyc7CisgICAgICAgICAgICBsaXN0RWxlbWVu dC5hcHBlbmRDaGlsZChvcmlnaW5hbEl0ZW0pOworCiAgICAgICAgICAgICByZXR1cm4gZW5kVGlt ZSAtIHN0YXJ0VGltZTsKICAgICAgICAgfQogCkBAIC00Miw4ICs0MywxMyBAQAogICAgICAgICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5hcHBlbmRDaGlsZChlbGVtZW50 KTsKICAgICAgICAgfQogCi0gICAgICAgIHZhciB0aW1lV2l0aG91dEZvY3VzID0gdGVzdCgxMDAw LCBmYWxzZSk7Ci0gICAgICAgIHZhciB0aW1lV2l0aEZvY3VzID0gdGVzdCgxMDAwLCB0cnVlKTsK KyAgICAgICAgY29uc3Qgc3RhcnQgPSBwZXJmb3JtYW5jZS5ub3coKTsKKyAgICAgICAgbGV0IGZh Y3RvciA9IDA7CisgICAgICAgIHdoaWxlICh0ZXN0KDEwMDAgKiBmYWN0b3IsIGZhbHNlKSA8IDUp CisgICAgICAgICAgICBmYWN0b3IrKzsKKworICAgICAgICB2YXIgdGltZVdpdGhvdXRGb2N1cyA9 IHRlc3QoMTAwMCAqIGZhY3RvciwgZmFsc2UpOworICAgICAgICB2YXIgdGltZVdpdGhGb2N1cyA9 IHRlc3QoMTAwMCAqIGZhY3RvciwgdHJ1ZSk7CiAKICAgICAgICAgaWYgKE1hdGguYWJzKHRpbWVX aXRoRm9jdXMgLSB0aW1lV2l0aG91dEZvY3VzKSA8PSB0aW1lV2l0aG91dEZvY3VzKSB7CiAgICAg ICAgICAgICBsb2coJ1BBU1MuIENsb25pbmcgZWxlbWVudHMgdGFrZXMgcm91Z2hseSBhcyBsb25n IHdpdGggYXMgd2l0aG91dCBmb2N1cy4nKTsK