201004 2019-08-21 15:50:53 -0700 [ews] Fix capitalization in Found x new Test failure message 2019-08-21 16:52:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1563768 0 aakash_jain 2019-08-21 15:50:53 -0700 Fix capitalization in 'Found x new Test failure' message. It should be 'test' instead of 'Test'. 1563769 1 376942 aakash_jain 2019-08-21 15:57:02 -0700 Created attachment 376942 Patch 1563772 2 ews-watchlist 2019-08-21 15:58:54 -0700 Attachment 376942 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1270: [TestAnalyzeLayoutTestsResults.test_failure_introduced_by_patch] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1270: [TestAnalyzeLayoutTestsResults.test_failure_introduced_by_patch] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1285: [TestAnalyzeLayoutTestsResults.test_flaky_and_consistent_failures_without_clean_tree_failures] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1285: [TestAnalyzeLayoutTestsResults.test_flaky_and_consistent_failures_without_clean_tree_failures] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1353: [TestAnalyzeLayoutTestsResults.test_clean_tree_has_some_failures] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1353: [TestAnalyzeLayoutTestsResults.test_clean_tree_has_some_failures] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1563802 3 376942 commit-queue 2019-08-21 16:51:40 -0700 Comment on attachment 376942 Patch Clearing flags on attachment: 376942 Committed r248975: <https://trac.webkit.org/changeset/248975> 1563803 4 commit-queue 2019-08-21 16:51:41 -0700 All reviewed patches have been landed. Closing bug. 1563804 5 webkit-bug-importer 2019-08-21 16:52:19 -0700 <rdar://problem/54578430> 376942 2019-08-21 15:57:02 -0700 2019-08-21 16:51:40 -0700 Patch bug-201004-20190821185701.patch text/plain 4620 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0ODk3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTA4LTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBGaXggY2FwaXRhbGl6YXRpb24gaW4gRm91bmQgeCBuZXcgVGVz dCBmYWlsdXJlIG1lc3NhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMTAwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAg ICAoQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cy5yZXBvcnRfZmFpbHVyZSk6CisgICAgICAgIChB bmFseXplQVBJVGVzdHNSZXN1bHRzLmFuYWx5emVSZXN1bHRzKToKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6IFVwZGF0ZWQgdW5pdC10ZXN0 cyBhY2NvcmRpbmdseS4KKwogMjAxOS0wOC0yMSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBh cHBsZS5jb20+CiAKICAgICAgICAgQXNzaWduIGV3czExNyB0byBFV1MgSGlnaC1TaWVycmEgRGVi dWcgcXVldWVzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5CShyZXZpc2lvbiAyNDg5NzIpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTEwNjUsNyArMTA2NSw3IEBAIGNsYXNzIEFu YWx5emVMYXlvdXRUZXN0c1Jlc3VsdHMoYnVpbGRzdGUKICAgICAgICAgc2VsZi5idWlsZC5yZXN1 bHRzID0gRkFJTFVSRQogICAgICAgICBwbHVyYWxTdWZmaXggPSAncycgaWYgbGVuKG5ld19mYWls dXJlcykgPiAxIGVsc2UgJycKICAgICAgICAgbmV3X2ZhaWx1cmVzX3N0cmluZyA9ICcsICcuam9p bihbZmFpbHVyZV9uYW1lIGZvciBmYWlsdXJlX25hbWUgaW4gbmV3X2ZhaWx1cmVzXSkKLSAgICAg ICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBuZXcgVGVzdCBmYWlsdXJle306IHt9Jy5mb3JtYXQobGVu KG5ld19mYWlsdXJlcyksIHBsdXJhbFN1ZmZpeCwgbmV3X2ZhaWx1cmVzX3N0cmluZykKKyAgICAg ICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBuZXcgdGVzdCBmYWlsdXJle306IHt9Jy5mb3JtYXQobGVu KG5ld19mYWlsdXJlcyksIHBsdXJhbFN1ZmZpeCwgbmV3X2ZhaWx1cmVzX3N0cmluZykKICAgICAg ICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUgPSBtZXNzYWdlCiAgICAgICAgIHNlbGYuYnVpbGQuYnVp bGRGaW5pc2hlZChbbWVzc2FnZV0sIEZBSUxVUkUpCiAgICAgICAgIHJldHVybiBkZWZlci5zdWNj ZWVkKE5vbmUpCkBAIC0xMzg2LDcgKzEzODYsNyBAQCBjbGFzcyBBbmFseXplQVBJVGVzdHNSZXN1 bHRzKGJ1aWxkc3RlcC5CCiAgICAgICAgICAgICBzZWxmLmZpbmlzaGVkKEZBSUxVUkUpCiAgICAg ICAgICAgICBzZWxmLmJ1aWxkLnJlc3VsdHMgPSBGQUlMVVJFCiAgICAgICAgICAgICBwbHVyYWxT dWZmaXggPSAncycgaWYgbGVuKG5ld19mYWlsdXJlcykgPiAxIGVsc2UgJycKLSAgICAgICAgICAg IG1lc3NhZ2UgPSAnRm91bmQge30gbmV3IEFQSSBUZXN0IGZhaWx1cmV7fToge30nLmZvcm1hdChs ZW4obmV3X2ZhaWx1cmVzKSwgcGx1cmFsU3VmZml4LCBuZXdfZmFpbHVyZXNfc3RyaW5nKQorICAg ICAgICAgICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBuZXcgQVBJIHRlc3QgZmFpbHVyZXt9OiB7fScu Zm9ybWF0KGxlbihuZXdfZmFpbHVyZXMpLCBwbHVyYWxTdWZmaXgsIG5ld19mYWlsdXJlc19zdHJp bmcpCiAgICAgICAgICAgICBzZWxmLmRlc2NyaXB0aW9uRG9uZSA9IG1lc3NhZ2UKICAgICAgICAg ICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIEZBSUxVUkUpCiAgICAgICAg IGVsc2U6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNDg5NzIpCisrKyBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTEy NjcsNyArMTI2Nyw3IEBAIGNsYXNzIFRlc3RBbmFseXplTGF5b3V0VGVzdHNSZXN1bHRzKEJ1aWwK ICAgICAgICAgc2VsZi5jb25maWd1cmVTdGVwKCkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgn Zmlyc3RfcnVuX2ZhaWx1cmVzJywgWyJqcXVlcnkvb2Zmc2V0Lmh0bWwiXSkKICAgICAgICAgc2Vs Zi5zZXRQcm9wZXJ0eSgnc2Vjb25kX3J1bl9mYWlsdXJlcycsIFsianF1ZXJ5L29mZnNldC5odG1s Il0pCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3Ry aW5nPSdGb3VuZCAxIG5ldyBUZXN0IGZhaWx1cmU6IGpxdWVyeS9vZmZzZXQuaHRtbCAoZmFpbHVy ZSknKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0 cmluZz0nRm91bmQgMSBuZXcgdGVzdCBmYWlsdXJlOiBqcXVlcnkvb2Zmc2V0Lmh0bWwgKGZhaWx1 cmUpJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKICAgICBkZWYgdGVzdF9mYWls dXJlX29uX2NsZWFuX3RyZWUoc2VsZik6CkBAIC0xMjgyLDcgKzEyODIsNyBAQCBjbGFzcyBUZXN0 QW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhCdWlsCiAgICAgICAgIHNlbGYuY29uZmlndXJlU3Rl cCgpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2ZpcnN0X3J1bl9mYWlsdXJlcycsIFsndGVz dDEnLCAndGVzdDInXSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnc2Vjb25kX3J1bl9mYWls dXJlcycsIFsndGVzdDEnXSkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlM VVJFLCBzdGF0ZV9zdHJpbmc9J0ZvdW5kIDEgbmV3IFRlc3QgZmFpbHVyZTogdGVzdDEgKGZhaWx1 cmUpJykKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9z dHJpbmc9J0ZvdW5kIDEgbmV3IHRlc3QgZmFpbHVyZTogdGVzdDEgKGZhaWx1cmUpJykKICAgICAg ICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKICAgICBkZWYgdGVzdF9mbGFreV9hbmRfaW5jb25z aXN0ZW50X2ZhaWx1cmVzX3dpdGhvdXRfY2xlYW5fdHJlZV9mYWlsdXJlcyhzZWxmKToKQEAgLTEz NTAsNyArMTM1MCw3IEBAIGNsYXNzIFRlc3RBbmFseXplTGF5b3V0VGVzdHNSZXN1bHRzKEJ1aWwK ICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnc2Vjb25kX3Jlc3VsdHNfZXhjZWVkX2ZhaWx1cmVf bGltaXQnLCBUcnVlKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdzZWNvbmRfcnVuX2ZhaWx1 cmVzJywgWyd0ZXN0e30nLmZvcm1hdChpKSBmb3IgaSBpbiByYW5nZSgwLCAzMCldKQogICAgICAg ICBzZWxmLnNldFByb3BlcnR5KCdjbGVhbl90cmVlX3J1bl9mYWlsdXJlcycsIFsndGVzdHt9Jy5m b3JtYXQoaSkgZm9yIGkgaW4gcmFuZ2UoMCwgMTApXSkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRj b21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0ZvdW5kIDMwIG5ldyBUZXN0IGZhaWx1 cmVzOiB0ZXN0MSwgdGVzdDAsIHRlc3QzLCB0ZXN0MiwgdGVzdDUsIHRlc3Q0LCB0ZXN0NywgdGVz dDYsIHRlc3Q5LCB0ZXN0OCwgdGVzdDI0LCB0ZXN0MjUsIHRlc3QyNiwgdGVzdDI3LCB0ZXN0MjAs IHRlc3QyMSwgdGVzdDIyLCB0ZXN0MjMsIHRlc3QyOCwgdGVzdDI5LCB0ZXN0MTksIHRlc3QxOCwg dGVzdDExLCB0ZXN0MTAsIHRlc3QxMywgdGVzdDEyLCB0ZXN0MTUsIHRlc3QxNCwgdGVzdDE3LCB0 ZXN0MTYgKGZhaWx1cmUpJykKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlM VVJFLCBzdGF0ZV9zdHJpbmc9J0ZvdW5kIDMwIG5ldyB0ZXN0IGZhaWx1cmVzOiB0ZXN0MSwgdGVz dDAsIHRlc3QzLCB0ZXN0MiwgdGVzdDUsIHRlc3Q0LCB0ZXN0NywgdGVzdDYsIHRlc3Q5LCB0ZXN0 OCwgdGVzdDI0LCB0ZXN0MjUsIHRlc3QyNiwgdGVzdDI3LCB0ZXN0MjAsIHRlc3QyMSwgdGVzdDIy LCB0ZXN0MjMsIHRlc3QyOCwgdGVzdDI5LCB0ZXN0MTksIHRlc3QxOCwgdGVzdDExLCB0ZXN0MTAs IHRlc3QxMywgdGVzdDEyLCB0ZXN0MTUsIHRlc3QxNCwgdGVzdDE3LCB0ZXN0MTYgKGZhaWx1cmUp JykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIGNsYXNzIFRlc3RDaGVja091dFNw ZWNpZmljUmV2aXNpb24oQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNl KToK