200994 2019-08-21 13:20:37 -0700 Have NetworkCache::store() null check its completion handler before calling it 2019-08-21 14:30:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen cgarcia commit-queue ews-watchlist ggaren koivisto webkit-bug-importer oldest_to_newest 1563648 0 cdumez 2019-08-21 13:20:37 -0700 Have NetworkCache::store() null check its completion handler before calling it. 1563651 1 376911 cdumez 2019-08-21 13:22:52 -0700 Created attachment 376911 Patch 1563652 2 webkit-bug-importer 2019-08-21 13:23:22 -0700 <rdar://problem/54568933> 1563660 3 376911 ggaren 2019-08-21 13:39:05 -0700 Comment on attachment 376911 Patch r=me 1563687 4 376911 commit-queue 2019-08-21 14:30:13 -0700 Comment on attachment 376911 Patch Clearing flags on attachment: 376911 Committed r248963: <https://trac.webkit.org/changeset/248963> 1563688 5 commit-queue 2019-08-21 14:30:15 -0700 All reviewed patches have been landed. Closing bug. 376911 2019-08-21 13:22:52 -0700 2019-08-21 14:30:13 -0700 Patch bug-200994-20190821132252.patch text/plain 4228 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJlY2M3N2IwYzNjMGZiODdh ZjI4YjJjYjJmNmE4MjcwMTg1MGI3NTIuLmEwZGFjOGJlNDQ5ZjZiNzBhMjU4MjdkMTU2MGU5Y2Qy Y2FkNGRkZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDgtMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBIYXZlIE5ldHdvcmtDYWNoZTo6c3Rv cmUoKSBudWxsIGNoZWNrIGl0cyBjb21wbGV0aW9uIGhhbmRsZXIgYmVmb3JlIGNhbGxpbmcgaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDk5NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29y a1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya1Jlc291cmNlTG9hZGVyOjpyZXRyaWV2ZUNhY2hlRW50cnkpOgorICAgICAgICBTdG9wIHBh c3NpbmcgbnVsbHB0ciBmb3IgdGhlIGNvbXBsZXRpb24gaGFuZGxlciBub3cgdGhhdCB0aGUgcGFy YW1ldGVyIGhhcyBhIGRlZmF1bHQgdmFsdWUuCisgICAgICAgIE5vdGUgdGhhdCBwYXNzaW5nIG51 bGxwdHIgaGVyZSB3YXMgbGlrZWx5IHdyb25nIHNpbmNlIHRoZSBOZXR3b3JrQ2FjaGU6OnN0b3Jl KCkgaW1wbGVtZW50YXRpb24KKyAgICAgICAgZGlkIG5vdCBudWxsLWNoZWNrIHRoZSBjb21wbGV0 aW9uIGhhbmRsZXIgYmVmb3JlIGNhbGxpbmcgaXQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6 OkNhY2hlOjpzdG9yZSk6CisgICAgICAgIEhhdmUgTmV0d29ya0NhY2hlOjpzdG9yZSgpIG51bGwg Y2hlY2sgaXRzIGNvbXBsZXRpb24gaGFuZGxlciBiZWZvcmUgY2FsbGluZyBpdCBhcyBjYWxsaW5n CisgICAgICAgIGEgbnVsbCBXVEY6OkZ1bmN0aW9uIGNyYXNoZXMuCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuaDoKKyAgICAgICAgVXNlIG51bGxwdHIgYXMg ZGVmYXVsdCBwYXJhbWV0ZXIgdmFsdWUgZm9yIHRoZSBjb21wbGV0aW9uIGhhbmRsZXIuCisKIDIw MTktMDgtMjEgIFJ1c3NlbGwgRXBzdGVpbiAgPHJlcHN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQ4OTQyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IGFhZWM3 MmViM2FlMmRkY2Y5ZTYzMDY4YWI5NDAwNDM2NzIxYWY3ZDEuLmYwYWZiY2NjNTRhY2RlYTY1NDFh NmUxMTg3NDc1YWU0MmJiNGRlYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTIzMiw3ICsyMzIsNyBAQCB2 b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6cmV0cmlldmVDYWNoZUVudHJ5KGNvbnN0IFJlc291 cmNlUmVxdWVzdCYgcmVxdWVzdCkKICAgICAgICAgICAgICAgICBhdXRvIGJ1ZmZlciA9IGVudHJ5 LT5yZWxlYXNlQnVmZmVyKCk7CiAgICAgICAgICAgICAgICAgYXV0byBjYWNoZUVudHJ5ID0gbV9j YWNoZS0+bWFrZUVudHJ5KHJlcXVlc3QsIGVudHJ5LT5yZXNwb25zZSwgYnVmZmVyLmNvcHlSZWYo KSk7CiAgICAgICAgICAgICAgICAgcmV0cmlldmVDYWNoZUVudHJ5SW50ZXJuYWwoV1RGTW92ZShj YWNoZUVudHJ5KSwgUmVzb3VyY2VSZXF1ZXN0IHsgcmVxdWVzdCB9KTsKLSAgICAgICAgICAgICAg ICBtX2NhY2hlLT5zdG9yZShyZXF1ZXN0LCBlbnRyeS0+cmVzcG9uc2UsIFdURk1vdmUoYnVmZmVy KSwgbnVsbHB0cik7CisgICAgICAgICAgICAgICAgbV9jYWNoZS0+c3RvcmUocmVxdWVzdCwgZW50 cnktPnJlc3BvbnNlLCBXVEZNb3ZlKGJ1ZmZlcikpOwogICAgICAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgICAgIH0KICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCmluZGV4IGIwODNkNWQzMmE1MWU2MWRhNDM3 NmRmOTQ0NmVmMTExNGVhNmJmMTIuLjc2ZWYxY2JlZmU5NGFlZmQ4ZmJhMTFlOGU2M2EyZWY5Y2I3 ZWJmMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05l dHdvcmtDYWNoZS5jcHAKQEAgLTQxNSw3ICs0MTUsOCBAQCBzdGQ6OnVuaXF1ZV9wdHI8RW50cnk+ IENhY2hlOjpzdG9yZShjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIGNv bgogICAgICAgICAgICAgbWFwcGVkQm9keS5zaGFyZWFibGVSZXNvdXJjZS0+Y3JlYXRlSGFuZGxl KG1hcHBlZEJvZHkuc2hhcmVhYmxlUmVzb3VyY2VIYW5kbGUpOwogICAgICAgICB9CiAjZW5kaWYK LSAgICAgICAgY29tcGxldGlvbkhhbmRsZXIobWFwcGVkQm9keSk7CisgICAgICAgIGlmIChjb21w bGV0aW9uSGFuZGxlcikKKyAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKG1hcHBlZEJvZHkp OwogICAgICAgICBMT0coTmV0d29ya0NhY2hlLCAiKE5ldHdvcmtQcm9jZXNzKSBzdG9yZWQiKTsK ICAgICB9KTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGUuaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlLmgKaW5kZXggODVkMTAwY2E2YzdjMDVmYjhjM2QxMmQwM2E0NDAyODExMDM5NWVm OS4uNTQyYTAyNjk5MDAzN2E0YWEwMTNkNWYwOWZhZTJkMjBlZGFhZWQyYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuaAorKysgYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5oCkBAIC0xMTUs NyArMTE1LDcgQEAgcHVibGljOgogICAgIH07CiAgICAgdXNpbmcgUmV0cmlldmVDb21wbGV0aW9u SGFuZGxlciA9IEZ1bmN0aW9uPHZvaWQoc3RkOjp1bmlxdWVfcHRyPEVudHJ5PiwgY29uc3QgUmV0 cmlldmVJbmZvJik+OwogICAgIHZvaWQgcmV0cmlldmUoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VS ZXF1ZXN0JiwgY29uc3QgR2xvYmFsRnJhbWVJRCYsIFJldHJpZXZlQ29tcGxldGlvbkhhbmRsZXIm Jik7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPEVudHJ5PiBzdG9yZShjb25zdCBXZWJDb3JlOjpSZXNv dXJjZVJlcXVlc3QmLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiwgUmVmUHRyPFdl YkNvcmU6OlNoYXJlZEJ1ZmZlcj4mJiwgRnVuY3Rpb248dm9pZChNYXBwZWRCb2R5Jik+JiYpOwor ICAgIHN0ZDo6dW5pcXVlX3B0cjxFbnRyeT4gc3RvcmUoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VS ZXF1ZXN0JiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYsIFJlZlB0cjxXZWJDb3Jl OjpTaGFyZWRCdWZmZXI+JiYsIEZ1bmN0aW9uPHZvaWQoTWFwcGVkQm9keSYpPiYmID0gbnVsbHB0 cik7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEVudHJ5PiBzdG9yZVJlZGlyZWN0KGNvbnN0IFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmLCBj b25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIHJlZGlyZWN0UmVxdWVzdCwgT3B0aW9uYWw8 U2Vjb25kcz4gbWF4QWdlQ2FwKTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8RW50cnk+IHVwZGF0ZShj b25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBHbG9iYWxGcmFtZUlEJiwgY29u c3QgRW50cnkmLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiB2YWxpZGF0aW5nUmVz cG9uc2UpOwogCg==