20099 2008-07-18 13:49:50 -0700 [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection 2008-08-27 18:42:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Minor --- 1 camaradetux camaradetux oldest_to_newest 86367 0 camaradetux 2008-07-18 13:49:50 -0700 Using SHIFT and UP/DOWN or HOME/END correctly extends selection but not with PAGE_UP/PAGE_DOWN. There's no bug, just no implementation. I'm attaching a trivial patch which is basically an adaptation of the code for up/down which is written just before. 86368 1 22374 camaradetux 2008-07-18 13:55:52 -0700 Created attachment 22374 Trivial patch changing call to frame->selection()->modify instead of frame->editor()->command A fairly simple patch which is basically a copy of what was written for the handling of up/down. I'm not sure the proper granularity is ParagraphGranularity though. 86650 2 pierre-luc.beaudoin 2008-07-22 07:51:05 -0700 Based on GEdit's behavior, ParagraphGranularity isn't ok. But considering that Firefox doesn't implement this, it might be ok. 86666 3 22431 camaradetux 2008-07-22 10:48:59 -0700 Created attachment 22431 new version with the proper granularity (simpler btw) The granulariy is now correct. The proper thing was already available but I was not aware of its existence. The patch is also simpler. Basically this patch changes "MovePageUp" to kevent->shiftKey() ? "MovePageUpAndModifySelection" : "MovePageUp" 87005 4 22431 sam 2008-07-26 14:55:18 -0700 Comment on attachment 22431 new version with the proper granularity (simpler btw) This looks ok, but it needs a changelog, and depending on the state of DRT for the GTK port a regression test as well. 87006 5 christian 2008-07-26 15:06:14 -0700 The new lines are indentend with tabs, but you should only use spaces in WebCore. When you address Sam's comments, please fix that as well. Otherwise the patch works as expected from a little testing. 89126 6 22942 camaradetux 2008-08-22 10:17:52 -0700 Created attachment 22942 Same as before plus the changelog entry Finally updated the patch with a changelog and spaces (damn default configuration !). 89552 7 22942 eric 2008-08-27 16:14:15 -0700 Comment on attachment 22942 Same as before plus the changelog entry I'm assuming that it's impossible to test this with DumpRenderTreeGtk. Looks sane enough. 89589 8 zecke 2008-08-27 18:42:27 -0700 Looked sane and landed in r35958. 22374 2008-07-18 13:55:52 -0700 2008-07-22 10:48:59 -0700 Trivial patch changing call to frame->selection()->modify instead of frame->editor()->command shift-pageup-pagedown-extends-selection.patch text/plain 1113 camaradetux ZGlmZiAtTnJ1IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3Bw IGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCi0tLSBhL1dl YktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcAkyMDA4LTA2LTE2IDIz OjIxOjMxLjAwMDAwMDAwMCArMDIwMAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAJMjAwOC0wNy0xOCAyMjo1MjoxMy4xODk3NjEyNzUgKzAyMDAKQEAg LTMxNywxMCArMzE3LDE2IEBACiAgICAgICAgICAgICAgICAgICAgICAgICB0cnVlKTsKICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgVktfUFJJT1I6ICAvLyBQYWdlVXAK LSAgICAgICAgICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIk1vdmVQYWdlVXAiKS5l eGVjdXRlKCk7CisJCWZyYW1lLT5zZWxlY3Rpb24oKS0+bW9kaWZ5KGtldmVudC0+c2hpZnRLZXko KSA/IFNlbGVjdGlvbkNvbnRyb2xsZXI6OkVYVEVORCA6IFNlbGVjdGlvbkNvbnRyb2xsZXI6Ok1P VkUsCisgICAgICAgICAgICAgICAgICAgICAgICBTZWxlY3Rpb25Db250cm9sbGVyOjpCQUNLV0FS RCwKKwkJCVBhcmFncmFwaEdyYW51bGFyaXR5LAorCQkJdHJ1ZSk7CiAgICAgICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgICAgICBjYXNlIFZLX05FWFQ6ICAvLyBQYWdlRG93bgotICAgICAgICAg ICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92ZVBhZ2VEb3duIikuZXhlY3V0ZSgp OworCQlmcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlmeShrZXZlbnQtPnNoaWZ0S2V5KCkgPyBTZWxl Y3Rpb25Db250cm9sbGVyOjpFWFRFTkQgOiBTZWxlY3Rpb25Db250cm9sbGVyOjpNT1ZFLAorICAg ICAgICAgICAgICAgICAgICAgICAgU2VsZWN0aW9uQ29udHJvbGxlcjo6Rk9SV0FSRCwKKwkJCVBh cmFncmFwaEdyYW51bGFyaXR5LAorCQkJdHJ1ZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgICAgICBjYXNlIFZLX0hPTUU6CiAgICAgICAgICAgICAgICAgaWYgKGtldmVudC0+Y3Ry bEtleSgpICYmIGtldmVudC0+c2hpZnRLZXkoKSkK 22431 2008-07-22 10:48:59 -0700 2008-08-22 10:17:52 -0700 new version with the proper granularity (simpler btw) shift-pageup-pagedown-extends-selection-version2.patch text/plain 988 camaradetux ZGlmZiAtTnJ1IFdlYktpdC1yMzUyMzEub2xkL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRp dG9yQ2xpZW50R3RrLmNwcCBiL1dlYktpdC1yMzUyMzEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRHdGsuY3BwCi0tLSBXZWJLaXQtcjM1MjMxLm9sZC9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAJMjAwOC0wNi0xNiAyMzoyMTozMS4wMDAw MDAwMDAgKzAyMDAKKysrIFdlYktpdC1yMzUyMzEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRHdGsuY3BwCTIwMDgtMDctMjIgMTk6MjY6MjUuNzQyNTUyNDc3ICswMjAwCkBA IC0zMTcsMTAgKzMxNywxMCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSk7CiAgICAg ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIFZLX1BSSU9SOiAgLy8gUGFnZVVw Ci0gICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZVVwIiku ZXhlY3V0ZSgpOworCQlmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoa2V2ZW50LT5zaGlmdEtleSgp ID8gIk1vdmVQYWdlVXBBbmRNb2RpZnlTZWxlY3Rpb24iIDogIk1vdmVQYWdlVXAiKS5leGVjdXRl KCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIFZLX05FWFQ6ICAv LyBQYWdlRG93bgotICAgICAgICAgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiTW92 ZVBhZ2VEb3duIikuZXhlY3V0ZSgpOworCQlmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoa2V2ZW50 LT5zaGlmdEtleSgpID8gIk1vdmVQYWdlRG93bkFuZE1vZGlmeVNlbGVjdGlvbiIgOiAiTW92ZVBh Z2VEb3duIikuZXhlY3V0ZSgpOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg Y2FzZSBWS19IT01FOgogICAgICAgICAgICAgICAgIGlmIChrZXZlbnQtPmN0cmxLZXkoKSAmJiBr ZXZlbnQtPnNoaWZ0S2V5KCkpCg== 22942 2008-08-22 10:17:52 -0700 2008-08-27 16:14:15 -0700 Same as before plus the changelog entry shift-page-up-down-extends-selection.patch text/plain 1439 camaradetux ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggOTM0MzJmZS4uODRhOTUyNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSw5IEBACisyMDA4LTA4LTIyICBB ZHJpZW4gTmFkZXIgIDxjYW1hcmFkZXR1eEBnbWFpbC5jb20+CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA5OQorICAgICAgICBbR1RLXSBTSElGVCtQ QUdFX1VQL0RPV04gZG9lc24ndCBleHRlbmQgc2VsZWN0aW9uCisKKyAgICAgICAgKiB3ZWJraXQg V2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcDoKKwogMjAwOC0wOC0xOCAgQWxwIFRv a2VyICA8YWxwQG51YW50aS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0 aGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRH dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCmlu ZGV4IGUzZDkzNWEuLjgxNTE3YjQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvRWRpdG9yQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAKQEAgLTMxNywxMCArMzE3LDEwIEBAIHZvaWQgRWRpdG9yQ2xpZW50 OjpoYW5kbGVLZXlib2FyZEV2ZW50KEtleWJvYXJkRXZlbnQqIGV2ZW50KQogICAgICAgICAgICAg ICAgICAgICAgICAgdHJ1ZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBj YXNlIFZLX1BSSU9SOiAgLy8gUGFnZVVwCi0gICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigp LT5jb21tYW5kKCJNb3ZlUGFnZVVwIikuZXhlY3V0ZSgpOworICAgICAgICAgICAgICAgIGZyYW1l LT5lZGl0b3IoKS0+Y29tbWFuZChrZXZlbnQtPnNoaWZ0S2V5KCkgPyAiTW92ZVBhZ2VVcEFuZE1v ZGlmeVNlbGVjdGlvbiIgOiAiTW92ZVBhZ2VVcCIpLmV4ZWN1dGUoKTsKICAgICAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgICAgIGNhc2UgVktfTkVYVDogIC8vIFBhZ2VEb3duCi0gICAgICAg ICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKCJNb3ZlUGFnZURvd24iKS5leGVjdXRl KCk7CisgICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5kKGtldmVudC0+c2hp ZnRLZXkoKSA/ICJNb3ZlUGFnZURvd25BbmRNb2RpZnlTZWxlY3Rpb24iIDogIk1vdmVQYWdlRG93 biIpLmV4ZWN1dGUoKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2Ug VktfSE9NRToKICAgICAgICAgICAgICAgICBpZiAoa2V2ZW50LT5jdHJsS2V5KCkgJiYga2V2ZW50 LT5zaGlmdEtleSgpKQo=