200987 2019-08-21 10:54:15 -0700 [GTK][WPE] Gtk-Doc fails with build options which need cooperation between CFLAGS and LDFLAGS 2019-08-21 11:59:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez bugs-noreply cgarcia clopez commit-queue pnormand webkit-bug-importer zan oldest_to_newest 1563554 0 aperez 2019-08-21 10:54:15 -0700 This can be reproduced with a recent enough version of Clang with support for ThinLTO, which *requires* passing -fuse-ld=lld to the linker, and -flto=thin to *both* the compiler and the linker. Failing to pass the linker options results in lld not being used and the GNU Binutils linkers don't understand LLVM bitcode, or in lld being used (if it's the default) but -flto=thin will be missing from the linker command line (not good either). This has gone unnoticed even when some distributions use LTO becase it just *happens* to work with the Binutils linkers: linking object built with -flto wors even if the flag is not passed to the linker. 1563558 1 aperez 2019-08-21 11:00:17 -0700 This can be reproduced by trying to build with the following CMake incantation: CC=clang CXX=clang \ LDFLAGS='-fuse-ld=lld -flto=thin' CFLAGS='-flto=thin' CXXFLAGS='-flto=thin' cmake -DPORT=GTK -DENABLE_GTKDOC=ON <…> 1563569 2 376897 aperez 2019-08-21 11:11:19 -0700 Created attachment 376897 Patch 1563577 3 376897 pnormand 2019-08-21 11:20:11 -0700 Comment on attachment 376897 Patch Looks legit :) 1563596 4 376897 commit-queue 2019-08-21 11:58:19 -0700 Comment on attachment 376897 Patch Clearing flags on attachment: 376897 Committed r248954: <https://trac.webkit.org/changeset/248954> 1563597 5 commit-queue 2019-08-21 11:58:21 -0700 All reviewed patches have been landed. Closing bug. 1563599 6 webkit-bug-importer 2019-08-21 11:59:19 -0700 <rdar://problem/54565709> 376897 2019-08-21 11:11:19 -0700 2019-08-21 11:58:19 -0700 Patch bug-200987-20190821211118.patch text/plain 1900 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvR3Rr RG9jLmNtYWtlIGIvU291cmNlL2NtYWtlL0d0a0RvYy5jbWFrZQppbmRleCAyZWUwNTU1MGI4MTQ0 MmVkYmM2NzNjZTY2ZTdkMmI1YWY3YmU0YmM4Li5iMGZiMzFjYWZhOGFhNmY1ZTI0ZThlMTIzYzQx MzE3MGRiYTI1NDA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvR3RrRG9jLmNtYWtlCisrKyBi L1NvdXJjZS9jbWFrZS9HdGtEb2MuY21ha2UKQEAgLTQsNyArNCw3IEBAIG1hY3JvKEFERF9HVEtE T0NfR0VORVJBVE9SIF9zdGFtcF9uYW1lIF9leHRyYV9hcmdzKQogICAgIGFkZF9jdXN0b21fY29t bWFuZCgKICAgICAgICAgT1VUUFVUICIke0NNQUtFX0JJTkFSWV9ESVJ9LyR7X3N0YW1wX25hbWV9 IgogICAgICAgICBERVBFTkRTICR7RG9jdW1lbnRhdGlvbkRlcGVuZGVuY2llc30KLSAgICAgICAg Q09NTUFORCAke0NNQUtFX0NPTU1BTkR9IC1FIGVudiAiQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSIg IkNGTEFHUz0ke0NNQUtFX0NfRkxBR1N9IC1Xbm8tdW51c2VkLXBhcmFtZXRlciIgJHtDTUFLRV9T T1VSQ0VfRElSfS9Ub29scy9ndGtkb2MvZ2VuZXJhdGUtZ3RrZG9jICR7X2V4dHJhX2FyZ3N9Cisg ICAgICAgIENPTU1BTkQgJHtDTUFLRV9DT01NQU5EfSAtRSBlbnYgIkNDPSR7Q01BS0VfQ19DT01Q SUxFUn0iICJDRkxBR1M9JHtDTUFLRV9DX0ZMQUdTfSAtV25vLXVudXNlZC1wYXJhbWV0ZXIiICJM REZMQUdTPSR7Q01BS0VfRVhFX0xJTktFUl9GTEFHU30iICR7Q01BS0VfU09VUkNFX0RJUn0vVG9v bHMvZ3RrZG9jL2dlbmVyYXRlLWd0a2RvYyAke19leHRyYV9hcmdzfQogICAgICAgICBDT01NQU5E IHRvdWNoICR7X3N0YW1wX25hbWV9CiAgICAgICAgIFdPUktJTkdfRElSRUNUT1JZICIke0NNQUtF X0JJTkFSWV9ESVJ9IgogICAgICAgICBWRVJCQVRJTQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIv Q2hhbmdlTG9nCmluZGV4IGU1YTMzNWU5ZTU3NGJjOTQxY2E0NGQzM2M3YWE4NzZlYjRhMjZmMGMu LjY1MDYzYTE3MzY5NTY3MjllNDdiYmFjZmY5MDUwNTgxZjI4MWUyNjIgMTAwNjQ0Ci0tLSBhL0No YW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOS0wOC0yMSAgQWRy aWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtd W1dQRV0gR3RrLURvYyBmYWlscyB3aXRoIGJ1aWxkIG9wdGlvbnMgd2hpY2ggbmVlZCBjb29wZXJh dGlvbiBiZXR3ZWVuIENGTEFHUyBhbmQgTERGTEFHUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwOTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBDRkxBR1Mgd2FzIGJlaW5nIHNldCBiZWZvcmUg dHJ5aW5nIHRvIGdlbmVyYXRlIHRoZSBkb2N1bWVudGF0aW9uCisgICAgICAgIGJ1dCBub3QgTERG TEFHUywgd2hpY2ggY291bGQgY2F1c2UgZXJyb3JzIHdoZW4gZ3RrLWRvYyB0cmllcyB0byBsaW5r CisgICAgICAgIGEgZ2VuZXJhdGVkIHByb2dyYW0gd2hlbiB0aGUgY29tcGlsZXIgZmxhZ3Mgd291 bGQgYWxzbyByZXF1aXJlIHVzYWdlCisgICAgICAgIG9mIGNlcnRhaW4gbGlua2VyIGZsYWdzIGxh dGVyIG9uLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0d0a0RvYy5jbWFrZTogQWxzbyBzZXQg TERGTEFHUyBpbiB0aGUgZW52aXJvbm1lbnQgd2hlbgorICAgICAgICBpbnZva2luZyBUb29scy9n dGtkb2MvZ2VuZXJhdGUtZ3RrZG9jLgorCiAyMDE5LTA4LTE2ICBSb3NzIEtpcnNsaW5nICA8cm9z cy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbV2luXSBXZWJDb3JlVGVzdFN1cHBvcnQg aXMgdG9vIGJpZyB0byBsaW5rCg==