200984 2019-08-21 09:35:23 -0700 [GTK] Build failure due to unwieldy definition of “None” from X11 headers 2019-08-21 10:24:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez bugs-noreply clopez commit-queue webkit-bug-importer oldest_to_newest 1563520 0 aperez 2019-08-21 09:35:23 -0700 This happens sometimes, depending on how “lucky” one with the chain of #includes generated in the derived sources for unified builds. Right now I have a reproducer locally so let's try and fix it for good. Build error log follows. ---- In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:30: In file included from ../Source/WebKit/Shared/ContextMenuContextData.h:34: In file included from ../Source/WebKit/Shared/WebHitTestResultData.h:25: In file included from DerivedSources/ForwardingHeaders/WebCore/DictionaryPopupInfo.h:29: DerivedSources/ForwardingHeaders/WebCore/TextIndicator.h:41:5: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:34: In file included from ../Source/WebKit/Shared/EditorState.h:30: DerivedSources/ForwardingHeaders/WebCore/FontAttributes.h:40:42: error: expected unqualified-id ListStyleType style { ListStyleType::None }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:34: In file included from ../Source/WebKit/Shared/EditorState.h:30: DerivedSources/ForwardingHeaders/WebCore/FontAttributes.h:78:51: error: expected identifier enum class SubscriptOrSuperscript : uint8_t { None, Subscript, Superscript }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:34: In file included from ../Source/WebKit/Shared/EditorState.h:30: DerivedSources/ForwardingHeaders/WebCore/FontAttributes.h:97:77: error: expected unqualified-id SubscriptOrSuperscript subscriptOrSuperscript { SubscriptOrSuperscript::None }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:34: In file included from ../Source/WebKit/Shared/EditorState.h:30: DerivedSources/ForwardingHeaders/WebCore/FontAttributes.h:111:58: error: expected unqualified-id WebCore::FontAttributes::SubscriptOrSuperscript::None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:30: DerivedSources/ForwardingHeaders/WebCore/Autofill.h:39:5: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: In file included from DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:28: DerivedSources/ForwardingHeaders/WebCore/Animation.h:194:76: error: expected unqualified-id static AnimationFillMode initialFillMode() { return AnimationFillMode::None; } ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: In file included from DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:40: In file included from DerivedSources/ForwardingHeaders/WebCore/ScrollableArea.h:29: DerivedSources/ForwardingHeaders/WebCore/ScrollTypes.h:53:5: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: In file included from DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:40: In file included from DerivedSources/ForwardingHeaders/WebCore/ScrollableArea.h:29: DerivedSources/ForwardingHeaders/WebCore/ScrollTypes.h:210:5: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: In file included from DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:40: In file included from DerivedSources/ForwardingHeaders/WebCore/ScrollableArea.h:29: DerivedSources/ForwardingHeaders/WebCore/ScrollTypes.h:223:5: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:485:9: error: expected identifier None = 0, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:495:9: error: expected identifier None = 0, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:536:9: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: In file included from ../Source/WebKit/Shared/FocusedElementInformation.h:32: DerivedSources/ForwardingHeaders/WebCore/GraphicsLayer.h:692:61: error: expected unqualified-id CustomAppearance m_customAppearance { CustomAppearance::None }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:35: ../Source/WebKit/Shared/FocusedElementInformation.h:41:5: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:73: DerivedSources/ForwardingHeaders/WebCore/DragActions.h:72:43: error: expected identifier enum class DragHandlingMethod : uint8_t { None, EditPlainText, EditRichText, UploadFile, PageLoad, SetColor, NonDefault }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:73: DerivedSources/ForwardingHeaders/WebCore/DragActions.h:81:38: error: expected unqualified-id WebCore::DragHandlingMethod::None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:77: DerivedSources/ForwardingHeaders/WebCore/FrameView.h:899:49: error: expected identifier enum class ViewportRendererType : uint8_t { None, Document, Body }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-25.cpp:6: In file included from ../Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp:31: In file included from ../Source/WebKit/UIProcess/WebPageProxy.h:77: DerivedSources/ForwardingHeaders/WebCore/FrameView.h:900:73: error: expected unqualified-id ViewportRendererType m_viewportRendererType { ViewportRendererType::None }; ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 1563523 1 376890 aperez 2019-08-21 09:42:10 -0700 Created attachment 376890 Patch 1563543 2 376890 commit-queue 2019-08-21 10:23:39 -0700 Comment on attachment 376890 Patch Clearing flags on attachment: 376890 Committed r248948: <https://trac.webkit.org/changeset/248948> 1563544 3 commit-queue 2019-08-21 10:23:40 -0700 All reviewed patches have been landed. Closing bug. 1563546 4 webkit-bug-importer 2019-08-21 10:24:18 -0700 <rdar://problem/54560945> 376890 2019-08-21 09:42:10 -0700 2019-08-21 10:23:39 -0700 Patch bug-200984-20190821194209.patch text/plain 1657 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg4MmUzNWEzODRlZTk2ZjZk YjUyNjNhOWQ5NWUxZjExNDcwMTc1NGMuLjVjMWYxZWZhNmNkZTU2OGJjYWUxNTA2MWYyZDg4YmQ0 NmM2OTVlOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjEgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBCdWls ZCBmYWlsdXJlIGR1ZSB0byB1bndpZWxkeSBkZWZpbml0aW9uIG9mIOKAnE5vbmXigJ0gZnJvbSBY MTEgaGVhZGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjAwOTg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTb3VyY2VzR1RLLnR4dDogTWFyayBBY2NlbGVyYXRlZEJhY2tpbmdTdG9yZS5jcHAgd2l0 aCBAbm8tdW5pZnkKKyAgICAgICAgYmVjYXVzZSBpdCBpbmNsdWRlcyBBY2NlbGVyYXRlZFN1cmZh Y2VYMTEuaCB3aGVuIGJ1aWxkaW5nIHdpdGgKKyAgICAgICAgRU5BQkxFX1gxMV9UQVJHRVQ9T04s IHdoaWNoIGluIHR1cm4gd2lsbCBpbmNsdWRlIHRoZSBYMTEgaGVhZGVycy4KKyAgICAgICAgSXQg aXMganVzdCBsdWNreSB0aGF0IG1vc3Qgb2YgdGhlIHRpbWUgdGhlIG9yZGVyIG9mIHRoZSBnZW5l cmF0ZWQKKyAgICAgICAgI2luY2x1ZGUgc3RhdGVtZW50cyBpbiB0aGUgdW5pZmllZCBzb3VyY2Vz IGhhcyBiZWVuIG1hc2tpbmcgdGhpcworICAgICAgICBwcm9ibGVtLgorCiAyMDE5LTA4LTIxICBS b2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgVmVyaWZ5IFByZWZldGNoIGFu ZCBjcmVkZW50aWFsIGJlaGF2aW9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NvdXJjZXNH VEsudHh0IGIvU291cmNlL1dlYktpdC9Tb3VyY2VzR1RLLnR4dAppbmRleCAwZjJiOThiMDM3MTEx YTM0YjVjODgxNjc3MDNhNmYwNDFkMTNhOGZjLi4zMTUyZWZjN2QyYWNiMzZlMjNlODNiMDExZDJm YjE4ZDUxYmMwYjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NvdXJjZXNHVEsudHh0Cisr KyBiL1NvdXJjZS9XZWJLaXQvU291cmNlc0dUSy50eHQKQEAgLTIzNiw3ICsyMzYsNyBAQCBVSVBy b2Nlc3MvZ2xpYi9XZWJQcm9jZXNzUHJveHlHTGliLmNwcAogVUlQcm9jZXNzL2dzdHJlYW1lci9J bnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0LmNwcAogVUlQcm9jZXNz L2dzdHJlYW1lci9XZWJQYWdlUHJveHlHU3RyZWFtZXIuY3BwCiAKLVVJUHJvY2Vzcy9ndGsvQWNj ZWxlcmF0ZWRCYWNraW5nU3RvcmUuY3BwCitVSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2lu Z1N0b3JlLmNwcCBAbm8tdW5pZnkKIFVJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5nU3Rv cmVXYXlsYW5kLmNwcCBAbm8tdW5pZnkKIFVJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5n U3RvcmVYMTEuY3BwIEBuby11bmlmeQogVUlQcm9jZXNzL2d0ay9EcmFnQW5kRHJvcEhhbmRsZXIu Y3BwCg==