200982 2019-08-21 08:57:41 -0700 [GStreamer] Clang warns about mismatched type tag in declarations for ImageOrientation 2019-08-21 10:09:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez bugs-noreply clopez commit-queue ggaren sabouhallawa simon.fraser webkit-bug-importer ysuzuki zan oldest_to_newest 1563511 0 aperez 2019-08-21 08:57:41 -0700 In file included from ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:89: ../Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:33:1: warning: class 'ImageOrientation' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags] class ImageOrientation; ^ ../Source/WebCore/platform/graphics/ImageOrientation.h:34:8: note: previous use is here struct ImageOrientation { ^ ../Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:33:1: note: did you mean struct here? class ImageOrientation; ^~~~~ struct 1 warning generated. 1563514 1 376889 aperez 2019-08-21 09:06:07 -0700 Created attachment 376889 Patch 1563537 2 376889 commit-queue 2019-08-21 10:08:54 -0700 Comment on attachment 376889 Patch Clearing flags on attachment: 376889 Committed r248946: <https://trac.webkit.org/changeset/248946> 1563538 3 commit-queue 2019-08-21 10:08:55 -0700 All reviewed patches have been landed. Closing bug. 1563539 4 webkit-bug-importer 2019-08-21 10:09:16 -0700 <rdar://problem/54560227> 376889 2019-08-21 09:06:07 -0700 2019-08-21 10:08:54 -0700 Patch bug-200982-20190821190606.patch text/plain 1474 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E1YWJlODMxM2U1NDI3 YjQ2ZDIwOTU3MjhkOTgzZTI5YjM2MjI3OS4uMjMxNGE5ZWNiM2IyODc0YjU1MDhjYTVhYjc5ZDhk ZWM0OGUzNGRiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA4LTIxICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl0gQ2xhbmcgd2FybnMgYWJvdXQgbWlzbWF0Y2hlZCB0eXBlIHRhZyBpbiBkZWNsYXJhdGlv bnMgZm9yIEltYWdlT3JpZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMDk4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvVmlkZW9UZXh0dXJlQ29waWVyR1N0cmVhbWVyLmg6IENoYW5n ZQorICAgICAgICB0eXBlIHRhZyBpbiB0aGUgZm9yd2FyZCBkZWNsYXJhdGlvbiB0byAic3RydWN0 IiwgaGVuY2UgbWF0Y2hpbmcgdGhlCisgICAgICAgIGFjdHVhbCB0eXBlIGRlZmluaXRpb24uCisK IDIwMTktMDgtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg bmV4dEVsZW1lbnRXaXRoR3JlYXRlclRhYkluZGV4IHNob3VsZCB1c2Ugc2hhZG93QWRqdXN0ZWRU YWJJbmRleApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL1ZpZGVvVGV4dHVyZUNvcGllckdTdHJlYW1lci5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvVGV4dHVyZUNvcGllckdTdHJlYW1lci5oCmlu ZGV4IDVjNTZlYzM0MTg4ODMzNDU3ODhmYTBiNTQ5YTk4MDMyN2QzZTdiZjkuLmQzZDJkNGYxYzhl OWU0ZWUwN2NjMTk2MTc3NzIzNzNjNmVjYjkzMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1RleHR1cmVDb3BpZXJHU3RyZWFtZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVmlkZW9U ZXh0dXJlQ29waWVyR1N0cmVhbWVyLmgKQEAgLTMwLDcgKzMwLDcgQEAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogY2xhc3MgVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW07Ci1jbGFzcyBJbWFnZU9y aWVudGF0aW9uOworc3RydWN0IEltYWdlT3JpZW50YXRpb247CiAKIGNsYXNzIFZpZGVvVGV4dHVy ZUNvcGllckdTdHJlYW1lciB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7Cg==