200981 2019-08-21 08:51:59 -0700 Get rid of m_weakThis data members now that we have a safe way to call makeWeakPtr() from various threads 2019-08-21 12:52:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1563505 0 cdumez 2019-08-21 08:51:59 -0700 Get rid of m_weakThis data members now that we have a safe way to call makeWeakPtr() from various threads. 1563506 1 376887 cdumez 2019-08-21 08:52:41 -0700 Created attachment 376887 Patch 1563563 2 376887 achristensen 2019-08-21 11:05:10 -0700 Comment on attachment 376887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376887&action=review > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:49 > +// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread. I don't think these comments are necessary. 1563567 3 cdumez 2019-08-21 11:10:03 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 376887 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376887&action=review > > > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:49 > > +// Use eager initialization for the WeakPtrFactory since we call makeWeakPtr() from another thread. > > I don't think these comments are necessary. I personally think it is important to document why we need eager initialization here so that nobody is tempted to remove it, or so that it can be removed when it is no longer needed. I seem to remember Geoff asking for a comment as well. 1563634 4 376887 commit-queue 2019-08-21 12:51:05 -0700 Comment on attachment 376887 Patch Clearing flags on attachment: 376887 Committed r248958: <https://trac.webkit.org/changeset/248958> 1563635 5 commit-queue 2019-08-21 12:51:06 -0700 All reviewed patches have been landed. Closing bug. 1563636 6 webkit-bug-importer 2019-08-21 12:52:18 -0700 <rdar://problem/54567696> 376887 2019-08-21 08:52:41 -0700 2019-08-21 12:51:05 -0700 Patch bug-200981-20190821085240.patch text/plain 9113 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU2NzA4ZDY1OTc5MDg2 OGMyMDgwNTVmZjU0YTY0MTZjZWIwODY4Mi4uYjJhYTg4N2NmYTE0ZThjNjA5ZTk1MmYxYzU3Yjkz NTc1ZWRlNWUzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA4LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiBtX3dlYWtU aGlzIGRhdGEgbWVtYmVycyBub3cgdGhhdCB3ZSBoYXZlIGEgc2FmZSB3YXkgdG8gY2FsbCBtYWtl V2Vha1B0cigpIGZyb20gdmFyaW91cyB0aHJlYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA5ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9N ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b24pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpz Y2hlZHVsZU1haW5UaHJlYWROb3RpZmljYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpkaXNwYXRjaE5vdGlmaWNhdGlvbik6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91 bmRhdGlvbi5oOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJX ZWJSVENEVE1GU2VuZGVyQmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENE VE1GU2VuZGVyQmFja2VuZDo6TGliV2ViUlRDRFRNRlNlbmRlckJhY2tlbmQpOgorICAgICAgICAo V2ViQ29yZTo6TGliV2ViUlRDRFRNRlNlbmRlckJhY2tlbmQ6Ok9uVG9uZUNoYW5nZSk6CisgICAg ICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RUTUZTZW5kZXJC YWNrZW5kLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jb2NvYS9Db29raWVTdG9yYWdl T2JzZXJ2ZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NvY29hL0Nvb2tpZVN0b3Jh Z2VPYnNlcnZlci5tbToKKyAgICAgICAgKFdlYkNvcmU6OkNvb2tpZVN0b3JhZ2VPYnNlcnZlcjo6 Q29va2llU3RvcmFnZU9ic2VydmVyKToKKyAgICAgICAgKFdlYkNvcmU6OkNvb2tpZVN0b3JhZ2VP YnNlcnZlcjo6Y29va2llc0RpZENoYW5nZSk6CisKIDIwMTktMDgtMjAgIEp1c3RpbiBGYW4gIDxq dXN0aW5fZmFuQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGNvbW1lbnQgZm9sbG93 LXVwIGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzUyLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u LmNwcAppbmRleCA1OWNmOGJhMjEzMTZiMzA3YzA1MDIzZWQ1NmQ5YjM5ZDI1NjE3ZjBiLi4xYjlh OTIxNTdhN2JlM2UzMTFiYTE3YjQ1ODc3YTgzNjYzNjZhNmI1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcApAQCAtNTUsOCAr NTUsNyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb246Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbihNZWRpYVBsYXllciogcGxheWVy KQotICAgIDogbV93ZWFrVGhpcyhtYWtlV2Vha1B0cigqdGhpcykpCi0gICAgLCBtX3BsYXllcihw bGF5ZXIpCisgICAgOiBtX3BsYXllcihwbGF5ZXIpCiAgICAgLCBtX3F1ZXVlZE5vdGlmaWNhdGlv bnMoKQogICAgICwgbV9xdWV1ZU11dGV4KCkKICAgICAsIG1fbmV0d29ya1N0YXRlKE1lZGlhUGxh eWVyOjpFbXB0eSkKQEAgLTc3NSw3ICs3NzQsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbjo6c2NoZWR1bGVNYWluVGhyZWFkTm90aWZpY2F0aW9uKE5vdGlmaWNhdGlvbgog ICAgIGlmIChkZWxheURpc3BhdGNoICYmICFtX21haW5UaHJlYWRDYWxsUGVuZGluZykgewogICAg ICAgICBtX21haW5UaHJlYWRDYWxsUGVuZGluZyA9IHRydWU7CiAKLSAgICAgICAgY2FsbE9uTWFp blRocmVhZChbd2Vha1RoaXMgPSBtX3dlYWtUaGlzXSB7CisgICAgICAgIGNhbGxPbk1haW5UaHJl YWQoW3dlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpXSB7CiAgICAgICAgICAgICBpZiAoIXdl YWtUaGlzKQogICAgICAgICAgICAgICAgIHJldHVybjsKIApAQCAtODA4LDcgKzgwNyw3IEBAIHZv aWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpkaXNwYXRjaE5vdGlmaWNhdGlvbigp CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIGlmICghbV9xdWV1ZWROb3RpZmljYXRpb25z LmlzRW1wdHkoKSAmJiAhbV9tYWluVGhyZWFkQ2FsbFBlbmRpbmcpIHsKLSAgICAgICAgICAgIGNh bGxPbk1haW5UaHJlYWQoW3dlYWtUaGlzID0gbV93ZWFrVGhpc10geworICAgICAgICAgICAgY2Fs bE9uTWFpblRocmVhZChbd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyldIHsKICAgICAgICAg ICAgICAgICBpZiAoIXdlYWtUaGlzKQogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9N ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uaApp bmRleCBhNjFlNWI5MWExYTFkOGYxYmJkYThlZWQ4OTVjMGQ4NWI2MjQyYmJlLi4wNDUzMjQ0MzJm N2FkMjk2NjZiY2M0Yzg5ZDlhOGIzZDk1NDJkZGY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5oCkBAIC00Niw3ICs0Niw4IEBAIGNs YXNzIEluYmFuZE1ldGFkYXRhVGV4dFRyYWNrUHJpdmF0ZUFWRjsKIGNsYXNzIEluYmFuZFRleHRU cmFja1ByaXZhdGVBVkY7CiBjbGFzcyBHZW5lcmljQ3VlRGF0YTsKIAotY2xhc3MgTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uIDogcHVibGljIENhbk1ha2VXZWFrUHRyPE1lZGlhUGxheWVy UHJpdmF0ZUFWRm91bmRhdGlvbj4sIHB1YmxpYyBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2Us IHB1YmxpYyBBVkZJbmJhbmRUcmFja1BhcmVudAorLy8gVXNlIGVhZ2VyIGluaXRpYWxpemF0aW9u IGZvciB0aGUgV2Vha1B0ckZhY3Rvcnkgc2luY2Ugd2UgY2FsbCBtYWtlV2Vha1B0cigpIGZyb20g YW5vdGhlciB0aHJlYWQuCitjbGFzcyBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24gOiBw dWJsaWMgQ2FuTWFrZVdlYWtQdHI8TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLCBXZWFr UHRyRmFjdG9yeUluaXRpYWxpemF0aW9uOjpFYWdlcj4sIHB1YmxpYyBNZWRpYVBsYXllclByaXZh dGVJbnRlcmZhY2UsIHB1YmxpYyBBVkZJbmJhbmRUcmFja1BhcmVudAogI2lmICFSRUxFQVNFX0xP R19ESVNBQkxFRAogICAgICwgcHJpdmF0ZSBMb2dnZXJIZWxwZXIKICNlbmRpZgpAQCAtMzI3LDcg KzMyOCw2IEBAIHByb3RlY3RlZDoKICAgICBjb25zdCBVUkwmIHJlc29sdmVkVVJMKCkgY29uc3Qg eyByZXR1cm4gbV9yZXNvbHZlZFVSTDsgfQogCiBwcml2YXRlOgotICAgIFdlYWtQdHI8TWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uPiBtX3dlYWtUaGlzOwogICAgIE1lZGlhUGxheWVyKiBt X3BsYXllcjsKIAogICAgIFdURjo6RnVuY3Rpb248dm9pZCgpPiBtX3BlbmRpbmdTZWVrOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xp YldlYlJUQ0RUTUZTZW5kZXJCYWNrZW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENEVE1GU2VuZGVyQmFja2VuZC5jcHAKaW5kZXgg MDVhYTEzZTg3ZTk4MGM4ZWViYjNjZTI2NTU5MGQyY2M4YmQ0Nzg5ZS4uYTY2YjAwN2IxZWYzMDVh YzAxYzU0OTc4M2ZiYzUxYThlMzRiZGUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RUTUZTZW5kZXJCYWNrZW5kLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGli V2ViUlRDRFRNRlNlbmRlckJhY2tlbmQuY3BwCkBAIC0zOSw3ICszOSw2IEBAIHN0YXRpYyBpbmxp bmUgU3RyaW5nIHRvV1RGU3RyaW5nKGNvbnN0IHN0ZDo6c3RyaW5nJiB2YWx1ZSkKIAogTGliV2Vi UlRDRFRNRlNlbmRlckJhY2tlbmQ6OkxpYldlYlJUQ0RUTUZTZW5kZXJCYWNrZW5kKHJ0Yzo6c2Nv cGVkX3JlZnB0cjx3ZWJydGM6OkR0bWZTZW5kZXJJbnRlcmZhY2U+JiYgc2VuZGVyKQogICAgIDog bV9zZW5kZXIoV1RGTW92ZShzZW5kZXIpKQotICAgICwgbV93ZWFrVGhpcyhtYWtlV2Vha1B0cih0 aGlzKSkKIHsKICAgICBtX3NlbmRlci0+UmVnaXN0ZXJPYnNlcnZlcih0aGlzKTsKIH0KQEAgLTgw LDcgKzc5LDcgQEAgdm9pZCBMaWJXZWJSVENEVE1GU2VuZGVyQmFja2VuZDo6T25Ub25lQ2hhbmdl KGNvbnN0IHN0ZDo6c3RyaW5nJiB0b25lLCBjb25zdCBzdGQKICAgICAvLyBXZSBhcmUganVzdCBp bnRlcmVzdGVkIGluIG5vdGlmeWluZyB0aGUgZW5kIG9mIHRoZSB0b25lLCB3aGljaCBjb3JyZXNw b25kcyB0byB0aGUgZW1wdHkgc3RyaW5nLgogICAgIGlmICghdG9uZS5lbXB0eSgpKQogICAgICAg ICByZXR1cm47Ci0gICAgY2FsbE9uTWFpblRocmVhZChbdGhpcywgd2Vha1RoaXMgPSBtX3dlYWtU aGlzLCB0b25lID0gdG9XVEZTdHJpbmcodG9uZSldIHsKKyAgICBjYWxsT25NYWluVGhyZWFkKFt0 aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKSwgdG9uZSA9IHRvV1RGU3RyaW5nKHRv bmUpXSB7CiAgICAgICAgIGlmICghd2Vha1RoaXMpCiAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIGlmIChtX29uVG9uZVBsYXllZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENEVE1GU2VuZGVyQmFja2VuZC5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RU TUZTZW5kZXJCYWNrZW5kLmgKaW5kZXggNGEwNjFmY2M5NTNiMTNkNTgzYmFlNTU0NTE1NWJjZTA4 ZGY4ZjlkOC4uODlmOWYyYzUyYjJkNjFmNmZkNzg3YmM3OGQxYzBmYjRlYzBjNTc3YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldl YlJUQ0RUTUZTZW5kZXJCYWNrZW5kLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RUTUZTZW5kZXJCYWNrZW5kLmgKQEAgLTM5LDcg KzM5LDggQEAgQUxMT1dfVU5VU0VEX1BBUkFNRVRFUlNfRU5ECiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAotY2xhc3MgTGliV2ViUlRDRFRNRlNlbmRlckJhY2tlbmQgZmluYWwgOiBwdWJsaWMgUlRD RFRNRlNlbmRlckJhY2tlbmQsIHByaXZhdGUgd2VicnRjOjpEdG1mU2VuZGVyT2JzZXJ2ZXJJbnRl cmZhY2UsIHB1YmxpYyBDYW5NYWtlV2Vha1B0cjxMaWJXZWJSVENEVE1GU2VuZGVyQmFja2VuZD4g eworLy8gVXNlIGVhZ2VyIGluaXRpYWxpemF0aW9uIGZvciB0aGUgV2Vha1B0ckZhY3Rvcnkgc2lu Y2Ugd2UgY2FsbCBtYWtlV2Vha1B0cigpIGZyb20gYW5vdGhlciB0aHJlYWQuCitjbGFzcyBMaWJX ZWJSVENEVE1GU2VuZGVyQmFja2VuZCBmaW5hbCA6IHB1YmxpYyBSVENEVE1GU2VuZGVyQmFja2Vu ZCwgcHJpdmF0ZSB3ZWJydGM6OkR0bWZTZW5kZXJPYnNlcnZlckludGVyZmFjZSwgcHVibGljIENh bk1ha2VXZWFrUHRyPExpYldlYlJUQ0RUTUZTZW5kZXJCYWNrZW5kLCBXZWFrUHRyRmFjdG9yeUlu aXRpYWxpemF0aW9uOjpFYWdlcj4gewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVi bGljOgogICAgIGV4cGxpY2l0IExpYldlYlJUQ0RUTUZTZW5kZXJCYWNrZW5kKHJ0Yzo6c2NvcGVk X3JlZnB0cjx3ZWJydGM6OkR0bWZTZW5kZXJJbnRlcmZhY2U+JiYpOwpAQCAtNTksNyArNjAsNiBA QCBwcml2YXRlOgogCiAgICAgcnRjOjpzY29wZWRfcmVmcHRyPHdlYnJ0Yzo6RHRtZlNlbmRlcklu dGVyZmFjZT4gbV9zZW5kZXI7CiAgICAgRnVuY3Rpb248dm9pZChjb25zdCBTdHJpbmcmKT4gbV9v blRvbmVQbGF5ZWQ7Ci0gICAgV2Vha1B0cjxMaWJXZWJSVENEVE1GU2VuZGVyQmFja2VuZD4gbV93 ZWFrVGhpczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvQ29va2llU3RvcmFnZU9ic2VydmVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL0Nvb2tpZVN0b3JhZ2VPYnNl cnZlci5oCmluZGV4IDdkNDc0N2FiYTAxY2IwNDAxNWJmZjcxNGU3NTFiNzdjYTliYWYzYmYuLjFi ZjBjNjA1YmJhNzBlMWJlM2RlYmMyNTE5YjRiNGEyNDgwYzE4M2MgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvQ29va2llU3RvcmFnZU9ic2VydmVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9Db29raWVTdG9yYWdl T2JzZXJ2ZXIuaApAQCAtMzUsNyArMzUsOCBAQCBPQkpDX0NMQVNTIFdlYkNvb2tpZU9ic2VydmVy QWRhcHRlcjsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBXRUJDT1JFX0VYUE9SVCBD b29raWVTdG9yYWdlT2JzZXJ2ZXIgOiBwdWJsaWMgQ2FuTWFrZVdlYWtQdHI8Q29va2llU3RvcmFn ZU9ic2VydmVyPiB7CisvLyBVc2UgZWFnZXIgaW5pdGlhbGl6YXRpb24gZm9yIHRoZSBXZWFrUHRy RmFjdG9yeSBzaW5jZSB3ZSBjYWxsIG1ha2VXZWFrUHRyKCkgZnJvbSBhIG5vbi1tYWluIHRocmVh ZC4KK2NsYXNzIFdFQkNPUkVfRVhQT1JUIENvb2tpZVN0b3JhZ2VPYnNlcnZlciA6IHB1YmxpYyBD YW5NYWtlV2Vha1B0cjxDb29raWVTdG9yYWdlT2JzZXJ2ZXIsIFdlYWtQdHJGYWN0b3J5SW5pdGlh bGl6YXRpb246OkVhZ2VyPiB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiAgICAgV1RG X01BS0VfTk9OQ09QWUFCTEUoQ29va2llU3RvcmFnZU9ic2VydmVyKTsKIHB1YmxpYzoKQEAgLTQ4 LDggKzQ5LDYgQEAgcHVibGljOgogICAgIHZvaWQgY29va2llc0RpZENoYW5nZSgpOwogCiBwcml2 YXRlOgotCi0gICAgV2Vha1B0cjxDb29raWVTdG9yYWdlT2JzZXJ2ZXI+IG1fd2Vha1RoaXM7CiAg ICAgUmV0YWluUHRyPE5TSFRUUENvb2tpZVN0b3JhZ2U+IG1fY29va2llU3RvcmFnZTsKICAgICBi b29sIG1faGFzUmVnaXN0ZXJlZEludGVybmFsc0Zvck5vdGlmaWNhdGlvbnMgeyBmYWxzZSB9Owog ICAgIFJldGFpblB0cjxXZWJDb29raWVPYnNlcnZlckFkYXB0ZXI+IG1fb2JzZXJ2ZXJBZGFwdGVy OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9Db29r aWVTdG9yYWdlT2JzZXJ2ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nv Y29hL0Nvb2tpZVN0b3JhZ2VPYnNlcnZlci5tbQppbmRleCBjNGQ0OGViYWRmMTRmNjcxODZhOWZh NDZiYzk0OTYyNmUzNTI3ZGIzLi4wMDhlMDVmMTgyNmYyNGRlYTE2NTllMDg4ZjRkNmQ2MDQ2NmVm MGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL0Nv b2tpZVN0b3JhZ2VPYnNlcnZlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2NvY29hL0Nvb2tpZVN0b3JhZ2VPYnNlcnZlci5tbQpAQCAtNzUsOCArNzUsNyBAQCBAZW5k CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIENvb2tpZVN0b3JhZ2VPYnNlcnZlcjo6Q29va2llU3Rv cmFnZU9ic2VydmVyKE5TSFRUUENvb2tpZVN0b3JhZ2UgKmNvb2tpZVN0b3JhZ2UpCi0gICAgOiBt X3dlYWtUaGlzKG1ha2VXZWFrUHRyKCp0aGlzKSkKLSAgICAsIG1fY29va2llU3RvcmFnZShjb29r aWVTdG9yYWdlKQorICAgIDogbV9jb29raWVTdG9yYWdlKGNvb2tpZVN0b3JhZ2UpCiB7CiAgICAg QVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBBU1NFUlQobV9jb29raWVTdG9yYWdlKTsKQEAg LTEzMCw3ICsxMjksNyBAQCB2b2lkIENvb2tpZVN0b3JhZ2VPYnNlcnZlcjo6c3RvcE9ic2Vydmlu ZygpCiAKIHZvaWQgQ29va2llU3RvcmFnZU9ic2VydmVyOjpjb29raWVzRGlkQ2hhbmdlKCkKIHsK LSAgICBjYWxsT25NYWluVGhyZWFkKFt3ZWFrVGhpcyA9IG1fd2Vha1RoaXNdIHsKKyAgICBjYWxs T25NYWluVGhyZWFkKFt3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKV0gewogICAgICAgICBp ZiAod2Vha1RoaXMgJiYgd2Vha1RoaXMtPm1fY29va2llQ2hhbmdlQ2FsbGJhY2spCiAgICAgICAg ICAgICB3ZWFrVGhpcy0+bV9jb29raWVDaGFuZ2VDYWxsYmFjaygpOwogICAgIH0pOwo=