<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200973</bug_id>
          
          <creation_ts>2019-08-21 05:42:01 -0700</creation_ts>
          <short_desc>[WPE] Build failure after r248846 ([WTF] Add makeUnique&lt;T&gt;, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part)</short_desc>
          <delta_ts>2019-08-21 07:40:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pablo Saavedra">psaavedra</reporter>
          <assigned_to name="Pablo Saavedra">psaavedra</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>pnormand</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1563449</commentid>
    <comment_count>0</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 05:42:01 -0700</bug_when>
    <thetext>WPE fails to build with `-DENABLE_WPE_QT_API=ON` after changes done by r248846 in:

* Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp
* Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp

; to forces FastMalloc use.


Related to:

* https://bugs.webkit.org/show_bug.cgi?id=200611
* https://bugs.webkit.org/show_bug.cgi?id=200620</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563453</commentid>
    <comment_count>1</comment_count>
      <attachid>376867</attachid>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 05:49:31 -0700</bug_when>
    <thetext>Created attachment 376867
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563454</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-08-21 05:51:03 -0700</bug_when>
    <thetext>Attachment 376867 did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:30:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: memory corruption  [changelog/unwantedsecurityterms] [3]
ERROR: Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp:442:  Use &apos;WTF::makeUnique&lt;&gt;&apos; instead of &apos;std::make_unique&lt;&gt;&apos;.  [runtime/wtf_make_unique] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563458</commentid>
    <comment_count>3</comment_count>
      <attachid>376867</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-08-21 06:10:04 -0700</bug_when>
    <thetext>Comment on attachment 376867
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376867&amp;action=review

&gt; Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp:442
&gt; -    std::unique_ptr&lt;JavascriptCallbackData&gt; data = makeUnique&lt;JavascriptCallbackData&gt;(callback, QPointer&lt;WPEQtView&gt;(this));
&gt; +    std::unique_ptr&lt;JavascriptCallbackData&gt; data = std::make_unique&lt;JavascriptCallbackData&gt;(callback, QPointer&lt;WPEQtView&gt;(this));

This doesn&apos;t look right. I think you can simply make JavascriptCallbackData WTF_MAKE_FAST_ALLOCATED and then makeUnique would work?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563459</commentid>
    <comment_count>4</comment_count>
      <attachid>376869</attachid>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 06:11:54 -0700</bug_when>
    <thetext>Created attachment 376869
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563460</commentid>
    <comment_count>5</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 06:12:54 -0700</bug_when>
    <thetext>(In reply to Philippe Normand from comment #3)
&gt; Comment on attachment 376867 [details]
&gt; patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=376867&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp:442
&gt; &gt; -    std::unique_ptr&lt;JavascriptCallbackData&gt; data = makeUnique&lt;JavascriptCallbackData&gt;(callback, QPointer&lt;WPEQtView&gt;(this));
&gt; &gt; +    std::unique_ptr&lt;JavascriptCallbackData&gt; data = std::make_unique&lt;JavascriptCallbackData&gt;(callback, QPointer&lt;WPEQtView&gt;(this));
&gt; 
&gt; This doesn&apos;t look right. I think you can simply make JavascriptCallbackData
&gt; WTF_MAKE_FAST_ALLOCATED and then makeUnique would work?

Faster than my eyes, I uploaded the right version one minute ago.  Sorry for the noise with the first one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563461</commentid>
    <comment_count>6</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-08-21 06:13:51 -0700</bug_when>
    <thetext>Attachment 376869 did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:30:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: memory corruption  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563462</commentid>
    <comment_count>7</comment_count>
      <attachid>376869</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-08-21 06:16:15 -0700</bug_when>
    <thetext>Comment on attachment 376869
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376869&amp;action=review

&gt; Source/WebKit/ChangeLog:31
&gt; +            [WTF][JSC] Make JSC and WTF aggressively-fast-malloced
&gt; +            https://bugs.webkit.org/show_bug.cgi?id=200611
&gt; +            ...
&gt; +            Putting WebKit classes in FastMalloc has many benefits.
&gt; +
&gt; +            1. Simply, it is fast.
&gt; +            2. vmmap can tell the amount of memory used for WebKit.
&gt; +            3. bmalloc can isolate WebKit memory allocation from the rest of
&gt; +               the world. This is useful since we can know more about what
&gt; +               component is corrupting the memory from the memory corruption
&gt; +               crash.

Can you remove this? It would make the style bot happy and we can land this through cq.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563465</commentid>
    <comment_count>8</comment_count>
      <attachid>376871</attachid>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 06:22:04 -0700</bug_when>
    <thetext>Created attachment 376871
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563466</commentid>
    <comment_count>9</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 06:23:20 -0700</bug_when>
    <thetext>(In reply to Philippe Normand from comment #7)
&gt; Comment on attachment 376869 [details]
&gt; patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=376869&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:31
&gt; &gt; +            [WTF][JSC] Make JSC and WTF aggressively-fast-malloced
&gt; &gt; +            https://bugs.webkit.org/show_bug.cgi?id=200611
&gt; &gt; +            ...
&gt; &gt; +            Putting WebKit classes in FastMalloc has many benefits.
&gt; &gt; +
&gt; &gt; +            1. Simply, it is fast.
&gt; &gt; +            2. vmmap can tell the amount of memory used for WebKit.
&gt; &gt; +            3. bmalloc can isolate WebKit memory allocation from the rest of
&gt; &gt; +               the world. This is useful since we can know more about what
&gt; &gt; +               component is corrupting the memory from the memory corruption
&gt; &gt; +               crash.
&gt; 
&gt; Can you remove this? It would make the style bot happy and we can land this
&gt; through cq.

done and thanks for pointing the solution.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563467</commentid>
    <comment_count>10</comment_count>
      <attachid>376871</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-08-21 06:26:09 -0700</bug_when>
    <thetext>Comment on attachment 376871
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376871&amp;action=review

&gt; Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp:383
&gt; +    WTF_MAKE_FAST_ALLOCATED;

Sorry, I&apos;ve just found out there&apos;s a WTF_MAKE_STRUCT_FAST_ALLOCATED macro as well. Can you use it here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563472</commentid>
    <comment_count>11</comment_count>
      <attachid>376874</attachid>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 06:49:27 -0700</bug_when>
    <thetext>Created attachment 376874
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563473</commentid>
    <comment_count>12</comment_count>
    <who name="Pablo Saavedra">psaavedra</who>
    <bug_when>2019-08-21 06:49:43 -0700</bug_when>
    <thetext>(In reply to Philippe Normand from comment #10)
&gt; Comment on attachment 376871 [details]
&gt; patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=376871&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp:383
&gt; &gt; +    WTF_MAKE_FAST_ALLOCATED;
&gt; 
&gt; Sorry, I&apos;ve just found out there&apos;s a WTF_MAKE_STRUCT_FAST_ALLOCATED macro as
&gt; well. Can you use it here?

Sure ... done</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563474</commentid>
    <comment_count>13</comment_count>
      <attachid>376874</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-08-21 06:57:45 -0700</bug_when>
    <thetext>Comment on attachment 376874
patch

Thanks! :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563480</commentid>
    <comment_count>14</comment_count>
      <attachid>376874</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-21 07:40:02 -0700</bug_when>
    <thetext>Comment on attachment 376874
patch

Clearing flags on attachment: 376874

Committed r248941: &lt;https://trac.webkit.org/changeset/248941&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1563481</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-21 07:40:05 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376867</attachid>
            <date>2019-08-21 05:49:31 -0700</date>
            <delta_ts>2019-08-21 06:04:41 -0700</delta_ts>
            <desc>patch</desc>
            <filename>bug-200973-20190821144930.patch</filename>
            <type>text/plain</type>
            <size>4223</size>
            <attacher name="Pablo Saavedra">psaavedra</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI2OTlhMjliZjlkM2QyNDEx
MjdlMjEwNWMxMTQyNjBmZTJiNzMxMjAuLjhmNzkxMGNhN2MxODU4Y2Q4MDM4N2Q2MTBiZWMwNjNh
ZTM2YjkzZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDIgQEAKKzIwMTktMDgtMjEgIFBhYmxvIFNh
YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQnVpbGQgZmFp
bHVyZSBhZnRlciByMjQ4ODQ2IChbV1RGXSBBZGQgbWFrZVVuaXF1ZTxUPiwgd2hpY2ggZW5zdXJl
cyBUIGlzIGZhc3QtYWxsb2NhdGVkLCBtYWtlVW5pcXVlIC8gbWFrZVVuaXF1ZVdpdGhvdXRGYXN0
TWFsbG9jQ2hlY2sgcGFydCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDk3MworCisgICAgICAgIFdQRSBmYWlscyB0byBidWlsZCB3aXRoIGAtREVO
QUJMRV9XUEVfUVRfQVBJPU9OYCBhZnRlciBjaGFuZ2VzIGRvbmUgYnkgcjI0ODg0NiBpbjoKKwor
ICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNw
cAorICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3
QmFja2VuZC5jcHAKKworICAgICAgICA7IHRvIGZvcmNlcyBGYXN0TWFsbG9jIHVzZS4KKworICAg
ICAgICBSZWxhdGVkIHRvOgorCisgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIwMDYxMQorICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMDA2MjAKKworICAgICAgICBUaGlzIHBhdGNoIHB1dHMgV1BFUXQuLi4g
Y2xhc3NlcyBpbnRvIEZhc3RNYWxsb2MgaW4gdGhlIHNhbWUgd2F5IGl0CisgICAgICAgIHdhcyBk
b25lIGJ5IG1hbnkgb3RoZXJzIGluIHIyNDg2MDM6CisKKyAgICAgICAgICAgIFtXVEZdW0pTQ10g
TWFrZSBKU0MgYW5kIFdURiBhZ2dyZXNzaXZlbHktZmFzdC1tYWxsb2NlZAorICAgICAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDYxMQorICAgICAgICAg
ICAgLi4uCisgICAgICAgICAgICBQdXR0aW5nIFdlYktpdCBjbGFzc2VzIGluIEZhc3RNYWxsb2Mg
aGFzIG1hbnkgYmVuZWZpdHMuCisKKyAgICAgICAgICAgIDEuIFNpbXBseSwgaXQgaXMgZmFzdC4K
KyAgICAgICAgICAgIDIuIHZtbWFwIGNhbiB0ZWxsIHRoZSBhbW91bnQgb2YgbWVtb3J5IHVzZWQg
Zm9yIFdlYktpdC4KKyAgICAgICAgICAgIDMuIGJtYWxsb2MgY2FuIGlzb2xhdGUgV2ViS2l0IG1l
bW9yeSBhbGxvY2F0aW9uIGZyb20gdGhlIHJlc3Qgb2YKKyAgICAgICAgICAgICAgIHRoZSB3b3Js
ZC4gVGhpcyBpcyB1c2VmdWwgc2luY2Ugd2UgY2FuIGtub3cgbW9yZSBhYm91dCB3aGF0CisgICAg
ICAgICAgICAgICBjb21wb25lbnQgaXMgY29ycnVwdGluZyB0aGUgbWVtb3J5IGZyb20gdGhlIG1l
bW9yeSBjb3JydXB0aW9uCisgICAgICAgICAgICAgICBjcmFzaC4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQ
RVF0Vmlldy5jcHA6CisgICAgICAgIChXUEVRdFZpZXc6OnJ1bkphdmFTY3JpcHQpOgorICAgICAg
ICAqIFVJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaDoKKyAgICAgICAgKiBV
SVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdMb2FkUmVxdWVzdC5oOgorCiAyMDE5LTA4LTIw
ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAg
W2lPU10gUkVHUkVTU0lPTiAoMjQ4NTAxKTogZ21haWwuY29tIGltYWdlcyBhcmUgc3RpbGwgbm90
IHNob3duIG9uIHNvbWUgdmVyc2lvbnMgb2YgaVBob25lIGlPUzEzCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAgYi9Tb3VyY2UvV2Vi
S2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAKaW5kZXggYjRmMjdiNmQzNGUy
NDJiYTU1MzVhYjViMmU0ZWNlNTMxNWQwOWQzNy4uNWMwOWZkZjkxZjJjOWZkMzUyOWQxZjBhODEw
Yjg5MjdlNzU4NjllZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dw
ZS9xdC9XUEVRdFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUv
cXQvV1BFUXRWaWV3LmNwcApAQCAtNDM5LDcgKzQzOSw3IEBAIHN0YXRpYyB2b2lkIGpzQXN5bmNS
ZWFkeUNhbGxiYWNrKEdPYmplY3QqIG9iamVjdCwgR0FzeW5jUmVzdWx0KiByZXN1bHQsIGdwb2lu
dGVyCiAqLwogdm9pZCBXUEVRdFZpZXc6OnJ1bkphdmFTY3JpcHQoY29uc3QgUVN0cmluZyYgc2Ny
aXB0LCBjb25zdCBRSlNWYWx1ZSYgY2FsbGJhY2spCiB7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPEph
dmFzY3JpcHRDYWxsYmFja0RhdGE+IGRhdGEgPSBtYWtlVW5pcXVlPEphdmFzY3JpcHRDYWxsYmFj
a0RhdGE+KGNhbGxiYWNrLCBRUG9pbnRlcjxXUEVRdFZpZXc+KHRoaXMpKTsKKyAgICBzdGQ6OnVu
aXF1ZV9wdHI8SmF2YXNjcmlwdENhbGxiYWNrRGF0YT4gZGF0YSA9IHN0ZDo6bWFrZV91bmlxdWU8
SmF2YXNjcmlwdENhbGxiYWNrRGF0YT4oY2FsbGJhY2ssIFFQb2ludGVyPFdQRVF0Vmlldz4odGhp
cykpOwogICAgIHdlYmtpdF93ZWJfdmlld19ydW5famF2YXNjcmlwdChtX3dlYlZpZXcuZ2V0KCks
IHNjcmlwdC50b1V0ZjgoKS5jb25zdERhdGEoKSwgbnVsbHB0ciwganNBc3luY1JlYWR5Q2FsbGJh
Y2ssIGRhdGEucmVsZWFzZSgpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy
b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaAppbmRleCBhMGMwZTdkMmUzNzI3M2U1
OGZkOWRiYmEyY2Q1MTY2NjhhMmNkYTI0Li5iMGVmMTlkN2Q1YTM2MzdiMDhhZjYyYzZjN2ExYmNm
MGI4ZDNiMTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0
L1dQRVF0Vmlld0JhY2tlbmQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3Bl
L3F0L1dQRVF0Vmlld0JhY2tlbmQuaApAQCAtMzcsNiArMzcsNyBAQAogY2xhc3MgV1BFUXRWaWV3
OwogCiBjbGFzcyBRX0RFQ0xfRVhQT1JUIFdQRVF0Vmlld0JhY2tlbmQgeworICAgIFdURl9NQUtF
X0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8V1BF
UXRWaWV3QmFja2VuZD4gY3JlYXRlKGNvbnN0IFFTaXplRiYsIFFQb2ludGVyPFFPcGVuR0xDb250
ZXh0PiwgRUdMRGlzcGxheSwgUVBvaW50ZXI8V1BFUXRWaWV3Pik7CiAgICAgV1BFUXRWaWV3QmFj
a2VuZChjb25zdCBRU2l6ZUYmLCBFR0xEaXNwbGF5LCBFR0xDb250ZXh0LCBRUG9pbnRlcjxRT3Bl
bkdMQ29udGV4dD4sIFFQb2ludGVyPFdQRVF0Vmlldz4pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdMb2FkUmVxdWVzdC5oIGIvU291cmNl
L1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdMb2FkUmVxdWVzdC5oCmluZGV4
IGFhZDBlMDY3ZTZjODI5OWYxNTY1Y2QxZDkxZDg4YjNiZDFiYWUxZGEuLmFjNjExYTBmZDQwZDE3
M2UxNjU4YzI2OTY5MGYxMTUwNWM0YTVmOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ
cm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3TG9hZFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2Vi
S2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0xvYWRSZXF1ZXN0LmgKQEAgLTI3LDYg
KzI3LDggQEAKIGNsYXNzIFdQRVF0Vmlld0xvYWRSZXF1ZXN0UHJpdmF0ZTsKIAogY2xhc3MgV1BF
UXRWaWV3TG9hZFJlcXVlc3QgOiBwdWJsaWMgUU9iamVjdCB7CisgICAgV1RGX01BS0VfRkFTVF9B
TExPQ0FURUQ7CisKICAgICBRX09CSkVDVAogICAgIFFfUFJPUEVSVFkoUVVybCB1cmwgUkVBRCB1
cmwpCiAgICAgUV9QUk9QRVJUWShXUEVRdFZpZXc6OkxvYWRTdGF0dXMgc3RhdHVzIFJFQUQgc3Rh
dHVzKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376869</attachid>
            <date>2019-08-21 06:11:54 -0700</date>
            <delta_ts>2019-08-21 06:20:57 -0700</delta_ts>
            <desc>patch</desc>
            <filename>bug-200973-20190821151153.patch</filename>
            <type>text/plain</type>
            <size>4078</size>
            <attacher name="Pablo Saavedra">psaavedra</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI2OTlhMjliZjlkM2QyNDEx
MjdlMjEwNWMxMTQyNjBmZTJiNzMxMjAuLjhmNzkxMGNhN2MxODU4Y2Q4MDM4N2Q2MTBiZWMwNjNh
ZTM2YjkzZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDIgQEAKKzIwMTktMDgtMjEgIFBhYmxvIFNh
YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQnVpbGQgZmFp
bHVyZSBhZnRlciByMjQ4ODQ2IChbV1RGXSBBZGQgbWFrZVVuaXF1ZTxUPiwgd2hpY2ggZW5zdXJl
cyBUIGlzIGZhc3QtYWxsb2NhdGVkLCBtYWtlVW5pcXVlIC8gbWFrZVVuaXF1ZVdpdGhvdXRGYXN0
TWFsbG9jQ2hlY2sgcGFydCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDk3MworCisgICAgICAgIFdQRSBmYWlscyB0byBidWlsZCB3aXRoIGAtREVO
QUJMRV9XUEVfUVRfQVBJPU9OYCBhZnRlciBjaGFuZ2VzIGRvbmUgYnkgcjI0ODg0NiBpbjoKKwor
ICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNw
cAorICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3
QmFja2VuZC5jcHAKKworICAgICAgICA7IHRvIGZvcmNlcyBGYXN0TWFsbG9jIHVzZS4KKworICAg
ICAgICBSZWxhdGVkIHRvOgorCisgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIwMDYxMQorICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMDA2MjAKKworICAgICAgICBUaGlzIHBhdGNoIHB1dHMgV1BFUXQuLi4g
Y2xhc3NlcyBpbnRvIEZhc3RNYWxsb2MgaW4gdGhlIHNhbWUgd2F5IGl0CisgICAgICAgIHdhcyBk
b25lIGJ5IG1hbnkgb3RoZXJzIGluIHIyNDg2MDM6CisKKyAgICAgICAgICAgIFtXVEZdW0pTQ10g
TWFrZSBKU0MgYW5kIFdURiBhZ2dyZXNzaXZlbHktZmFzdC1tYWxsb2NlZAorICAgICAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDYxMQorICAgICAgICAg
ICAgLi4uCisgICAgICAgICAgICBQdXR0aW5nIFdlYktpdCBjbGFzc2VzIGluIEZhc3RNYWxsb2Mg
aGFzIG1hbnkgYmVuZWZpdHMuCisKKyAgICAgICAgICAgIDEuIFNpbXBseSwgaXQgaXMgZmFzdC4K
KyAgICAgICAgICAgIDIuIHZtbWFwIGNhbiB0ZWxsIHRoZSBhbW91bnQgb2YgbWVtb3J5IHVzZWQg
Zm9yIFdlYktpdC4KKyAgICAgICAgICAgIDMuIGJtYWxsb2MgY2FuIGlzb2xhdGUgV2ViS2l0IG1l
bW9yeSBhbGxvY2F0aW9uIGZyb20gdGhlIHJlc3Qgb2YKKyAgICAgICAgICAgICAgIHRoZSB3b3Js
ZC4gVGhpcyBpcyB1c2VmdWwgc2luY2Ugd2UgY2FuIGtub3cgbW9yZSBhYm91dCB3aGF0CisgICAg
ICAgICAgICAgICBjb21wb25lbnQgaXMgY29ycnVwdGluZyB0aGUgbWVtb3J5IGZyb20gdGhlIG1l
bW9yeSBjb3JydXB0aW9uCisgICAgICAgICAgICAgICBjcmFzaC4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQ
RVF0Vmlldy5jcHA6CisgICAgICAgIChXUEVRdFZpZXc6OnJ1bkphdmFTY3JpcHQpOgorICAgICAg
ICAqIFVJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaDoKKyAgICAgICAgKiBV
SVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdMb2FkUmVxdWVzdC5oOgorCiAyMDE5LTA4LTIw
ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAg
W2lPU10gUkVHUkVTU0lPTiAoMjQ4NTAxKTogZ21haWwuY29tIGltYWdlcyBhcmUgc3RpbGwgbm90
IHNob3duIG9uIHNvbWUgdmVyc2lvbnMgb2YgaVBob25lIGlPUzEzCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAgYi9Tb3VyY2UvV2Vi
S2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAKaW5kZXggYjRmMjdiNmQzNGUy
NDJiYTU1MzVhYjViMmU0ZWNlNTMxNWQwOWQzNy4uZjdlMjlkYzJlMTQwOGQxNzFhNTM3NzI1ZjI1
NmJmMTI4YWVjNWUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dw
ZS9xdC9XUEVRdFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUv
cXQvV1BFUXRWaWV3LmNwcApAQCAtMzc5LDcgKzM3OSw5IEBAIHZvaWQgV1BFUXRWaWV3Ojpsb2Fk
SHRtbChjb25zdCBRU3RyaW5nJiBodG1sLCBjb25zdCBRVXJsJiBiYXNlVXJsKQogICAgICAgICB3
ZWJraXRfd2ViX3ZpZXdfbG9hZF9odG1sKG1fd2ViVmlldy5nZXQoKSwgaHRtbC50b1V0ZjgoKS5j
b25zdERhdGEoKSwgYmFzZVVybC50b1N0cmluZygpLnRvVXRmOCgpLmNvbnN0RGF0YSgpKTsKIH0K
IAotc3RydWN0IEphdmFzY3JpcHRDYWxsYmFja0RhdGEgeworY2xhc3MgSmF2YXNjcmlwdENhbGxi
YWNrRGF0YSB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CitwdWJsaWM6CiAgICAgSmF2
YXNjcmlwdENhbGxiYWNrRGF0YShRSlNWYWx1ZSBjYiwgUVBvaW50ZXI8V1BFUXRWaWV3PiBvYmop
CiAgICAgICAgIDogY2FsbGJhY2soY2IpCiAgICAgICAgICwgb2JqZWN0KG9iaikgeyB9CmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tl
bmQuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3QmFja2Vu
ZC5oCmluZGV4IGEwYzBlN2QyZTM3MjczZTU4ZmQ5ZGJiYTJjZDUxNjY2OGEyY2RhMjQuLmIwZWYx
OWQ3ZDVhMzYzN2IwOGFmNjJjNmM3YTFiY2YwYjhkM2IxMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3QmFja2VuZC5oCisrKyBiL1NvdXJj
ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3QmFja2VuZC5oCkBAIC0zNyw2
ICszNyw3IEBACiBjbGFzcyBXUEVRdFZpZXc7CiAKIGNsYXNzIFFfREVDTF9FWFBPUlQgV1BFUXRW
aWV3QmFja2VuZCB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAg
c3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxXUEVRdFZpZXdCYWNrZW5kPiBjcmVhdGUoY29uc3QgUVNp
emVGJiwgUVBvaW50ZXI8UU9wZW5HTENvbnRleHQ+LCBFR0xEaXNwbGF5LCBRUG9pbnRlcjxXUEVR
dFZpZXc+KTsKICAgICBXUEVRdFZpZXdCYWNrZW5kKGNvbnN0IFFTaXplRiYsIEVHTERpc3BsYXks
IEVHTENvbnRleHQsIFFQb2ludGVyPFFPcGVuR0xDb250ZXh0PiwgUVBvaW50ZXI8V1BFUXRWaWV3
Pik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0
Vmlld0xvYWRSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQ
RVF0Vmlld0xvYWRSZXF1ZXN0LmgKaW5kZXggYWFkMGUwNjdlNmM4Mjk5ZjE1NjVjZDFkOTFkODhi
M2JkMWJhZTFkYS4uYWM2MTFhMGZkNDBkMTczZTE2NThjMjY5NjkwZjExNTA1YzRhNWY5ZSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdMb2Fk
UmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRW
aWV3TG9hZFJlcXVlc3QuaApAQCAtMjcsNiArMjcsOCBAQAogY2xhc3MgV1BFUXRWaWV3TG9hZFJl
cXVlc3RQcml2YXRlOwogCiBjbGFzcyBXUEVRdFZpZXdMb2FkUmVxdWVzdCA6IHB1YmxpYyBRT2Jq
ZWN0IHsKKyAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKKwogICAgIFFfT0JKRUNUCiAgICAg
UV9QUk9QRVJUWShRVXJsIHVybCBSRUFEIHVybCkKICAgICBRX1BST1BFUlRZKFdQRVF0Vmlldzo6
TG9hZFN0YXR1cyBzdGF0dXMgUkVBRCBzdGF0dXMpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376871</attachid>
            <date>2019-08-21 06:22:04 -0700</date>
            <delta_ts>2019-08-21 06:48:37 -0700</delta_ts>
            <desc>patch</desc>
            <filename>bug-200973-20190821152202.patch</filename>
            <type>text/plain</type>
            <size>3500</size>
            <attacher name="Pablo Saavedra">psaavedra</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI2OTlhMjliZjlkM2QyNDEx
MjdlMjEwNWMxMTQyNjBmZTJiNzMxMjAuLmQzNTczOGRiNTZhZWZhNWU3Yjc1ZTYxMmJkNmZmYTQ2
NzI4OTg0MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTktMDgtMjEgIFBhYmxvIFNh
YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQnVpbGQgZmFp
bHVyZSBhZnRlciByMjQ4ODQ2IChbV1RGXSBBZGQgbWFrZVVuaXF1ZTxUPiwgd2hpY2ggZW5zdXJl
cyBUIGlzIGZhc3QtYWxsb2NhdGVkLCBtYWtlVW5pcXVlIC8gbWFrZVVuaXF1ZVdpdGhvdXRGYXN0
TWFsbG9jQ2hlY2sgcGFydCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDk3MworCisgICAgICAgIFdQRSBmYWlscyB0byBidWlsZCB3aXRoIGAtREVO
QUJMRV9XUEVfUVRfQVBJPU9OYCBhZnRlciBjaGFuZ2VzIGRvbmUgYnkgcjI0ODg0NiBpbjoKKwor
ICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNw
cAorICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3
QmFja2VuZC5jcHAKKworICAgICAgICA7IHRvIGZvcmNlcyBGYXN0TWFsbG9jIHVzZS4KKworICAg
ICAgICBSZWxhdGVkIHRvOgorCisgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIwMDYxMQorICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMDA2MjAKKworICAgICAgICBUaGlzIHBhdGNoIHB1dHMgV1BFUXQuLi4g
Y2xhc3NlcyBpbnRvIEZhc3RNYWxsb2MgaW4gdGhlIHNhbWUgd2F5IGl0CisgICAgICAgIHdhcyBk
b25lIGJ5IG1hbnkgb3RoZXJzIGluIHIyNDg2MDMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcu
Y3BwOgorICAgICAgICAoV1BFUXRWaWV3OjpydW5KYXZhU2NyaXB0KToKKyAgICAgICAgKiBVSVBy
b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmg6CisgICAgICAgICogVUlQcm9jZXNz
L0FQSS93cGUvcXQvV1BFUXRWaWV3TG9hZFJlcXVlc3QuaDoKKwogMjAxOS0wOC0yMCAgU2FpZCBB
Ym91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJF
R1JFU1NJT04gKDI0ODUwMSk6IGdtYWlsLmNvbSBpbWFnZXMgYXJlIHN0aWxsIG5vdCBzaG93biBv
biBzb21lIHZlcnNpb25zIG9mIGlQaG9uZSBpT1MxMwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy
b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwCmluZGV4IGI0ZjI3YjZkMzRlMjQyYmE1NTM1
YWI1YjJlNGVjZTUzMTVkMDlkMzcuLmY3ZTI5ZGMyZTE0MDhkMTcxYTUzNzcyNWYyNTZiZjEyOGFl
YzVlMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BF
UXRWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0
Vmlldy5jcHAKQEAgLTM3OSw3ICszNzksOSBAQCB2b2lkIFdQRVF0Vmlldzo6bG9hZEh0bWwoY29u
c3QgUVN0cmluZyYgaHRtbCwgY29uc3QgUVVybCYgYmFzZVVybCkKICAgICAgICAgd2Via2l0X3dl
Yl92aWV3X2xvYWRfaHRtbChtX3dlYlZpZXcuZ2V0KCksIGh0bWwudG9VdGY4KCkuY29uc3REYXRh
KCksIGJhc2VVcmwudG9TdHJpbmcoKS50b1V0ZjgoKS5jb25zdERhdGEoKSk7CiB9CiAKLXN0cnVj
dCBKYXZhc2NyaXB0Q2FsbGJhY2tEYXRhIHsKK2NsYXNzIEphdmFzY3JpcHRDYWxsYmFja0RhdGEg
eworICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOworcHVibGljOgogICAgIEphdmFzY3JpcHRD
YWxsYmFja0RhdGEoUUpTVmFsdWUgY2IsIFFQb2ludGVyPFdQRVF0Vmlldz4gb2JqKQogICAgICAg
ICA6IGNhbGxiYWNrKGNiKQogICAgICAgICAsIG9iamVjdChvYmopIHsgfQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmggYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaAppbmRl
eCBhMGMwZTdkMmUzNzI3M2U1OGZkOWRiYmEyY2Q1MTY2NjhhMmNkYTI0Li5iMGVmMTlkN2Q1YTM2
MzdiMDhhZjYyYzZjN2ExYmNmMGI4ZDNiMTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ
UHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaAorKysgYi9Tb3VyY2UvV2ViS2l0
L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaApAQCAtMzcsNiArMzcsNyBA
QAogY2xhc3MgV1BFUXRWaWV3OwogCiBjbGFzcyBRX0RFQ0xfRVhQT1JUIFdQRVF0Vmlld0JhY2tl
bmQgeworICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIHN0YXRpYyBz
dGQ6OnVuaXF1ZV9wdHI8V1BFUXRWaWV3QmFja2VuZD4gY3JlYXRlKGNvbnN0IFFTaXplRiYsIFFQ
b2ludGVyPFFPcGVuR0xDb250ZXh0PiwgRUdMRGlzcGxheSwgUVBvaW50ZXI8V1BFUXRWaWV3Pik7
CiAgICAgV1BFUXRWaWV3QmFja2VuZChjb25zdCBRU2l6ZUYmLCBFR0xEaXNwbGF5LCBFR0xDb250
ZXh0LCBRUG9pbnRlcjxRT3BlbkdMQ29udGV4dD4sIFFQb2ludGVyPFdQRVF0Vmlldz4pOwpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdMb2Fk
UmVxdWVzdC5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdM
b2FkUmVxdWVzdC5oCmluZGV4IGFhZDBlMDY3ZTZjODI5OWYxNTY1Y2QxZDkxZDg4YjNiZDFiYWUx
ZGEuLmFjNjExYTBmZDQwZDE3M2UxNjU4YzI2OTY5MGYxMTUwNWM0YTVmOWUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3TG9hZFJlcXVlc3Qu
aAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlld0xvYWRS
ZXF1ZXN0LmgKQEAgLTI3LDYgKzI3LDggQEAKIGNsYXNzIFdQRVF0Vmlld0xvYWRSZXF1ZXN0UHJp
dmF0ZTsKIAogY2xhc3MgV1BFUXRWaWV3TG9hZFJlcXVlc3QgOiBwdWJsaWMgUU9iamVjdCB7Cisg
ICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CisKICAgICBRX09CSkVDVAogICAgIFFfUFJPUEVS
VFkoUVVybCB1cmwgUkVBRCB1cmwpCiAgICAgUV9QUk9QRVJUWShXUEVRdFZpZXc6OkxvYWRTdGF0
dXMgc3RhdHVzIFJFQUQgc3RhdHVzKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376874</attachid>
            <date>2019-08-21 06:49:27 -0700</date>
            <delta_ts>2019-08-21 07:40:02 -0700</delta_ts>
            <desc>patch</desc>
            <filename>bug-200973-20190821154925.patch</filename>
            <type>text/plain</type>
            <size>3345</size>
            <attacher name="Pablo Saavedra">psaavedra</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI2OTlhMjliZjlkM2QyNDEx
MjdlMjEwNWMxMTQyNjBmZTJiNzMxMjAuLmQzNTczOGRiNTZhZWZhNWU3Yjc1ZTYxMmJkNmZmYTQ2
NzI4OTg0MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTktMDgtMjEgIFBhYmxvIFNh
YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQnVpbGQgZmFp
bHVyZSBhZnRlciByMjQ4ODQ2IChbV1RGXSBBZGQgbWFrZVVuaXF1ZTxUPiwgd2hpY2ggZW5zdXJl
cyBUIGlzIGZhc3QtYWxsb2NhdGVkLCBtYWtlVW5pcXVlIC8gbWFrZVVuaXF1ZVdpdGhvdXRGYXN0
TWFsbG9jQ2hlY2sgcGFydCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDk3MworCisgICAgICAgIFdQRSBmYWlscyB0byBidWlsZCB3aXRoIGAtREVO
QUJMRV9XUEVfUVRfQVBJPU9OYCBhZnRlciBjaGFuZ2VzIGRvbmUgYnkgcjI0ODg0NiBpbjoKKwor
ICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNw
cAorICAgICAgICAgIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3
QmFja2VuZC5jcHAKKworICAgICAgICA7IHRvIGZvcmNlcyBGYXN0TWFsbG9jIHVzZS4KKworICAg
ICAgICBSZWxhdGVkIHRvOgorCisgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIwMDYxMQorICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMDA2MjAKKworICAgICAgICBUaGlzIHBhdGNoIHB1dHMgV1BFUXQuLi4g
Y2xhc3NlcyBpbnRvIEZhc3RNYWxsb2MgaW4gdGhlIHNhbWUgd2F5IGl0CisgICAgICAgIHdhcyBk
b25lIGJ5IG1hbnkgb3RoZXJzIGluIHIyNDg2MDMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcu
Y3BwOgorICAgICAgICAoV1BFUXRWaWV3OjpydW5KYXZhU2NyaXB0KToKKyAgICAgICAgKiBVSVBy
b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmg6CisgICAgICAgICogVUlQcm9jZXNz
L0FQSS93cGUvcXQvV1BFUXRWaWV3TG9hZFJlcXVlc3QuaDoKKwogMjAxOS0wOC0yMCAgU2FpZCBB
Ym91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJF
R1JFU1NJT04gKDI0ODUwMSk6IGdtYWlsLmNvbSBpbWFnZXMgYXJlIHN0aWxsIG5vdCBzaG93biBv
biBzb21lIHZlcnNpb25zIG9mIGlQaG9uZSBpT1MxMwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy
b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwCmluZGV4IGI0ZjI3YjZkMzRlMjQyYmE1NTM1
YWI1YjJlNGVjZTUzMTVkMDlkMzcuLjk3MDQ0NGJhODJmZjM3MTQyYThkNTlmYzBkMWI1ZTY3YzAz
NzUyZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BF
UXRWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0
Vmlldy5jcHAKQEAgLTM4MCw2ICszODAsNyBAQCB2b2lkIFdQRVF0Vmlldzo6bG9hZEh0bWwoY29u
c3QgUVN0cmluZyYgaHRtbCwgY29uc3QgUVVybCYgYmFzZVVybCkKIH0KIAogc3RydWN0IEphdmFz
Y3JpcHRDYWxsYmFja0RhdGEgeworICAgIFdURl9NQUtFX1NUUlVDVF9GQVNUX0FMTE9DQVRFRDsK
ICAgICBKYXZhc2NyaXB0Q2FsbGJhY2tEYXRhKFFKU1ZhbHVlIGNiLCBRUG9pbnRlcjxXUEVRdFZp
ZXc+IG9iaikKICAgICAgICAgOiBjYWxsYmFjayhjYikKICAgICAgICAgLCBvYmplY3Qob2JqKSB7
IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRW
aWV3QmFja2VuZC5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZp
ZXdCYWNrZW5kLmgKaW5kZXggYTBjMGU3ZDJlMzcyNzNlNThmZDlkYmJhMmNkNTE2NjY4YTJjZGEy
NC4uYjBlZjE5ZDdkNWEzNjM3YjA4YWY2MmM2YzdhMWJjZjBiOGQzYjEzNCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmgKKysr
IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmgK
QEAgLTM3LDYgKzM3LDcgQEAKIGNsYXNzIFdQRVF0VmlldzsKIAogY2xhc3MgUV9ERUNMX0VYUE9S
VCBXUEVRdFZpZXdCYWNrZW5kIHsKKyAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1Ymxp
YzoKICAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFdQRVF0Vmlld0JhY2tlbmQ+IGNyZWF0ZShj
b25zdCBRU2l6ZUYmLCBRUG9pbnRlcjxRT3BlbkdMQ29udGV4dD4sIEVHTERpc3BsYXksIFFQb2lu
dGVyPFdQRVF0Vmlldz4pOwogICAgIFdQRVF0Vmlld0JhY2tlbmQoY29uc3QgUVNpemVGJiwgRUdM
RGlzcGxheSwgRUdMQ29udGV4dCwgUVBvaW50ZXI8UU9wZW5HTENvbnRleHQ+LCBRUG9pbnRlcjxX
UEVRdFZpZXc+KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUv
cXQvV1BFUXRWaWV3TG9hZFJlcXVlc3QuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93
cGUvcXQvV1BFUXRWaWV3TG9hZFJlcXVlc3QuaAppbmRleCBhYWQwZTA2N2U2YzgyOTlmMTU2NWNk
MWQ5MWQ4OGIzYmQxYmFlMWRhLi5hYzYxMWEwZmQ0MGQxNzNlMTY1OGMyNjk2OTBmMTE1MDVjNGE1
ZjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0
Vmlld0xvYWRSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9x
dC9XUEVRdFZpZXdMb2FkUmVxdWVzdC5oCkBAIC0yNyw2ICsyNyw4IEBACiBjbGFzcyBXUEVRdFZp
ZXdMb2FkUmVxdWVzdFByaXZhdGU7CiAKIGNsYXNzIFdQRVF0Vmlld0xvYWRSZXF1ZXN0IDogcHVi
bGljIFFPYmplY3QgeworICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOworCiAgICAgUV9PQkpF
Q1QKICAgICBRX1BST1BFUlRZKFFVcmwgdXJsIFJFQUQgdXJsKQogICAgIFFfUFJPUEVSVFkoV1BF
UXRWaWV3OjpMb2FkU3RhdHVzIHN0YXR1cyBSRUFEIHN0YXR1cykK
</data>

          </attachment>
      

    </bug>

</bugzilla>