200969 2019-08-21 01:20:48 -0700 Web Inspector: Provide an engineering option to log protocol traffic as text 2019-08-22 22:04:39 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1563412 0 joepeck 2019-08-21 01:20:48 -0700 Provide an engineering option to log protocol traffic as text This makes the protocol traffic easier to copy/paste and filter. 1563413 1 376853 joepeck 2019-08-21 01:21:27 -0700 Created attachment 376853 [PATCH] Proposed Fix 1563422 2 376853 hi 2019-08-21 02:36:55 -0700 Comment on attachment 376853 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=376853&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387 > + debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText, WI.unlocalizedString("Log Protocol as Text")); I'd put this in a "Protocol Logging:" section to match what's there in the Debug pane. 1564068 3 joepeck 2019-08-22 09:00:44 -0700 > > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387 > > + debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText, WI.unlocalizedString("Log Protocol as Text")); > > I'd put this in a "Protocol Logging:" section to match what's there in the > Debug pane. Good idea. I moved this into the `protocol` variables and Debug section as "Log as Text". 1564070 4 377014 joepeck 2019-08-22 09:01:17 -0700 Created attachment 377014 [PATCH] For Landing 1564087 5 377014 commit-queue 2019-08-22 09:43:04 -0700 Comment on attachment 377014 [PATCH] For Landing Clearing flags on attachment: 377014 Committed r249014: <https://trac.webkit.org/changeset/249014> 1564378 6 webkit-bug-importer 2019-08-22 22:04:39 -0700 <rdar://problem/54628714> 376853 2019-08-21 01:21:27 -0700 2019-08-22 09:00:52 -0700 [PATCH] Proposed Fix log-as-text.patch text/plain 3740 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI2Y2ZiMWU2NjMyLi5hYzJjN2YxYTBmYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBQcm92aWRlIGFuIGVuZ2luZWVyaW5nIG9wdGlvbiB0byBsb2cgcHJvdG9jb2wgdHJhZmZpYyBh cyB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDA5NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv UHJvdG9jb2wvTG9nZ2luZ1Byb3RvY29sVHJhY2VyLmpzOgorICAgICAgICAoV0kuTG9nZ2luZ1By b3RvY29sVHJhY2VyLnByb3RvdHlwZS5fcHJvY2Vzc0VudHJ5KToKKyAgICAgICAgKFdJLkxvZ2dp bmdQcm90b2NvbFRyYWNlcik6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5n c1RhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuU2V0dGluZ3NUYWJDb250ZW50Vmlldy5w cm90b3R5cGUuX2NyZWF0ZUVuZ2luZWVyaW5nU2V0dGluZ3NWaWV3KToKKwogMjAxOS0wOC0yMSAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJlbW92ZSB1bm5lY2Vzc2FyeSBwcm9wZXJ0aWVzIG9uIFNWR3MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcwppbmRleCBi ODZhNWE2YTZjMi4uYTVlNWI1NTk3YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKQEAgLTE5Myw2ICsxOTMsNyBAQCBXSS5z ZXR0aW5ncyA9IHsKICAgICBwcm90b2NvbEZpbHRlck11bHRpcGxleGluZ0JhY2tlbmRNZXNzYWdl czogbmV3IFdJLlNldHRpbmcoInByb3RvY29sLWZpbHRlci1tdWx0aXBsZXhpbmctYmFja2VuZC1t ZXNzYWdlcyIsIHRydWUpLAogCiAgICAgLy8gRW5naW5lZXJpbmcKKyAgICBlbmdpbmVlcmluZ0xv Z1Byb3RvY29sQXNUZXh0OiBuZXcgV0kuU2V0dGluZygiZW5naW5lZXJpbmctbG9nLXByb3RvY29s LWFzLXRleHQiLCBmYWxzZSksCiAgICAgZW5naW5lZXJpbmdTaG93SW50ZXJuYWxTY3JpcHRzOiBu ZXcgV0kuU2V0dGluZygiZW5naW5lZXJpbmctc2hvdy1pbnRlcm5hbC1zY3JpcHRzIiwgZmFsc2Up LAogICAgIGVuZ2luZWVyaW5nUGF1c2VGb3JJbnRlcm5hbFNjcmlwdHM6IG5ldyBXSS5TZXR0aW5n KCJlbmdpbmVlcmluZy1wYXVzZS1mb3ItaW50ZXJuYWwtc2NyaXB0cyIsIGZhbHNlKSwKICAgICBl bmdpbmVlcmluZ1Nob3dJbnRlcm5hbE9iamVjdHNJbkhlYXBTbmFwc2hvdDogbmV3IFdJLlNldHRp bmcoImVuZ2luZWVyaW5nLXNob3ctaW50ZXJuYWwtb2JqZWN0cy1pbi1oZWFwLXNuYXBzaG90Iiwg ZmFsc2UpLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv UHJvdG9jb2wvTG9nZ2luZ1Byb3RvY29sVHJhY2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvTG9nZ2luZ1Byb3RvY29sVHJhY2VyLmpzCmluZGV4IGU4 NGNhNGNiOTM3Li4yMDM2ZjAzM2NjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvTG9nZ2luZ1Byb3RvY29sVHJhY2VyLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0xvZ2dpbmdQcm90b2Nv bFRyYWNlci5qcwpAQCAtMTIxLDcgKzEyMSw3IEBAIFdJLkxvZ2dpbmdQcm90b2NvbFRyYWNlciA9 IGNsYXNzIExvZ2dpbmdQcm90b2NvbFRyYWNlciBleHRlbmRzIFdJLlByb3RvY29sVHJhY2VyCiAg ICAgICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgICAgICBsZXQgcHJlZml4ID0gYCR7ZW50 cnkudHlwZX0gKCR7dGFyZ2V0SWR9KWA7Ci0gICAgICAgICAgICBpZiAoIXdpbmRvdy5JbnNwZWN0 b3JUZXN0ICYmIEluc3BlY3RvckZyb250ZW5kSG9zdC5pc0JlaW5nSW5zcGVjdGVkKCkpIHsKKyAg ICAgICAgICAgIGlmICghd2luZG93Lkluc3BlY3RvclRlc3QgJiYgSW5zcGVjdG9yRnJvbnRlbmRI b3N0LmlzQmVpbmdJbnNwZWN0ZWQoKSAmJiAhV0kuc2V0dGluZ3MuZW5naW5lZXJpbmdMb2dQcm90 b2NvbEFzVGV4dC52YWx1ZSkgewogICAgICAgICAgICAgICAgIGlmIChlbnRyeS50eXBlID09PSAi cmVxdWVzdCIgfHwgZW50cnkudHlwZSA9PT0gImV4Y2VwdGlvbiIpCiAgICAgICAgICAgICAgICAg ICAgIGNvbnNvbGUudHJhY2UocHJlZml4LCBlbnRyeS5tZXNzYWdlKTsKICAgICAgICAgICAgICAg ICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcwppbmRleCBmMzhkMDll YmIwMC4uOGI1ZGMxMmExZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5q cwpAQCAtMzg0LDYgKzM4NCw3IEBAIFdJLlNldHRpbmdzVGFiQ29udGVudFZpZXcgPSBjbGFzcyBT ZXR0aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuVGFiQ29udGVudFZpCiAgICAgICAgIGxl dCBlbmdpbmVlcmluZ1NldHRpbmdzVmlldyA9IG5ldyBXSS5TZXR0aW5nc1ZpZXcoImVuZ2luZWVy aW5nIiwgV0kudW5sb2NhbGl6ZWRTdHJpbmcoIkVuZ2luZWVyaW5nIikpOwogCiAgICAgICAgIGxl dCBkZWJ1Z2dpbmdHcm91cCA9IGVuZ2luZWVyaW5nU2V0dGluZ3NWaWV3LmFkZEdyb3VwKFdJLnVu bG9jYWxpemVkU3RyaW5nKCJEZWJ1Z2dpbmc6IikpOworICAgICAgICBkZWJ1Z2dpbmdHcm91cC5h ZGRTZXR0aW5nKFdJLnNldHRpbmdzLmVuZ2luZWVyaW5nTG9nUHJvdG9jb2xBc1RleHQsIFdJLnVu bG9jYWxpemVkU3RyaW5nKCJMb2cgUHJvdG9jb2wgYXMgVGV4dCIpKTsKICAgICAgICAgZGVidWdn aW5nR3JvdXAuYWRkU2V0dGluZyhXSS5zZXR0aW5ncy5lbmdpbmVlcmluZ1Nob3dJbnRlcm5hbFNj cmlwdHMsIFdJLnVubG9jYWxpemVkU3RyaW5nKCJTaG93IFdlYktpdC1pbnRlcm5hbCBzY3JpcHRz IikpOwogICAgICAgICBkZWJ1Z2dpbmdHcm91cC5hZGRTZXR0aW5nKFdJLnNldHRpbmdzLmVuZ2lu ZWVyaW5nUGF1c2VGb3JJbnRlcm5hbFNjcmlwdHMsIFdJLnVubG9jYWxpemVkU3RyaW5nKCJQYXVz ZSBpbiBXZWJLaXQtaW50ZXJuYWwgc2NyaXB0cyIpKTsKIAo= 377014 2019-08-22 09:01:17 -0700 2019-08-22 09:43:04 -0700 [PATCH] For Landing for-landing-2.patch text/plain 3333 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFmYzg4ZDA3ODFiLi5hODczNmQ5MjgzMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBQcm92aWRlIGFuIGVuZ2luZWVyaW5nIG9wdGlvbiB0byBsb2cgcHJvdG9jb2wgdHJhZmZpYyBh cyB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDA5NjkKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1By b3RvY29sL0xvZ2dpbmdQcm90b2NvbFRyYWNlci5qczoKKyAgICAgICAgKFdJLkxvZ2dpbmdQcm90 b2NvbFRyYWNlci5wcm90b3R5cGUuX3Byb2Nlc3NFbnRyeSk6CisgICAgICAgIChXSS5Mb2dnaW5n UHJvdG9jb2xUcmFjZXIpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NU YWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlNldHRpbmdzVGFiQ29udGVudFZpZXcucHJv dG90eXBlLl9jcmVhdGVEZWJ1Z1NldHRpbmdzVmlldyk6CisKIDIwMTktMDgtMjEgIE5pa2l0YSBW YXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog UlRMOiBET00gb3V0bGluZSBpbiBFbGVtZW50cyB0YWIgc2hvdWxkIGJlIExUUgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCmluZGV4 IGRjMjVhNWFmZDcwLi45Mzk0YWU2OGM1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcwpAQCAtMTg5LDYgKzE4OSw3IEBAIFdJ LnNldHRpbmdzID0gewogICAgIGV4cGVyaW1lbnRhbEVuYWJsZVN0eWxlc0p1bXBUb0VmZmVjdGl2 ZTogbmV3IFdJLlNldHRpbmcoImV4cGVyaW1lbnRhbC1zdHlsZXMtanVtcC10by1lZmZlY3RpdmUi LCBmYWxzZSksCiAKICAgICAvLyBQcm90b2NvbAorICAgIHByb3RvY29sTG9nQXNUZXh0OiBuZXcg V0kuU2V0dGluZygicHJvdG9jb2wtbG9nLWFzLXRleHQiLCBmYWxzZSksCiAgICAgcHJvdG9jb2xB dXRvTG9nTWVzc2FnZXM6IG5ldyBXSS5TZXR0aW5nKCJwcm90b2NvbC1hdXRvLWxvZy1tZXNzYWdl cyIsIGZhbHNlKSwKICAgICBwcm90b2NvbEF1dG9Mb2dUaW1lU3RhdHM6IG5ldyBXSS5TZXR0aW5n KCJwcm90b2NvbC1hdXRvLWxvZy10aW1lLXN0YXRzIiwgZmFsc2UpLAogICAgIHByb3RvY29sRmls dGVyTXVsdGlwbGV4aW5nQmFja2VuZE1lc3NhZ2VzOiBuZXcgV0kuU2V0dGluZygicHJvdG9jb2wt ZmlsdGVyLW11bHRpcGxleGluZy1iYWNrZW5kLW1lc3NhZ2VzIiwgdHJ1ZSksCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9Mb2dnaW5nUHJv dG9jb2xUcmFjZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90 b2NvbC9Mb2dnaW5nUHJvdG9jb2xUcmFjZXIuanMKaW5kZXggZTg0Y2E0Y2I5MzcuLjYwMTBlMzRm ZDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90 b2NvbC9Mb2dnaW5nUHJvdG9jb2xUcmFjZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvTG9nZ2luZ1Byb3RvY29sVHJhY2VyLmpzCkBAIC0xMjEs NyArMTIxLDcgQEAgV0kuTG9nZ2luZ1Byb3RvY29sVHJhY2VyID0gY2xhc3MgTG9nZ2luZ1Byb3Rv Y29sVHJhY2VyIGV4dGVuZHMgV0kuUHJvdG9jb2xUcmFjZXIKICAgICAgICAgICAgICAgICByZXR1 cm47CiAKICAgICAgICAgICAgIGxldCBwcmVmaXggPSBgJHtlbnRyeS50eXBlfSAoJHt0YXJnZXRJ ZH0pYDsKLSAgICAgICAgICAgIGlmICghd2luZG93Lkluc3BlY3RvclRlc3QgJiYgSW5zcGVjdG9y RnJvbnRlbmRIb3N0LmlzQmVpbmdJbnNwZWN0ZWQoKSkgeworICAgICAgICAgICAgaWYgKCF3aW5k b3cuSW5zcGVjdG9yVGVzdCAmJiBJbnNwZWN0b3JGcm9udGVuZEhvc3QuaXNCZWluZ0luc3BlY3Rl ZCgpICYmICFXSS5zZXR0aW5ncy5wcm90b2NvbExvZ0FzVGV4dC52YWx1ZSkgewogICAgICAgICAg ICAgICAgIGlmIChlbnRyeS50eXBlID09PSAicmVxdWVzdCIgfHwgZW50cnkudHlwZSA9PT0gImV4 Y2VwdGlvbiIpCiAgICAgICAgICAgICAgICAgICAgIGNvbnNvbGUudHJhY2UocHJlZml4LCBlbnRy eS5tZXNzYWdlKTsKICAgICAgICAgICAgICAgICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJD b250ZW50Vmlldy5qcwppbmRleCBmMzhkMDllYmIwMC4uM2ZiODM5OWEwNDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29u dGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcwpAQCAtNDEzLDYgKzQxMyw3IEBAIFdJLlNldHRp bmdzVGFiQ29udGVudFZpZXcgPSBjbGFzcyBTZXR0aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMg V0kuVGFiQ29udGVudFZpCiAgICAgICAgIH0pOwogCiAgICAgICAgIHByb3RvY29sTWVzc2FnZXNH cm91cC5hZGRTZXR0aW5nKFdJLnNldHRpbmdzLnByb3RvY29sQXV0b0xvZ1RpbWVTdGF0cywgV0ku dW5sb2NhbGl6ZWRTdHJpbmcoIlRpbWUgU3RhdHMiKSk7CisgICAgICAgIHByb3RvY29sTWVzc2Fn ZXNHcm91cC5hZGRTZXR0aW5nKFdJLnNldHRpbmdzLnByb3RvY29sTG9nQXNUZXh0LCBXSS51bmxv Y2FsaXplZFN0cmluZygiTG9nIGFzIFRleHQiKSk7CiAKICAgICAgICAgdGhpcy5fZGVidWdTZXR0 aW5nc1ZpZXcuYWRkU2VwYXJhdG9yKCk7CiAK