200965 2019-08-20 20:50:03 -0700 JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop 2019-08-21 12:18:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue saam webkit-bug-importer ysuzuki oldest_to_newest 1563384 0 ross.kirsling 2019-08-20 20:50:03 -0700 JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop 1563387 1 376842 ross.kirsling 2019-08-20 20:54:11 -0700 Created attachment 376842 Patch 1563521 2 376842 saam 2019-08-21 09:37:34 -0700 Comment on attachment 376842 Patch Maybe run them in a shorter loop so they hit the JITs in eager tests at least? Maybe a loop with 100 iterations? 1563583 3 ross.kirsling 2019-08-21 11:31:59 -0700 (In reply to Saam Barati from comment #2) > Comment on attachment 376842 [details] > Patch > > Maybe run them in a shorter loop so they hit the JITs in eager tests at > least? Maybe a loop with 100 iterations? Works for me. 1563584 4 376898 ross.kirsling 2019-08-21 11:33:19 -0700 Created attachment 376898 Patch for landing 1563604 5 376898 commit-queue 2019-08-21 12:17:20 -0700 Comment on attachment 376898 Patch for landing Clearing flags on attachment: 376898 Committed r248955: <https://trac.webkit.org/changeset/248955> 1563605 6 commit-queue 2019-08-21 12:17:22 -0700 All reviewed patches have been landed. Closing bug. 1563606 7 webkit-bug-importer 2019-08-21 12:18:18 -0700 <rdar://problem/54566510> 376842 2019-08-20 20:54:11 -0700 2019-08-21 11:33:17 -0700 Patch bug-200965-20190820205410.patch text/plain 3115 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODYwCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE4ZGE5NTFiNWQ1MTM4MTNkOGMzNmQzMWYzNTk5 YjIzYzYyZjY3MDIuLjY4MGM3YjM4ODFkNjQ5ZjgwZjAxZWRjMjMwN2I5MGJkZTkwODQ2YWEgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTktMDgtMjAgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNv bnkuY29tPgorCisgICAgICAgIEpTVGVzdHMvc3RyZXNzL29wdGlvbmFsLWNoYWluaW5nIHNob3Vs ZCBub3QgY2FsbCBzaG91bGRUaHJvd1R5cGVFcnJvciBpbiBhIGxvb3AKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDk2NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaGFzIG5vdGhpbmcgdG8gZG8g d2l0aCA/LiBpbiBwYXJ0aWN1bGFyLCBidXQgdGhyb3dpbmcgPjFNIHR5cGUgZXJyb3JzIHRha2Vz IDEwMHMgaW4gRGVidWcgb24gbXkgbWFjaGluZS4KKyAgICAgICAgSSB3YXMgcmVhbGx5IG9ubHkg bWVhbmluZyB0byBKSVRpZnkgdGhlIHNpbXBsZSBzdWNjZXNzIGNhc2VzIGhlcmUsIHNvIGxldCdz IHN0b3AgdGhpcyBub25zZW5zZS4gOlAKKworICAgICAgICAqIHN0cmVzcy9vcHRpb25hbC1jaGFp bmluZy5qczoKKyAgICAgICAgKHRlc3RCYXNpY0Nhc2VzKToKKyAgICAgICAgKHNob3VsZFRocm93 VHlwZUVycm9yKToKKwogMjAxOS0wOC0xOSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWJraXQganNjIENyYXNoIGluIFJlZ0V4cDo6bWF0Y2hJbmxpbmUg KHRoaXM9PG9wdGltaXplZCBvdXQ+CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9vcHRpb25h bC1jaGFpbmluZy5qcyBiL0pTVGVzdHMvc3RyZXNzL29wdGlvbmFsLWNoYWluaW5nLmpzCmluZGV4 IDI3Njc5NDkwYWUyMTk4NmZjOGY0YmVmNzgwYTJkMWQ1MjMwZTg3NjcuLjJhM2EwMzM0NTcxYWJi MTQ2ZWIzNzNlNjJjZDk2YmU2Y2I4NDU5NWMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL29w dGlvbmFsLWNoYWluaW5nLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL29wdGlvbmFsLWNoYWluaW5n LmpzCkBAIC02NiwyMyArNjYsMjUgQEAgZnVuY3Rpb24gdGVzdEJhc2ljQ2FzZXMoKSB7CiAKICAg ICBzaG91bGRCZSh1bmRlZmluZWQ/LigpLCB1bmRlZmluZWQpOwogICAgIHNob3VsZEJlKG51bGw/ LigpLCB1bmRlZmluZWQpOwotICAgIHNob3VsZFRocm93VHlwZUVycm9yKCgpID0+IHRydWU/Ligp LCAndHJ1ZSBpcyBub3QgYSBmdW5jdGlvbicpOwotICAgIHNob3VsZFRocm93VHlwZUVycm9yKCgp ID0+IGZhbHNlPy4oKSwgJ2ZhbHNlIGlzIG5vdCBhIGZ1bmN0aW9uJyk7Ci0gICAgc2hvdWxkVGhy b3dUeXBlRXJyb3IoKCkgPT4gMD8uKCksICcwIGlzIG5vdCBhIGZ1bmN0aW9uJyk7Ci0gICAgc2hv dWxkVGhyb3dUeXBlRXJyb3IoKCkgPT4gMT8uKCksICcxIGlzIG5vdCBhIGZ1bmN0aW9uJyk7Ci0g ICAgc2hvdWxkVGhyb3dUeXBlRXJyb3IoKCkgPT4gJyc/LigpLCAnXCdcJyBpcyBub3QgYSBmdW5j dGlvbicpOwotICAgIHNob3VsZFRocm93VHlwZUVycm9yKCgpID0+ICdoaSc/LigpLCAnXCdoaVwn IGlzIG5vdCBhIGZ1bmN0aW9uJyk7Ci0gICAgc2hvdWxkVGhyb3dUeXBlRXJyb3IoKCkgPT4gKHt9 KT8uKCksICcoe30pIGlzIG5vdCBhIGZ1bmN0aW9uJyk7Ci0gICAgc2hvdWxkVGhyb3dUeXBlRXJy b3IoKCkgPT4gKHsgeDogJ2hpJyB9KT8uKCksICcoeyB4OiBcJ2hpXCcgfSkgaXMgbm90IGEgZnVu Y3Rpb24nKTsKLSAgICBzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9PiBbXT8uKCksICdbXSBpcyBu b3QgYSBmdW5jdGlvbicpOwotICAgIHNob3VsZFRocm93VHlwZUVycm9yKCgpID0+IFsnaGknXT8u KCksICdbXCdoaVwnXSBpcyBub3QgYSBmdW5jdGlvbicpOwotICAgIHNob3VsZFRocm93VHlwZUVy cm9yKCgpID0+IG1hc3F1ZXJhZGVyPy4oKSwgJ21hc3F1ZXJhZGVyIGlzIG5vdCBhIGZ1bmN0aW9u Jyk7CisgICAgc2hvdWxkQmUoKCgpID0+IDMpPy4oKSwgMyk7CiB9CiBub0lubGluZSh0ZXN0QmFz aWNDYXNlcyk7CiAKIGZvciAobGV0IGkgPSAwOyBpIDwgMWU1OyBpKyspCiAgICAgdGVzdEJhc2lj Q2FzZXMoKTsKIAorc2hvdWxkVGhyb3dUeXBlRXJyb3IoKCkgPT4gdHJ1ZT8uKCksICd0cnVlIGlz IG5vdCBhIGZ1bmN0aW9uJyk7CitzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9PiBmYWxzZT8uKCks ICdmYWxzZSBpcyBub3QgYSBmdW5jdGlvbicpOworc2hvdWxkVGhyb3dUeXBlRXJyb3IoKCkgPT4g MD8uKCksICcwIGlzIG5vdCBhIGZ1bmN0aW9uJyk7CitzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9 PiAxPy4oKSwgJzEgaXMgbm90IGEgZnVuY3Rpb24nKTsKK3Nob3VsZFRocm93VHlwZUVycm9yKCgp ID0+ICcnPy4oKSwgJ1wnXCcgaXMgbm90IGEgZnVuY3Rpb24nKTsKK3Nob3VsZFRocm93VHlwZUVy cm9yKCgpID0+ICdoaSc/LigpLCAnXCdoaVwnIGlzIG5vdCBhIGZ1bmN0aW9uJyk7CitzaG91bGRU aHJvd1R5cGVFcnJvcigoKSA9PiAoe30pPy4oKSwgJyh7fSkgaXMgbm90IGEgZnVuY3Rpb24nKTsK K3Nob3VsZFRocm93VHlwZUVycm9yKCgpID0+ICh7IHg6ICdoaScgfSk/LigpLCAnKHsgeDogXCdo aVwnIH0pIGlzIG5vdCBhIGZ1bmN0aW9uJyk7CitzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9PiBb XT8uKCksICdbXSBpcyBub3QgYSBmdW5jdGlvbicpOworc2hvdWxkVGhyb3dUeXBlRXJyb3IoKCkg PT4gWydoaSddPy4oKSwgJ1tcJ2hpXCddIGlzIG5vdCBhIGZ1bmN0aW9uJyk7CitzaG91bGRUaHJv d1R5cGVFcnJvcigoKSA9PiBtYXNxdWVyYWRlcj8uKCksICdtYXNxdWVyYWRlciBpcyBub3QgYSBm dW5jdGlvbicpOworCiBzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9PiAoe30pPy5pKCksICcoe30p Py5pIGlzIG5vdCBhIGZ1bmN0aW9uJyk7CiBzaG91bGRCZSgoe30pLmk/LigpLCB1bmRlZmluZWQp Owogc2hvdWxkQmUoKHt9KT8uaT8uKCksIHVuZGVmaW5lZCk7Cg== 376898 2019-08-21 11:33:19 -0700 2019-08-21 12:17:20 -0700 Patch for landing bug-200965-20190821113318.patch text/plain 2440 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODYwCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE4ZGE5NTFiNWQ1MTM4MTNkOGMzNmQzMWYzNTk5 YjIzYzYyZjY3MDIuLjZkOGYzOWVmMmI2ZGFhMzJhMTAzODAwMDVjNzExNzhjYWQ4YTgyY2YgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTktMDgtMjEgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNv bnkuY29tPgorCisgICAgICAgIEpTVGVzdHMvc3RyZXNzL29wdGlvbmFsLWNoYWluaW5nIHNob3Vs ZCBub3QgY2FsbCBzaG91bGRUaHJvd1R5cGVFcnJvciBpbiBhIGxvb3AKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDk2NQorCisgICAgICAgIFJldmll d2VkIGJ5IFNhYW0gQmFyYXRpLgorCisgICAgICAgIFRoaXMgaGFzIG5vdGhpbmcgdG8gZG8gd2l0 aCA/LiBpbiBwYXJ0aWN1bGFyLCBidXQgdGhyb3dpbmcgPjFNIHR5cGUgZXJyb3JzIHRha2VzIDEw MHMgaW4gRGVidWcgb24gbXkgbWFjaGluZS4KKyAgICAgICAgVGhlIG1haW4gaWRlYSBoZXJlIHdh cyB0byBKSVRpZnkgdGhlIHNpbXBsZSBzdWNjZXNzIGNhc2VzLCBzbyBsZXQncyBub3QgcnVuIHRo ZSBzaW1wbGUgZmFpbHVyZXMgc28gbWFueSB0aW1lcy4KKworICAgICAgICAqIHN0cmVzcy9vcHRp b25hbC1jaGFpbmluZy5qczoKKwogMjAxOS0wOC0xOSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2Zm QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJraXQganNjIENyYXNoIGluIFJlZ0V4cDo6bWF0Y2hJ bmxpbmUgKHRoaXM9PG9wdGltaXplZCBvdXQ+CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9v cHRpb25hbC1jaGFpbmluZy5qcyBiL0pTVGVzdHMvc3RyZXNzL29wdGlvbmFsLWNoYWluaW5nLmpz CmluZGV4IDI3Njc5NDkwYWUyMTk4NmZjOGY0YmVmNzgwYTJkMWQ1MjMwZTg3NjcuLjQ1YzBiZGZh MGI0YTUxNWFhYTMxYmI2MDg4ZmYxYTU2OTk3OWRlNzEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3Ry ZXNzL29wdGlvbmFsLWNoYWluaW5nLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL29wdGlvbmFsLWNo YWluaW5nLmpzCkBAIC0zNSw3ICszNSw3IEBAIGZ1bmN0aW9uIHNob3VsZFRocm93VHlwZUVycm9y KGZ1bmMsIG1lc3NhZ2VQcmVmaXgpIHsKIGNvbnN0IG1hc3F1ZXJhZGVyID0gbWFrZU1hc3F1ZXJh ZGVyKCk7CiBtYXNxdWVyYWRlci5mb28gPSAzOwogCi1mdW5jdGlvbiB0ZXN0QmFzaWNDYXNlcygp IHsKK2Z1bmN0aW9uIHRlc3RCYXNpY1N1Y2Nlc3NDYXNlcygpIHsKICAgICBzaG91bGRCZSh1bmRl ZmluZWQ/LnZhbHVlT2YoKSwgdW5kZWZpbmVkKTsKICAgICBzaG91bGRCZShudWxsPy52YWx1ZU9m KCksIHVuZGVmaW5lZCk7CiAgICAgc2hvdWxkQmUodHJ1ZT8udmFsdWVPZigpLCB0cnVlKTsKQEAg LTY2LDYgKzY2LDExIEBAIGZ1bmN0aW9uIHRlc3RCYXNpY0Nhc2VzKCkgewogCiAgICAgc2hvdWxk QmUodW5kZWZpbmVkPy4oKSwgdW5kZWZpbmVkKTsKICAgICBzaG91bGRCZShudWxsPy4oKSwgdW5k ZWZpbmVkKTsKKyAgICBzaG91bGRCZSgoKCkgPT4gMyk/LigpLCAzKTsKK30KK25vSW5saW5lKHRl c3RCYXNpY1N1Y2Nlc3NDYXNlcyk7CisKK2Z1bmN0aW9uIHRlc3RCYXNpY0ZhaWx1cmVDYXNlcygp IHsKICAgICBzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9PiB0cnVlPy4oKSwgJ3RydWUgaXMgbm90 IGEgZnVuY3Rpb24nKTsKICAgICBzaG91bGRUaHJvd1R5cGVFcnJvcigoKSA9PiBmYWxzZT8uKCks ICdmYWxzZSBpcyBub3QgYSBmdW5jdGlvbicpOwogICAgIHNob3VsZFRocm93VHlwZUVycm9yKCgp ID0+IDA/LigpLCAnMCBpcyBub3QgYSBmdW5jdGlvbicpOwpAQCAtNzgsMTAgKzgzLDEzIEBAIGZ1 bmN0aW9uIHRlc3RCYXNpY0Nhc2VzKCkgewogICAgIHNob3VsZFRocm93VHlwZUVycm9yKCgpID0+ IFsnaGknXT8uKCksICdbXCdoaVwnXSBpcyBub3QgYSBmdW5jdGlvbicpOwogICAgIHNob3VsZFRo cm93VHlwZUVycm9yKCgpID0+IG1hc3F1ZXJhZGVyPy4oKSwgJ21hc3F1ZXJhZGVyIGlzIG5vdCBh IGZ1bmN0aW9uJyk7CiB9Ci1ub0lubGluZSh0ZXN0QmFzaWNDYXNlcyk7Citub0lubGluZSh0ZXN0 QmFzaWNGYWlsdXJlQ2FzZXMpOwogCiBmb3IgKGxldCBpID0gMDsgaSA8IDFlNTsgaSsrKQotICAg IHRlc3RCYXNpY0Nhc2VzKCk7CisgICAgdGVzdEJhc2ljU3VjY2Vzc0Nhc2VzKCk7CisKK2ZvciAo bGV0IGkgPSAwOyBpIDwgMTAwOyBpKyspCisgICAgdGVzdEJhc2ljRmFpbHVyZUNhc2VzKCk7CiAK IHNob3VsZFRocm93VHlwZUVycm9yKCgpID0+ICh7fSk/LmkoKSwgJyh7fSk/LmkgaXMgbm90IGEg ZnVuY3Rpb24nKTsKIHNob3VsZEJlKCh7fSkuaT8uKCksIHVuZGVmaW5lZCk7Cg==