200956 2019-08-20 17:32:11 -0700 JSBigInt::m_length should be immutable. 2019-08-20 17:40:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1563326 0 mark.lam 2019-08-20 17:32:11 -0700 This is because the JSBigInt cell size is allocated with that length. Changing the length after construction does not change the size of the cell, and hence, makes no sense. 1563329 1 376832 mark.lam 2019-08-20 17:35:42 -0700 Created attachment 376832 proposed patch. 1563330 2 376832 ysuzuki 2019-08-20 17:37:04 -0700 Comment on attachment 376832 proposed patch. r=me 1563331 3 mark.lam 2019-08-20 17:39:38 -0700 Thanks for the review. Landed in r248927: <http://trac.webkit.org/r248927>. 1563333 4 webkit-bug-importer 2019-08-20 17:40:19 -0700 <rdar://problem/54536646> 376832 2019-08-20 17:35:42 -0700 2019-08-20 17:37:04 -0700 proposed patch. bug-200956.patch text/plain 1920 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ4OTI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE5LTA4LTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBK U0JpZ0ludDo6bV9sZW5ndGggc2hvdWxkIGJlIGltbXV0YWJsZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDk1NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSB0aGUgSlNCaWdJ bnQgY2VsbCBzaXplIGlzIGFsbG9jYXRlZCB3aXRoIHRoYXQgbGVuZ3RoLiAgQ2hhbmdpbmcKKyAg ICAgICAgdGhlIGxlbmd0aCBhZnRlciBjb25zdHJ1Y3Rpb24gZG9lcyBub3QgY2hhbmdlIHRoZSBz aXplIG9mIHRoZSBjZWxsLCBhbmQgaGVuY2UsCisgICAgICAgIG1ha2VzIG5vIHNlbnNlLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgc2V0TGVuZ3RoKCkgbWV0aG9kLCBhbmQgZGVj b3JhdGVzIHRoZSBtX2xlbmd0aCBmaWVsZCB3aXRoCisgICAgICAgIGNvbnN0IHRvIGVuZm9yY2Ug dGhhdCBpdHMgc3VwcG9zZWQgdG8gYmUgaW1tdXRhYmxlIGFmdGVyIGNvbnN0cnVjdGlvbi4KKwor ICAgICAgICAqIHJ1bnRpbWUvSlNCaWdJbnQuaDoKKwogMjAxOS0wOC0yMCAgRGV2aW4gUm91c3Nv ICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wbGVtZW50 IGBxdWVyeUhvbGRlcnNgIENvbW1hbmQgTGluZSBBUEkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTQmlnSW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNCaWdJbnQuaAkocmV2aXNpb24gMjQ4OTI1KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYg QEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTcgQ2FpbyBMaW1hIDx0aWNhaW9saW1hQGdtYWls LmNvbT4KKyAqIENvcHlyaWdodCAoQykgMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTcxLDcgKzcyLDYgQEAgcHVi bGljOgogICAgIHZvaWQgc2V0U2lnbihib29sIHNpZ24pIHsgbV9zaWduID0gc2lnbjsgfQogICAg IGJvb2wgc2lnbigpIGNvbnN0IHsgcmV0dXJuIG1fc2lnbjsgfQogCi0gICAgdm9pZCBzZXRMZW5n dGgodW5zaWduZWQgbGVuZ3RoKSB7IG1fbGVuZ3RoID0gbGVuZ3RoOyB9CiAgICAgdW5zaWduZWQg bGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gbV9sZW5ndGg7IH0KIAogICAgIGVudW0gY2xhc3MgRXJy b3JQYXJzZU1vZGUgewpAQCAtMjQ2LDggKzI0Niw4IEBAIHByaXZhdGU6CiAKICAgICBEaWdpdCBk aWdpdCh1bnNpZ25lZCk7CiAgICAgdm9pZCBzZXREaWdpdCh1bnNpZ25lZCwgRGlnaXQpOwotICAg ICAgICAKLSAgICB1bnNpZ25lZCBtX2xlbmd0aDsKKworICAgIGNvbnN0IHVuc2lnbmVkIG1fbGVu Z3RoOwogICAgIGJvb2wgbV9zaWduIHsgZmFsc2UgfTsKIH07CiAK