200943 2019-08-20 14:39:02 -0700 nextElementWithGreaterTabIndex should use shadowAdjustedTabIndex 2019-08-20 18:42:18 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 199606 1 rniwa rniwa achristensen cdumez webkit-bug-importer wenson_hsieh oldest_to_newest 1563244 0 rniwa 2019-08-20 14:39:02 -0700 Address FIXME I added to nextElementWithGreaterTabIndex in https://trac.webkit.org/changeset/248784 1563248 1 376810 rniwa 2019-08-20 14:45:23 -0700 Created attachment 376810 Cleanup 1563249 2 rniwa 2019-08-20 14:49:49 -0700 Thanks for the review! 1563364 3 376810 rniwa 2019-08-20 18:41:53 -0700 Comment on attachment 376810 Cleanup Clearing flags on attachment: 376810 Committed r248932: <https://trac.webkit.org/changeset/248932> 1563365 4 rniwa 2019-08-20 18:41:55 -0700 All reviewed patches have been landed. Closing bug. 1563366 5 webkit-bug-importer 2019-08-20 18:42:18 -0700 <rdar://problem/54538688> 376810 2019-08-20 14:45:23 -0700 2019-08-20 18:41:53 -0700 Cleanup bug-200943-20190820144523.patch text/plain 3374 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA4LTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIG5leHRFbGVtZW50V2l0aEdyZWF0 ZXJUYWJJbmRleCBzaG91bGQgdXNlIHNoYWRvd0FkanVzdGVkVGFiSW5kZXgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDk0MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBzaGFkb3dBZGp1c3RlZFRh YkluZGV4IGluc3RlYWQgb2YgdGFiSW5kZXhGb3JFbGVtZW50IGluIG5leHRFbGVtZW50V2l0aEdy ZWF0ZXJUYWJJbmRleC4KKworICAgICAgICBCZWNhdXNlIG5leHRFbGVtZW50V2l0aEdyZWF0ZXJU YWJJbmRleCBpcyBvbmx5IGNhbGxlZCB0byBmaW5kIGFuIGVsZW1lbnQgd2l0aCBhIHRhYiBpbmRl eAorICAgICAgICBzZXQgdG8gYSBncmVhdGVyIHZhbHVlIHRoYW4gdGhlIGFyZ3VtZW50IHRhYklu ZGV4LCB3aGljaCBpcyBhbHdheXMgYSBwb3NpdGl2ZSBpbnRlZ2VyLAorICAgICAgICB3aGV0aGVy IHdlIGNhbGwgc2hhZG93QWRqdXN0ZWRUYWJJbmRleCBvciB0YWJJbmRleEZvckVsZW1lbnQgaGFz IG5vIGVmZmVjdCBvbiBhbiBlbGVtZW50CisgICAgICAgIHdpdGggYSBzaGFkb3cgcm9vdCBvciBv biBhIHNsb3QgZWxlbWVudC4gRnVydGhlcm1vcmUsIG5vbmUgb2YgdGhlIGVsZW1lbnRzIHdpdGgK KyAgICAgICAgYW4gaXNLZXlib2FyZEZvY3VzYWJsZSBvdmVycmlkZSBjYW4gaGF2ZSBhIGF1dGhv ciBkZWZpbmVkIHNoYWRvdyByb290IGF0dGFjaGVkIGVpdGhlci4KKworICAgICAgICBBcyBhIHJl c3VsdCwgdGhpcyByZWZhY3RvcmluZyB3aWxsIGhhdmUgbm8gb2JzZXJ2YWJsZSBiZWhhdmlvcmFs IGNoYW5nZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhlcmUgc2hvdWxkIGJlIG5v IG9ic2VydmFibGUgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGFnZS9Gb2N1c0NvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dGFiSW5kZXhGb3JFbGVtZW50KTogTWVyZ2Vk IGludG8gc2hhZG93QWRqdXN0ZWRUYWJJbmRleC4KKyAgICAgICAgKFdlYkNvcmU6OnNoYWRvd0Fk anVzdGVkVGFiSW5kZXgpOgorICAgICAgICAoV2ViQ29yZTo6bmV4dEVsZW1lbnRXaXRoR3JlYXRl clRhYkluZGV4KToKKwogMjAxOS0wOC0yMCAgSnVzdGluIEZhbiAgPGp1c3Rpbl9mYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY29tbWVudCBmb2xsb3ctdXAgZm9yIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3NTIuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAyNDg5MTIpCisrKyBTb3VyY2Uv V2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyNSwx OSArMzI1LDEzIEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc0ZvY3VzYWJsZVNjb3BlT3duZXIKICAg ICByZXR1cm4gZWxlbWVudC5pc0tleWJvYXJkRm9jdXNhYmxlKGV2ZW50KSAmJiBpc0ZvY3VzU2Nv cGVPd25lcihlbGVtZW50KTsKIH0KIAotLy8gRklYTUU6IFRoaXMgZnVuY3Rpb24gc2hvdWxkIGJl IG1lcmdlZCBpbnRvIHNoYWRvd0FkanVzdGVkVGFiSW5kZXguCi1zdGF0aWMgaW5saW5lIGludCB0 YWJJbmRleEZvckVsZW1lbnQoY29uc3QgRWxlbWVudCYgZWxlbWVudCkKLXsKLSAgICByZXR1cm4g ZWxlbWVudC5zaG91bGRCZUlnbm9yZWRJblNlcXVlbnRpYWxGb2N1c05hdmlnYXRpb24oKSA/IC0x IDogZWxlbWVudC50YWJJbmRleFNldEV4cGxpY2l0bHkoKS52YWx1ZU9yKDApOwotfQotCiBzdGF0 aWMgaW5saW5lIGludCBzaGFkb3dBZGp1c3RlZFRhYkluZGV4KEVsZW1lbnQmIGVsZW1lbnQsIEtl eWJvYXJkRXZlbnQqIGV2ZW50KQogewogICAgIGlmIChpc05vbkZvY3VzYWJsZVNjb3BlT3duZXIo ZWxlbWVudCwgZXZlbnQpKSB7CiAgICAgICAgIGlmICghZWxlbWVudC50YWJJbmRleFNldEV4cGxp Y2l0bHkoKSkKICAgICAgICAgICAgIHJldHVybiAwOyAvLyBUcmVhdCBhIHNoYWRvdyBob3N0IHdp dGhvdXQgdGFiaW5kZXggaWYgaXQgaGFzIHRhYmluZGV4PTAgZXZlbiB0aG91Z2ggSFRNTEVsZW1l bnQ6OnRhYkluZGV4IHJldHVybnMgLTEgb24gc3VjaCBhbiBlbGVtZW50LgogICAgIH0KLSAgICBy ZXR1cm4gdGFiSW5kZXhGb3JFbGVtZW50KGVsZW1lbnQpOworICAgIHJldHVybiBlbGVtZW50LnNo b3VsZEJlSWdub3JlZEluU2VxdWVudGlhbEZvY3VzTmF2aWdhdGlvbigpID8gLTEgOiBlbGVtZW50 LnRhYkluZGV4U2V0RXhwbGljaXRseSgpLnZhbHVlT3IoMCk7CiB9CiAKIEZvY3VzQ29udHJvbGxl cjo6Rm9jdXNDb250cm9sbGVyKFBhZ2UmIHBhZ2UsIE9wdGlvblNldDxBY3Rpdml0eVN0YXRlOjpG bGFnPiBhY3Rpdml0eVN0YXRlKQpAQCAtNjI2LDggKzYyMCw3IEBAIHN0YXRpYyBFbGVtZW50KiBu ZXh0RWxlbWVudFdpdGhHcmVhdGVyVGEKICAgICAgICAgaWYgKCFpczxFbGVtZW50Pigqbm9kZSkp CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgRWxlbWVudCYgY2FuZGlkYXRlID0gZG93 bmNhc3Q8RWxlbWVudD4oKm5vZGUpOwotICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGJlIGNh bGxpbmcgc2hhZG93QWRqdXN0ZWRUYWJJbmRleCBpbnN0ZWFkLgotICAgICAgICBpbnQgY2FuZGlk YXRlVGFiSW5kZXggPSB0YWJJbmRleEZvckVsZW1lbnQoY2FuZGlkYXRlKTsKKyAgICAgICAgaW50 IGNhbmRpZGF0ZVRhYkluZGV4ID0gc2hhZG93QWRqdXN0ZWRUYWJJbmRleChjYW5kaWRhdGUsIGV2 ZW50KTsKICAgICAgICAgaWYgKGlzRm9jdXNhYmxlRWxlbWVudE9yU2NvcGVPd25lcihjYW5kaWRh dGUsIGV2ZW50KSAmJiBjYW5kaWRhdGVUYWJJbmRleCA+IHRhYkluZGV4ICYmICghd2lubmVyIHx8 IGNhbmRpZGF0ZVRhYkluZGV4IDwgd2lubmluZ1RhYkluZGV4KSkgewogICAgICAgICAgICAgd2lu bmVyID0gJmNhbmRpZGF0ZTsKICAgICAgICAgICAgIHdpbm5pbmdUYWJJbmRleCA9IGNhbmRpZGF0 ZVRhYkluZGV4Owo=