20093 2008-07-18 05:03:20 -0700 JSC shell does not clear exceptions after it executes toString on an expression 2008-08-24 21:08:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction P2 Normal --- 1 oliver webkit-unassigned sam zwarich oldest_to_newest 86309 0 oliver 2008-07-18 05:03:20 -0700 The JSC shell doesn't check for toString on the result of an expression throwing, so it will eventually result in incorrect behaviour in some cases. Trivial reproduction: 1. Start jsc 2. enter eval({toString:function(){throw{};}}); 3. goto 2 86326 1 ap 2008-07-18 07:24:14 -0700 *** Bug 20094 has been marked as a duplicate of this bug. *** 89224 2 zwarich 2008-08-24 17:27:24 -0700 I can fix this by checking the completion type, but for your example the completion type is Normal, not Throw, even though there is an exception on the global object's ExecState. This would appear to be a separate bug, so I'll file it. 89225 3 22967 zwarich 2008-08-24 17:29:44 -0700 Created attachment 22967 Fix that exposes problem with exceptions and eval Here is my proposed fix. The assertions about exceptions on the global ExecState currently fail on Oliver's example. 89230 4 zwarich 2008-08-24 18:02:03 -0700 The problem isn't with eval, it is that an exception is thrown while printing the value. A similar issue occurs with the inspector. We should decide what to do in both cases. 89232 5 22970 zwarich 2008-08-24 18:24:43 -0700 Created attachment 22970 Proposed patch Here's a fix. It doesn't make the user aware of any exceptions that occurred while printing the final value, but we should deal with that problem later, together with the solution for the inspector. 89233 6 22971 zwarich 2008-08-24 18:31:31 -0700 Created attachment 22971 Proposed patch (with better ChangeLog) I forgot to mention something in the ChangeLog. 89241 7 zwarich 2008-08-24 21:08:50 -0700 Committed r35911. 22967 2008-08-24 17:29:44 -0700 2008-08-24 18:31:31 -0700 Fix that exposes problem with exceptions and eval exceptionclear.diff text/plain 2024 zwarich SW5kZXg6IGtqcy9TaGVsbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL1NoZWxsLmNwcAkocmV2aXNp b24gMzU5MDgpCisrKyBranMvU2hlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTAsMTIgKzM1 MCwxNiBAQCBzdGF0aWMgYm9vbCBydW5XaXRoU2NyaXB0cyhHbG9iYWxPYmplY3QqCiAgICAgICAg ICAgICBDb21wbGV0aW9uIGNvbXBsZXRpb24gPSBJbnRlcnByZXRlcjo6ZXZhbHVhdGUoZ2xvYmFs T2JqZWN0LT5nbG9iYWxFeGVjKCksIGdsb2JhbE9iamVjdC0+Z2xvYmFsU2NvcGVDaGFpbigpLCBm aWxlTmFtZSwgMSwgc2NyaXB0LmRhdGEoKSk7CiAgICAgICAgICAgICBzdWNjZXNzID0gc3VjY2Vz cyAmJiBjb21wbGV0aW9uLmNvbXBsVHlwZSgpICE9IFRocm93OwogICAgICAgICAgICAgaWYgKGR1 bXApIHsKLSAgICAgICAgICAgICAgICBpZiAoc3VjY2VzcykKLSAgICAgICAgICAgICAgICAgICAg cHJpbnRmKCJFbmQ6ICVzXG4iLCBjb21wbGV0aW9uLnZhbHVlKCktPnRvU3RyaW5nKGdsb2JhbE9i amVjdC0+Z2xvYmFsRXhlYygpKS5hc2NpaSgpKTsKLSAgICAgICAgICAgICAgICBlbHNlCisgICAg ICAgICAgICAgICAgaWYgKGNvbXBsZXRpb24uY29tcGxUeXBlKCkgPT0gVGhyb3cpCiAgICAgICAg ICAgICAgICAgICAgIHByaW50ZigiRXhjZXB0aW9uOiAlc1xuIiwgY29tcGxldGlvbi52YWx1ZSgp LT50b1N0cmluZyhnbG9iYWxPYmplY3QtPmdsb2JhbEV4ZWMoKSkuYXNjaWkoKSk7CisgICAgICAg ICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBwcmludGYoIkVuZDogJXNcbiIsIGNv bXBsZXRpb24udmFsdWUoKS0+dG9TdHJpbmcoZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCkpLmFz Y2lpKCkpOwogICAgICAgICAgICAgfQogCisgICAgICAgICAgICBpZiAoY29tcGxldGlvbi5jb21w bFR5cGUoKSA9PSBUaHJvdykKKyAgICAgICAgICAgICAgICBnbG9iYWxPYmplY3QtPmdsb2JhbEV4 ZWMoKS0+Y2xlYXJFeGNlcHRpb24oKTsKKyAgICAgICAgICAgIEFTU0VSVCghZ2xvYmFsT2JqZWN0 LT5nbG9iYWxFeGVjKCktPmhhZEV4Y2VwdGlvbigpKTsKKwogI2lmIEVOQUJMRShTQU1QTElOR19U T09MKQogICAgICAgICAgICAgbWFjaGluZS0+bV9zYW1wbGVyLT5zdG9wKCk7CiAgICAgICAgICAg ICBtYWNoaW5lLT5tX3NhbXBsZXItPmR1bXAoZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCkpOwpA QCAtMzkwLDggKzM5NCwxMyBAQCBzdGF0aWMgdm9pZCBydW5JbnRlcmFjdGl2ZShHbG9iYWxPYmpl Y3QqCiAgICAgICAgIGxpbmUuYXBwZW5kKCdcMCcpOwogICAgICAgICBDb21wbGV0aW9uIGNvbXBs ZXRpb24gPSBJbnRlcnByZXRlcjo6ZXZhbHVhdGUoZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCks IGdsb2JhbE9iamVjdC0+Z2xvYmFsU2NvcGVDaGFpbigpLCBpbnRlcnByZXRlck5hbWUsIDEsIGxp bmUuZGF0YSgpKTsKICNlbmRpZgotICAgICAgICBpZiAoY29tcGxldGlvbi5pc1ZhbHVlQ29tcGxl dGlvbigpKQorICAgICAgICBwcmludGYoIiVkXG4iLCBjb21wbGV0aW9uLmNvbXBsVHlwZSgpKTsK KyAgICAgICAgaWYgKGNvbXBsZXRpb24uY29tcGxUeXBlKCkgPT0gVGhyb3cpIHsKKyAgICAgICAg ICAgIHByaW50ZigiRXhjZXB0aW9uOiAlc1xuIiwgY29tcGxldGlvbi52YWx1ZSgpLT50b1N0cmlu ZyhnbG9iYWxPYmplY3QtPmdsb2JhbEV4ZWMoKSkuYXNjaWkoKSk7CisgICAgICAgICAgICBnbG9i YWxPYmplY3QtPmdsb2JhbEV4ZWMoKS0+Y2xlYXJFeGNlcHRpb24oKTsKKyAgICAgICAgfSBlbHNl CiAgICAgICAgICAgICBwcmludGYoIiVzXG4iLCBjb21wbGV0aW9uLnZhbHVlKCktPnRvU3RyaW5n KGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpKS5VVEY4U3RyaW5nKCkuY19zdHIoKSk7CisgICAg ICAgIEFTU0VSVCghZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCktPmhhZEV4Y2VwdGlvbigpKTsK ICAgICB9CiAgICAgcHJpbnRmKCJcbiIpOwogfQo= 22970 2008-08-24 18:24:43 -0700 2008-08-24 18:31:31 -0700 Proposed patch exceptionclear.diff text/plain 2582 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM1OTA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMDgt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMDkzOiBKU0Mgc2hl bGwgZG9lcyBub3QgY2xlYXIgZXhjZXB0aW9ucyBhZnRlciBpdCBleGVjdXRlcyB0b1N0cmluZyBv biBhbiBleHByZXNzaW9uCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAwOTM+CisKKyAgICAgICAgQ2xlYXIgZXhjZXB0aW9ucyBhZnRlciBldmFsdWF0 aW5nIGFueSBjb2RlIGluIHRoZSBKU0Mgc2hlbGwuIFdlIGRvIG5vdAorICAgICAgICByZXBvcnQg ZXhjZXB0aW9ucyB0aGF0IGFyZSBjYXVzZWQgYnkgY2FsbGluZyB0b1N0cmluZyBvbiB0aGUgZmlu YWwKKyAgICAgICAgdmFsdWVkLCBidXQgYXQgbGVhc3Qgd2UgYXZvaWQgaW5jb3JyZWN0IGJlaGF2 aW91ci4KKworICAgICAgICAqIGtqcy9TaGVsbC5jcHA6CisgICAgICAgIChydW5XaXRoU2NyaXB0 cyk6CisgICAgICAgIChydW5JbnRlcmFjdGl2ZSk6CisKIDIwMDgtMDgtMjQgIE1hcmsgUm93ZSAg PG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5k ZXg6IGtqcy9TaGVsbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL1NoZWxsLmNwcAkocmV2aXNpb24g MzU5MDgpCisrKyBranMvU2hlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTAsMTIgKzM1MCwx NCBAQCBzdGF0aWMgYm9vbCBydW5XaXRoU2NyaXB0cyhHbG9iYWxPYmplY3QqCiAgICAgICAgICAg ICBDb21wbGV0aW9uIGNvbXBsZXRpb24gPSBJbnRlcnByZXRlcjo6ZXZhbHVhdGUoZ2xvYmFsT2Jq ZWN0LT5nbG9iYWxFeGVjKCksIGdsb2JhbE9iamVjdC0+Z2xvYmFsU2NvcGVDaGFpbigpLCBmaWxl TmFtZSwgMSwgc2NyaXB0LmRhdGEoKSk7CiAgICAgICAgICAgICBzdWNjZXNzID0gc3VjY2VzcyAm JiBjb21wbGV0aW9uLmNvbXBsVHlwZSgpICE9IFRocm93OwogICAgICAgICAgICAgaWYgKGR1bXAp IHsKLSAgICAgICAgICAgICAgICBpZiAoc3VjY2VzcykKLSAgICAgICAgICAgICAgICAgICAgcHJp bnRmKCJFbmQ6ICVzXG4iLCBjb21wbGV0aW9uLnZhbHVlKCktPnRvU3RyaW5nKGdsb2JhbE9iamVj dC0+Z2xvYmFsRXhlYygpKS5hc2NpaSgpKTsKLSAgICAgICAgICAgICAgICBlbHNlCisgICAgICAg ICAgICAgICAgaWYgKGNvbXBsZXRpb24uY29tcGxUeXBlKCkgPT0gVGhyb3cpCiAgICAgICAgICAg ICAgICAgICAgIHByaW50ZigiRXhjZXB0aW9uOiAlc1xuIiwgY29tcGxldGlvbi52YWx1ZSgpLT50 b1N0cmluZyhnbG9iYWxPYmplY3QtPmdsb2JhbEV4ZWMoKSkuYXNjaWkoKSk7CisgICAgICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBwcmludGYoIkVuZDogJXNcbiIsIGNvbXBs ZXRpb24udmFsdWUoKS0+dG9TdHJpbmcoZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCkpLmFzY2lp KCkpOwogICAgICAgICAgICAgfQogCisgICAgICAgICAgICBnbG9iYWxPYmplY3QtPmdsb2JhbEV4 ZWMoKS0+Y2xlYXJFeGNlcHRpb24oKTsKKwogI2lmIEVOQUJMRShTQU1QTElOR19UT09MKQogICAg ICAgICAgICAgbWFjaGluZS0+bV9zYW1wbGVyLT5zdG9wKCk7CiAgICAgICAgICAgICBtYWNoaW5l LT5tX3NhbXBsZXItPmR1bXAoZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCkpOwpAQCAtMzkwLDgg KzM5MiwxMiBAQCBzdGF0aWMgdm9pZCBydW5JbnRlcmFjdGl2ZShHbG9iYWxPYmplY3QqCiAgICAg ICAgIGxpbmUuYXBwZW5kKCdcMCcpOwogICAgICAgICBDb21wbGV0aW9uIGNvbXBsZXRpb24gPSBJ bnRlcnByZXRlcjo6ZXZhbHVhdGUoZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCksIGdsb2JhbE9i amVjdC0+Z2xvYmFsU2NvcGVDaGFpbigpLCBpbnRlcnByZXRlck5hbWUsIDEsIGxpbmUuZGF0YSgp KTsKICNlbmRpZgotICAgICAgICBpZiAoY29tcGxldGlvbi5pc1ZhbHVlQ29tcGxldGlvbigpKQor ICAgICAgICBpZiAoY29tcGxldGlvbi5jb21wbFR5cGUoKSA9PSBUaHJvdykKKyAgICAgICAgICAg IHByaW50ZigiRXhjZXB0aW9uOiAlc1xuIiwgY29tcGxldGlvbi52YWx1ZSgpLT50b1N0cmluZyhn bG9iYWxPYmplY3QtPmdsb2JhbEV4ZWMoKSkuYXNjaWkoKSk7CisgICAgICAgIGVsc2UKICAgICAg ICAgICAgIHByaW50ZigiJXNcbiIsIGNvbXBsZXRpb24udmFsdWUoKS0+dG9TdHJpbmcoZ2xvYmFs T2JqZWN0LT5nbG9iYWxFeGVjKCkpLlVURjhTdHJpbmcoKS5jX3N0cigpKTsKKworICAgICAgICBn bG9iYWxPYmplY3QtPmdsb2JhbEV4ZWMoKS0+Y2xlYXJFeGNlcHRpb24oKTsKICAgICB9CiAgICAg cHJpbnRmKCJcbiIpOwogfQo= 22971 2008-08-24 18:31:31 -0700 2008-08-24 20:49:42 -0700 Proposed patch (with better ChangeLog) exceptionclear.diff text/plain 2736 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM1OTA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDgt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMDkzOiBKU0Mgc2hl bGwgZG9lcyBub3QgY2xlYXIgZXhjZXB0aW9ucyBhZnRlciBpdCBleGVjdXRlcyB0b1N0cmluZyBv biBhbiBleHByZXNzaW9uCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAwOTM+CisKKyAgICAgICAgQ2xlYXIgZXhjZXB0aW9ucyBhZnRlciBldmFsdWF0 aW5nIGFueSBjb2RlIGluIHRoZSBKU0Mgc2hlbGwuIFdlIGRvIG5vdAorICAgICAgICByZXBvcnQg ZXhjZXB0aW9ucyB0aGF0IGFyZSBjYXVzZWQgYnkgY2FsbGluZyB0b1N0cmluZyBvbiB0aGUgZmlu YWwKKyAgICAgICAgdmFsdWVkLCBidXQgYXQgbGVhc3Qgd2UgYXZvaWQgaW5jb3JyZWN0IGJlaGF2 aW91ci4KKworICAgICAgICBBbHNvLCBwcmludCBhbnkgZXhjZXB0aW9ucyB0aGF0IG9jY3VycmVk IHdoaWxlIGV2YWx1YXRpbmcgY29kZSBhdCB0aGUKKyAgICAgICAgaW50ZXJhY3RpdmUgcHJvbXB0 LCBub3QganVzdCB3aGlsZSBldmFsdWF0aW5nIGNvZGUgZnJvbSBhIGZpbGUuCisKKyAgICAgICAg KiBranMvU2hlbGwuY3BwOgorICAgICAgICAocnVuV2l0aFNjcmlwdHMpOgorICAgICAgICAocnVu SW50ZXJhY3RpdmUpOgorCiAyMDA4LTA4LTI0ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBranMvU2hlbGwuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGtqcy9TaGVsbC5jcHAJKHJldmlzaW9uIDM1OTA4KQorKysga2pzL1No ZWxsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUwLDEyICszNTAsMTQgQEAgc3RhdGljIGJvb2wg cnVuV2l0aFNjcmlwdHMoR2xvYmFsT2JqZWN0KgogICAgICAgICAgICAgQ29tcGxldGlvbiBjb21w bGV0aW9uID0gSW50ZXJwcmV0ZXI6OmV2YWx1YXRlKGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygp LCBnbG9iYWxPYmplY3QtPmdsb2JhbFNjb3BlQ2hhaW4oKSwgZmlsZU5hbWUsIDEsIHNjcmlwdC5k YXRhKCkpOwogICAgICAgICAgICAgc3VjY2VzcyA9IHN1Y2Nlc3MgJiYgY29tcGxldGlvbi5jb21w bFR5cGUoKSAhPSBUaHJvdzsKICAgICAgICAgICAgIGlmIChkdW1wKSB7Ci0gICAgICAgICAgICAg ICAgaWYgKHN1Y2Nlc3MpCi0gICAgICAgICAgICAgICAgICAgIHByaW50ZigiRW5kOiAlc1xuIiwg Y29tcGxldGlvbi52YWx1ZSgpLT50b1N0cmluZyhnbG9iYWxPYmplY3QtPmdsb2JhbEV4ZWMoKSku YXNjaWkoKSk7Ci0gICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGlmIChjb21w bGV0aW9uLmNvbXBsVHlwZSgpID09IFRocm93KQogICAgICAgICAgICAgICAgICAgICBwcmludGYo IkV4Y2VwdGlvbjogJXNcbiIsIGNvbXBsZXRpb24udmFsdWUoKS0+dG9TdHJpbmcoZ2xvYmFsT2Jq ZWN0LT5nbG9iYWxFeGVjKCkpLmFzY2lpKCkpOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICAgICAgcHJpbnRmKCJFbmQ6ICVzXG4iLCBjb21wbGV0aW9uLnZhbHVlKCktPnRv U3RyaW5nKGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpKS5hc2NpaSgpKTsKICAgICAgICAgICAg IH0KIAorICAgICAgICAgICAgZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCktPmNsZWFyRXhjZXB0 aW9uKCk7CisKICNpZiBFTkFCTEUoU0FNUExJTkdfVE9PTCkKICAgICAgICAgICAgIG1hY2hpbmUt Pm1fc2FtcGxlci0+c3RvcCgpOwogICAgICAgICAgICAgbWFjaGluZS0+bV9zYW1wbGVyLT5kdW1w KGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpKTsKQEAgLTM5MCw4ICszOTIsMTIgQEAgc3RhdGlj IHZvaWQgcnVuSW50ZXJhY3RpdmUoR2xvYmFsT2JqZWN0KgogICAgICAgICBsaW5lLmFwcGVuZCgn XDAnKTsKICAgICAgICAgQ29tcGxldGlvbiBjb21wbGV0aW9uID0gSW50ZXJwcmV0ZXI6OmV2YWx1 YXRlKGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpLCBnbG9iYWxPYmplY3QtPmdsb2JhbFNjb3Bl Q2hhaW4oKSwgaW50ZXJwcmV0ZXJOYW1lLCAxLCBsaW5lLmRhdGEoKSk7CiAjZW5kaWYKLSAgICAg ICAgaWYgKGNvbXBsZXRpb24uaXNWYWx1ZUNvbXBsZXRpb24oKSkKKyAgICAgICAgaWYgKGNvbXBs ZXRpb24uY29tcGxUeXBlKCkgPT0gVGhyb3cpCisgICAgICAgICAgICBwcmludGYoIkV4Y2VwdGlv bjogJXNcbiIsIGNvbXBsZXRpb24udmFsdWUoKS0+dG9TdHJpbmcoZ2xvYmFsT2JqZWN0LT5nbG9i YWxFeGVjKCkpLmFzY2lpKCkpOworICAgICAgICBlbHNlCiAgICAgICAgICAgICBwcmludGYoIiVz XG4iLCBjb21wbGV0aW9uLnZhbHVlKCktPnRvU3RyaW5nKGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhl YygpKS5VVEY4U3RyaW5nKCkuY19zdHIoKSk7CisKKyAgICAgICAgZ2xvYmFsT2JqZWN0LT5nbG9i YWxFeGVjKCktPmNsZWFyRXhjZXB0aW9uKCk7CiAgICAgfQogICAgIHByaW50ZigiXG4iKTsKIH0K