200919 2019-08-20 05:58:59 -0700 ASSERTION FAILED: !s_isInvalidatingStyleWithRuleSets in com.apple.WebCore: WebCore::DocumentRuleSets::collectFeatures const 2019-08-22 11:03:03 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue zalan oldest_to_newest 1563032 0 koivisto 2019-08-20 05:58:59 -0700 ASSERTION FAILED: !s_isInvalidatingStyleWithRuleSets ./css/DocumentRuleSets.cpp(157) : void WebCore::DocumentRuleSets::collectFeatures() const 1 0x6ccbf2179 WTFCrash 2 0x6d12242ab WTFCrashWithInfo(int, char const*, char const*, int) 3 0x6d32a2007 WebCore::DocumentRuleSets::collectFeatures() const 4 0x6d32a1f26 WebCore::DocumentRuleSets::appendAuthorStyleSheets(WTF::Vector<WTF::RefPtr<WebCore::CSSStyleSheet, WTF::DumbPtrTraits<WebCore::CSSStyleSheet> >, 0ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::MediaQueryEvaluator*, WebCore::InspectorCSSOMWrappers&, WebCore::StyleResolver*) 5 0x6d330c6e9 WebCore::StyleResolver::appendAuthorStyleSheets(WTF::Vector<WTF::RefPtr<WebCore::CSSStyleSheet, WTF::DumbPtrTraits<WebCore::CSSStyleSheet> >, 0ul, WTF::CrashOnOverflow, 16ul> const&) 6 0x6d4b43d19 WebCore::Style::Scope::resolver() 7 0x6d32a3e94 WebCore::ElementRuleCollector::matchAuthorShadowPseudoElementRules(bool, WebCore::StyleResolver::RuleRange&) 8 0x6d32a3987 WebCore::ElementRuleCollector::matchAuthorRules(bool) 9 0x6d4b3ecbc WebCore::Style::Invalidator::invalidateIfNeeded(WebCore::Element&, WebCore::SelectorFilter const*) 10 0x6d4b3c5bc WebCore::Style::Invalidator::invalidateStyleWithMatchElement(WebCore::Element&, WebCore::MatchElement) 11 0x6d4b3cfa1 WebCore::Style::ClassChangeInvalidation::invalidateStyleWithRuleSets() 12 0x6d3543f71 WebCore::Style::ClassChangeInvalidation::ClassChangeInvalidation(WebCore::Element&, WebCore::SpaceSplitString const&, WebCore::SpaceSplitString const&) 13 0x6d352b1bd WebCore::Style::ClassChangeInvalidation::ClassChangeInvalidation(WebCore::Element&, WebCore::SpaceSplitString const&, WebCore::SpaceSplitString const&) 14 0x6d352ac30 WebCore::Element::classAttributeChanged(WTF::AtomString const&) 15 0x6d352a7a3 WebCore::Element::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason) 16 0x6d368edbc WebCore::StyledElement::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason) 17 0x6d3535e66 WebCore::Element::didModifyAttribute(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&) 18 0x6d352a357 WebCore::Element::setAttributeInternal(unsigned int, WebCore::QualifiedName const&, WTF::AtomString const&, WebCore::Element::SynchronizationOfLazyAttribute) 19 0x6d3523cc2 WebCore::Element::setAttribute(WebCore::QualifiedName const&, WTF::AtomString const&) 20 0x6d380dc29 WebCore::DOMTokenList::updateAssociatedAttributeFromTokens() 21 0x6d380d906 WebCore::DOMTokenList::toggle(WTF::AtomString const&, WTF::Optional<bool>) 22 0x6d1a2e7d1 WebCore::jsDOMTokenListPrototypeFunctionToggleBody(JSC::ExecState*, WebCore::JSDOMTokenList*, JSC::ThrowScope&) 23 0x6d197eeb0 long long WebCore::IDLOperation<WebCore::JSDOMTokenList>::call<&(WebCore::jsDOMTokenListPrototypeFunctionToggleBody(JSC::ExecState*, WebCore::JSDOMTokenList*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*) 24 0x6d197eb9c WebCore::jsDOMTokenListPrototypeFunctionToggle(JSC::ExecState*) 25 0x3c9f9be0116b 26 0x6ccfae230 llint_entry 27 0x6ccfae2d3 llint_entry 28 0x6ccfae230 llint_entry 29 0x6ccfae2d3 llint_entry 30 0x3c9f9bf6e0af 31 0x6ccfae230 llint_entry 1563034 1 koivisto 2019-08-20 06:05:41 -0700 <rdar://problem/53413013> = 1563038 2 376765 koivisto 2019-08-20 06:13:26 -0700 Created attachment 376765 patch 1563482 3 376876 koivisto 2019-08-21 07:45:06 -0700 Created attachment 376876 patch 1563535 4 376876 commit-queue 2019-08-21 10:05:53 -0700 Comment on attachment 376876 patch Clearing flags on attachment: 376876 Committed r248945: <https://trac.webkit.org/changeset/248945> 1563536 5 commit-queue 2019-08-21 10:05:54 -0700 All reviewed patches have been landed. Closing bug. 1564129 6 youennf 2019-08-22 11:03:03 -0700 *** Bug 200319 has been marked as a duplicate of this bug. *** 376765 2019-08-20 06:13:26 -0700 2019-08-20 06:30:17 -0700 patch host-styleresolver-during-invalidation.patch text/plain 2081 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZTYzODYwOWQ2ZS4uMWJmYzBmZjY0YTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxOS0wOC0yMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIXNfaXNJbnZhbGlkYXRpbmdTdHlsZVdpdGhS dWxlU2V0cyBpbiBjb20uYXBwbGUuV2ViQ29yZTogV2ViQ29yZTo6RG9jdW1lbnRSdWxlU2V0czo6 Y29sbGVjdEZlYXR1cmVzIGNvbnN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA5MTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzNDEzMDEzPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJvdHMgc2hv dyB0aGF0IGluIHNvbWUgdGltaW5nLWRlcGVuZGVudCBjYXNlcyB3ZSBtYXkgZW5kIHVwIGNvbnN0 cnVjdGluZyBhIHN0eWxlIHJlc29sdmVyIGluIHRoZSBtaWRkbGUgdGhlIGNsYXNzIGNoYW5nZSBp bnZhbGlkYXRpb24uCisKKyAgICAgICAgU2VlbiBvbiBQYWQgYm90cyBpbgorCisgICAgICAgIG1l ZGlhL3RyYWNrL3RyYWNrLW5vZGUtYWRkLXJlbW92ZS5odG1sCisgICAgICAgIG1lZGlhL1czQy92 aWRlby9ldmVudHMvZXZlbnRfbG9hZHN0YXJ0X21hbnVhbC5odG1sCisgICAgICAgIG1lZGlhL1cz Qy92aWRlby9yZWFkeVN0YXRlL3JlYWR5U3RhdGVfaW5pdGlhbC5odG1sCisKKyAgICAgICAgYnV0 IGNhbid0IHJlcHJvIGxvY2FsbHkuCisKKyAgICAgICAgKiBzdHlsZS9TdHlsZUludmFsaWRhdGlv bkZ1bmN0aW9ucy5oOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OnRyYXZlcnNlUnVsZUZlYXR1 cmVzSW5TaGFkb3dUcmVlKToKKworICAgICAgICBFbnN1cmUgdGhlIGhvc3QgcmVzb2x2ZXIgaXMg YWx3YXlzIGNvbnN0cnVjdGVkIGJlZm9yZSBzdGFydGluZyBydWxlLWJhc2VkIGludmFsaWRhdGlv bi4KKwogMjAxOS0wOC0xOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdnZXI6IGFkZCBhIGdsb2JhbCBicmVha3BvaW50IGZv ciBwYXVzaW5nIGluIHRoZSBuZXh0IG1pY3JvdGFzawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3R5bGUvU3R5bGVJbnZhbGlkYXRpb25GdW5jdGlvbnMuaCBiL1NvdXJjZS9XZWJDb3JlL3N0 eWxlL1N0eWxlSW52YWxpZGF0aW9uRnVuY3Rpb25zLmgKaW5kZXggMDJmZmQ0MDY0Y2YuLjk1YzQ0 ZTdkMzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUludmFsaWRhdGlv bkZ1bmN0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlSW52YWxpZGF0aW9u RnVuY3Rpb25zLmgKQEAgLTM5LDYgKzM5LDEwIEBAIGlubGluZSB2b2lkIHRyYXZlcnNlUnVsZUZl YXR1cmVzSW5TaGFkb3dUcmVlKEVsZW1lbnQmIGVsZW1lbnQsIFRyYXZlcnNlRnVuY3Rpb24mCiB7 CiAgICAgaWYgKCFlbGVtZW50LnNoYWRvd1Jvb3QoKSkKICAgICAgICAgcmV0dXJuOworCisgICAg Ly8gRW5zdXJlIHRoYXQgYWxzbyB0aGUgaG9zdCByZXNvbHZlciBpcyBjb25zdHJ1Y3RlZCBzbyBp dCBkb2Vzbid0IGdldCBjcmVhdGVkIGR1cmluZyBpbnZhbGlkYXRpb24uCisgICAgU3R5bGU6OlNj b3BlOjpmb3JOb2RlKCplbGVtZW50LnNoYWRvd1Jvb3QoKS0+aG9zdCgpKS5yZXNvbHZlcigpOwor CiAgICAgYXV0byYgc2hhZG93UnVsZVNldHMgPSBlbGVtZW50LnNoYWRvd1Jvb3QoKS0+c3R5bGVT Y29wZSgpLnJlc29sdmVyKCkucnVsZVNldHMoKTsKICAgICBhdXRvJiBhdXRob3JTdHlsZSA9IHNo YWRvd1J1bGVTZXRzLmF1dGhvclN0eWxlKCk7CiAgICAgYm9vbCBoYXNIb3N0UHNldWRvQ2xhc3NS dWxlc01hdGNoaW5nSW5TaGFkb3dUcmVlID0gYXV0aG9yU3R5bGUuaGFzSG9zdFBzZXVkb0NsYXNz UnVsZXNNYXRjaGluZ0luU2hhZG93VHJlZSgpOwo= 376876 2019-08-21 07:45:06 -0700 2019-08-21 10:05:53 -0700 patch host-styleresolver-during-invalidation-2.patch text/plain 2034 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZTYzODYwOWQ2ZS4uYzdmMTFmNWY0MjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxOS0wOC0yMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIXNfaXNJbnZhbGlkYXRpbmdTdHlsZVdpdGhS dWxlU2V0cyBpbiBjb20uYXBwbGUuV2ViQ29yZTogV2ViQ29yZTo6RG9jdW1lbnRSdWxlU2V0czo6 Y29sbGVjdEZlYXR1cmVzIGNvbnN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA5MTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzNDEzMDEzPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJvdHMgc2hv dyB0aGF0IGluIHNvbWUgdGltaW5nLWRlcGVuZGVudCBjYXNlcyB3ZSBtYXkgZW5kIHVwIGNvbnN0 cnVjdGluZyBhIHN0eWxlIHJlc29sdmVyIGluIHRoZSBtaWRkbGUgdGhlIGNsYXNzIGNoYW5nZSBp bnZhbGlkYXRpb24uCisKKyAgICAgICAgVGhpcyBoYXBwZW5zIGZsYWtpbHkgb24gUGFkIGJvdHMg aW4KKworICAgICAgICBtZWRpYS90cmFjay90cmFjay1ub2RlLWFkZC1yZW1vdmUuaHRtbAorICAg ICAgICBtZWRpYS9XM0MvdmlkZW8vZXZlbnRzL2V2ZW50X2xvYWRzdGFydF9tYW51YWwuaHRtbAor ICAgICAgICBtZWRpYS9XM0MvdmlkZW8vcmVhZHlTdGF0ZS9yZWFkeVN0YXRlX2luaXRpYWwuaHRt bAorCisgICAgICAgIGFuZCBhbHNvIHJlcHJvZXMgbG9jYWxseSB3aXRoIGxvdHMgb2YgcnVucyBv dmVyIHRoZXNlIHRlc3RzLgorCisgICAgICAgICogc3R5bGUvU3R5bGVJbnZhbGlkYXRpb25GdW5j dGlvbnMuaDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjp0cmF2ZXJzZVJ1bGVGZWF0dXJlcyk6 CisKKyAgICAgICAgRW5zdXJlIHRoYXQgZm9yIGVsZW1lbnRzIGluIHNoYWRvdyB0cmVlIHRoZSBo b3N0IHJlc29sdmVyIGlzIGFsc28gYWx3YXlzIGNvbnN0cnVjdGVkIGJlZm9yZSBzdGFydGluZyBy dWxlLWJhc2VkIGludmFsaWRhdGlvbi4KKwogMjAxOS0wOC0xOSAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdnZXI6IGFkZCBh IGdsb2JhbCBicmVha3BvaW50IGZvciBwYXVzaW5nIGluIHRoZSBuZXh0IG1pY3JvdGFzawpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVJbnZhbGlkYXRpb25GdW5jdGlvbnMu aCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlSW52YWxpZGF0aW9uRnVuY3Rpb25zLmgKaW5k ZXggMDJmZmQ0MDY0Y2YuLmQ0MWEwZDg4MjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9z dHlsZS9TdHlsZUludmFsaWRhdGlvbkZ1bmN0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0 eWxlL1N0eWxlSW52YWxpZGF0aW9uRnVuY3Rpb25zLmgKQEAgLTc2LDYgKzc2LDEwIEBAIGlubGlu ZSB2b2lkIHRyYXZlcnNlUnVsZUZlYXR1cmVzKEVsZW1lbnQmIGVsZW1lbnQsIFRyYXZlcnNlRnVu Y3Rpb24mJiBmdW5jdGlvbikKIAogICAgIHRyYXZlcnNlUnVsZUZlYXR1cmVzSW5TaGFkb3dUcmVl KGVsZW1lbnQsIGZ1bmN0aW9uKTsKICAgICB0cmF2ZXJzZVJ1bGVGZWF0dXJlc0ZvclNsb3R0ZWQo ZWxlbWVudCwgZnVuY3Rpb24pOworCisgICAgLy8gRW5zdXJlIHRoYXQgdGhlIGNvbnRhaW5pbmcg dHJlZSByZXNvbHZlciBhbHNvIGV4aXN0cyBzbyBpdCBkb2Vzbid0IGdldCBjcmVhdGVkIGluIHRo ZSBtaWRkbGUgb2YgaW52YWxpZGF0aW9uLgorICAgIGlmIChlbGVtZW50LmlzSW5TaGFkb3dUcmVl KCkpCisgICAgICAgIFN0eWxlOjpTY29wZTo6Zm9yTm9kZSgqZWxlbWVudC5jb250YWluaW5nU2hh ZG93Um9vdCgpLT5ob3N0KCkpLnJlc29sdmVyKCk7CiB9CiAKIH0K