200897 2019-08-19 13:57:41 -0700 NetworkDataTask is being ref'd / deref'd from several threads and is not ThreadSafeRefCounted 2019-08-19 15:51:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198318 1 cdumez cdumez achristensen commit-queue ggaren rniwa thorton webkit-bug-importer youennf oldest_to_newest 1562792 0 cdumez 2019-08-19 13:57:41 -0700 NetworkDataTask is being ref'd / deref'd from several threads and is not ThreadSafeRefCounted. See the makeRef() calls below: void NetworkDataTaskCocoa::resume() { if (m_scheduledFailureType != NoFailure) m_failureTimer.startOneShot(0_s); auto& cocoaSession = static_cast<NetworkSessionCocoa&>(*m_session); if (cocoaSession.deviceManagementRestrictionsEnabled() && m_isForMainResourceNavigationForAnyFrame) { auto didDetermineDeviceRestrictionPolicyForURL = makeBlockPtr([this, protectedThis = makeRef(*this)](BOOL isBlocked) { callOnMainThread([this, protectedThis = makeRef(*this), isBlocked] { if (isBlocked) { scheduleFailure(RestrictedURLFailure); return; } [m_task resume]; }); }); 1562804 1 cdumez 2019-08-19 14:41:00 -0700 cc'ing Tim as he added this code. I am still confirming if this can really get called on a background thread or if the callOnMainThread() call is merely to make things asynchronous. 1562811 2 cdumez 2019-08-19 15:14:01 -0700 (In reply to Chris Dumez from comment #1) > cc'ing Tim as he added this code. I am still confirming if this can really > get called on a background thread or if the callOnMainThread() call is > merely to make things asynchronous. Ouch, definitely not called on the main thread. There is indeed a bug here. 1562814 3 376712 cdumez 2019-08-19 15:17:56 -0700 Created attachment 376712 Patch 1562817 4 376712 ggaren 2019-08-19 15:23:02 -0700 Comment on attachment 376712 Patch r=me 1562825 5 376712 commit-queue 2019-08-19 15:50:47 -0700 Comment on attachment 376712 Patch Clearing flags on attachment: 376712 Committed r248874: <https://trac.webkit.org/changeset/248874> 1562826 6 commit-queue 2019-08-19 15:50:50 -0700 All reviewed patches have been landed. Closing bug. 1562827 7 webkit-bug-importer 2019-08-19 15:51:19 -0700 <rdar://problem/54487810> 376712 2019-08-19 15:17:56 -0700 2019-08-19 15:50:47 -0700 Patch bug-200897-20190819151756.patch text/plain 3396 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZlZjk4MGE4MzJkYzY2ZWEz MmIxZDlhMTU1ZGY1YjVkNmFlYjY2MmQuLjczMTM4NGIxYWFiOWNiZTEwOWI1NDAzYWUyMDBhOWYz OWJlZTNmNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDgtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBOZXR3b3JrRGF0YVRhc2sgaXMgYmVp bmcgcmVmJ2QgLyBkZXJlZidkIGZyb20gc2V2ZXJhbCB0aHJlYWRzIGFuZCBpcyBub3QgVGhyZWFk U2FmZVJlZkNvdW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMDg5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5ldHdvcmtEYXRhVGFzayBzdWJjbGFzc2VzIFJlZkNvdW50ZWQgYW5kIGlzIHJlZidk IC8gZGVyZWYnZCBvbiB0aGUgbWFpbiB0aHJlYWQuIEhvd2V2ZXIsIHRoZXJlCisgICAgICAgIGlz IGNvZGUgaW4gTmV0d29ya0RhdGFUYXNrQ29jb2E6OnJlc3VtZSgpIHRoYXQgd2FzIHJlZidpbmcg LyBkZXJlZidpbmcgaXQgb24gYSBiYWNrZ3JvdW5kIHRocmVhZCwKKyAgICAgICAgd2hpY2ggaXMg dW5zYWZlLiBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwgSGF2ZSBOZXR3b3JrRGF0YVRhc2sgc3ViY2xh c3MgVGhyZWFkU2FmZVJlZkNvdW50ZWQsIGFuZAorICAgICAgICBtYWtlIHN1cmUgaXQgYWx3YXlz IGdldHMgZGVzdHJveWVkIG9uIHRoZSBtYWluIHRocmVhZC4KKworICAgICAgICAqIE5ldHdvcmtQ cm9jZXNzL05ldHdvcmtEYXRhVGFzay5oOgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29j b2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRh VGFza0NvY29hOjpyZXN1bWUpOgorICAgICAgICBBdm9pZCBzb21lIHVubmVjZXNzYXJ5IHJlZmNv dW50aW5nIGNodXJuLgorCiAyMDE5LTA4LTE5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBjYWxsIHRvIGluaXRpYWxpemVNYWluVGhy ZWFkIGludHJvZHVjZWQgaW4gcjI0ODU0OSB0byBhZnRlciBXZWJLaXQuZnJhbWV3b3JrIGhhcyBi ZWVuIGxvYWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrRGF0YVRhc2suaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFU YXNrLmgKaW5kZXggMWZiMDc4ZGY3YTMyZGM4MTc4YjI4N2Q2ODM4N2ZiYmY4M2UxZDc2NC4uMDll M2FhNjU1MzQ0YmE0OTY1NDJmNjEzMTFlYWNkODA0NTNiMDNmNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suaAorKysgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5oCkBAIC0zNSw2ICszNSw3IEBACiAj aW5jbHVkZSA8V2ViQ29yZS9TdG9yZWRDcmVkZW50aWFsc1BvbGljeS5oPgogI2luY2x1ZGUgPFdl YkNvcmUvVGltZXIuaD4KICNpbmNsdWRlIDx3dGYvQ29tcGxldGlvbkhhbmRsZXIuaD4KKyNpbmNs dWRlIDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZT dHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNzgsNyArNzksNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB+TmV0d29ya0RhdGFUYXNrQ2xpZW50KCkgeyB9CiB9OwogCi1jbGFzcyBO ZXR3b3JrRGF0YVRhc2sgOiBwdWJsaWMgUmVmQ291bnRlZDxOZXR3b3JrRGF0YVRhc2s+LCBwdWJs aWMgQ2FuTWFrZVdlYWtQdHI8TmV0d29ya0RhdGFUYXNrPiB7CitjbGFzcyBOZXR3b3JrRGF0YVRh c2sgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8TmV0d29ya0RhdGFUYXNrLCBXVEY6OkRl c3RydWN0aW9uVGhyZWFkOjpNYWluPiwgcHVibGljIENhbk1ha2VXZWFrUHRyPE5ldHdvcmtEYXRh VGFzaz4gewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8TmV0d29ya0RhdGFUYXNrPiBjcmVhdGUo TmV0d29ya1Nlc3Npb24mLCBOZXR3b3JrRGF0YVRhc2tDbGllbnQmLCBjb25zdCBOZXR3b3JrTG9h ZFBhcmFtZXRlcnMmKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KaW5kZXggYzJlN2IzNjg1NGU3Mzk1 Y2I2OTMwZDZlMjU3NDhjNGJhZDYwMTIxNS4uYTRlZmE5ZmJhNDY0YTk1MDQwZjNhZGEwZDhiZWQw MWU5ZWQ0MDgxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2Nv YS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCkBAIC01MDQsOCArNTA0LDggQEAgdm9p ZCBOZXR3b3JrRGF0YVRhc2tDb2NvYTo6cmVzdW1lKCkKIAogICAgIGF1dG8mIGNvY29hU2Vzc2lv biA9IHN0YXRpY19jYXN0PE5ldHdvcmtTZXNzaW9uQ29jb2EmPigqbV9zZXNzaW9uKTsKICAgICBp ZiAoY29jb2FTZXNzaW9uLmRldmljZU1hbmFnZW1lbnRSZXN0cmljdGlvbnNFbmFibGVkKCkgJiYg bV9pc0Zvck1haW5SZXNvdXJjZU5hdmlnYXRpb25Gb3JBbnlGcmFtZSkgewotICAgICAgICBhdXRv IGRpZERldGVybWluZURldmljZVJlc3RyaWN0aW9uUG9saWN5Rm9yVVJMID0gbWFrZUJsb2NrUHRy KFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKEJPT0wgaXNCbG9ja2VkKSB7 Ci0gICAgICAgICAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFr ZVJlZigqdGhpcyksIGlzQmxvY2tlZF0geworICAgICAgICBhdXRvIGRpZERldGVybWluZURldmlj ZVJlc3RyaWN0aW9uUG9saWN5Rm9yVVJMID0gbWFrZUJsb2NrUHRyKFt0aGlzLCBwcm90ZWN0ZWRU aGlzID0gbWFrZVJlZigqdGhpcyldKEJPT0wgaXNCbG9ja2VkKSBtdXRhYmxlIHsKKyAgICAgICAg ICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3Rl Y3RlZFRoaXMpLCBpc0Jsb2NrZWRdIHsKICAgICAgICAgICAgICAgICBpZiAoaXNCbG9ja2VkKSB7 CiAgICAgICAgICAgICAgICAgICAgIHNjaGVkdWxlRmFpbHVyZShSZXN0cmljdGVkVVJMRmFpbHVy ZSk7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsK